bittnerbarni added a comment.
I'm planning to submit more patches in the future, as I have time for them. So
it wouldn't be in vain :)
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
bittnerbarni added a comment.
Thank you for all the assistance. Could you please do that?
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bittnerbarni marked 14 inline comments as done.
bittnerbarni added a comment.
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bittnerbarni updated this revision to Diff 66492.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidy
bittnerbarni updated this revision to Diff 65606.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidy
bittnerbarni added inline comments.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:55
@@ +54,3 @@
+ hasDeclaration(decl(equalsBoundNode("lhsStrT"))),
+ hasDescendant(BasicStringPlusOperator));
+
Yes this
bittnerbarni updated this revision to Diff 65384.
bittnerbarni marked an inline comment as done.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationC
bittnerbarni updated this revision to Diff 63098.
bittnerbarni added a comment.
Thank you, for your valuable comments Alexander!
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performanc
bittnerbarni updated this revision to Diff 61893.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidyM
bittnerbarni added inline comments.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:67
@@ +66,3 @@
+Finder->addMatcher(
+exprWithCleanups(anyOf(hasDescendant(AssingOperator),
+ hasDescendant(PlusOperatorMatcher))
bittnerbarni updated this revision to Diff 59661.
bittnerbarni marked 6 inline comments as done.
bittnerbarni added a comment.
Removed the unnecessary hasDescendant calls and simplified the checker as
suggested. Tested on LLVM codebase, with minor improvements in speed (~1%).
http://reviews.llv
bittnerbarni updated this revision to Diff 58054.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidyM
bittnerbarni updated this revision to Diff 57894.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang-tidy/performance/InefficientStringAdditionCheck.h
clang-tidy/performance/PerformanceTidyModule.cpp
bittnerbarni updated this revision to Diff 57346.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang-tidy/performance/InefficientStringAdditionCheck.h
clang-tidy/performance/PerformanceTidyModule.cpp
bittnerbarni updated this revision to Diff 57294.
bittnerbarni added a comment.
Sorry for uploading 2 line long diffs. I uploaded the whole diff now.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang
bittnerbarni updated this revision to Diff 57181.
http://reviews.llvm.org/D20196
Files:
docs/clang-tidy/checks/performance-inefficient-string-addition.rst
Index: docs/clang-tidy/checks/performance-inefficient-string-addition.rst
=
bittnerbarni updated this revision to Diff 57185.
http://reviews.llvm.org/D20196
Files:
docs/clang-tidy/checks/performance-inefficient-string-addition.rst
Index: docs/clang-tidy/checks/performance-inefficient-string-addition.rst
=
bittnerbarni updated this revision to Diff 57172.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/InefficientStringAdditionCheck.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/checks/performance-inefficient-string-addition.rst
test/clang-tidy/performance-inefficient-string-additio
18 matches
Mail list logo
