[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:3496-3501 + assert(!Tok.is(tok::l_brace) || !Tok.is(BK_Block) || +

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. In D101868#2777423 , @feg208 wrote: > In D101868#2776633 , > @HazardyKnusperkeks wrote: > >> In D101868#2775550 , @feg208 wrote: >>

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. In D101868#2775550 , @feg208 wrote: > This reworks substantially this commit. I recognize there are lacking/broken > tests but I just would like to ensure that the general direction doesn't > seem likely to end in

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2983 /// \endcode -SBPO_ControlStatementsExceptForEachMacros, +SBPO_ControlStatementsExceptControlMacros, /// Put a space before opening parentheses only if the

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks added a comment. Looks good, but please add a test with the `else IF` and just `else` case. Also for me it would be ok to add your `KJ_IF_MAYBE` to the default configuration. But I have no experience on that. Comment at:

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2766871 , @vlovich wrote: > In D102706#2766680 , > @HazardyKnusperkeks wrote: > >> Maybe a bit more test cases with smaller lambdas? Or without the outer >>

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. Maybe a bit more test cases with smaller lambdas? Or without the outer parenthesis? Comment at: clang/include/clang/Format/Format.h:2456 + enum LambdaBodyIndentationKind : unsigned char { +/// Align lambda body relative to the lambda

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I second that ColumnLimit breaking test case. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102392/new/ https://reviews.llvm.org/D102392

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. Something which just came to my mind. Since you wrote your own LineFormatter, you have to add test cases for all kinds of indention and wrapping. It seems that the string wrapping does not happen, how about comments? Are classes, namespaces, functions, etc.

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:16465 + "test demo[] = {\n" + "{56, 23,\"hello world i am a very

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1404 + isArrayOfStructuresInit(TheLine)); + if (AlignArrayOfStructuresInit) { +Penalty +=

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good, but please wait for others to state their opinion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

HazardyKnusperkeks added a comment. I have not a great knowledge about python, but it looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. I really like alignment! :) But why is this completely different than the other alignment options? You should also add an entry to the release notes. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:32 +// The notion here is that we

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:135 return; +} } krasimir wrote: > nit: use spaces for indentation, no tabs (Phabricator makes it look this line > starts with a tab character) That's not

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:365 + + verifyFormat("test \?\?= ABC;", Style); + verifyFormat("test \?\?= true;", Style); Why do you escape `?`? I've never seen that. Repository: rG LLVM

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Jep, that would also confuse myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2705 } - if (FormatTok->Tok.is(tok::l_brace)) { + if (FormatTok->Tok.is(tok::equal)) { +nextToken(); MyDeveloperDay wrote: > shouldn't this be > >

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good, and I'm always in favor of having a `Leave` Option. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. LGTM but please wait for @MyDeveloperDay opinion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-commits mailing

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Looks okay for me, but please fix the formatting notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Looks good, but please fix the clang-format notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. In D100727#2698422 , @curdeius wrote: > More I look at the current state of this option, more I think it's misleading. > I would expect that the if after else is also controlled by this option. And, > the last else as

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. In D100727#2697815 , @curdeius wrote: > Oh, you're right. Should we go for a separate option then? > AllowShortElseStatementsOnASingleLine? What would control else if statements > then? I think I would prefer to

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. In D100727#2697490 , @curdeius wrote: > In D100727#2697419 , > @HazardyKnusperkeks wrote: > >> How is >> >> if (a) return; >> else >> return; >> >> formatted with the

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. How is if (a) return; else return; formatted with the different options? And from the documentation I think it was intended that only `if` is short, never the `else`. So I think it behaves correctly, nevertheless I think it should be possible, but

[PATCH] D100590: DeclContext: Fix iterator category

HazardyKnusperkeks updated this revision to Diff 337985. HazardyKnusperkeks added a comment. Trigger build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100590/new/ https://reviews.llvm.org/D100590 Files: clang/include/clang/AST/DeclBase.h

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I don't know if you did elsewhere, but you have to give a name and email for the commit, so that someone can push it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100590: DeclContext: Fix iterator category

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: rsmith, v.g.vassilev. HazardyKnusperkeks added projects: clang, clang-tools-extra, LLDB. Herald added a subscriber: JDevlieghere. HazardyKnusperkeks requested review of this revision. Herald added a subscriber:

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5077 + verifyFormat("asm volatile(\"string\", : : val);", Style); + verifyFormat("asm volatile(\"string\", : val1 : val2);", Style); + You should add a test case with

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

HazardyKnusperkeks added a comment. Look good in general, only the few comments. Comment at: clang/unittests/Format/FormatTest.cpp:8892 FormatStyle Style = getLLVMStyle(); + FormatStyle NoEmptyLines = getLLVMStyle(); + NoEmptyLines.MaxEmptyLinesToKeep = 0;

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

HazardyKnusperkeks added a comment. While the fix seems to be right, I don't think we should change the LLVM style (and possibly other styles). So my suggestion is to apply the fix, but actually change the style so that it behaves like before, so that braces of enums are wrapped. And maybe

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5243c63cda3: [clang-format] Fix aligning with linebreaks (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

HazardyKnusperkeks added a comment. In D99031#2640425 , @aybassiouny wrote: >> How about verifyFormat? Would that fail without your patch? > > @HazardyKnusperkeks sorry, but not sure that I understand your point. Are you > suggesting to use verifyFormat

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good. How about `verifyFormat`? Would that fail without your patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks added a subscriber: curdeius. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:168 +- Option ``SpaceBeforeForLoopSemiColon`` has been added to control whether + spaces will be added before the semi-colons in for loops.

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1914 +ELAAMS_Leave, +/// Always add empty line after access modifiers. +/// \code It does not always add, it does enforces one empty line, or am I mistaken?

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks added reviewers: MyDeveloperDay, HazardyKnusperkeks. HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/ReleaseNotes.rst:168 +- Option

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3690-3691 +return (isAllowedByAfterEnum && isAllowedByShortEnums) || (Line.startsWith(tok::kw_class) && Style.BraceWrapping.AfterClass) ||

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks added a comment. Please add a note to the release notes and also a test for a range based for with initializer (c++20). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks updated this revision to Diff 329755. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Addressed comments - Fixed handling of continued string literals when aligning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added a comment. Please also add an entry in the `clang/doc/ReleaseNotes.rst`. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284 (!PreviousLine->InPPDirective || !RootToken.HasUnescapedNewline)) -Newlines = std::min(1u, Newlines); +

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2616044 , @atirit wrote: > In D93938#2614825 , > @HazardyKnusperkeks wrote: > >> If the bugs are (very) similar, I could live with one fix for both. >> Otherwise you

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:332-340 if (Changes[ScopeStart - 1].Tok->is(TT_FunctionDeclarationName) || (ScopeStart > Start + 1 &&

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added a comment. I would like additional tests: - With at least 2 empty lines - With 0-2 empty lines without `verifyFormat` to demonstrate what is kept, added, and removed. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2613096 , @atirit wrote: > In D93938#2612952 , > @HazardyKnusperkeks wrote: > >> In my opinion you should then, either temporarily deactivate the test, or >> fix the

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2612908 , @atirit wrote: > In D93938#2610568 , @curdeius wrote: > >> I hadn't had another look, because the CI still shows the test `AfterEnum` >> to be failing. > > I

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, nikola. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Breaking a

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks added a comment. In D97927#2605914 , @kentsommer wrote: > LGTM > > Sorry for the slow response! No problem, we all have some phases where we don't have or find the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2605517 , @timwoj wrote: > In D94500#2605515 , > @HazardyKnusperkeks wrote: > >> In D94500#2604754 , @timwoj wrote: >> >>>

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f9f94b2e2b: [clang-format] Rework Whitesmiths mode to use line-level values in… (authored by timwoj, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97927: [clang-format] Rename case sorting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b02794f0aeb: [clang-format] Rename case sorting (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7309404536c: [clang-format] Suppress diagnostics on second parse (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2604754 , @timwoj wrote: > Rebase onto master again `master` or `main`? Please rebase on `main`. That is where the pushes land. (And as far as I can see `master` hasn't been updated in quite some time.

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks added a comment. In D97927#2603089 , @curdeius wrote: > LGTM. It's indeed more logical this way. > Hopefully the original author will confirm. I'll give him one week, if he or nobody else comes along to object I'll push it.

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: kentsommer, curdeius, MyDeveloperDay, PragmaNull. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 328075. HazardyKnusperkeks added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 Files: clang/include/clang/Format/Format.h

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Could you please rebase your patch an reupload the diff, it doesn't apply anymore. (And doing it by hand is too much work for me.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2597241 , @kuzkry wrote: > Thank you for delivering it, @HazardyKnusperkeks. > > One thing concerns me though. I'm not an author of changes done in > clang/docs/ClangFormatStyleOptions.rst in lines 2372,

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca52815fb3c: [clang-format][PR47290] Add ShortNamespaceLines format option (authored by kuzkry, committed by

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG418b4a7b3158: [clang-format] Respect spaces in line comment section... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D95017: [clang-format] Add case aware include sorting.

HazardyKnusperkeks added a comment. In D95017#2572578 , @PragmaNull wrote: > In D95017#2572238 , @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2593229 , @timwoj wrote: > In D94500#2592448 , > @HazardyKnusperkeks wrote: > >> Do you need someone to push this? > > Yes I do. I don't have committer access. Please

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2592605 , @kuzkry wrote: >> Do you need someone to push it? > > Yes, I need someone to do that. I don't have write permissions. I'm new here. Please state the name and mail for the commit. I will push it for

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks updated this revision to Diff 326928. HazardyKnusperkeks added a comment. - Work with `::max` instead of many checks for `== 0`. - Additional Testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96896/new/

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Is this acceptable to the others? Do you need someone to push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 ___

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Do you need someone to push this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 ___ cfe-commits mailing list

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b1df924ae0: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers (authored by darwin, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. In D97137#2584417 , @darwin wrote: > Hi guys, thanks for accepting the change. But I don't have commit access of > LLVM. Can someone commit it for me? Can and will do. Need the name and email for the commit. But I

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D97137#2580664 , @darwin wrote: > In D97137#2579669 , > @HazardyKnusperkeks wrote:

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. You should mark comments as done, if they are. Does your modification maybe add something to the alignment which is not a declaration? int a; double b; a * b; How is that formatted? Yeah unlikely that something like that is in code, but it could be

[PATCH] D97137: Bug fix of https://bugs.llvm.org/show_bug.cgi?id=49175

HazardyKnusperkeks added a comment. Just out of curiosity, in which language is `Const` used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 ___ cfe-commits

[PATCH] D95017: [clang-format] Add case aware include sorting.

HazardyKnusperkeks added a comment. In D95017#2572578 , @PragmaNull wrote: > In D95017#2572238 , @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2243 Reflow = true; if (ContentStartColumn + RemainingTokenColumns > ColumnLimit) {

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before line

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 324407. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Added DiagHandlerCtxt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. In D96760#2565171 , @njames93 wrote: > I did have another plan for a different way to go about this, not sure if its > really any better though. > It involved building a vector of the edits the config would apply to

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3342-3346 inline std::error_code parseConfiguration(StringRef Config, FormatStyle *Style, bool AllowUnknownOptions = false) { return

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: njames93, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:106 +<< "for source file " << FileName; +EXPECT_EQ(Manager.getIncludePriority("", true), 0) +<< "for source file " << FileName; I would also

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25f753c51e7b: [clang-format] Add possibility to be based on parent directory (authored by HazardyKnusperkeks). Repository: rG LLVM Github

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Although I would put it in one test, this is fine by me. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1201-1206 +} + +TEST_F(ShortNamespaceLinesTest, +

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Have you rebased your change? It seems that your release notes are still for LLVM 12. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Apart from my comments, this looks good to me and I really wonder why it hasn't been pushed. (I would directly use it!) Comment at: clang/include/clang/Format/Format.h:2821 MaxEmptyLinesToKeep == R.MaxEmptyLinesToKeep && +

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 320886. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Silence unused variable warnings in release and using `llvm::reverse` with range based for. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. In D93844#2536354 , @njames93 wrote: > As a follow up it may be wise to pass a diag handler to parseConfiguration as > when we parse it a second time, we probably

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

HazardyKnusperkeks added a comment. You need to supply a full diff (with context). Please also add it to the release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94661/new/ https://reviews.llvm.org/D94661 ___ cfe-commits mailing list

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 320589. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Fixed documentation (and rebased). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93844/new/

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG772eb24e0062: [clang-format] Add option to control the spaces in a line comment (authored by HazardyKnusperkeks). Repository: rG LLVM Github

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:160 +parent directory (or its parent if there is none). If there is no parent +file found it falls back to the ``LLVM``

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2532077 , @MyDeveloperDay wrote: > I have a script that runs clang-format -n on various directories in clang > that are clang format clean, polly is one of them because they have clang > format as a unit test

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2532666 , @MyDeveloperDay wrote: >> What can be done to move this change along? > > I feel there has to be a fundamental acceptance that it is ok for > clang-format to alter code (something it already does

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2532071 , @curdeius wrote: > LGTM. Could you please give us a link to the failing test in Polly? May be > GitHub or buildbot. No problem: http://lab.llvm.org:8011/#builders/10/builds/2294 Repository: rG

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks updated this revision to Diff 320196. HazardyKnusperkeks added a comment. The previous one broke a (format) test in polly. This lead me to change the one breaking behavior, no it is not breaking anymore. A comment starting with `}` will only be indented if it is in a comment

[PATCH] D95128: [clang-format] [NFC] Remove unused arguments

HazardyKnusperkeks added a comment. I did add the commit here, but I can give you the hash explicitly: 9aa38a0615119a7a9f3bee33a2b8915c45f1cab9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 320058. HazardyKnusperkeks added a comment. Rebased and Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93844/new/ https://reviews.llvm.org/D93844 Files:

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

This revision was automatically updated to reflect the committed changes. Closed by commit rG078f30e04d1f: [clang-format] Add option to control the spaces in a line comment (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D92257?vs=317294=320046#toc

[PATCH] D95128: [clang-format] [NFC] Remove unused arguments

HazardyKnusperkeks closed this revision. HazardyKnusperkeks added a comment. Commited but forgot the Differential Link in the Message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95128/new/ https://reviews.llvm.org/D95128

<    5   6   7   8   9   10   11   >