[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297355. bogser01 added a comment. Rebase diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D88314: Added llvm-string-referencing check

bogser01 added a comment. @aaron.ballman Thank you for picking up this review! Running the check over the entire LLVM causes ~74K warnings across 430 files. As to the false positive rate it's tricky to measure. Based on previous analysis on //flang// codebase, I would say roughly 50% of the

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297246. bogser01 added a comment. Added documentation & Nit fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files:

[PATCH] D88314: Added llvm-string-referencing check

bogser01 added a comment. @alexfh does this look alright? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295811. bogser01 added a comment. Remove conflict markers 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295810. bogser01 added a comment. Removed residual conflict markers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files:

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295580. bogser01 added a comment. Fixed unit test 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295553. bogser01 added a comment. Fixed failing unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D88314: Added llvm-string-referencing check

bogser01 created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. bogser01 requested review of this revision. Clang-tidy pass detecting the use of const std::string& references. Use of llvm::StringRef is recommended in the LLVM Programmer's Manual

[PATCH] D88311: Added llvm-string-referencing check

bogser01 updated this revision to Diff 294331. bogser01 added a comment. Herald added a subscriber: mgorny. Changed upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88311/new/ https://reviews.llvm.org/D88311 Files:

[PATCH] D88311: Added llvm-string-referencing check

bogser01 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. bogser01 requested review of this revision. Clang-tidy pass detecting the use of const std::string& references. Use of llvm::StringRef is recommended in the LLVM Programmer's Manual instead:

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

bogser01 created this revision. bogser01 added reviewers: djasper, alexfh. bogser01 added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. bogser01 requested review of this revision. Skeleton checks generated by clang-tidy add_check.py cause