[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a68babd9973: [clang-doc] Add template support. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480979. brettw added a comment. New patch with llvm::Optional converted to std::optional (previously collided with a refactor). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files:

[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6dbb5f1646: [clang-doc] Add template support. (authored by brettw). Changed prior to commit: https://reviews.llvm.org/D139154?vs=480560=480960#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139154: [clang-doc] Add template support

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:119-123 + // This variant (that takes no qualified name parameter) uses the Name as the + // QualName (very useful in unit tests to reduce verbosity). This can't use + // the empty string

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480560. brettw marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

brettw marked an inline comment as done. brettw added a comment. New patch up. Comment at: clang-tools-extra/test/clang-doc/single-file.cpp:19 // CHECK-NEXT:DefLocation: -// CHECK-NEXT: LineNumber: [[@LINE-8]] +// CHECK-NEXT: LineNumber: 11 //

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480536. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480251. brettw added a reviewer: paulkirth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 479772. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D139154: [clang-doc] Add template support

brettw created this revision. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Decodes the template parameters for both functions and records. For template specializations, records a

[PATCH] D138961: [clang-doc] Fix warnings about lock_guard.

brettw created this revision. brettw added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Fixes a warning about a potentially unsupported template argument deduction

[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b8c7e02122a: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 478683. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a469fc5727: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476955. brettw marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476612. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476183. brettw marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 475869. brettw added a comment. Updated the lit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added a comment. If you're curious, you can see the simplification the YAML output format change makes in the consuming code: https://fuchsia-review.git.corp.google.com/c/fuchsia/+/760570/2/tools/cppdocgen/clangdoc/clangdoc.go Since it allows us to remove some special-casing code for

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Previously file

[PATCH] D136894: Add clang-doc readme

brettw abandoned this revision. brettw added a comment. Ok thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136894/new/ https://reviews.llvm.org/D136894 ___ cfe-commits mailing list

[PATCH] D136894: Add clang-doc readme

brettw added a comment. I definitely wasn't intending to write "formal documentation" for clang-doc. I was trying to write some notes for a future contributor as I'm winding down my work here, and it seems nobody else is working on it or has any knowledge about it. Is there a place in LLVM for

[PATCH] D136894: Add clang-doc readme

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds a readme to clang-doc with an overview of the structure of the code.

[PATCH] D136638: [clang-doc] Fix typedef/using output.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7231c9966e52: [clang-doc] Fix typedef/using output. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136638: [clang-doc] Fix typedef/using output.

brettw updated this revision to Diff 470598. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136638/new/ https://reviews.llvm.org/D136638 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D136638: [clang-doc] Fix typedef/using output.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Provides an initializer for the TypedefInfo.IsUsing member. Previously this

[PATCH] D134371: [clang-doc] Add typedef/using information.

This revision was automatically updated to reflect the committed changes. Closed by commit rG21fb70c6ab3b: [clang-doc] Add typedef/using information. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467894. brettw added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw reopened this revision. brettw added a comment. This revision is now accepted and ready to land. New patch up to fix warnings that caused the revert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 466858. brettw added a comment. Fixed -Wall issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:336 Reference *I, FieldId ) { switch (ID) { case REFERENCE_USR: haowei wrote: > This block ID came from L582, which read from a bitcode file

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added a comment. I can guarantee that nobody uses this for anything useful because it doesn't work well enough. For example, before I started changing it, requesting HTML output crashed on startup and many of the most basic syntactic things were broken. My previous patch changed enums

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:202 + bool IsFileInRootDir = false) : LineNumber(LineNumber), Filename(std::move(Filename)), IsFileInRootDir(IsFileInRootDir) {} paulkirth wrote: >

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:540 } - template <> void addChild(NamespaceInfo *I, EnumInfo &) { paulkirth wrote: > nit: can we avoid unrelated changes to whitespace here and elsewhere in the > patch?

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 462313. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw updated this revision to Diff 462281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw marked an inline comment as done. brettw added a comment. If you have more questions, I can schedule a meeting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw marked an inline comment as done. brettw added a comment. First, for the mechanical part of the change, this code implement multiple constructors:   Info() = default;   Info(InfoType IT) : IT(IT) {}   Info(InfoType IT, SymbolID USR) : USR(USR), IT(IT) {}   Info(InfoType IT, SymbolID USR,

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Read typedef and "using" type alias

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw created this revision. Herald added a project: All. brettw requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The *Info object (for the copy of the AST") constructors had many duplicated variants. Many of the variants

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

brettw updated this revision to Diff 461397. brettw marked an inline comment as done. brettw added a comment. Comment addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134225/new/ https://reviews.llvm.org/D134225 Files: clang-tools-extra/clang-doc/Representation.h

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw updated this revision to Diff 461366. brettw added a comment. Clang-formatted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Several different places in the code had similar computations for the

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > brettw wrote: > > paulkirth wrote: > > > do

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw updated this revision to Diff 461259. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134055: [clang-doc] Export enum type and value information.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > do you need to do all of this? APSInt

[PATCH] D134055: [clang-doc] Export enum type and value information.

brettw updated this revision to Diff 460882. brettw marked 2 inline comments as done. brettw retitled this revision from "[clang-doc] Export more enum information" to "[clang-doc] Export enum type and value information.". brettw edited the summary of this revision. Repository: rG LLVM Github

[PATCH] D134055: [clang-doc] Export more enum information

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Add support for explicitly typed enums: enum Foo : unsigned { ... }; to

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw updated this revision to Diff 460538. brettw marked 4 inline comments as done. brettw added a comment. There is no usage change for this. It just adds another field to the YAML. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133732/new/ https://reviews.llvm.org/D133732 Files:

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds support for default arguments in the internal representation and reads

[PATCH] D131739: [clang-doc] Always emit the TagType for RecordInfo

brettw added a comment. In D131739#3719634 , @paulkirth wrote: > Can you update the summary to reflect what's in this change now + add a tag > for clang-doc? > > `[clang-doc] Always emit the TagType for RecordInfo` > > I can land this and D131793

[PATCH] D131793: [clang-doc] Fix assert on startup

brettw added a comment. In D131793#3719619 , @paulkirth wrote: > This is LGTM, but can you add a tag to the summary title/commit message? ie. > `[clang-doc] Fix assert on startup in clang-doc` Done Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131739: Fix some clang-doc issues.

brettw updated this revision to Diff 452227. brettw edited the summary of this revision. brettw added a comment. Startup assert fix broken out into https://reviews.llvm.org/D131793 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131739/new/ https://reviews.llvm.org/D131739 Files:

[PATCH] D131793: Fix assert on startup in clang-doc

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. When using `clang-doc

[PATCH] D131739: Fix some clang-doc issues.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Always emit the TagType for

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451882. brettw marked 2 inline comments as done. brettw added a comment. New patch up with requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:166 + ExpectedE.Members.emplace_back("int", "value", AccessSpecifier::AS_public); + //ExpectedE.Members.back().Description.push_back(MakeOneLineCommentInfo(" Some docs"));

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451632. brettw added a comment. New patch up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451299. brettw marked an inline comment as done. brettw added a comment. I updated the comment test that's not currently working with a TODO. There are some open questions in the code review about some bigger questions about this tool. Since this has been

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw marked 2 inline comments as done. brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:439 +static void populateMemberTypeInfo(MemberTypeInfo , const FieldDecl *D) { + ASTContext& Context = D->getASTContext(); + RawComment *Comment =

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451001. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added a comment. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:354 +template <> llvm::Expected getCommentInfo(MemberTypeInfo *I) { + I->Description.emplace_back(); + return >Description.back(); paulkirth wrote: > So, I see that this uses

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450976. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450967. brettw added a comment. Herald added subscribers: usaxena95, arphaman. Added some tests (with one open question). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw created this revision. brettw added a reviewer: phosek. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Struct/class data members did not have the comments associated with them. This