r335190 - Fix hmaptool cmake file to work on Windows

Author: bruno Date: Wed Jun 20 16:08:43 2018 New Revision: 335190 URL: http://llvm.org/viewvc/llvm-project?rev=335190=rev Log: Fix hmaptool cmake file to work on Windows Unbreak a few windows buildbots: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11315

Re: [PATCH] D46485: Add python tool to dump and construct header maps

Hi Stella, On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator wrote: > > stella.stamenova added a comment. > > This breaks the clang tests on Windows when building using Visual Studio as > none of the updated tests can find hmaptool. Yes. I contacted Galina about that but maybe

r335184 - Warning for framework headers using double quote includes

Author: bruno Date: Wed Jun 20 15:11:59 2018 New Revision: 335184 URL: http://llvm.org/viewvc/llvm-project?rev=335184=rev Log: Warning for framework headers using double quote includes Introduce -Wquoted-include-in-framework-header, which should fire a warning whenever a quote include appears in

r335177 - Add python tool to dump and construct header maps

Author: bruno Date: Wed Jun 20 14:16:37 2018 New Revision: 335177 URL: http://llvm.org/viewvc/llvm-project?rev=335177=rev Log: Add python tool to dump and construct header maps Header maps are binary files used by Xcode, which are used to map header names or paths to other locations. Clang has

r334859 - [Modules] Improve .Private fix-its to handle 'explicit' and 'framework'

Author: bruno Date: Fri Jun 15 13:13:28 2018 New Revision: 334859 URL: http://llvm.org/viewvc/llvm-project?rev=334859=rev Log: [Modules] Improve .Private fix-its to handle 'explicit' and 'framework' When in the context of suggestion the fix-it from .Private to _Private for private modules, trim

r334747 - [CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2

Author: bruno Date: Thu Jun 14 11:20:04 2018 New Revision: 334747 URL: http://llvm.org/viewvc/llvm-project?rev=334747=rev Log: [CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2 On MacOS, if CMAKE_OSX_SYSROOT is used and the user has command line tools installed, we

r333718 - [Modules] Warning for module declarations lacking 'framework' qualifier

Author: bruno Date: Thu May 31 18:26:18 2018 New Revision: 333718 URL: http://llvm.org/viewvc/llvm-project?rev=333718=rev Log: [Modules] Warning for module declarations lacking 'framework' qualifier When a module declaration for a framework lacks the 'framework' qualifier, the listed headers

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

On Fri, May 18, 2018 at 12:46 PM Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > > > On Fri, May 18, 2018 at 11:54 AM Vedant Kumar via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On May 18, 2018, at 11:48 AM, Eric Liu wrote: >> >> >> So I have reverted this

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

On Fri, May 18, 2018 at 11:54 AM Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On May 18, 2018, at 11:48 AM, Eric Liu wrote: > > > So I have reverted this with r332751. > > > Thanks! > > > I can't see how this introduced cyclic dependencies in module

r331322 - [Modules] Allow @import to reach submodules in private module maps

Author: bruno Date: Tue May 1 19:25:03 2018 New Revision: 331322 URL: http://llvm.org/viewvc/llvm-project?rev=331322=rev Log: [Modules] Allow @import to reach submodules in private module maps A @import targeting a top level module from a private module map file (@import Foo_Private), would

r331233 - [Modules] Fix testcases from r331232

Author: bruno Date: Mon Apr 30 15:57:02 2018 New Revision: 331233 URL: http://llvm.org/viewvc/llvm-project?rev=331233=rev Log: [Modules] Fix testcases from r331232 Modified: cfe/trunk/test/Modules/Inputs/non-ambiguous-enum/A.framework/Modules/module.modulemap

r331232 - [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl

Author: bruno Date: Mon Apr 30 15:14:29 2018 New Revision: 331232 URL: http://llvm.org/viewvc/llvm-project?rev=331232=rev Log: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl Support for ObjC/C ODR-like semantics with structural equivalence checking was added back in r306918.

r331063 - [Modules][ObjC] ASTReader should add protocols for class extensions

Author: bruno Date: Fri Apr 27 11:01:23 2018 New Revision: 331063 URL: http://llvm.org/viewvc/llvm-project?rev=331063=rev Log: [Modules][ObjC] ASTReader should add protocols for class extensions During deserialization clang is currently missing the merging of protocols into the canonical

r330240 - [Modules] Turn on system header validation for implicit modules

Author: bruno Date: Tue Apr 17 23:07:49 2018 New Revision: 330240 URL: http://llvm.org/viewvc/llvm-project?rev=330240=rev Log: [Modules] Turn on system header validation for implicit modules After r300027 implicit builds might fail when updating the SDK on darwin. Make validation of system

r330152 - Use export_as for autolinking frameworks

Author: bruno Date: Mon Apr 16 12:42:32 2018 New Revision: 330152 URL: http://llvm.org/viewvc/llvm-project?rev=330152=rev Log: Use export_as for autolinking frameworks framework module SomeKitCore { ... export_as SomeKit } Given the module above, while generting autolink information during

Re: [PATCH] D45165: Use llvm::sys::fs::real_path() in clang.

Thanks Nico! On Tue, Apr 10, 2018 at 6:39 AM, Nico Weber via Phabricator wrote: > thakis added a comment. > > r329698, thanks! > > > https://reviews.llvm.org/D45165 > > > -- Bruno Cardoso Lopes http://www.brunocardoso.cc

r328857 - [Modules] Improve fixit for framework private module maps

Author: bruno Date: Thu Mar 29 22:17:58 2018 New Revision: 328857 URL: http://llvm.org/viewvc/llvm-project?rev=328857=rev Log: [Modules] Improve fixit for framework private module maps The wrong source range was being provided in some case, fix that to get a better fixit.

r328053 - [Modules] Honor -fmodule-name when handling private framework modules

Author: bruno Date: Tue Mar 20 15:36:39 2018 New Revision: 328053 URL: http://llvm.org/viewvc/llvm-project?rev=328053=rev Log: [Modules] Honor -fmodule-name when handling private framework modules When skipping building the module for a private framework module, LangOpts.CurrentModule isn't

r325305 - [Modules] Extend -fmodule-name semantic for frameworks with private modules

Author: bruno Date: Thu Feb 15 16:12:57 2018 New Revision: 325305 URL: http://llvm.org/viewvc/llvm-project?rev=325305=rev Log: [Modules] Extend -fmodule-name semantic for frameworks with private modules Assume Foo.framework with two module maps and two modules Foo and Foo_Private. Framework

r325154 - [Modules] Add more language features to be used with requires-declaration

Author: bruno Date: Wed Feb 14 11:01:03 2018 New Revision: 325154 URL: http://llvm.org/viewvc/llvm-project?rev=325154=rev Log: [Modules] Add more language features to be used with requires-declaration Features added: c99, c11, c17, cplusplus14 and cplusplus17. rdar://problem/36328787

r324965 - [Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo correction

Author: bruno Date: Mon Feb 12 15:43:21 2018 New Revision: 324965 URL: http://llvm.org/viewvc/llvm-project?rev=324965=rev Log: [Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo correction Typo correction is the last step here, remapping should come first.

Re: r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Hi Eric, On Mon, Jan 8, 2018 at 9:31 PM, Eric Fiselier wrote: > I haven't done a ton of investigation yet, but I suspect this commit is > responsible for breaking my LLVM module selfhost build, which uses libc++ as > the STL, and builds LLD (No bots appear to test this

r321906 - Track shadow modules with a generation counter.

Author: bruno Date: Fri Jan 5 14:13:56 2018 New Revision: 321906 URL: http://llvm.org/viewvc/llvm-project?rev=321906=rev Log: Track shadow modules with a generation counter. This is a follow up to r321855, closing the gap between our internal shadow modules implementation and upstream. It has

r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Author: bruno Date: Thu Jan 4 18:33:18 2018 New Revision: 321855 URL: http://llvm.org/viewvc/llvm-project?rev=321855=rev Log: Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones When modules come from module map files explicitly specified by

r321786 - Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones"

Author: bruno Date: Wed Jan 3 23:31:24 2018 New Revision: 321786 URL: http://llvm.org/viewvc/llvm-project?rev=321786=rev Log: Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones" This reverts r321781 until I fix the leaks pointed out by bots:

r321781 - [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Author: bruno Date: Wed Jan 3 18:17:40 2018 New Revision: 321781 URL: http://llvm.org/viewvc/llvm-project?rev=321781=rev Log: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones When modules come from module map files explicitly specified by

r321342 - [Modules] Map missing private submodules from Foo.Private to Foo_Private

Author: bruno Date: Thu Dec 21 21:04:43 2017 New Revision: 321342 URL: http://llvm.org/viewvc/llvm-project?rev=321342=rev Log: [Modules] Map missing private submodules from Foo.Private to Foo_Private In case `@import Foo.Private` fails because the submodule doesn't exist, look for `Foo_Private`

r318507 - Change path used in a test from r318503 to work on windows

Author: bruno Date: Thu Nov 16 20:26:07 2017 New Revision: 318507 URL: http://llvm.org/viewvc/llvm-project?rev=318507=rev Log: Change path used in a test from r318503 to work on windows http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13565 Modified:

r318503 - [PCH+Modules] Improve diagnosticts to help out users pass an extra header search path

Author: bruno Date: Thu Nov 16 19:24:11 2017 New Revision: 318503 URL: http://llvm.org/viewvc/llvm-project?rev=318503=rev Log: [PCH+Modules] Improve diagnosticts to help out users pass an extra header search path When mixing PCH and Implicit Modules, missing a header search path can lead to the

r316016 - [OpenCL] Restrict swizzle length check to OpenCL mode

Author: bruno Date: Tue Oct 17 10:54:57 2017 New Revision: 316016 URL: http://llvm.org/viewvc/llvm-project?rev=316016=rev Log: [OpenCL] Restrict swizzle length check to OpenCL mode Changes behavior introduced in r298369 to only error out on vector component invalid length access on OpenCL mode.

Re: [libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

Hi Eric, This is also failing http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/39697/ Can you take a look? Thanks, On Tue, Oct 17, 2017 at 9:07 AM, Eric Fiselier via cfe-commits wrote: > These shadowing warnings should be fixed now. > > /Eric > > On

r315829 - Mark test as unsupported until r315808 is fixed

Author: bruno Date: Sat Oct 14 15:14:23 2017 New Revision: 315829 URL: http://llvm.org/viewvc/llvm-project?rev=315829=rev Log: Mark test as unsupported until r315808 is fixed This is causing: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/43381 Modified:

Re: r315627 - [lit] Raise the logic for enabling clang & lld substitutions to llvm.

Hi Zachary, I reverted this in r315712, since it's making one of our bots red since yesterday (more explanations in the commit): http://green.lab.llvm.org/green/job/clang-stage1-configure-RA Cheers, On Thu, Oct 12, 2017 at 2:56 PM, Zachary Turner via cfe-commits

r315712 - Revert "[lit] Raise the logic for enabling clang & lld substitutions to llvm."

Author: bruno Date: Fri Oct 13 10:11:13 2017 New Revision: 315712 URL: http://llvm.org/viewvc/llvm-project?rev=315712=rev Log: Revert "[lit] Raise the logic for enabling clang & lld substitutions to llvm." This reverts commit r315627, fixing bot failures:

Re: r298369 - [OpenCL] Added diagnostic for checking length of vector

On Thu, Oct 12, 2017 at 8:39 AM, Anastasia Stulova wrote: > > I think this bit is a bit confusing to us. Some of our original OpenCL > checks were removed in some places because in some cases OpenCL semantic was > adopted elsewhere. It's confusing indeed. We should

Re: [clang-tools-extra] r315287 - Revert "Revert r315214 since diff -Z isn't portable, this is breaking:"

On Tue, Oct 10, 2017 at 2:08 AM, Ilya Biryukov via cfe-commits wrote: > Author: ibiryukov > Date: Tue Oct 10 02:08:47 2017 > New Revision: 315287 > > URL: http://llvm.org/viewvc/llvm-project?rev=315287=rev > Log: > Revert "Revert r315214 since diff -Z isn't portable,

Re: r298369 - [OpenCL] Added diagnostic for checking length of vector

Hi Egor, On Tue, Mar 21, 2017 at 6:20 AM, Egor Churaev via cfe-commits wrote: > Author: echuraev > Date: Tue Mar 21 08:20:57 2017 > New Revision: 298369 > > URL: http://llvm.org/viewvc/llvm-project?rev=298369=rev > Log: > [OpenCL] Added diagnostic for checking length

[clang-tools-extra] r315242 - Revert r315214 since diff -Z isn't portable, this is breaking:

Author: bruno Date: Mon Oct 9 13:22:05 2017 New Revision: 315242 URL: http://llvm.org/viewvc/llvm-project?rev=315242=rev Log: Revert r315214 since diff -Z isn't portable, this is breaking: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive

Re: [clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

Hi, On Mon, Oct 9, 2017 at 9:58 AM, Ilya Biryukov via cfe-commits wrote: > Author: ibiryukov > Date: Mon Oct 9 09:58:16 2017 > New Revision: 315214 > > URL: http://llvm.org/viewvc/llvm-project?rev=315214=rev > Log: > [clangd] Added a command-line arg to mirror clangd

Re: r312595 - [Darwin] Enable -fstack-protector (back) by default with -ffreestanding

On Tue, Sep 5, 2017 at 4:58 PM, Joerg Sonnenberger via cfe-commits <cfe-commits@lists.llvm.org> wrote: > On Tue, Sep 05, 2017 at 11:50:58PM -0000, Bruno Cardoso Lopes via cfe-commits > wrote: >> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp >> URL: >> http:

r312599 - Fix indentation mistake from r312595

Author: bruno Date: Tue Sep 5 17:44:10 2017 New Revision: 312599 URL: http://llvm.org/viewvc/llvm-project?rev=312599=rev Log: Fix indentation mistake from r312595 Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL:

r312595 - [Darwin] Enable -fstack-protector (back) by default with -ffreestanding

Author: bruno Date: Tue Sep 5 16:50:58 2017 New Revision: 312595 URL: http://llvm.org/viewvc/llvm-project?rev=312595=rev Log: [Darwin] Enable -fstack-protector (back) by default with -ffreestanding Go back to behavior prior to r289005. rdar://problem/32987198 Modified:

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

On Fri, Aug 11, 2017 at 9:27 PM, Richard Smith <rich...@metafoo.co.uk> wrote: > On 11 August 2017 at 16:51, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith <rich...@metafoo.co.uk> &g

r310775 - Revert "[Modules] Prevent #import to reenter header if not building a module."

Author: bruno Date: Fri Aug 11 18:38:26 2017 New Revision: 310775 URL: http://llvm.org/viewvc/llvm-project?rev=310775=rev Log: Revert "[Modules] Prevent #import to reenter header if not building a module." This reverts commit r310605. Richard pointed out a better way to achieve this, which I'll

Re: r310706 - [modules] Set the lexical DC for dummy tag decls that refer to hidden

Hi Alex, On Fri, Aug 11, 2017 at 9:06 AM, Alex Lorenz via cfe-commits wrote: > Author: arphaman > Date: Fri Aug 11 05:06:52 2017 > New Revision: 310706 > > URL: http://llvm.org/viewvc/llvm-project?rev=310706=rev > Log: > [modules] Set the lexical DC for dummy tag

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

; On Thu, Aug 10, 2017 at 9:38 AM, Bruno Cardoso Lopes >> <bruno.card...@gmail.com> wrote: >> > Hi Hans, can we please get this merged into 5.0? >> > >> > Thanks, >> > >> > On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits >&

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

Hi Hans, can we please get this merged into 5.0? Thanks, On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits <cfe-commits@lists.llvm.org> wrote: > Author: bruno > Date: Thu Aug 10 08:16:24 2017 > New Revision: 310605 > > URL: http://llvm.org/viewvc/llvm-p

r310605 - [Modules] Prevent #import to reenter header if not building a module.

Author: bruno Date: Thu Aug 10 08:16:24 2017 New Revision: 310605 URL: http://llvm.org/viewvc/llvm-project?rev=310605=rev Log: [Modules] Prevent #import to reenter header if not building a module. When non-modular headers are imported while not building a module but in -fmodules mode, be

Re: r309752 - [Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7

; it as "release blocker", is that enough for you to see it? or next >> time is something I can do to make your life easier? Cool, thanks again! >> Thanks, >> >> On Tue, Aug 1, 2017 at 3:10 PM, Bruno Cardoso Lopes via cfe-commits >> <cfe-commits@lists.llvm

r309752 - [Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7

Author: bruno Date: Tue Aug 1 15:10:36 2017 New Revision: 309752 URL: http://llvm.org/viewvc/llvm-project?rev=309752=rev Log: [Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7 This fixes PR31504 and it's a follow up from adding #include_next for Darwin in r289018.

r309722 - [Sema] Fix lax conversion between non ext vectors

Author: bruno Date: Tue Aug 1 12:05:25 2017 New Revision: 309722 URL: http://llvm.org/viewvc/llvm-project?rev=309722=rev Log: [Sema] Fix lax conversion between non ext vectors r282968 introduced a regression due to the lack of proper testing. Re-add lax conversion support between non ext

[libcxx] r308225 - Check for _MSC_VER before defining _LIBCPP_MSVCRT

Author: bruno Date: Mon Jul 17 14:52:31 2017 New Revision: 308225 URL: http://llvm.org/viewvc/llvm-project?rev=308225=rev Log: Check for _MSC_VER before defining _LIBCPP_MSVCRT Some targets (e.g. Darwin) might have the Win32 API available, but they do not use MSVC CRT. Assume _LIBCPP_MSVCRT only

Re: r307296 - [Objective-C] Fix non-determinism in clang

Awesome, thanks! On Thu, Jul 6, 2017 at 11:49 AM, Mandeep Singh Grang via cfe-commits wrote: > Author: mgrang > Date: Thu Jul 6 11:49:57 2017 > New Revision: 307296 > > URL: http://llvm.org/viewvc/llvm-project?rev=307296=rev > Log: > [Objective-C] Fix

r306918 - [Modules] Implement ODR-like semantics for tag types in C/ObjC

Author: bruno Date: Fri Jun 30 17:06:47 2017 New Revision: 306918 URL: http://llvm.org/viewvc/llvm-project?rev=306918=rev Log: [Modules] Implement ODR-like semantics for tag types in C/ObjC Allow ODR for ObjC/C in the sense that we won't keep more that one definition around (merge them).

r306917 - Change enumerator default linkage type for C

Author: bruno Date: Fri Jun 30 17:06:27 2017 New Revision: 306917 URL: http://llvm.org/viewvc/llvm-project?rev=306917=rev Log: Change enumerator default linkage type for C Redeclaration lookup should never find hidden enumerators in C, because they do not have linkage (C11 6.2.2/6) The linkage

Re: r306583 - [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

Hi Graydon, Can you please add a testcase for this? Thanks, On Wed, Jun 28, 2017 at 11:36 AM, Graydon Hoare via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: graydon > Date: Wed Jun 28 11:36:27 2017 > New Revision: 306583 > > URL: http://llvm.org/viewvc/llvm-project?rev=306583=rev

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

On Wed, Jun 21, 2017 at 4:56 PM, Richard Smith wrote: > On 21 June 2017 at 16:55, Bruno Cardoso Lopes > wrote: >> >> On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith >> wrote: >> > On 21 June 2017 at 14:51, Bruno Cardoso Lopes

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith wrote: > On 21 June 2017 at 14:51, Bruno Cardoso Lopes > wrote: >> >> Hi Richard, >> >> Somehow this commit caused some methods in ObjC to do not become >> visible in an interface when compiling with

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

Hi Richard, Somehow this commit caused some methods in ObjC to do not become visible in an interface when compiling with modules on. I filed https://bugs.llvm.org/show_bug.cgi?id=33552, any idea what could have gone wrong here? `hasVisibleDeclarationImpl` doesn't seem to have changed the logic.

r305875 - Support MS builtins using 'long' on LP64 platforms

Author: bruno Date: Tue Jun 20 21:20:46 2017 New Revision: 305875 URL: http://llvm.org/viewvc/llvm-project?rev=305875=rev Log: Support MS builtins using 'long' on LP64 platforms This allows for -fms-extensions to work the same on LP64. For example, _BitScanReverse is expected to be 32-bit,

r305874 - Run dos2unix on ms-intrinsics-rotations.c test. NFC

Author: bruno Date: Tue Jun 20 21:20:40 2017 New Revision: 305874 URL: http://llvm.org/viewvc/llvm-project?rev=305874=rev Log: Run dos2unix on ms-intrinsics-rotations.c test. NFC Modified: cfe/trunk/test/CodeGen/ms-intrinsics-rotations.c Modified:

Re: r284060 - Implement MS _BitScan intrinsics

On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith wrote: > > On Jun 16, 2017, at 11:02, Reid Kleckner wrote: > > We should fix it. > > > Agreed. > > We just need a new character code in the builtin function prototype > encoding. Currently there is no

Re: r284060 - Implement MS _BitScan intrinsics

On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes wrote: > On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits > wrote: >> SGTM too. Regarding Duncan's last question -- I can't think of any such >> customer. :) If you all

Re: r284060 - Implement MS _BitScan intrinsics

On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits wrote: > SGTM too. Regarding Duncan's last question -- I can't think of any such > customer. :) If you all think the right thing for clang to do is to infer > LLP64 behavior on LP64 (Darwin) +

Re: r303630 - Allow to use vfs::FileSystem for file accesses inside ASTUnit.

On Wed, May 24, 2017 at 12:18 AM, Ilya Biryukov wrote: > We test it in clangd (https://reviews.llvm.org/D33416). > Logically, it's a single change, split into two part: for cfe and > clang-tools-extra. I see, thanks! > > On Wed, May 24, 2017 at 1:48 AM, Bruno Cardoso

r302771 - Make tests from r302765 windows friendly

Author: bruno Date: Thu May 11 02:06:52 2017 New Revision: 302771 URL: http://llvm.org/viewvc/llvm-project?rev=302771=rev Log: Make tests from r302765 windows friendly and appease: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2030 Modified:

r302765 - [Sema] Improve redefinition errors pointing to the same header

Author: bruno Date: Thu May 11 01:20:07 2017 New Revision: 302765 URL: http://llvm.org/viewvc/llvm-project?rev=302765=rev Log: [Sema] Improve redefinition errors pointing to the same header Diagnostics related to redefinition errors that point to the same header file do not provide much

r302491 - [Modules] Allow umbrella frameworks to define private submodules for subframeworks

Author: bruno Date: Mon May 8 19:41:38 2017 New Revision: 302491 URL: http://llvm.org/viewvc/llvm-project?rev=302491=rev Log: [Modules] Allow umbrella frameworks to define private submodules for subframeworks In r298391 we fixed the umbrella framework model to work when submodules named

Re: r301613 - clang/test/Index/index-module.m: Relax expressions to satisfy DOSish path separator \\, since r301597.

Thanks!! On Thu, Apr 27, 2017 at 9:17 PM, NAKAMURA Takumi via cfe-commits wrote: > Author: chapuni > Date: Thu Apr 27 23:17:31 2017 > New Revision: 301613 > > URL: http://llvm.org/viewvc/llvm-project?rev=301613=rev > Log: > clang/test/Index/index-module.m: Relax

Re: r301610 - Move functionality for handling module maps as inputs from the -emit-module

On Thu, Apr 27, 2017 at 6:49 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Apr 27 20:49:42 2017 > New Revision: 301610 > > URL: http://llvm.org/viewvc/llvm-project?rev=301610=rev > Log: > Move functionality for handling module maps as inputs

Re: r301597 - [Modules] Improve diagnostics for incomplete umbrella

r 27, 2017 at 3:29 PM, Bruno Cardoso Lopes via cfe-commits <cfe-commits@lists.llvm.org> wrote: > Author: bruno > Date: Thu Apr 27 17:29:14 2017 > New Revision: 301597 > > URL: http://llvm.org/viewvc/llvm-project?rev=301597=rev > Log: > [Modules] Improve diagnostics

r301597 - [Modules] Improve diagnostics for incomplete umbrella

Author: bruno Date: Thu Apr 27 17:29:14 2017 New Revision: 301597 URL: http://llvm.org/viewvc/llvm-project?rev=301597=rev Log: [Modules] Improve diagnostics for incomplete umbrella One of the -Wincomplete-umbrella warnings diagnoses when a header is present in the directory but it's not present

r301596 - [Modules] Refactor logic for incomplete umbrella warnings. NFC

Author: bruno Date: Thu Apr 27 17:29:10 2017 New Revision: 301596 URL: http://llvm.org/viewvc/llvm-project?rev=301596=rev Log: [Modules] Refactor logic for incomplete umbrella warnings. NFC Modified: cfe/trunk/include/clang/Lex/Preprocessor.h cfe/trunk/lib/Lex/PPLexerChange.cpp

r301453 - [Modules] Fix a crash-on-invalid with overloaded functions

Author: bruno Date: Wed Apr 26 15:13:45 2017 New Revision: 301453 URL: http://llvm.org/viewvc/llvm-project?rev=301453=rev Log: [Modules] Fix a crash-on-invalid with overloaded functions Do not add an overload if the function doesn't have a prototype; this can happen if, for instance, a

r301382 - [Modules][ObjC] Check definition from canonical decl on designated initializers

Author: bruno Date: Wed Apr 26 00:06:20 2017 New Revision: 301382 URL: http://llvm.org/viewvc/llvm-project?rev=301382=rev Log: [Modules][ObjC] Check definition from canonical decl on designated initializers Use definition from canonical decl when checking for designated initializers. This is

Re: r289018 - [Headers] Enable #include_next on Darwin

gt;> On Wed, Dec 7, 2016 at 9:13 PM, Bruno Cardoso Lopes via cfe-commits >>> <cfe-commits@lists.llvm.org> wrote: >>>> Author: bruno >>>> Date: Wed Dec 7 20:13:56 2016 >>>> New Revision: 289018 >>>> >>>> URL: http://llv

Re: r289018 - [Headers] Enable #include_next on Darwin

On Tue, Apr 25, 2017 at 6:29 AM, Aaron Ballman <aa...@aaronballman.com> wrote: > On Wed, Dec 7, 2016 at 9:13 PM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> Author: bruno >> Date: Wed Dec 7 20:13:56 2016 >> New Revision: 2890

r301261 - [Modules] Fix test to wipe out the cache before using it

Author: bruno Date: Mon Apr 24 16:58:13 2017 New Revision: 301261 URL: http://llvm.org/viewvc/llvm-project?rev=301261=rev Log: [Modules] Fix test to wipe out the cache before using it This should appease bots: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental_check/35914

Re: r259901 - [modules] Separately track whether an identifier's preprocessor information and

Hi Richard, FTR, this caused http://bugs.llvm.org/show_bug.cgi?id=32693 Any suggestions on how to approach this? On Fri, Feb 5, 2016 at 11:03 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Fri Feb 5 13:03:40 2016 > New Revision: 259901 > > URL:

r300108 - [Modules] Enable local submodule visibility for ObjC/C

Author: bruno Date: Wed Apr 12 16:46:16 2017 New Revision: 300108 URL: http://llvm.org/viewvc/llvm-project?rev=300108=rev Log: [Modules] Enable local submodule visibility for ObjC/C Remove the restriction where this is only valid with C++ rdar://problem/29055656 Differential Revision:

r300109 - [Driver] Add compiler option to generate a reproducer

Author: bruno Date: Wed Apr 12 16:46:20 2017 New Revision: 300109 URL: http://llvm.org/viewvc/llvm-project?rev=300109=rev Log: [Driver] Add compiler option to generate a reproducer One way to currently test the reproducers is to setup "FORCE_CLANG_DIAGNOSTICS_CRASH=1" before invoking clang. This

r300027 - [Modules] Remove darwin specific code to check for SystemVersion.plist

Author: bruno Date: Tue Apr 11 23:49:00 2017 New Revision: 300027 URL: http://llvm.org/viewvc/llvm-project?rev=300027=rev Log: [Modules] Remove darwin specific code to check for SystemVersion.plist This isn't need anymore and modules options -fbuild-session-file and

r298464 - [Modules] Rebuild modules on umbrella header mismatch

Author: bruno Date: Tue Mar 21 19:11:21 2017 New Revision: 298464 URL: http://llvm.org/viewvc/llvm-project?rev=298464=rev Log: [Modules] Rebuild modules on umbrella header mismatch This restores behavior pre-r230064 since after PCMCache work (r298278) we don't reload PCMs from disk within the

r298391 - [Modules] Find PrivateHeaders when looking into subframeworks

Author: bruno Date: Tue Mar 21 11:43:51 2017 New Revision: 298391 URL: http://llvm.org/viewvc/llvm-project?rev=298391=rev Log: [Modules] Find PrivateHeaders when looking into subframeworks Fix the current parsing of subframeworks in modulemaps to lookup for headers based on whether they are

r298175 - [Modules] In case of lock timeout, fallback and build module

Author: bruno Date: Fri Mar 17 19:26:18 2017 New Revision: 298175 URL: http://llvm.org/viewvc/llvm-project?rev=298175=rev Log: [Modules] In case of lock timeout, fallback and build module Duncan's r298165 introduced the PCMCache mechanism, which guarantees that locks aren't necessary anymore for

r298012 - [Modules] Add documentation on private frameworks

Author: bruno Date: Thu Mar 16 18:18:55 2017 New Revision: 298012 URL: http://llvm.org/viewvc/llvm-project?rev=298012=rev Log: [Modules] Add documentation on private frameworks Expand a bit on private modules with some guidance on how to write them in the context of frameworks.

r298013 - [Headers] Reapply: Add #include_next for tgmath.h on Darwin

Author: bruno Date: Thu Mar 16 18:19:00 2017 New Revision: 298013 URL: http://llvm.org/viewvc/llvm-project?rev=298013=rev Log: [Headers] Reapply: Add #include_next for tgmath.h on Darwin Reapply r289181 but rename the include guard to avoid conflict with the one from Darwin. Allow darwin to

Re: [libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

Hi Eric, I fixed the build for darwin in r297703, let me know if you have any comments. Thanks, On Mon, Mar 13, 2017 at 3:04 PM, Bruno Cardoso Lopes wrote: > Hi Eric, > >> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR >> @@ -62,12 +66,7 @@ if (APPLE

[libcxx] r297703 - Fix cmake to find the compiler-rt libs on darwin

Author: bruno Date: Mon Mar 13 23:12:29 2017 New Revision: 297703 URL: http://llvm.org/viewvc/llvm-project?rev=297703=rev Log: Fix cmake to find the compiler-rt libs on darwin Followup for r297553, which left darwin in a broken state

Re: [libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

Hi Eric, > if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR > @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER) > message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not > supported on OS X") >endif() >if (LIBFILE) > -execute_process(COMMAND

r296656 - [PCH] Avoid VarDecl emission attempt if no owning module avaiable

Author: bruno Date: Wed Mar 1 13:18:42 2017 New Revision: 296656 URL: http://llvm.org/viewvc/llvm-project?rev=296656=rev Log: [PCH] Avoid VarDecl emission attempt if no owning module avaiable This is a stopgap fix for PR31863, a regression introduced in r276159. Consider this snippet: struct

r294362 - [ASTReader] Improve ReadASTBlock error message when module not available

Author: bruno Date: Tue Feb 7 15:55:02 2017 New Revision: 294362 URL: http://llvm.org/viewvc/llvm-project?rev=294362=rev Log: [ASTReader] Improve ReadASTBlock error message when module not available Point to the PCM file that could not be found. rdar://problem/30381981 Modified:

r294361 - [PCH] Fix a regression when PCH is used with -fmodules

Author: bruno Date: Tue Feb 7 15:54:57 2017 New Revision: 294361 URL: http://llvm.org/viewvc/llvm-project?rev=294361=rev Log: [PCH] Fix a regression when PCH is used with -fmodules Following up on r291465 after a regression in r276159. When we use -fmodule-name=X while building a PCH, modular

r292635 - [Sema] Remove dead typedef

Author: bruno Date: Fri Jan 20 13:04:01 2017 New Revision: 292635 URL: http://llvm.org/viewvc/llvm-project?rev=292635=rev Log: [Sema] Remove dead typedef Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL:

r291794 - [Modules] Fix misleading warning about missing textual header in umbrella header

Author: bruno Date: Thu Jan 12 13:15:33 2017 New Revision: 291794 URL: http://llvm.org/viewvc/llvm-project?rev=291794=rev Log: [Modules] Fix misleading warning about missing textual header in umbrella header When a textual header is present inside a umbrella dir but not in the header, we get the

r291644 - [Modules] Support #import when entering files with modules

Author: bruno Date: Tue Jan 10 20:14:51 2017 New Revision: 291644 URL: http://llvm.org/viewvc/llvm-project?rev=291644=rev Log: [Modules] Support #import when entering files with modules Textual headers and builtins that are #import'd from different modules should get re-entered when these

Re: [libcxx] r291466 - [Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW

obably -mmacosx-version-min=10.11. Any > thoughts on what's going wrong? > > On Mon, Jan 9, 2017 at 11:21 AM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: bruno >> Date: Mon Jan 9 13:21:48 2017 >> New Revision: 291466

[libcxx] r291517 - [Chrono][Darwin] Include header for gettimeofday

Author: bruno Date: Mon Jan 9 18:51:02 2017 New Revision: 291517 URL: http://llvm.org/viewvc/llvm-project?rev=291517=rev Log: [Chrono][Darwin] Include header for gettimeofday Followup on r291466 and include the proper header. This fixes:

[libcxx] r291466 - [Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW

Author: bruno Date: Mon Jan 9 13:21:48 2017 New Revision: 291466 URL: http://llvm.org/viewvc/llvm-project?rev=291466=rev Log: [Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW Use CLOCK_UPTIME_RAW in case clock_gettime is available on Darwin. On Apple platforms only CLOCK_UPTIME_RAW or

r290326 - [CrashReproducer] Add support for merging -ivfsoverlay

Author: bruno Date: Thu Dec 22 01:06:03 2016 New Revision: 290326 URL: http://llvm.org/viewvc/llvm-project?rev=290326=rev Log: [CrashReproducer] Add support for merging -ivfsoverlay Merge all VFS mapped files inside -ivfsoverlay inputs into the vfs overlay provided by the crash reproducer. This

<    1   2   3   4   5   6   >