bruno added a subscriber: bruno.
bruno added a comment.
Hi Paul,
I'm interested in this patch. Do you have any plans to wrap it up?
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
bruno closed this revision.
bruno added a comment.
Thanks Doug!
Committed r281383
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue Sep 13 15:04:35 2016
New Revision: 281383
URL: http://llvm.org/viewvc/llvm-project?rev=281383&view=rev
Log:
[SemaObjC] Be more strict while parsing type arguments and protocols
Fix a crash-on-invalid.
When parsing type arguments and protocols,
parseObjCTypeArgsOrProtocolQ
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added a subscriber: cfe-commits.
Currently, driver level warnings do not show option names (e.g. warning:
complain about foo [-Woption-name]) in a diagnostic unless
-fdiagnostics-show-option is explictly specified. OTOH, the driv
bruno created this revision.
bruno added a reviewer: rnk.
bruno added subscribers: cfe-commits, ahatanak.
Support lax conversions on compound assignment expressions like:
typedef __attribute__((vector_size(8))) double float64x1_t;
typedef __attribute__((vector_size(16))) double float64x2_t;
bruno added a comment.
Ping!
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
In https://reviews.llvm.org/D23852#529308, @aaron.ballman wrote:
> In https://reviews.llvm.org/D23852#525291, @doug.gregor wrote:
>
> > This will work, but it's *really* unfortunate to put tentative parsing into
> > this code path because tentative parsing is far fr
On Wed, Aug 31, 2016 at 11:00 PM, Justin Bogner wrote:
> Chris Bieneman writes:
>> beanz created this revision.
>> beanz added reviewers: bogner, zaks.anna, bruno, filcab.
>> beanz added a subscriber: cfe-commits.
>> Herald added a subscriber: emaste.
>>
>> The FreeBSD and GNUTools drivers suppor
bruno added inline comments.
Comment at: docs/CommandGuide/clang.rst:114
@@ -110,1 +113,3 @@
+ compiler-rt.
+
.. option:: -ansi
zlei wrote:
> bruno wrote:
> > It might be worth mentioning what's the default behaviour in case the flag
> > isn't specified?
> This
bruno added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:276
@@ +275,3 @@
+def warn_drv_sanitizers_and_nodefaultlibs : Warning<
+ "Passing -nodefaultlibs and -fsanitize has resulted in linking sanitizer
runtimes.">,
+ InGroup>;
What
bruno added a comment.
Hi Chris,
Thanks for doing this.
Comment at: lib/Driver/Driver.cpp:1554
@@ -1551,1 +1553,3 @@
+Args.hasArg(options::OPT_fsanitize_EQ))
+ Diag(clang::diag::warn_drv_sanitizers_and_nodefaultlibs);
}
How hard is to fire the w
bruno added a subscriber: bruno.
bruno added a comment.
Hi Lei,
Thanks for the doc improvement!
Comment at: docs/CommandGuide/clang.rst:114
@@ -110,1 +113,3 @@
+ compiler-rt.
+
.. option:: -ansi
It might be worth mentioning what's the default behaviour in case
bruno closed this revision.
bruno added a comment.
Thanks Richard. r280159
https://reviews.llvm.org/D23905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue Aug 30 16:25:42 2016
New Revision: 280159
URL: http://llvm.org/viewvc/llvm-project?rev=280159&view=rev
Log:
[Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.
This adds support for modules that require (no-)gnu-inline-asm
environment, such as the comp
bruno added a subscriber: bruno.
bruno added a comment.
Regardless of the way we decide to go with this, it would be nice if a driver
level warning is used to tell users about any non-obvious assumed behavior
when these flags are used together.
https://reviews.llvm.org/D24048
_
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Nice, LGTM
https://reviews.llvm.org/D24042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
bruno added a comment.
Ping!
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D23905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
https://reviews.llvm.org/D23837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
bruno updated the summary for this revision.
bruno updated this revision to Diff 69456.
bruno added a comment.
Updated patch and changed approach after Doug's comment.
https://reviews.llvm.org/D23852
Files:
lib/Parse/ParseDecl.cpp
lib/Parse/ParseObjc.cpp
lib/Parse/Parser.cpp
test/SemaOb
bruno updated this revision to Diff 69392.
bruno added a comment.
Update patch after Richard's comment
https://reviews.llvm.org/D23905
Files:
docs/Modules.rst
lib/Basic/Module.cpp
lib/Headers/module.modulemap
test/Modules/Inputs/GNUAsm/NeedsGNUInlineAsm.framework/Headers/NeedsGNUInline
On Thu, Aug 25, 2016 at 9:52 PM, Richard Smith wrote:
> On 25 Aug 2016 7:37 p.m., "Bruno Cardoso Lopes"
> wrote:
>
> bruno created this revision.
> bruno added a reviewer: rsmith.
> bruno added subscribers: cfe-commits, eladcohen.
>
> This adds support for modules that require (no-)gnu-inline-asm
bruno abandoned this revision.
bruno added a comment.
Abandon in favor of https://reviews.llvm.org/D23905
https://reviews.llvm.org/D23859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, eladcohen.
This adds support for modules that require (no-)gnu-inline-asm
environment, such as the compiler builtin cpuid submodule.
This is the gnu-inline-asm variant of https://reviews.llvm.org/D2
bruno closed this revision.
bruno added a comment.
Applied your suggestions and committed r279754. Thanks!
https://reviews.llvm.org/D23860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: bruno
Date: Thu Aug 25 12:09:33 2016
New Revision: 279754
URL: http://llvm.org/viewvc/llvm-project?rev=279754&view=rev
Log:
[Sema][Comments] Add support for TypeAliasTemplate
Emit proper diagnostics when -Wdocumentation is used with constructs such as:
template
using fn = int(T aaa,
bruno created this revision.
bruno added a reviewer: gribozavr.
bruno added a subscriber: cfe-commits.
Emit proper diagnostics when -Wdocumentation is used with constructs such as:
template
using fn = int(T aaa, int ccc);
Previously clang wouldn't recognize the function and complain with
'co
Author: bruno
Date: Wed Aug 24 19:22:08 2016
New Revision: 279691
URL: http://llvm.org/viewvc/llvm-project?rev=279691&view=rev
Log:
[Sema][Comments] Factor out function type loc logic. NFCI
This is in prepatation for @param TypeAliasTemplate support.
Modified:
cfe/trunk/lib/AST/Comment.cpp
bruno created this revision.
bruno added reviewers: rsmith, echristo.
bruno added subscribers: cfe-commits, friss.
Herald added a subscriber: mehdi_amini.
When building with -fno-gnu-inline-asm and -fmodules on Darwin, the compilation
might fail if some of the implicit modules try to use gnu asm
bruno closed this revision.
bruno added a comment.
r279662
https://reviews.llvm.org/D23783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Wed Aug 24 16:11:43 2016
New Revision: 279662
URL: http://llvm.org/viewvc/llvm-project?rev=279662&view=rev
Log:
[Sema][Comments] Support @param with c++ 'using' keyword
Give appropriate warnings with -Wdocumentation for @param comments
that refer to function aliases defined wi
bruno created this revision.
bruno added a reviewer: doug.gregor.
bruno added subscribers: cfe-commits, manmanren.
Fix a crash-on-invalid.
When parsing type arguments and protocols, ParseTypeName() tries to find
matching tokens for '[', '(', etc whenever they appear among potential
type names. If
bruno added a comment.
Hi Olivier,
Can you add a test? Can you also include some context to the patch?
Thanks,
https://reviews.llvm.org/D23837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: bruno
Date: Mon Aug 22 16:50:22 2016
New Revision: 279481
URL: http://llvm.org/viewvc/llvm-project?rev=279481&view=rev
Log:
[SemaObjC] Do not RebuildObjCMessageExpr without valid method decl
Fix crash-on-invalid in ObjC Sema by avoiding to rebuild a message
expression to a 'super' class i
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added a subscriber: cfe-commits.
Give appropriate warnings with -Wdocumentation for @param comments
that refer to function aliases defined with 'using'. Very similar
to typedef's behavior. Support for TypeAliasTemplateDecl comes ne
Author: bruno
Date: Fri Aug 12 13:18:24 2016
New Revision: 278543
URL: http://llvm.org/viewvc/llvm-project?rev=278543&view=rev
Log:
Reapply [VFS] Skip non existent files from the VFS tree
Reapply r278457 with test fixed to not abouse fs case sensitivity.
When the VFS uses a YAML file, the real f
Author: bruno
Date: Thu Aug 11 21:17:26 2016
New Revision: 278459
URL: http://llvm.org/viewvc/llvm-project?rev=278459&view=rev
Log:
Revert "[VFS] Skip non existent files from the VFS tree"
Breaking bots:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/27281/
This rever
bruno accepted this revision.
bruno added a reviewer: bruno.
bruno added a comment.
This revision is now accepted and ready to land.
Applied your comments, and committed in r278456!
Thanks
https://reviews.llvm.org/D23422
___
cfe-commits mailing lis
Author: bruno
Date: Thu Aug 11 20:51:04 2016
New Revision: 278457
URL: http://llvm.org/viewvc/llvm-project?rev=278457&view=rev
Log:
[VFS] Skip non existent files from the VFS tree
When the VFS uses a YAML file, the real file path for a
virtual file is described in the "external-contents" field. E
Author: bruno
Date: Thu Aug 11 20:50:53 2016
New Revision: 278456
URL: http://llvm.org/viewvc/llvm-project?rev=278456&view=rev
Log:
[VFS] Add 'ignore-non-existent-contents' field to YAML files
Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path
obtained via 'external-conten
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path
obtained via 'external-contents' should cause iteration on the VFS to stop.
If 'true', the VFS should ignore the entr
On Thu, Aug 11, 2016 at 5:43 AM, Joerg Sonnenberger via cfe-commits
wrote:
>
> On Wed, Aug 10, 2016 at 02:36:01PM -0700, Bruno Cardoso Lopes wrote:
> > Hi Joerg,
> >
> > > Given that bzero is pretty much non-standard at this point, I strongly
> > > dislike the approach of checking only the functio
Author: bruno
Date: Thu Aug 11 13:33:15 2016
New Revision: 278379
URL: http://llvm.org/viewvc/llvm-project?rev=278379&view=rev
Log:
[Sema] Add more strict check for sizeof diagnostics for bzero
Follow-up from r278264 after Joerg's feedback.
Since bzero is not standard, be more strict: also check
bruno added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:1438-1450
@@ -1437,3 +1437,15 @@
// Search for a module with the given name.
Module = PP->getHeaderSearchInfo().lookupModule(ModuleName);
-if (!Module) {
+HeaderSearchOptions &HSOpts =
+
Hi Joerg,
> Given that bzero is pretty much non-standard at this point, I strongly
> dislike the approach of checking only the function name.
Thanks for the feedback. bzero it's widely used though, I think it's a
usability win to perform a diagnostic here, despite bzero being
non-standard.
Is th
This typo was exactly the reason why, r278264. Thanks
On Fri, Aug 5, 2016 at 10:09 AM, David Majnemer
wrote:
>
>
> On Thu, Aug 4, 2016 at 4:55 PM, Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> Author: bruno
>> Date: Thu Aug 4 18:55:22 2016
>>
Author: bruno
Date: Wed Aug 10 13:34:47 2016
New Revision: 278264
URL: http://llvm.org/viewvc/llvm-project?rev=278264&view=rev
Log:
Reapply [Sema] Add sizeof diagnostics for bzero
Reapply r277787. For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct st
Thanks Matthias!
On Tue, Aug 9, 2016 at 6:02 PM, Matthias Braun via cfe-commits
wrote:
> Author: matze
> Date: Tue Aug 9 20:02:28 2016
> New Revision: 278191
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278191&view=rev
> Log:
> test/hard_link_count(): Fix test on darwin
>
> The hard link cou
Ping!
On Thu, Aug 4, 2016 at 8:03 AM, Adrian Prantl wrote:
>
>> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes
>> wrote:
>>
>> Hi Eric,
>>
>> After we upgraded our green dragon bots to El Captain (10.11), the
>> test below started to fail on some of our machines:
>>
>> --
>> test/std/experime
regards,
> Gabor Ballabas
>
>
> On 08/05/2016 01:55 AM, Bruno Cardoso Lopes via cfe-commits wrote:
>>
>> Author: bruno
>> Date: Thu Aug 4 18:55:22 2016
>> New Revision: 277787
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=277787&vie
Author: bruno
Date: Fri Aug 5 11:41:00 2016
New Revision: 277830
URL: http://llvm.org/viewvc/llvm-project?rev=277830&view=rev
Log:
Revert "[Sema] Add sizeof diagnostics for bzero"
This reverts commit r277787, which caused PR28870.
Modified:
cfe/trunk/lib/AST/Decl.cpp
cfe/trunk/lib/Sema/
bruno closed this revision.
bruno added a comment.
Thanks! Committed in r277787
https://reviews.llvm.org/D22525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Thu Aug 4 18:55:22 2016
New Revision: 277787
URL: http://llvm.org/viewvc/llvm-project?rev=277787&view=rev
Log:
[Sema] Add sizeof diagnostics for bzero
For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct stat *stamps) {
bzero(s
Hi Eric,
After we upgraded our green dragon bots to El Captain (10.11), the
test below started to fail on some of our machines:
--
test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp
TEST_CASE(hard_link_count_for_directory)
{
uintmax_t DirExpect = 3;
Hi Artem,
This broke
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26856,
can you take a look?
Thanks,
On Tue, Aug 2, 2016 at 4:12 PM, Artem Belevich via cfe-commits
wrote:
> Author: tra
> Date: Tue Aug 2 18:12:51 2016
> New Revision: 277542
>
> URL: http://llvm.o
Hi Nirav,
This test is failing on darwin:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574
Can you take a look?
On Wed, Jul 27, 2016 at 12:57 PM, Nirav Dave via cfe-commits
wrote:
> Author: niravd
> Date: Wed Jul 27 14:57:40 2016
> New Revision: 276907
>
> URL: h
bruno closed this revision.
bruno added a comment.
Thanks Manman, Committed r276020
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue Jul 19 15:21:18 2016
New Revision: 276020
URL: http://llvm.org/viewvc/llvm-project?rev=276020&view=rev
Log:
[SemaObjC] Improve ObjCDictionaryLiteral and ObjCArryLiteral diagnostics
Sema actions on ObjCDictionaryLiteral and ObjCArryLiteral are currently
done as a side-effec
bruno created this revision.
bruno added a reviewer: zaks.anna.
bruno added a subscriber: cfe-commits.
For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct stat *stamps) {
memset(stamps, 0, sizeof(stamps));
}
t.c:7:28: warning: 'memset' call op
bruno added a comment.
Ping!
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Thanks, r275907.
https://reviews.llvm.org/D22248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Mon Jul 18 15:37:06 2016
New Revision: 275907
URL: http://llvm.org/viewvc/llvm-project?rev=275907&view=rev
Log:
[Sema] Create a separate group for incompatible function pointer warning
Give incompatible function pointer warning its own diagnostic group
but still leave it as a
bruno created this revision.
bruno added reviewers: rsmith, doug.gregor.
bruno added subscribers: cfe-commits, dexonsmith.
C++ static destructors can be problematic in multi-threaded environment. Some
of the issues users often complain about include:
1. Teardown ordering: crashes when one thread
bruno added a subscriber: bruno.
Comment at: lib/Headers/cpuid.h:114
@@ -109,2 +113,3 @@
#define bit_AVX 0x1000
+#define bit_F16C0x2000
#define bit_RDRND 0x4000
Isn't this one also meant for gcc compat?
https://reviews.llvm.or
bruno added a subscriber: bruno.
bruno accepted this revision.
bruno added a reviewer: bruno.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM with one small fix, see below.
Comment at: lib/Driver/Tools.cpp:6379
@@ +6378,3 @@
+void ClangAs::AddX86Targ
bruno added a subscriber: bruno.
bruno added a comment.
Hi,
Can you provide more details on what the build issues are? It seems that the
line you introduce is covered in the ifdef below, wonder why it's not
triggering in your build?
Repository:
rL LLVM
https://reviews.llvm.org/D22200
__
bruno updated this revision to Diff 64162.
bruno added a comment.
Thanks for the review Manman, I found a much better approach. Updated the patch
to reflect that!
https://reviews.llvm.org/D22183
Files:
lib/Parse/ParseObjc.cpp
test/SemaObjC/objc-array-literal.m
test/SemaObjC/objc-dictiona
bruno added a comment.
Ping!
https://reviews.llvm.org/D22248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: bob.wilson, doug.gregor, krememek.
bruno added subscribers: cfe-commits, dexonsmith.
Give incompatible pointer warning for function pointers its own diagnostic
group while leaving it as a subgroup of incompatible-pointer-types. This is in
prepa
bruno created this revision.
bruno added reviewers: manmanren, doug.gregor.
bruno added a subscriber: cfe-commits.
Calls to TransformExpr for NSDictionary elements (keys and values) in
TransformObjCDictionaryLiteral might fail to obtain TypoCorrections. This is OK,
but the early exits with ExprErr
bruno closed this revision.
bruno added a comment.
Thanks Reid,
Committed r274646.
http://reviews.llvm.org/D21700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Wed Jul 6 13:05:23 2016
New Revision: 274646
URL: http://llvm.org/viewvc/llvm-project?rev=274646&view=rev
Log:
[SemaExpr] Support assignments from vector to scalars with same size
Before r266366, clang used to support constructs like:
typedef __attribute__((vector_size(8))
bruno updated this revision to Diff 62802.
bruno added a comment.
Update patch after Reid's suggestions.
http://reviews.llvm.org/D21700
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
===
--
bruno added a comment.
In http://reviews.llvm.org/D21700#470103, @rnk wrote:
> After writing r266366, we discovered that GCC accepts none of the code in
> that test case, so we should consider turning -flax-vector-conversions off by
> default.
Makes sense, specially given the non obvious sema
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Cool, thanks! LGTM
http://reviews.llvm.org/D21641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
bruno added a comment.
Ping!
http://reviews.llvm.org/D21700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: rnk, rsmith.
bruno added a subscriber: cfe-commits.
Before r266366, clang used to support constructs like:
typedef __attribute__((vector_size(8))) double float64x1_t;
typedef __attribute__((vector_size(16))) double float64x2_t;
float64x1_t
Hi Andrey,
On Mon, Jun 20, 2016 at 3:31 AM, Andrey Turetskiy via cfe-commits
wrote:
> Author: aturetsk
> Date: Mon Jun 20 05:31:39 2016
> New Revision: 273147
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273147&view=rev
> Log:
> [X86] Add -mno-iamcu option.
>
> Add -mno-iamcu option to:
> 1
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Assuming that it's guaranteed that the other path would always print out the
statistics, LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D21338
__
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Sure! LGTM
http://reviews.llvm.org/D19274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
bruno added a comment.
FTR, I finally test it out for compile time and could not notice any difference
besides noise. Thanks Eric!
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
bruno added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:179
@@ +178,3 @@
+"exception", "iterator", "random", "strstream", "vector",
+"forward_list", "limits", "ratio", "system_error",
+
Applying your patch reveled a bunch of ^M (carriage-return)
bruno added a comment.
Before this goes in again, I want to double check that this doesn't affect
compile time on darwin + frameworks. Will get back to you asap.
Comment at: lib/Lex/PPDirectives.cpp:218
@@ +217,3 @@
+ SmallString<32> LowerInclude{Include};
+ for (char& Ch : L
bruno added inline comments.
Comment at: test/PCH/include-timestamp.cpp:8
@@ +7,3 @@
+// RUN: sleep 1
+// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck
-check-prefix=CHECK-TIMESTAMP %s
+
pgousseau wrote:
> Without the sleep the test fails for me, as it
> The information about whether the file is in a system path is already being
> computed, so it would incur no extra overhead. I'm not sure that's the right
> fix. You are more than welcome to revert the (clang) commit while we think
> of the right fix.
I'm not sure what the right fix is either, b
Author: bruno
Date: Fri Jun 3 20:13:22 2016
New Revision: 271758
URL: http://llvm.org/viewvc/llvm-project?rev=271758&view=rev
Log:
[Modules] Improve diagnostics for LockFileManager errors
Uses error message now provided by LockFileManager in LLVM r271755.
rdar://problem/26529101
Modified:
bruno closed this revision.
bruno added a comment.
Applied your suggestions and committed in r271755!
Thanks
http://reviews.llvm.org/D20942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
I think this should be reverted until we figure out how to solve it.
Moreover, it looks expensive to check for each file if it's within a system
path. I would really like to measure compile time for this change before it
goes definitely in.
On Fri, Jun 3, 2016 at 4:53 PM, Justin Bogner via cfe-com
bruno added a subscriber: llvm-commits.
bruno added a comment.
Adding the right list for this +llvm-commits
http://reviews.llvm.org/D20942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added subscribers: cfe-commits, dexonsmith.
This is currently used by clang to lock access to modules; improve the error
message so that clang can use better output messages from locking error issues.
http://reviews.llvm.or
bruno added inline comments.
Comment at: test/PCH/include-timestamp.cpp:5
@@ +4,3 @@
+// Check timestamp is included by default.
+// RUN: %clang_cc1 -x c++-header -emit-pch -o %t
%S/Inputs/include-timestamp-pch.h
+// RUN: touch %S/Inputs/include-timestamp.h
Can y
bruno closed this revision.
bruno added a comment.
Committed in r271042
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed in r269661
http://reviews.llvm.org/D20266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed in r264971
http://reviews.llvm.org/D18585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Thanks Doug!
Committed r271314
http://reviews.llvm.org/D20451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue May 31 13:46:31 2016
New Revision: 271314
URL: http://llvm.org/viewvc/llvm-project?rev=271314&view=rev
Log:
[Parser] Fix look ahead after EOF while parsing objc message and lambdas
If a closing ')' isn't found for a macro instantiation inside a '[',
the next token is EOF,
Author: bruno
Date: Fri May 27 15:43:00 2016
New Revision: 271042
URL: http://llvm.org/viewvc/llvm-project?rev=271042&view=rev
Log:
[Driver] Fix driver support for color diagnostics
Diagnostics that happen during driver time do not have color output support
unless -fcolor-diagonostic is explicitl
bruno added a comment.
Ping!
http://reviews.llvm.org/D20451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
301 - 400 of 545 matches
Mail list logo
