bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
aturetsk wrote:
> bruno wrote:
> > Taking a look
bruno added a comment.
You can probably find a way to test this by taking a look at
unittests/Basic/VirtualFileSystemTest.cpp
Repository:
rL LLVM
http://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
bruno added a comment.
Hi,
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
Taking a look at this again I don't think there's
Ping on the testcase :-)
On Tue, May 17, 2016 at 9:36 AM, Nico Weber via cfe-commits
wrote:
> Is it possible to write a test for this?
>
> On Tue, May 17, 2016 at 10:34 AM, Cameron Desrochers via cfe-commits
> wrote:
>>
>> Author: cameron314
>> Date: Tue May 17 09:34:53 2016
>> New Revision: 269
bruno added a subscriber: bruno.
bruno added a comment.
Hi Pierre,
Comment at: test/PCH/pragma-once-timestamp.cpp:17
@@ +16,3 @@
+
+// REQUIRES: system-windows
+
Can you move this to the beginning of the file? It makes it easier to spot that
this is windows onl
bruno added a subscriber: bruno.
bruno added a comment.
Hi Cameron,
Can you add a testcase?
Repository:
rL LLVM
http://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
bruno added a comment.
Ping!
http://reviews.llvm.org/D20451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added reviewers: dexonsmith, silvas.
bruno removed subscribers: silvas, dexonsmith.
bruno updated this revision to Diff 57993.
bruno added a comment.
Great idea Duncan, attached a new patch!
http://reviews.llvm.org/D20404
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Driver/T
bruno created this revision.
bruno added reviewers: doug.gregor, rsmith.
bruno added a subscriber: cfe-commits.
If a closing ')' isn't found for a macro instantiation inside a '[',
the next token is EOF, this leads to crashes if we try to look ahead of
that. This could be triggered whenever trying
bruno added a subscriber: bruno.
bruno added a comment.
Hi Manman,
Comment at: lib/Serialization/ASTWriter.cpp:2191
@@ -2191,1 +2190,3 @@
+// We write out exported module macros for PCH as well.
+if (true) {
auto Leafs = PP.getLeafModuleMacros(Name);
-
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, dexonsmith.
Diagnostics that happen during driver time do not have color output
support unless -fcolor-diagonostic is explicitly passed into the driver.
OTOH, it works great for cc1 mode since dianos
Author: bruno
Date: Mon May 16 11:46:01 2016
New Revision: 269661
URL: http://llvm.org/viewvc/llvm-project?rev=269661&view=rev
Log:
[Modules] Use vfs for (recursive) directory iteration
Clang performs directory walk while searching headers inside modules by
using the ::sys::fs instead of ::vfs. T
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
Clang performs directory walk while searching headers inside modules by
using the ::sys::fs instead of ::vfs. This prevents any code that uses
the VFS (e.g, reproducer scripts) to actually find
Author: bruno
Date: Fri May 13 19:00:18 2016
New Revision: 269520
URL: http://llvm.org/viewvc/llvm-project?rev=269520&view=rev
Log:
[VFS] Add level() method to vfs::recursive_directory_iterator
Unlike sys::fs::recursive_directory_iterator,
vfs::recursive_directory_iterator does not implement the
bruno closed this revision.
bruno added a comment.
Thanks Ben!
Committed r269502
http://reviews.llvm.org/D20194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Fri May 13 17:21:51 2016
New Revision: 269502
URL: http://llvm.org/viewvc/llvm-project?rev=269502&view=rev
Log:
[ModuleMap][CrashReproducer] Collect headers from inner frameworks
(1) Collect headers under inner frameworks (frameworks inside other
other frameworks).
(2) Make su
bruno updated this revision to Diff 57263.
bruno added a comment.
Updated after Ben's suggestions!
http://reviews.llvm.org/D20194
Files:
include/clang/Lex/ModuleMap.h
lib/Frontend/ModuleDependencyCollector.cpp
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/crash-recovery/Frameworks/A.framewo
Author: bruno
Date: Thu May 12 14:13:07 2016
New Revision: 269327
URL: http://llvm.org/viewvc/llvm-project?rev=269327&view=rev
Log:
[VFS] Reapply #2: Reconstruct the VFS overlay tree for more accurate lookup
Reapply r269100 and r269270, reverted due to
https://llvm.org/bugs/show_bug.cgi?id=27725.
Author: bruno
Date: Thu May 12 14:13:04 2016
New Revision: 269326
URL: http://llvm.org/viewvc/llvm-project?rev=269326&view=rev
Log:
[Unittests] Reverse the order of arguments for correct debug output
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/
12:29 PM Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> Author: bruno
>> Date: Wed May 11 22:23:36 2016
>> New Revision: 269270
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=269270&view=rev
>> Log:
>> [VFS] Reapply r269100: Reconstruct the V
Author: bruno
Date: Wed May 11 23:43:27 2016
New Revision: 269276
URL: http://llvm.org/viewvc/llvm-project?rev=269276&view=rev
Log:
Revert "[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more
accurate lookup"
Reverts r269270, buildbots still failing:
http://lab.llvm.org:8011/builder
Author: bruno
Date: Wed May 11 22:23:36 2016
New Revision: 269270
URL: http://llvm.org/viewvc/llvm-project?rev=269270&view=rev
Log:
[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup
The way we currently build the internal VFS overlay representation leads
to ineffici
> What are the platform-specifics for crash reproducing? Shouldn't it
> basically be saving some files and storing some data for reconstructing?
Feature-wise the crash reproducer for modules could "just" work for
windows, there should not be anything platform-specific, I never
tested it on windows
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
(1) Collect headers under inner frameworks (frameworks inside other
other frameworks).
(2) Make sure we also collect the right header files inside them.
More info on (2):
Consider a dummy fra
Author: bruno
Date: Wed May 11 15:58:47 2016
New Revision: 269234
URL: http://llvm.org/viewvc/llvm-project?rev=269234&view=rev
Log:
[VFS][Unittests] Make dir iteration tests depend only on content
Do not rely on any specific order while comparing the results of
directory iteration.
Modified:
> I'm glad to help, but it makes me uneasy to have somebody working on a
> filesystem abstraction that does not have ready access to test and debug
> their changes across the major host platforms that LLVM supports (linux,
> mac, windows). Is there any way you can get access? I don't think that
> w
bruno added a comment.
Hi,
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:154
@@ -153,1 +153,3 @@
+def err_drv_cxx_not_supported : Error<
+ "C++ is not supported for target '%0'">;
Are you sure there's no equivalente for this already? I'm surprised!
Hi Sean,
> So sorry! It had gone quiet for a few hours and I wanted to avoid leaving it
> red any longer.
No problem, the priority is to get bot greens!
> Does any platform define a guaranteed directory iteration order? I feel like
> depending on it in the first place is unwise (or maybe I'm mis
; Changes to this VFS code seem to have a trend of breaking on windows. Any
> idea why that is? I can understand things breaking on windows when writing
> low-level parts of an FS abstraction, but this patch seems fairly
> high-level. Is there a missing layering or something?
>
> -
Author: bruno
Date: Tue May 10 17:30:01 2016
New Revision: 269133
URL: http://llvm.org/viewvc/llvm-project?rev=269133&view=rev
Log:
[VFS] One more unittest change to fix win10 buildbot
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5110
Follow up from r2
Author: bruno
Date: Tue May 10 15:20:55 2016
New Revision: 269108
URL: http://llvm.org/viewvc/llvm-project?rev=269108&view=rev
Log:
[VFS] Change unittest to try appeasing win10 buildbot
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5103
Follow up from r
Author: bruno
Date: Tue May 10 13:43:00 2016
New Revision: 269100
URL: http://llvm.org/viewvc/llvm-project?rev=269100&view=rev
Log:
[VFS] Reconstruct the VFS overlay tree for more accurate lookup
The way we currently build the internal VFS overlay representation leads
to inefficient path search a
Author: bruno
Date: Fri May 6 18:58:58 2016
New Revision: 268825
URL: http://llvm.org/viewvc/llvm-project?rev=268825&view=rev
Log:
[CrashReproducer] Always use realpath for destination
When running reproducer scripts we need that original symlinks from the
source filesystem are reproduced in the
Author: bruno
Date: Fri May 6 18:21:50 2016
New Revision: 268819
URL: http://llvm.org/viewvc/llvm-project?rev=268819&view=rev
Log:
[CrashReproducer] Change module map callback signature. NFC
Use a StringRef instead of a FileEntry in the moduleMapAddHeader
callback to allow more flexibility on wh
Author: bruno
Date: Fri May 6 18:21:57 2016
New Revision: 268820
URL: http://llvm.org/viewvc/llvm-project?rev=268820&view=rev
Log:
[VFS] Add dump methods to the VFS overlay tree
Useful when debugging issues within the VFS overlay.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modifie
Author: bruno
Date: Mon May 2 15:20:49 2016
New Revision: 268297
URL: http://llvm.org/viewvc/llvm-project?rev=268297&view=rev
Log:
Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as"
This reverts commit r264813 / 6484b95d634f53dd929c75265ef3c4decf397584.
While using
bruno added a subscriber: bruno.
bruno added a reviewer: bruno.
bruno added a comment.
Hi Andrey,
What about the code / tests that check for this flags?
http://reviews.llvm.org/D19658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
bruno added a comment.
LGTM
http://reviews.llvm.org/D18398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed r266245
http://reviews.llvm.org/D18997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Wed Apr 13 15:59:07 2016
New Revision: 266245
URL: http://llvm.org/viewvc/llvm-project?rev=266245&view=rev
Log:
[SemaObjC] Properly handle mix between type arguments and protocols.
Under certain conditions clang currently fails to properly diagnostic ObjectC
parameter list whe
Author: bruno
Date: Wed Apr 13 14:28:16 2016
New Revision: 266233
URL: http://llvm.org/viewvc/llvm-project?rev=266233&view=rev
Log:
[VFS] Move default values to in-class member initialization. NFC
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified: cfe/trunk/lib/Basic/VirtualFileSy
Author: bruno
Date: Wed Apr 13 14:28:21 2016
New Revision: 266234
URL: http://llvm.org/viewvc/llvm-project?rev=266234&view=rev
Log:
[CrashReproducer] Setup 'use-external-names' in YAML files.
Hide the real paths when rebuilding from VFS by setting up the crash
reproducer to use 'use-external-name
Author: bruno
Date: Wed Apr 13 14:28:24 2016
New Revision: 266235
URL: http://llvm.org/viewvc/llvm-project?rev=266235&view=rev
Log:
[CrashReproducer] Add test to run the reproducer script + modules
Now that we have basic support in place, make sure the reproducer script
works with modules for a s
bruno abandoned this revision.
bruno added a comment.
Hi Ben,
Comment at: lib/Basic/FileManager.cpp:221-223
@@ -220,2 +220,5 @@
// See if there is already an entry in the map.
+ // FIXME: Note that when first requested, the returned file name equals to
the
+ // requested p
bruno updated this revision to Diff 53470.
bruno added a comment.
New patch after Manman's review.
http://reviews.llvm.org/D18997
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseObjc.cpp
lib/Sema/SemaDeclObjC.cpp
test/SemaObjC/parameterized_classes.m
Index: test/SemaObjC/parameterized_
bruno added a comment.
Hi Ben,
Comment at: lib/Basic/FileManager.cpp:221-223
@@ -220,2 +220,5 @@
// See if there is already an entry in the map.
+ // FIXME: Note that when first requested, the returned file name equals to
the
+ // requested path. This is not true when retu
bruno added a comment.
Hi Manman,
Comment at: lib/Parse/ParseObjc.cpp:1697
@@ -1696,3 +1696,3 @@
// We syntactically matched a type argument, so commit to parsing
- // type arguments.
+ // type arguments. Finding protocol arguments after here is an error.
bruno updated this revision to Diff 53363.
bruno added a comment.
Hi Richard & Ben,
Thanks for the review!
I've attached a new patch and changed the approach: made
findUsableModuleForHeader receive a FileName
instead of FileEntry. Answering the questions below:
FileManager::getFile returns th
bruno created this revision.
bruno added a reviewer: doug.gregor.
bruno added subscribers: manmanren, dexonsmith, cfe-commits.
Under certain conditions clang currently fails to properly diagnostic ObjectC
parameter list when type args and protocols are mixed in the same list. This
happens when the
bruno added a comment.
Ping!
http://reviews.llvm.org/D18849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sure, I'll tackle this soon!
On Wed, Apr 6, 2016 at 6:59 PM, Sean Silva wrote:
>
>
> On Wed, Mar 16, 2016 at 7:20 PM, Bruno Cardoso Lopes via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: bruno
>> Date: Wed Mar 16 21:20:43 2016
&
Didn't notice that yield an error, thanks again Sean!
On Wed, Apr 6, 2016 at 7:04 PM, Sean Silva wrote:
>
>
> On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva wrote:
>
>>
>>
>> On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits <
>> cfe-c
Better yet. Committed r265632
Thanks Sean,
On Wed, Apr 6, 2016 at 6:11 PM, Sean Silva wrote:
> We also have toUppercase in include/clang/Basic/CharInfo.h
>
> -- Sean Silva
>
> On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-commits <
> cfe-commits@lists.llvm.or
Author: bruno
Date: Wed Apr 6 20:12:18 2016
New Revision: 265632
URL: http://llvm.org/viewvc/llvm-project?rev=265632&view=rev
Log:
[CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h
Use toUppercase instead of ::toupper()
Modified:
cfe/trunk/lib/Frontend/ModuleDependencyCo
Attempt to fix in r265630.
On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes wrote:
> Thanks Hans, taking a look!
>
> On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg wrote:
>
>> On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits
>> wrote:
>> >
Author: bruno
Date: Wed Apr 6 20:04:09 2016
New Revision: 265630
URL: http://llvm.org/viewvc/llvm-project?rev=265630&view=rev
Log:
[CrashReproducer] Change std::toupper to ::toupper
Attempt to fix windows bots
Modified:
cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp
Modified: cfe/tru
Thanks Hans, taking a look!
On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg wrote:
> On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits
> wrote:
> > Author: bruno
> > Date: Wed Apr 6 19:00:57 2016
> > New Revision: 265622
> >
> > URL: htt
bruno created this revision.
bruno added reviewers: rsmith, benlangmuir, klimek.
bruno added subscribers: aprantl, dexonsmith, cfe-commits.
The reproducer script (generated by the crash reproducer) invokes clang
and tries to rebuild modules using the headers in the .cache/vfs
directory. Depending
Author: bruno
Date: Wed Apr 6 19:00:57 2016
New Revision: 265622
URL: http://llvm.org/viewvc/llvm-project?rev=265622&view=rev
Log:
[CrashReproducer] Setup 'case-sensitive' in YAML files.
The crash reproducer was not setting up case sensitivity in the
VFS yaml files, which defaults to true. Make
Author: bruno
Date: Wed Apr 6 19:00:42 2016
New Revision: 265621
URL: http://llvm.org/viewvc/llvm-project?rev=265621&view=rev
Log:
[CrashReproducer] Move ModuleDependencyCollector method around. NFC
Modified:
cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp
Modified: cfe/trunk/lib/Front
Author: bruno
Date: Mon Apr 4 15:26:57 2016
New Revision: 265343
URL: http://llvm.org/viewvc/llvm-project?rev=265343&view=rev
Log:
[CrashReproducer] Pass -I, -F and -resource-dir to the reproducer script when
using modules/vfs
The reproducer should use -I/-F/-resource-dir in the same way as the
bruno added a subscriber: bruno.
bruno added a comment.
Hi Andrey,
Comment at: include/clang/Driver/Options.td:1281
@@ -1280,1 +1280,3 @@
+def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption,
CoreOption]>,
+ HelpText<"Use Intel MCU ABI.">;
def malign_functions_EQ :
Author: bruno
Date: Fri Apr 1 12:39:08 2016
New Revision: 265162
URL: http://llvm.org/viewvc/llvm-project?rev=265162&view=rev
Log:
[CrashReproducer] Add -fmodule-cache-path to reproducer script
The cc1 invocation in the reproducer script should contain a valid path in
-fmodule-cache-path; for th
bruno added a comment.
Committed r264987!
Comment at: lib/Driver/Driver.cpp:2549-2550
@@ +2548,4 @@
+ unsigned CurDigit = 0;
+ unsigned MaxDigits = Digits.size();
+ while (CurDigit < MaxDigits) {
+unsigned Digit = (unsigned)strtol(Str, &End, 10);
rnk wrot
Author: bruno
Date: Wed Mar 30 21:45:46 2016
New Revision: 264987
URL: http://llvm.org/viewvc/llvm-project?rev=264987&view=rev
Log:
[DarwinDriver] Increase the number of valid digits for ld64 version string.
Previously only 3 digits were valid. Increase it to 5.
Differential Revision: http://rev
Author: bruno
Date: Wed Mar 30 18:54:25 2016
New Revision: 264971
URL: http://llvm.org/viewvc/llvm-project?rev=264971&view=rev
Log:
[CrashReproducer] Add a module map callback for added headers
The current ModuleDependencyCollector has a AST listener to collect
header files present in loaded modu
Author: bruno
Date: Wed Mar 30 18:54:00 2016
New Revision: 264970
URL: http://llvm.org/viewvc/llvm-project?rev=264970&view=rev
Log:
[VFS] Handle empty entries in directory traversal
The VFS YAML files contain empty directory entries to describe that it's
returning from a subdirectory before descr
Author: bruno
Date: Tue Mar 29 19:25:57 2016
New Revision: 264813
URL: http://llvm.org/viewvc/llvm-project?rev=264813&view=rev
Log:
[Driver] Quote clang full version in dwarf producer when invoking cc1as
Convenience to allow easy copy-n-paste from clang -v output when
reproducing cc1as comandline
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
The current ModuleDependencyCollector has a AST listener to collect
header files present in loaded modules, but this isn't enough to collect
all headers needed in the crash reproducer. On
Author: bruno
Date: Tue Mar 29 18:47:40 2016
New Revision: 264808
URL: http://llvm.org/viewvc/llvm-project?rev=264808&view=rev
Log:
[CrashReproducer] Cleanup and move functionality around in
ModuleDependencyCollector. NFC
- Make ModuleDependencyCollector use the DependencyCollector interface
- M
Author: bruno
Date: Tue Mar 29 16:30:58 2016
New Revision: 264788
URL: http://llvm.org/viewvc/llvm-project?rev=264788&view=rev
Log:
[Sema] Attempt [3] to fix tests for utf-8 invalid format string specifiers
Make the tests darwin only. The bots complaining already output UTF-8
invalid specifiers,
Author: bruno
Date: Tue Mar 29 15:47:09 2016
New Revision: 264784
URL: http://llvm.org/viewvc/llvm-project?rev=264784&view=rev
Log:
[Sema] Attempt [2] to fix tests for utf-8 invalid format string specifiers
Some buildbots still complain. Followup from r264752 and 264765.
Modified:
cfe/trunk/
Author: bruno
Date: Tue Mar 29 13:38:44 2016
New Revision: 264765
URL: http://llvm.org/viewvc/llvm-project?rev=264765&view=rev
Log:
[Sema] Attempt to fix tests for utf-8 invalid format string specifiers
Followup from r264752.
Attempt to appease buildbots:
http://lab.llvm.org:8011/builders/clang
bruno closed this revision.
bruno added a comment.
Thanks Richard. Applied your last comments and committed in r264752
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: bruno
Date: Tue Mar 29 12:35:02 2016
New Revision: 264752
URL: http://llvm.org/viewvc/llvm-project?rev=264752&view=rev
Log:
[Sema] Handle UTF-8 invalid format string specifiers
Improve invalid format string specifier handling by printing out
invalid specifiers characters with \x, \u and \
bruno updated this revision to Diff 51859.
bruno added a comment.
Update after Richard's review.
- Handle scanf
- Properly update `ConversionSpecifier`
http://reviews.llvm.org/D18296
Files:
include/clang/Analysis/Analyses/FormatString.h
lib/Analysis/FormatString.cpp
lib/Analysis/FormatSt
bruno added a comment.
In http://reviews.llvm.org/D18296#384766, @rsmith wrote:
> This patch builds a length-1 `ConversionSpecifier` but includes the complete
> code point in the length of the overall format specifier, which is
> inconsistent. Please either treat the trailing bytes as part of t
bruno updated this revision to Diff 51828.
bruno added a comment.
Thanks Reid. The original idea was to have MaxDigits despite the size of the
input array (but bounded by its size). But since there are no other users up to
this point, your suggestion seems better, updated the patch to reflect it
bruno added a comment.
Ping :-)
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping :-)
http://reviews.llvm.org/D18304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D18304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: bob.wilson, dexonsmith.
bruno added a subscriber: cfe-commits.
Previously only 3 digits were valid. Increase it to 5.
http://reviews.llvm.org/D18304
Files:
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Dr
>> // RUN: not env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \
>> -// RUN: %clang -fsyntax-only %s -I %S/Inputs/crash-recovery -isysroot
>> %/t/i/\
>> +// RUN: %clang -fsyntax-only %s -I %S/Inputs/System -isysroot %/t/i/\
>
> Is this an intentional revert? Test fails for me
Author: bruno
Date: Sun Mar 20 13:08:32 2016
New Revision: 263912
URL: http://llvm.org/viewvc/llvm-project?rev=263912&view=rev
Log:
[VFS] Fix test to use more restrict set of headers
Modified:
cfe/trunk/test/Modules/crash-vfs-relative-overlay.m
Modified: cfe/trunk/test/Modules/crash-vfs-rela
Nice! Thanks Benjamin
On Thu, Mar 17, 2016 at 9:19 AM, Benjamin Kramer via cfe-commits
wrote:
> Author: d0k
> Date: Thu Mar 17 11:19:51 2016
> New Revision: 263718
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263718&view=rev
> Log:
> Use a simpler set of mock headers for the vfs+modules crash
Author: bruno
Date: Thu Mar 17 16:30:55 2016
New Revision: 263750
URL: http://llvm.org/viewvc/llvm-project?rev=263750&view=rev
Log:
Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files"
Tests failing on
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/46102
This reverts comm
Author: bruno
Date: Sat Mar 19 21:08:48 2016
New Revision: 263893
URL: http://llvm.org/viewvc/llvm-project?rev=263893&view=rev
Log:
Reapply [2] [VFS] Add 'overlay-relative' field to YAML files
This reapplies r261552 and r263748. Fixed testcase to reapply.
The VFS overlay mapping between virtual
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, dexonsmith.
Improve invalid format string specifier handling by printing out invalid
specifiers characters with \x, \u and \U. Previously clang would print gargabe
whenever the character is unprint
Author: bruno
Date: Thu Mar 17 16:11:23 2016
New Revision: 263748
URL: http://llvm.org/viewvc/llvm-project?rev=263748&view=rev
Log:
Reapply [VFS] Add 'overlay-relative' field to YAML files
This reapplies r261552.
The VFS overlay mapping between virtual paths and real paths is done through
the 'e
Author: bruno
Date: Wed Mar 16 23:59:52 2016
New Revision: 263691
URL: http://llvm.org/viewvc/llvm-project?rev=263691&view=rev
Log:
[VFS] Remove wrong header include
Follow up from r263686. Forgot to remove the wrong header file.
Modified:
cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp
Author: bruno
Date: Wed Mar 16 21:20:43 2016
New Revision: 263686
URL: http://llvm.org/viewvc/llvm-project?rev=263686&view=rev
Log:
Reapply [2]: [VFS] Add support for handling path traversals
This was applied twice r261551 and 263617 and later reverted because:
(1) Windows bot failing on unittes
Thanks!
On Wed, Mar 16, 2016 at 5:35 AM, NAKAMURA Takumi wrote:
> chapuni added a subscriber: chapuni.
> chapuni added a comment.
>
> Excuse me, I have reverted it in r263636.
>
>
>
> Comment at: lib/Frontend/ModuleDependencyCollector.cpp:65
> @@ +64,3 @@
> +static bool real_path
Author: bruno
Date: Tue Mar 15 23:39:38 2016
New Revision: 263617
URL: http://llvm.org/viewvc/llvm-project?rev=263617&view=rev
Log:
Reapply: [VFS] Add support for handling path traversals
This is originally r261551, reverted because of windows bots failing on
unittests. Change the current behavio
Sean Silva wrote:
>>>> > This or r261551 seem to be causing a build failure:
>>>> >
>>>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527
>>>> >
>>>> > -- Sean SIlva
>>>>
Author: bruno
Date: Tue Feb 23 11:06:50 2016
New Revision: 261654
URL: http://llvm.org/viewvc/llvm-project?rev=261654&view=rev
Log:
Revert "[VFS] Add support for handling path traversals"
This reverts commit r261551 due to failing tests in windows bots:
http://lab.llvm.org:8011/builders/clang-x6
ixed in r261556.
>>>
>>> On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote:
>>> > This or r261551 seem to be causing a build failure:
>>> >
>>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527
>&g
Author: bruno
Date: Tue Feb 23 01:06:12 2016
New Revision: 261613
URL: http://llvm.org/viewvc/llvm-project?rev=261613&view=rev
Log:
Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call
to getVFSFromYAML in unittests"
This reverts commit r261552 and r261556 because of fai
;
>> This is hopefully fixed in r261556.
>>
>> On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote:
>> > This or r261551 seem to be causing a build failure:
>> >
>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/buil
401 - 500 of 545 matches
Mail list logo