[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

CarlosAlbertoEnciso added a comment. In D132316#3748845 , @Ericson2314 wrote: > Let's just revert this. I'll do it later today if no one beats me to it. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

CarlosAlbertoEnciso added a comment. @Ericson2314 It seems that these changes break building on Windows using Visual Studio 2019. There are 2 issues: - CMake now creates a directory `$(Configuration)` in the root build directory. $(Configuration)\lib\cmake\llvm Location before the changes:

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso added a comment. In D131665#3740037 , @phosek wrote: > LGTM @phosek Thanks for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c6c4f6a9b3e: [CMake] Support passing arguments to build tool (bootstrap). (authored by CarlosAlbertoEnciso). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso added a comment. To give more scope to the reviewers, the following CMake options illustrate the benefit of this patch. For example, if I want to do a dry run on stage-2, I will pass `-DLLVM_EXTERNAL_PROJECT_BUILD_TOOL_ARGS="-n --verbose"` -DCLANG_ENABLE_BOOTSTRAP=ON

[PATCH] D131755: [CMake] Explicit bootstrap options override any passthrough ones.

This revision was automatically updated to reflect the committed changes. Closed by commit rG177cbb1c9b66: [CMake] Explicit bootstrap options override any passthrough ones. (authored by CarlosAlbertoEnciso). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131755: [CMake] Explicit bootstrap options override any passthrough ones.

CarlosAlbertoEnciso added a comment. In D131755#3723366 , @beanz wrote: > Looks good to me. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131755/new/

[PATCH] D131755: [CMake] Explicit bootstrap options override any passthrough ones.

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: sylvestre.ledru, andrewng, russell.gallop, phosek, beanz. CarlosAlbertoEnciso added projects: All, LLVM, clang. Herald added a subscriber: mgorny. CarlosAlbertoEnciso requested review of this revision. Herald added a

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: andrewng, phosek, beanz, russell.gallop. CarlosAlbertoEnciso added a project: LLVM. Herald added a subscriber: mgorny. Herald added a project: All. CarlosAlbertoEnciso requested review of this revision. Herald added a

[PATCH] D127863: [clang] Dont print implicit forrange initializer

CarlosAlbertoEnciso added a comment. @kadircet It seems that your change broke couple of clang tests: https://lab.llvm.org/buildbot/#/builders/109/builds/40797 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127863/new/

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

CarlosAlbertoEnciso added a comment. In D97411#2611142 , @probinson wrote: > In D97411#2598625 , @akhuang wrote: > >> I started looking into some diffs of debug info in libc++ tests, but it's >> pretty hard to

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

CarlosAlbertoEnciso added a comment. In D77184#1960473 , @thakis wrote: > I pushed Andrew's fix (thanks!) (with minor formatting tweaks) in > dbb0d8ecb3a024bd6817ebd8ad8c5c199a51d933 >

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

CarlosAlbertoEnciso added a comment. In D77184#1957632 , @thakis wrote: > Thanks! Hi, After the series of changes you have done, I am experiencing a build error on Windows. These are some of the errors: - Attribute ignored -- Loadable modules not

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @rsmith & @probinson, Is there anything I can add to this patch in order to submit it? This patch is blocking the review https://reviews.llvm.org/D44826 which is already approved. Thanks very much. Comment at:

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso updated this revision to Diff 156460. CarlosAlbertoEnciso marked an inline comment as done. CarlosAlbertoEnciso added a comment. A minor modification to allow the comments for `MarkNamespaceAliasReferenced` to be picked up by doxygen. https://reviews.llvm.org/D46190 Files:

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso updated this revision to Diff 156456. CarlosAlbertoEnciso added a comment. Used `clang-format-diff` as indicated by @probinson: - The lib and include files follow the clang format. - The tests mostly follow the clang format. I removed some extra formatting which was

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @probinson: I tried `clang-format-diff` and the main format issues are with the test cases. Do you want the test cases to follow the clang format? https://reviews.llvm.org/D46190 ___ cfe-commits mailing list

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1166775, @probinson wrote: > A bunch of style comments. Maybe try clang-format-diff. @probinson: Thanks very much for your review. https://reviews.llvm.org/D46190 ___

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added inline comments. Comment at: include/clang/Sema/SemaInternal.h:91 Var->markUsed(SemaRef.Context); + SemaRef.MarkUsingReferenced(Var, Loc, /*CXXScopeSpec*=*/nullptr, RefExpr); } probinson wrote: > The comments on a nullptr parameter

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso updated this revision to Diff 156234. CarlosAlbertoEnciso marked 11 inline comments as done. CarlosAlbertoEnciso added a comment. Address review comments from @probinson https://reviews.llvm.org/D46190 Files: include/clang/Sema/Lookup.h include/clang/Sema/Sema.h

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @rsmith and @probinson: Is there anything I can add to this patch? The review https://reviews.llvm.org/D44826 is already approved and it is blocked by this patch being reviewed. Thanks very much https://reviews.llvm.org/D46190

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @rsmith Is there anything I can add to this patch? The review https://reviews.llvm.org/D44826 is already approved and it is dependent on this patch being reviewed. Thanks very much https://reviews.llvm.org/D46190

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added inline comments. Comment at: lib/Sema/Sema.cpp:1884-1885 + ND = NA->getAliasedNamespace(); + if (auto *NNS = NA->getQualifier()) +MarkNamespaceAliasReferenced(NNS->getAsNamespaceAlias()); +} rsmith wrote: > The

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso updated this revision to Diff 154091. CarlosAlbertoEnciso added a comment. Update the patch to address the comments from the reviewers. https://reviews.llvm.org/D46190 Files: include/clang/Sema/Lookup.h include/clang/Sema/Sema.h include/clang/Sema/SemaInternal.h

[PATCH] D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D48441#1151889, @ioeric wrote: > Hi Carlos, thanks for letting us know! I sent r336249 to fix the windows > test. Hi @ioeric, Thanks very much. Happy to help. Repository: rL LLVM https://reviews.llvm.org/D48441

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1135295, @probinson wrote: > Style comments. > The two new Sema methods (for namespaces and using references) are C++ > specific, so SemaDeclCXX.cpp would seem like a more appropriate home for them. Both functions have

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1135688, @rsmith wrote: > The right way to handle this is to pass both the ultimately-selected > declaration and the declaration found by name lookup into the calls to > `MarkAnyDeclReferenced` and friends. We should mark

[PATCH] D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring.

CarlosAlbertoEnciso added a comment. Hi, It seems that your patch is causing an error in the tests for http://lab.llvm.org:8011/builders/clang-x64-ninja-win7

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. rsmith Thanks very much for your review. I will address them. https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @probinson Thanks very much for your review. I will address them. https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. The review https://reviews.llvm.org/D44826 is already approved and it is dependent on this patch being reviewed. @rsmith Is there anything I can add to this patch? Thanks https://reviews.llvm.org/D46190

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

CarlosAlbertoEnciso added a comment. @Typz, It seems that the changes done to `ClangFormatStyleOptions.rst` @334408 are causing the generation of the documentation to fail, with the following error: Warning, treated as error: /llvm/tools/clang/docs/ClangFormatStyleOptions.rst:1060:

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. The review https://reviews.llvm.org/D44826 is already approved and it is dependent on this patch being reviewed. Is there anything I can add to this patch? Thanks very much. https://reviews.llvm.org/D46190

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:282-290 +def warn_unused_using_declaration : Warning< + "unused using declaration %0">, + InGroup, DefaultIgnore; +def warn_unused_using_directive : Warning< + "unused using

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. Thanks to all reviewers for your comments and suggestions. https://reviews.llvm.org/D44826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso updated this revision to Diff 149425. CarlosAlbertoEnciso marked 3 inline comments as done. CarlosAlbertoEnciso added a comment. Address feedback from @thakis in relation to the Release Notes. https://reviews.llvm.org/D44826 Files: docs/ReleaseNotes.rst

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added inline comments. Comment at: docs/ReleaseNotes.rst:139 + used in conjunction with ``-Werror`` and as a result, the new warnings + are turned into new errors. + thakis wrote: > nit: I'd omit this paragraph -- this is true for all

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso updated this revision to Diff 149261. CarlosAlbertoEnciso added a comment. This patch addresses the reviewers comments: - Additional test cases to cover: -Wunused, -Wall and -Wno-unused-using - Formatting in ReleaseNotes - Removed the '-Wunused-usings' alias (GCC

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. Thanks https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:828-829 // -Wunused-local-typedefs = -Wunused-local-typedef +def : DiagGroup<"unused-usings", [UnusedUsing]>; +// -Wunused-usings = -Wunused-using

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso marked 2 inline comments as done. CarlosAlbertoEnciso added a comment. @lebedev.ri, Thanks very much for your review. I will address those issues and update the patch. https://reviews.llvm.org/D44826 ___ cfe-commits mailing

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso marked 2 inline comments as done. CarlosAlbertoEnciso added inline comments. Comment at: lib/Serialization/ASTReader.cpp:8101-8103 +UsingDecl *D = dyn_cast_or_null( +GetDecl(UnusedUsingCandidates[I])); +if (D) dblaikie wrote:

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso updated this revision to Diff 148578. CarlosAlbertoEnciso edited the summary of this revision. CarlosAlbertoEnciso added a comment. This patch addresses the reviewers comments: 1. Merge the -Wunused-local-typedefs and -Wunused-usings implementations 2. Update the Release

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. Thanks https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso updated this revision to Diff 147050. CarlosAlbertoEnciso edited the summary of this revision. CarlosAlbertoEnciso added a comment. Address the issues raised by the reviewer (rsmith). https://reviews.llvm.org/D46190 Files: include/clang/Sema/Sema.h lib/Sema/Sema.cpp

[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1083502, @rsmith wrote: > Let's look at your original example again (I've cleaned it up and extended it > a bit, but hopefully this matches your intent): > > namespace nsp { > int var1, var2; > } > > using

[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1083502, @rsmith wrote: > This is already the correct outcome. Both typedefs are referenced; this is > correct because they are named by the source code. Neither typedef is marked > as "used"; this is correct because a

[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

CarlosAlbertoEnciso added a comment. My initial approach was based on the following test case: void Bar() { typedef int I_Ref; I_Ref var_bar; } void Foo() { typedef int I_Used; I_Used var_foo; var_foo = 2; } void Test() { Foo(); } and the generated AST

[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1081836, @rsmith wrote: > In https://reviews.llvm.org/D46190#1081773, @rsmith wrote: > > > No, absolutely not. This would be insanely expensive, and marks entirely > > unrelated things "used". > > > My apologies, reading

[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

CarlosAlbertoEnciso added a comment. Note: The patch includes the entry points to set Objective-C and OpenMP declarations, but I do not know anything about Objective-C or OpenMP. The functions just return without updating any extra 'Used' bit. Any suggestion on how to deal with those

[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: rsmith, erichkeane, probinson, dblaikie. CarlosAlbertoEnciso added a project: clang. Herald added a subscriber: aprantl. The following submission under review https://reviews.llvm.org/D44826 introduced an option to

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. @dblaikie, Thanks for your feedback and questions. I will address them. Currently I am looking with more detail the tracking of the 'used' and 'referenced' bits. Repository: rC Clang https://reviews.llvm.org/D44826

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D44826#1046906, @dblaikie wrote: > First of all, thanks very much for your feedback. > While implementing the warning is great (wonder if there's any codebase > that isn't -Wunused-using clean, that we could use to compare

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328494: [SemaCXX] _Pragma(clang optimize off) not affecting lambda. (authored by CarlosAlbertoEnciso, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D44826#1046913, @Eugene.Zelenko wrote: > Please also mention new warning in Release Notes and documentation. I will do it. > Will this warning be part of -Wall or -Wextra? The warning is part of -Wall Thanks for your feedback.

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D44826#1046910, @Eugene.Zelenko wrote: > This duplicates Clang-tidy misc-unused-using-decls > . > If Clang will provide same or better functionality, it

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D44826#1046671, @erichkeane wrote: > My opinion matters less than @rsmith or @dblaikie on the review, but it seems > to me that Typedef and Using are SO similar that the implementations should > just be combined. You'd likely

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: rsmith, erichkeane, probinson, dblaikie. CarlosAlbertoEnciso added a project: clang. Herald added subscribers: cfe-commits, JDevlieghere, aprantl. Add -Wunused-using, a warning that finds unused using declarations.

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso added a comment. Thanks @erichkeane for your review. Repository: rC Clang https://reviews.llvm.org/D43821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso added a comment. Ping. Thanks Repository: rC Clang https://reviews.llvm.org/D43821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso added a comment. Ping. Thanks Repository: rC Clang https://reviews.llvm.org/D43821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso updated this revision to Diff 137550. CarlosAlbertoEnciso added a comment. Correct the issues raised by the reviews. Repository: rC Clang https://reviews.llvm.org/D43821 Files: lib/Sema/SemaLambda.cpp test/CodeGenCXX/optnone-pragma-optimize-off.cpp Index:

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12598 +// have to apply optnone due to a pragma. +AddRangeBasedOptnone(FD); + erichkeane wrote: > Should thi sonly happen if this is a definition? Additionally, does this >

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso added a comment. Ping. Thanks Repository: rC Clang https://reviews.llvm.org/D43821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: rsmith, erichkeane, andreadb. CarlosAlbertoEnciso added a project: clang. Declaring "_Pragma("clang optimize off")" before the body of a function with a lambda leads to the lambda functions in the body not being

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

CarlosAlbertoEnciso added a subscriber: aheejin. CarlosAlbertoEnciso added a comment. Thanks @aheejin Repository: rL LLVM https://reviews.llvm.org/D42640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

CarlosAlbertoEnciso added a comment. Hi @ioeric: Just to let you know that your submission seems to break a Windows test. FAIL: Extra Tools Unit Tests :: clangd/Checking/./ClangdTests.exe/SymbolCollectorTest.IWYUPragma (15474 of 36599) Thanks Repository: rL LLVM

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

CarlosAlbertoEnciso added a comment. Build now is OK. Thanks @ilya-biryukov Repository: rL LLVM https://reviews.llvm.org/D43227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

CarlosAlbertoEnciso added a comment. Hi, It seems that your submission broke the Windows/Linux builds for 'clangd'. The generated error message is: C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\future(263): error C2512:

[PATCH] D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D43272#1008703, @sammccall wrote: > r325239 should fix, sorry! Build now is OK. Thanks @sammccall. Repository: rL LLVM https://reviews.llvm.org/D43272 ___ cfe-commits mailing

[PATCH] D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread.

CarlosAlbertoEnciso added a comment. Hi, It seems that your submission have broken the Windows and Linux Builds for 'clangd'. This is the error message: /home/xxx/llvm-root/llvm/tools/clang/tools/extra/clangd/Trace.cpp:54:76: error: call of overloaded

[PATCH] D43189: [DebugInfo] Avoid name conflict of generated VLA expression variable.

CarlosAlbertoEnciso added a comment. LGTM. Thanks. https://reviews.llvm.org/D43189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

CarlosAlbertoEnciso added a comment. Hi @sdesmalen! For the following test case int main() { int size = 2; int var[size]; var[1] = 1; return 0; } I compared the DWARF generated by GCC and it looks like DW_TAG_variable "var" DW_AT_location ... DW_AT_type

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

CarlosAlbertoEnciso added a comment. Hi @sdesmalen! First of all my apologies for commenting after the issue has been closed, but I do not have an account to add a comment to the associated bugzilla. I have found what it seems to be an issue with the current implementation. For the given test

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#961367, @probinson wrote: > With the GDB test results and LLDB able to handle it, this LGTM. > Carlos, do you have commit access? Hi Paul, Thanks for the LGTM. I do not have commit access.

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#912837, @probinson wrote: > Have you tried the GDB suite yet? If it has no problems, and we can make > LLDB happy, I'm okay with it. These are the results when using GCC as the default compiler: === gdb

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#912837, @probinson wrote: > Have you tried the GDB suite yet? If it has no problems, and we can make > LLDB happy, I'm okay with it. Hi Paul, Following the instructions from David Blaikie on how to build/run the GDB

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. Hi Tamas, Thanks very much for your message. In https://reviews.llvm.org/D39239#910797, @tberghammer wrote: > - Can you do a diff of the debug_info dump before and after your change? > Understanding what have changed should give us a pretty good clue about

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a reviewer: tberghammer. CarlosAlbertoEnciso added a comment. Hi Tamas, I have added you to this review, as I think I have found something odd with the LLDB. Basically after this intended patch to the compiler (to emit scoped information only for scoped enums) the

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#905641, @probinson wrote: > Have you tried this change against the GDB and LLDB test suites? If they > have failures then we should think about whether those tests are > over-specific or whether we should put this under a

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#905641, @probinson wrote: > Have you tried this change against the GDB and LLDB test suites? If they > have failures then we should think about whether those tests are > over-specific or whether we should put this under a

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso updated this revision to Diff 120066. https://reviews.llvm.org/D39239 Files: lib/AST/Decl.cpp test/Modules/odr.cpp test/SemaCXX/return-noreturn.cpp test/SemaTemplate/temp_arg_enum_printing.cpp test/SemaTemplate/temp_arg_enum_printing_more.cpp

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso created this revision. An unscoped enumeration used as template argument, should not have any qualified information about its enclosing scope, as its visibility is global. In the case of scoped enumerations, they must include information about their enclosing scope. For the