[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

2022-05-17 Thread Changwei Zou via Phabricator via cfe-commits
sheisc added a comment. In D125789#3519538 , @craig.topper wrote: > Is it gcc that needs a fix or binutils? Yes. Exactly speaking, it is the GNU assembler in binutils. https://www.gnu.org/software/binutils/ Repository: rG LLVM Github Monorepo

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

2022-05-17 Thread Changwei Zou via Phabricator via cfe-commits
sheisc added a comment. In D125789#3519493 , @pengfei wrote: > In D125789#3519433 , @sheisc wrote: > >> In D125789#3519411 , @pengfei >> wrote: >> >>> I think another

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

2022-05-17 Thread Changwei Zou via Phabricator via cfe-commits
sheisc added a comment. In D125789#3519411 , @pengfei wrote: > I think another way is to report the issue to GCC. From the perspective of > the user, GCC should support both `{%k1} {z}` and `{%k1}{z}`. Then we don't > need the clange on LLVM. Yes. It

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

2022-05-17 Thread Changwei Zou via Phabricator via cfe-commits
sheisc abandoned this revision. sheisc added a comment. In D125789#3519361 , @pengfei wrote: > I guess a lot of lines of tests need to update > > $ grep -rn " {z}" llvm/test/CodeGen/X86/ | wc -l > 7797 Thanks. Yes. It seems to be a big revision,

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

2022-05-17 Thread Changwei Zou via Phabricator via cfe-commits
sheisc updated this revision to Diff 430067. sheisc retitled this revision from "Fix release note typo from 6da3d66f" to "FIX the assembly format of the x86 backend to make both clang and gcc happy". sheisc edited the summary of this revision. sheisc added a project: libc-project. Repository:

[PATCH] D125789: Fix release note typo from 6da3d66f

2022-05-17 Thread Changwei Zou via Phabricator via cfe-commits
sheisc created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. sheisc requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The GNU assembler (used in gcc) complains about the syntactic