[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-10 Thread Chris Apple via cfe-commits
@@ -864,11 +864,18 @@ INTERCEPTOR(void *, pvalloc, size_t size) { #define RTSAN_MAYBE_INTERCEPT_PVALLOC #endif +#if !SANITIZER_FREEBSD +// enabling this interception on freebsd leads to infinite recursion +// on pthread lib initialization cjappl wrote: It loo

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
@@ -1539,6 +1543,7 @@ TEST_F(KqueueTest, KeventDiesWhenRealtime) { ExpectNonRealtimeSurvival(Func); } +#if SANITIZER_APPLE cjappl wrote: ah, fine to leave then probably. Thanks for pointing that out https://github.com/llvm/llvm-project/pull/125389

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
@@ -864,11 +864,18 @@ INTERCEPTOR(void *, pvalloc, size_t size) { #define RTSAN_MAYBE_INTERCEPT_PVALLOC #endif +#if !SANITIZER_FREEBSD +// enabling this interception on freebsd leads to infinite recursion +// on pthread lib initialization cjappl wrote: Can yo

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
@@ -1539,6 +1543,7 @@ TEST_F(KqueueTest, KeventDiesWhenRealtime) { ExpectNonRealtimeSurvival(Func); } +#if SANITIZER_APPLE cjappl wrote: "Kqueue is a scalable event notification interface introduced in FreeBSD 4.1 in July 2000, also supported in NetBSD, Op

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl commented: Cool, much better with this version of the init! A few more smaller scale things and this is looking good https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
@@ -43,6 +44,21 @@ static __rtsan::Context &GetContextForThisThreadImpl() { return *current_thread_context; } +#else + +// On FreeBSD, pthread api cannot be used as calloc is called under the hood +// at library initialization time. +static __thread Context *ctx = nullptr; +

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
cjappl wrote: Thanks for the feedback @brooksdavis and @bsdimp - always hard to tell how popular or unpopular a change would be, especially from "outside the community" (aka me not knowing much about the BSD flavors :) > Sure we can keep it open for a while, still a long road before 21.x anyw

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
@@ -43,6 +44,21 @@ static __rtsan::Context &GetContextForThisThreadImpl() { return *current_thread_context; } +#else + +// On FreeBSD, pthread api cannot be used as calloc is called under the hood +// at library initialization time. cjappl wrote: Can you el

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
@@ -43,6 +44,21 @@ static __rtsan::Context &GetContextForThisThreadImpl() { return *current_thread_context; } +#else + +// On FreeBSD, pthread api cannot be used as calloc is called under the hood +// at library initialization time. +static __thread Context *ctx = nullptr; +

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl commented: (sorry meant to leave these comments the other day, these comments are separate from the "should we enable it" discussion) https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@l

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-03 Thread Chris Apple via cfe-commits
cjappl wrote: > @devnexen in principle, I'm of course not opposed to rtsan supporting FreeBSD > - is there any motivation in particular for why you propose adding it here? > Is this the first of many patches that are needed, or is it the only one that > you can foresee? I'd like to make sure t

[clang] [rtsan][clang] NFC: Move rtsan init to addSanitizers (PR #119904)

2024-12-13 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][clang] NFC: Move rtsan init to addSanitizers (PR #119904)

2024-12-13 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119904 This seems to pass tests and behaves as expected. As suggested by @vitalybuka on #118989 >From 8cfcf0461739e45716be1b3ed6700b5712b7801e Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 12 Dec 2024 10:37:1

[clang] [llvm] [rtsan][llvm] Remove function pass, only support module pass (PR #119739)

2024-12-13 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [rtsan][llvm] Remove function pass, only support module pass (PR #119739)

2024-12-12 Thread Chris Apple via cfe-commits
cjappl wrote: > > Remove functional pass > > > > function pass? Thanks, fixed https://github.com/llvm/llvm-project/pull/119739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [rtsan][llvm] Remove function pass, only support module pass (PR #119739)

2024-12-12 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/119739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [rtsan][llvm] Remove functional pass, only support module pass (PR #119739)

2024-12-12 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119739 As suggested by @vitalybuka on #118989 Most of the other sanitizers are now only module level passes. This moves all functionality into the module pass, and removes the function pass. >From c19f2f7da960a81e2c8

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-12 Thread Chris Apple via cfe-commits
@@ -1024,12 +1024,14 @@ void EmitAssemblyHelper::RunOptimizationPipeline( FPM.addPass(BoundsCheckingPass()); }); -if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) +if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) { cjappl wr

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-12 Thread Chris Apple via cfe-commits
@@ -1024,12 +1024,14 @@ void EmitAssemblyHelper::RunOptimizationPipeline( FPM.addPass(BoundsCheckingPass()); }); -if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) +if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) { PB.registerScalarOp

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-08 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/119074 >From 2c882a78ce82801590a6bfd217c8e8b8e4b4c6f5 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Sat, 7 Dec 2024 07:45:34 -0800 Subject: [PATCH] [rtsan] Add `verify_interceptors` to docs --- clang/docs/RealtimeS

[clang] [rtsan] NFC: Adding links to Disabling, adding a few ` marks (PR #119075)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] NFC: Adding links to Disabling, adding a few ` marks (PR #119075)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119075 None >From 94225043e5e60424bc10fa0b8d33a21228420866 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Sat, 7 Dec 2024 07:51:45 -0800 Subject: [PATCH] [rtsan] NFC: Very small fixes of docs, adding `, adding link

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119074 None >From 649e184e37ba94ac77b840ae4d02213a8fb77ab5 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Sat, 7 Dec 2024 07:45:34 -0800 Subject: [PATCH] [rtsan] Add `verify_interceptors` to docs --- clang/docs/Rea

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-06 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/118989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-06 Thread Chris Apple via cfe-commits
@@ -25,3 +25,7 @@ attributes #0 = { mustprogress noinline sanitize_realtime optnone ssp uwtable(sy ; RealtimeSanitizer pass should insert __rtsan_realtime_exit right before function return ; CHECK: call{{.*}}@__rtsan_realtime_exit ; CHECK-NEXT: ret{{.*}}void + +; RealtimeSani

[clang] [rtsan] NFC: Update docs with suppress_equal_stacks (PR #117187)

2024-11-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/117187 None >From b5888f70bd1bbefc6a711ef2022478980ed2505f Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 21 Nov 2024 08:45:33 -0800 Subject: [PATCH] [rtsan] NFC: Update docs with suppress_equal_stacks --- cla

[clang] [rtsan] NFC: Update docs with suppress_equal_stacks (PR #117187)

2024-11-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/117187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] NFC: Update docs with customizable functions (PR #117086)

2024-11-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/117086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] NFC: Update docs with customizable functions (PR #117086)

2024-11-20 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/117086 These functions recently were helpful for a user, so I decided to add them to the official docs. Any feedback on wording or content appreciated as always >From 056fa6a787efb0721b30fee6e0bdea9843e303d4 Mon Sep

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Chris Apple via cfe-commits
@@ -1259,6 +1263,12 @@ class Analyzer { return true; } +bool TraverseStmt(Stmt *Statement) { + if (Statement != TrailingRequiresClause) cjappl wrote: Could consider leaving a comment here saying why you skip trailing requires clauses (some

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/114266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Chris Apple via cfe-commits
https://github.com/cjappl commented: for whatever it's worth - LGTM. Leaving to more experienced heads in this area to actually approve. Good sleuthing! https://github.com/llvm/llvm-project/pull/114266 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [rtsan][NFC] Add 'known to have non-deterministic' caveat to documentation (PR #114281)

2024-10-31 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/114281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][NFC] Add 'known to have non-deterministic' caveat to documentation (PR #114281)

2024-10-31 Thread Chris Apple via cfe-commits
cjappl wrote: #114331 has been merged, so the test failure is fixed. Going to save the build machine a workout and submit without a rebase, as this change is very unlikely to cause any problems https://github.com/llvm/llvm-project/pull/114281 ___ cfe

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

2024-10-30 Thread Chris Apple via cfe-commits
cjappl wrote: FYI @jurahul - having a build failure when I try to build docs after this change. I think a few little bits were missed. ``` Warning, treated as error: ./llvm-project/build/tools/clang/docs/ClangFormattedStatus.rst:document isn't included in any toctree ``` https://github.com/ll

[clang] [rtsan][NFC] Add 'known to have non-deterministic' caveat to documentation (PR #114281)

2024-10-30 Thread Chris Apple via cfe-commits
cjappl wrote: (doc build failure is unrelated, I will rebase after approval and make sure that passes): > Warning, treated as error: > /home/runner/work/llvm-project/llvm-project/clang-build/tools/clang/docs/index.rst:89:toctree > contains reference to nonexisting document 'ClangFormattedStatu

[clang] [rtsan][NFC] Add 'known to have non-deterministic' caveat to documentation (PR #114281)

2024-10-30 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/114281 As suggested by @fmayer in #113979 >From 8d3e3d29b317a35a06780f8ad2a90f437b6f3bcc Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Wed, 30 Oct 2024 10:50:30 -0700 Subject: [PATCH] [rtsan][NFC] Add 'known to hav

[clang] [rtsan][NFC] Add documentation link to Function Effects (PR #113979)

2024-10-28 Thread Chris Apple via cfe-commits
@@ -11,11 +11,16 @@ RealtimeSanitizer (a.k.a. RTSan) is a real-time safety testing tool for C and C+ projects. RTSan can be used to detect real-time violations, i.e. calls to methods that are not safe for use in functions with deterministic run time requirements. RTSan consi

[clang] [rtsan][NFC] Add documentation link to Function Effects (PR #113979)

2024-10-28 Thread Chris Apple via cfe-commits
cjappl wrote: CC for review @dougsonos https://github.com/llvm/llvm-project/pull/113979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][NFC] Add documentation link to Function Effects (PR #113979)

2024-10-28 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/113979 None >From d2a311863881486fbed6097d6358b096f305377a Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Mon, 28 Oct 2024 16:17:48 -0700 Subject: [PATCH] [rtsan][NFC] Add documentation link to Function Effects ---

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-10-28 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/109855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][asan] NFC Fix hyperlink to CMake doc (PR #113931)

2024-10-28 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/113931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-10-28 Thread Chris Apple via cfe-commits
cjappl wrote: Happy to help. I'll merge this afternoon after the checks are green. Excited to have these docs up, had many conversations where I've wanted to refer people to them! https://github.com/llvm/llvm-project/pull/109855 ___ cfe-commits mail

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-10-28 Thread Chris Apple via cfe-commits
cjappl wrote: @dougsonos let me know if you want to merge this, happy to push the button when you are OK with it https://github.com/llvm/llvm-project/pull/109855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [rtsan][asan] NFC Fix hyperlink to CMake doc (PR #113931)

2024-10-28 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/113931 The links right now show up like: https://github.com/user-attachments/assets/9e6b3e1f-e78f-46cb-a9f7-8164b6233340";> ([rtsan](https://clang.llvm.org/docs/RealtimeSanitizer.html), [asan](https://clang.llvm.org/d

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/112727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/112727 >From 1bdbc3baf8399c4571429cff727bfa9bb260e400 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 17 Oct 2024 08:20:08 -0700 Subject: [PATCH 1/5] [rtsan][NFC] Documentation of suppression flag --- clang/docs

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang-tools-extra] [compiler-rt] Added support for the .yml file extension (PR #79899)

2024-10-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/79899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/112727 >From 37a1728dde2cad21b9f851268c1625b7ef2dc338 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 17 Oct 2024 08:20:08 -0700 Subject: [PATCH 1/4] [rtsan][NFC] Documentation of suppression flag --- clang/docs

[clang] [llvm] [LoongArch] Support LoongArch-specific amswap[_db].{b/h} and amadd[_db].{b/h} instructions (PR #113255)

2024-10-24 Thread Chris Apple via cfe-commits
cjappl wrote: Thanks for the quick fix, working for me after I pulled latest main. https://github.com/llvm/llvm-project/pull/113255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-24 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/112727 >From c8b2090824d19618e876051cfcc18a4fad49649d Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 17 Oct 2024 08:20:08 -0700 Subject: [PATCH 1/3] [rtsan][NFC] Documentation of suppression flag --- clang/docs

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-24 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang-tools-extra] [compiler-rt] Added support for the .yml file extension (PR #79899)

2024-10-24 Thread Chris Apple via cfe-commits
cjappl wrote: Closing This should be split into multiple reviews that do one small atomic thing. The reviews should have good descriptions and tests. You should try to minimize white space and formatting changes. Feel free to resubmit if you think these changes still need to be made. https://g

[clang] [llvm] [LoongArch] Support LoongArch-specific amswap[_db].{b/h} and amadd[_db].{b/h} instructions (PR #113255)

2024-10-24 Thread Chris Apple via cfe-commits
cjappl wrote: Just a heads up, I think this broke documentation builds. After bisecting it points to this commit. ``` ninja -C build docs-clang-html FAILED: tools/clang/docs/CMakeFiles/docs-clang-html ~/code/radsan_cjappl/llvm-project/build/tools/clang/docs/CMakeFiles/docs-clang-html cd ~/code

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-24 Thread Chris Apple via cfe-commits
cjappl wrote: (test failure seems unrelated, but I will ensure it's green before I submit after I get approval, going to rebase now) https://github.com/llvm/llvm-project/pull/112727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [compiler-rt] [llvm] [rtsan][llvm][NFC] Rename sanitize_realtime_unsafe attr to sanitize_realtime_blocking (PR #113155)

2024-10-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl approved this pull request. LGTM - would love some eyes from more established folks to make sure we are not breaking any bw-compatability foo, and seeing as this spans the tree a bit. Definitely I am for this change, I think the attr is more clear this way, and we cau

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-17 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/112727 >From c8b2090824d19618e876051cfcc18a4fad49649d Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 17 Oct 2024 08:20:08 -0700 Subject: [PATCH 1/2] [rtsan][NFC] Documentation of suppression flag --- clang/docs

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-17 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-17 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-17 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-17 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/112727 None >From c8b2090824d19618e876051cfcc18a4fad49649d Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 17 Oct 2024 08:20:08 -0700 Subject: [PATCH] [rtsan][NFC] Documentation of suppression flag --- clang/do

[clang] Effect analysis: correctly detect `(x ? a : b)` as nonblocking when a and b are (PR #111224)

2024-10-08 Thread Chris Apple via cfe-commits
cjappl wrote: > @dougsonos Maybe you should ask for commit access since you’ll likely be > contributing more patches to this in the future as I understand it? > > > > CC @AaronBallman Does that still work like it used to or did your maintainers > rfc change something about that too? A few d

[clang] Effect analysis: correctly detect `(x ? a : b)` as nonblocking when a and b are (PR #111224)

2024-10-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl approved this pull request. LGTM. Will let a little time pass to let Sirraide chime in, because this section of the code isn't my forte. If you want this merged ASAP @dougsonos and you feel confident in it, ping me and I can merge. https://github.com/llvm/llvm-proje

[clang] [NFC][rtsan] Update docs to include [[clang::blocking]] (PR #111249)

2024-10-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/111249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][rtsan] Update docs to include [[clang::blocking]] (PR #111249)

2024-10-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/111249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][rtsan] Update docs to include [[clang::blocking]] (PR #111249)

2024-10-05 Thread Chris Apple via cfe-commits
@@ -58,31 +58,71 @@ code. return 0; } # Compile and link - % clang++ -fsanitize=realtime -g example_realtime_violation.cpp + % clang++ -fsanitize=realtime example_realtime_violation.cpp If a real-time safety violation is detected in a ``[[clang::nonblocking]]`

[clang] [NFC][rtsan] Update docs to include [[clang::blocking]] (PR #111249)

2024-10-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][rtsan] Add sanitize_realtime_unsafe attr to [[clang::blocking]] function IR (PR #111055)

2024-10-04 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/111055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][rtsan] Add sanitize_realtime_unsafe attr to [[clang::blocking]] function IR (PR #111055)

2024-10-03 Thread Chris Apple via cfe-commits
https://github.com/cjappl approved this pull request. Will wait to merge for a bit to let others chime in, but LGTM https://github.com/llvm/llvm-project/pull/111055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-30 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/110296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-27 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/110296 >From eb8712a4eb82495a84e593c375f787017380de40 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Fri, 27 Sep 2024 09:40:11 -0700 Subject: [PATCH 1/3] [rtsan] Update docs to include run-time flags --- clang/docs/

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-27 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-27 Thread Chris Apple via cfe-commits
@@ -84,6 +84,75 @@ non-zero exit code. #14 0x0001958960dc () #15 0x2f557ffc () +Run-time flags +-- + +RealtimeSanitizer supports a number of run-time flags, which can be specified in the ``RTSAN_OPTIONS`` environment variable: + +.. code-block::

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-27 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/110296 >From eb8712a4eb82495a84e593c375f787017380de40 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Fri, 27 Sep 2024 09:40:11 -0700 Subject: [PATCH 1/2] [rtsan] Update docs to include run-time flags --- clang/docs/

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-27 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/110296 None >From 128f414de9f19596e81db6afe5e1d0b166888775 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Fri, 27 Sep 2024 09:40:11 -0700 Subject: [PATCH] [rtsan] Update docs to include run-time flags --- clang/doc

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-27 Thread Chris Apple via cfe-commits
cjappl wrote: CC for review @davidtrevelyan https://github.com/llvm/llvm-project/pull/110296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-27 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/110296 >From eb8712a4eb82495a84e593c375f787017380de40 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Fri, 27 Sep 2024 09:40:11 -0700 Subject: [PATCH] [rtsan] Update docs to include run-time flags --- clang/docs/Real

[clang] [rtsan] Update docs to include run-time flags (PR #110296)

2024-09-27 Thread Chris Apple via cfe-commits
cjappl wrote: And if he is interested to review/stay up to date on our docs @dougsonos for review https://github.com/llvm/llvm-project/pull/110296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-26 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-26 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/109855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl approved this pull request. Overall, very thorough. I would wait for more eyes but this LGTM https://github.com/llvm/llvm-project/pull/109855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" cjappl wrote: May be worth documenting how t

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" cjappl wrote: It is not only C++, but also w

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-25 Thread Chris Apple via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

  1   2   3   >