[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

ccotter accepted this revision. ccotter added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCoroutineParametersCheck.cpp:20 + Finder->addMatcher( +

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter marked an inline comment as done. ccotter added a comment. > Do you have plans to also detect the bugprone scenario described in the Notes > here? I didn't have plans in this review, or in the immediate future after. I did name this check broadly as "bugprone-incorrect-enable-if," so I

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp:61-62 + + FixItHint TypenameHint = + FixItHint::CreateInsertion(ElaboratedLoc->getBeginLoc(), "typename "); + FixItHint

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter updated this revision to Diff 549777. ccotter marked 9 inline comments as done. ccotter added a comment. - Fix docs, handle C++20 simplification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter marked an inline comment as done. ccotter added a comment. @PiotrZSL would you mind landing this for me? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp:67 + diag(EnableIf->getBeginLoc(), "incorrect std::enable_if usage detected; use " +"'typename std::enable_if<...>::type'") + <<

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter updated this revision to Diff 547599. ccotter added a comment. - Edited wrong file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 Files:

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547585. ccotter added a comment. - Use matchesAnyListedName and fix windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547573. ccotter marked 5 inline comments as done. ccotter added a comment. - Add tests, do not inspect instantiations, add option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:24-26 + hasType(recordDecl(hasAnyName( + "::std::unique_lock", "::std::lock_guard", +

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked an inline comment as done. ccotter added a comment. All done on my end - @PiotrZSL if you're good would you mind landing this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 3 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-basic.cpp:484 } // Tests to verify the proper use of auto where the init variable type and the PiotrZSL

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 547483. ccotter added a comment. - Check nullptr - Add tests for rbegin/crbegin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 547433. ccotter marked 2 inline comments as done. ccotter added a comment. - Feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547061. ccotter added a comment. - Specify version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D154999: [clang-tidy] Add bugprone-std-forward-type-mismatch check

ccotter added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/std-forward-type-mismatch.rst:18 +doSomething(std::forward(base)); // Incorrect usage +doSomething(static_cast(base)); // Suggested usage + } How confident are

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 546996. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 546991. ccotter marked an inline comment as done. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter marked an inline comment as done. ccotter added a comment. > 3. What about boost enable_if ? Support it, or restrict check to std only. > 4. What about enable_if used as an function argument ? Support it, or add > some info to documentation that such construction is not supported. I

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter updated this revision to Diff 545450. ccotter marked 5 inline comments as done. ccotter added a comment. - Improve docs, check for null/empty Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter updated this revision to Diff 545379. ccotter added a comment. - Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545332. ccotter added a comment. - Fix ReleaseNotes again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545331. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. @PiotrZSL - checking back, do you plan to revisit this change soon (I think there are some pending feedback and you planned some changes)? I'd like to see this in change merged in. Let me know if I can help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter added a comment. Thanks, fixed the first false positive example you gave. Let me think about the second example in your most recent post: char c = '\n'; using Size = int; Size size = 10U; std::string str2(c, size); This is my newly added case `swapped4`, where one of my

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 530349. ccotter added a comment. - Exclude false positive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files:

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter added a comment. bump please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. bump - @njames93 let me know if you have any further feedback. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 ___ cfe-commits

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 520237. ccotter marked an inline comment as done. ccotter added a comment. - Fix compile for non-libc++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-basic.cpp:481 + // CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead + // CHECK-FIXES: for (auto It :

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 520232. ccotter added a comment. Feedback and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 10 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-basic.cpp:477 + + for (S::const_iterator It = cbegin(Ss), E = cend(Ss); It != E; ++It) { +printf("s4 has value %d\n",

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter added a comment. bump please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 520143. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. Addressed all comments except for the `handleReturnType` one which I responded to - let me know your thoughts, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 520125. ccotter added a comment. - Better handling for ctor inits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:247-248 +ParamsRange.getEnd(), SM, LangOpts, tok::r_paren, tok::r_paren); +return

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 520104. ccotter marked 3 inline comments as done. ccotter added a comment. Fix bug, other cleanups, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520032. ccotter added a comment. - fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added a comment. Note, @PiotrZSL I don't have commit access, so if you're happy with the updates, could you please land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520027. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MissingStdForwardCheck.cpp:70 + Finder->addMatcher( + parmVarDecl( + parmVarDecl().bind("param"), isTemplateTypeOfFunction(), PiotrZSL wrote: > maybe think

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520026. ccotter marked 6 inline comments as done. ccotter added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added a comment. bump? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 512455. ccotter marked an inline comment as done. ccotter added a comment. Fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forwarding-reference-param-not-forwarded.cpp:138 + +} // namespace negative_cases PiotrZSL wrote: > ccotter wrote:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 512318. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512315. ccotter added a comment. arc diff properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512314. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512313. ccotter added a comment. refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. > Would you consider supporting enable_if via parameters I was planning to support those too, but in a subsequent commit / review since this review is rather large. Is that OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141892: Implement modernize-use-constraints

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:157-160 +return std::make_tuple( +matchEnableIfSpecialization( +LastTemplateParam->getTypeSourceInfo()->getTypeLoc()), +LastTemplateParam);

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512308. ccotter marked 12 inline comments as done. ccotter added a comment. feedback+rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. bump - any other feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forwarding-reference-param-not-forwarded.cpp:138 + +} // namespace negative_cases ccotter wrote: > PiotrZSL wrote: > > what about when someone uses std::move

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 511847. ccotter added a comment. - Rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D147551: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion

ccotter accepted this revision. ccotter added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147551/new/ https://reviews.llvm.org/D147551

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter marked 5 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:496 + const Expr *SpelledExpr = E->IgnoreUnlessSpelledInSource(); + if (dyn_cast(SpelledExpr)) +

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 510270. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/avoid-c-arrays.cpp:170-172 + char init4[] = "abcdef"; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not declare C-style arrays, use

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 510267. ccotter added a comment. - Add tests for char[] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 510262. ccotter added a comment. - Fix double curly brace matching in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:99 + unless(isExpansionInSystemHeader()), argumentCountIs(1U), + IgnoreDependentExpresions + ?

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter accepted this revision. ccotter added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 + callExpr( + unless(isExpansionInSystemHeader()),

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:158-159 + callee(cxxMethodDecl(BeginNameMatcher))), + callExpr(argumentCountIs(1), +

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 509874. ccotter marked 3 inline comments as done. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 509544. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 509543. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 509541. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 509539. ccotter added a comment. - Use common function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files:

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

ccotter accepted this revision. ccotter added a comment. This revision is now accepted and ready to land. If https://github.com/isocpp/CppCoreGuidelines/issues/2060 is accepted to only consider `[=]`, then I assume we'd want to change the default value of IgnoreCaptureDefaultByReference to be

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter added a comment. @PiotrZSL if you're happy with these changes, would you mind committing them for me? "Chris Cotter " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. In D140760#4222989 , @PiotrZSL wrote: > What about classes that doesn't have begin/end method but got cbegin/cend ? > I thing there is open issue for that. Should we handle that in a separate patch? Repository: rG LLVM

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508869. ccotter marked 2 inline comments as done. ccotter added a comment. - fix docs, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:20 + +AST_MATCHER(Expr, hasUnevaluatedContext) { + if (isa(Node) || isa(Node)) PiotrZSL wrote: > move this matcher to some

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter updated this revision to Diff 508865. ccotter added a comment. - move to utility file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 Files:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

ccotter added a comment. Herald added a subscriber: PiotrZSL. @Febbe - checking in. is this still on your radar? I would love to see this merged! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 508476. ccotter added a comment. - alpha Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 508474. ccotter added a comment. - fix bad rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

ccotter added a comment. Herald added subscribers: mgehre, shchenz. Herald added projects: clang-tools-extra, All. bump - I know this is really old, but @lewmpk do you plan on finishing up the last remaining comments? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter added a comment. I didn't update the release notes since this check is new. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 ___ cfe-commits mailing

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 508452. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 508451. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508450. ccotter added a comment. - add tests, simplify expr, handle unevaluated exprs - formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:83-84 + + if (!Param) +return; + PiotrZSL wrote: > I thing this can never happen Another review suggested I check the

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508441. ccotter marked 4 inline comments as done. ccotter retitled this revision from "[clang-tidy] Implement cppcoreguidelines F.19 " to "[clang-tidy] Implement cppcoreguidelines F.19". ccotter added a comment. - add tests, simplify expr, handle

[PATCH] D146921: Reviewers:

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Is it worth adding a cppcoreguidelines alias (ES.56)? Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/forward-usage.rst:98 + +.. option:: DisableTypeMismatchSuggestion + Curious what others thing but I think the tool

[PATCH] D146888: [clang-tidy] Flag std::forward on non-forwarding references

ccotter abandoned this revision. ccotter added a comment. Indeed - sorry i missed that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146888/new/ https://reviews.llvm.org/D146888 ___ cfe-commits mailing

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 508351. ccotter marked 8 inline comments as done. ccotter added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D146888: [clang-tidy] Flag std::forward on non-forwarding references

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:70-74 + const auto CharExpr = expr(anyOf( + ignoringParenImpCasts(characterLiteral()), +

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 508345. ccotter marked 4 inline comments as done. ccotter added a comment. - Add more cases to swapped params - Change message, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588 +: ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", +

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 506339. ccotter added a comment. Herald added a subscriber: PiotrZSL. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >