[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. In D73904#1874303 , @thakis wrote: > I fixed windows tests in a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 > . > Please watch bots after landing patches next

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

This revision was automatically updated to reflect the committed changes. Closed by commit rGc49866acceb1: [clang] stop baremetal driver to append .a to lib (authored by christof). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. The function @MaskRay suggested does not address the problem with `-march=` and others, but it does sound good to use that function. I'm also not sure if `-L` is a feature that is relied upon at the moment by anybody that uses the baremetal driver. For the moment I'll

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof updated this revision to Diff 243896. christof added a comment. Added a test for arm-none-eabi selection Note that the selection mechanism in the Baremetal driver is rather weak. It does not seem to respond on `-mthumb`, `-march` and `-mcpu` options. The cc1 options show a normalized

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. Just noticed the comment from Peter asking for clang/test/Driver/arm-compiler-rt.c, I'll add that in a moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 ___

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof updated this revision to Diff 243868. christof added a comment. With updated tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp Index:

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof created this revision. christof added reviewers: peter.smith, jroelofs. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the clang baremetal driver selects the rt.builtins static library it prefix with "-l" and appends ".a". The result is a nonsense option

[PATCH] D31814: Add option to add command-line options and version info to output file

christof commandeered this revision. christof added a reviewer: salari01. christof added a comment. Herald added a subscriber: aheejin. With the ok of the author, I'll try to get some movement on this work again. https://reviews.llvm.org/D31814 ___

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof marked an inline comment as done. christof added a comment. Sorry for missing the API comments. Thanks for the fix chapuni :-) Repository: rL LLVM https://reviews.llvm.org/D31709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

This revision was automatically updated to reflect the committed changes. Closed by commit rL306384: Revert "Revert "[NFC] Refactor DiagnosticRenderer to use FullSourceLoc"" (authored by christof). Changed prior to commit: https://reviews.llvm.org/D31709?vs=101933=104115#toc Repository: rL

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

christof added a reviewer: alexfh. christof added a comment. Added Alexander as he seems to have touched clang-tidy recently. https://reviews.llvm.org/D34513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

christof added a comment. This looks good to me. But since I have never touch this code, I'll wait a bit till accepting this for others to have a say. https://reviews.llvm.org/D34513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof added a comment. I'll go ahead and commit this on the grounds that it was already approved and the changes I made were the last nit-picks of @rnk https://reviews.llvm.org/D31709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof added a comment. @rnk can you let me know if you are happy with the changes? @rovka I assume the rebase did not change your mind about the patch. But please let me know if you have new reservations. Thanks Comment at: lib/Frontend/DiagnosticRenderer.cpp:512 //

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof updated this revision to Diff 101933. christof marked 6 inline comments as done. christof added a comment. Rebased onto current HEAD and addressed the comments from Reid. https://reviews.llvm.org/D31709 Files: include/clang/Basic/SourceLocation.h

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof commandeered this revision. christof added a reviewer: sanwou01. christof added a comment. This refactoring was ready to land some time ago, except for a few small details. It's a shame if we don't commit this refactoring, so with @sanwou01 his agreement, I'm taking over this patch.