[PATCH] D56631: [MSVC Compat] Fix typo correction for inclusion directives.

christylee accepted this revision. christylee added a comment. This revision is now accepted and ready to land. Thanks for catching that! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56631/new/ https://reviews.llvm.org/D56631 ___ cfe-commi

[PATCH] D52280: Don't trim non-alphanumeric characters in 'file not found' errors for include directives.

christylee accepted this revision. christylee added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rC Clang https://reviews.llvm.org/D52280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 165361. christylee added a comment. Added tests. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp test/Preprocessor/empty_file_to_include.h test/Preprocessor/include-likely-typo.c Index:

[PATCH] D51333: Diagnose likely typos in include statements

christylee added a comment. @rsmith , thanks for the review, I fixed the variable capitalization. If you could land it for me that'll be awesome! In https://reviews.llvm.org/D51333#1233042, @sammccall wrote: > One thing I'd like to do sometime is add code completion of filenames in > #include

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 165350. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp Index: lib/Lex/PPDirectives.cpp === --- lib/Lex/PPDirectives.cpp +++ lib

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 165349. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp Index: lib/Lex/PPDirectives.cpp === --- lib/Lex/PPDirectives.cpp +++ lib

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 165311. christylee added a comment. Addressed @rsmith 's comments. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp Index: lib/Lex/PPDirectives.cpp ===

[PATCH] D51333: Diagnose likely typos in include statements

christylee added inline comments. Comment at: lib/Lex/PPDirectives.cpp:1901 +FilenameLoc, +LangOpts.MSVCCompat ? NormalizedPath.c_str() : Filename, false, +LookupFrom, LookupFromFile, CurDir, rsmith wrote: > You're passing in `

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 165162. christylee edited the summary of this revision. christylee added a comment. Emit non-fatal error for typo if file exists. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp Index: lib/L

[PATCH] D51333: Diagnose likely typos in include statements

christylee marked 2 inline comments as done. christylee added a comment. In https://reviews.llvm.org/D51333#1219938, @rsmith wrote: > Instead of guessing whether the corrected filename would be valid, why not > strip off the leading and trailing non-alphanumeric characters, look up the > result

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 163132. christylee edited the summary of this revision. christylee added a comment. Merged warning with existing file_not_found_error. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp lib/Lex

[PATCH] D51333: Diagnose likely typos in include statements

christylee created this revision. Herald added a subscriber: cfe-commits. When someone writes #include "" or #include " some_file.h " the compiler returns "file not fond..." with fonts and quotes that may make it hard to see there are excess quotes or surprising bytes in the filename. Th