collinbaker added a comment.
Collin Baker
collinba...@chromium.org
This should also be in the author field of the commits
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
collinbaker added a comment.
All done. Again, I don't have commit access so someone else will need to land
this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
collinbaker updated this revision to Diff 503954.
collinbaker added a comment.
Rebase w/ conflict in libclang.map
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
Files:
clang/docs/ReleaseNotes.rst
collinbaker marked 5 inline comments as done.
collinbaker added a comment.
I am very bad at using differential
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
collinbaker updated this revision to Diff 503953.
collinbaker retitled this revision from "Handle template parameter-dependent
bit field widths in libclang" to "Fix include order in CXType.cpp".
collinbaker edited the summary of this revision.
collinbaker added a comment.
Re-add "Fixes" commit
collinbaker updated this revision to Diff 503952.
collinbaker added a comment.
Missed commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
Files:
clang/docs/ReleaseNotes.rst
collinbaker updated this revision to Diff 503950.
collinbaker marked 3 inline comments as done.
collinbaker edited the summary of this revision.
collinbaker added a comment.
Cleanups and split header order change to separate commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
collinbaker marked 5 inline comments as done.
collinbaker added a comment.
Changed as requested. Again leaving it up to a committer to commit this
Comment at: clang/include/clang-c/Index.h:3552
+ * If the cursor does not reference a bit field declaration or if the bit
+ *
collinbaker updated this revision to Diff 503570.
collinbaker edited the summary of this revision.
collinbaker added a comment.
Requested changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
Files:
collinbaker added a comment.
@dexonsmith can you weigh in?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
___
cfe-commits mailing list
collinbaker marked 3 inline comments as done.
collinbaker added a comment.
Thanks for the review. Someone else will need to commit since I don't have
permission.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
collinbaker updated this revision to Diff 502763.
collinbaker added a comment.
Add symbol to version map
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
Files:
clang/docs/ReleaseNotes.rst
collinbaker added inline comments.
Comment at: clang/include/clang-c/Index.h:3552
+ * If the cursor does not reference a bit field declaration or if the bit
+ * field's width does not depend on template parameters, 0 is returned.
+ */
vedgy wrote:
> I just
collinbaker updated this revision to Diff 502762.
collinbaker added a comment.
Add release notes and remove unneeded include
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
Files:
collinbaker updated this revision to Diff 502758.
collinbaker added a comment.
Sync with upstream changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
Files:
clang/include/clang-c/Index.h
collinbaker added a comment.
Pinging this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new/
https://reviews.llvm.org/D130303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
collinbaker created this revision.
collinbaker added a reviewer: rnk.
Herald added a subscriber: arphaman.
Herald added a project: All.
collinbaker requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
In a class template, a bit field's width
collinbaker updated this revision to Diff 397394.
collinbaker added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115049/new/
https://reviews.llvm.org/D115049
Files:
clang/include/clang/Driver/ToolChain.h
collinbaker marked 2 inline comments as done.
collinbaker added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:500
+ if (getTriple().isAndroid() &&
+ getTriple().getEnvironmentName() != "android") {
+llvm::outs() << getTriple().getEnvironmentName() <<
collinbaker updated this revision to Diff 393978.
collinbaker added a comment.
- Address comments
- Fix VEToolchain build error
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115049/new/
https://reviews.llvm.org/D115049
Files:
collinbaker updated this revision to Diff 391661.
collinbaker added a comment.
Fix variable name style
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115049/new/
https://reviews.llvm.org/D115049
Files:
clang/include/clang/Driver/ToolChain.h
collinbaker created this revision.
Herald added subscribers: abrachet, danielkiss, kristof.beyls.
collinbaker requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Clang searches for runtimes (e.g. libclang_rt*) first in a
subdirectory named for
22 matches
Mail list logo
