[PATCH] D85256: Add -Wtautological-value-range-compare warning.

xbolva00 added a comment. >> But I think that and this are separate changes and I'd prefer not to combine >> them. Yeah, right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/ https://reviews.llvm.org/D85256

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

xbolva00 added a comment. Could this solve https://bugs.llvm.org/show_bug.cgi?id=40921? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/ https://reviews.llvm.org/D85256 ___ cfe-commits mailing li

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

xbolva00 added a comment. Thanks. Can you add some test cases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:274 + "misaligned atomic operation may incur " + "significant performance penalty " + "(the expected (%0 bytes) exceeds the actual alignment (%1 bytes)">, Use ; ra

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 280694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 280693. xbolva00 added a comment. More tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 280692. xbolva00 added a comment. Updated. Thanks for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSem

[PATCH] D82728: [clang] Add -Wsuggest-override

xbolva00 added a comment. Is it possible to emit fixit note with "override" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82728/new/ https://reviews.llvm.org/D82728 ___ cfe-commits mailing list cfe-c

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

xbolva00 added a comment. >> UTC_ARGS (I can't help associating it with Coordinated Universal Time). Me too. Any suggestions for new name? TCU_ARGS? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 __

[PATCH] D79830: Add support of __builtin_expect_with_probability

xbolva00 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2216 +// it could have side-effects. +if (CGM.getCodeGenOpts().OptimizationLevel == 0) + return RValue::get(ArgValue); Fix comment and remove Probability? CHANGES SINCE LA

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

xbolva00 added a comment. Can you provide some compile time data with warning enabled/disabled? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

xbolva00 added a comment. Great! Maybe worth to add a release note that -Os works with LTO? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79919/new/ https://reviews.llvm.org/D79919 ___ cfe-commits mail

[PATCH] D79830: Add support of __builtin_expect_with_probability

xbolva00 added a comment. In D79830#2034380 , @RKSimon wrote: > Add a description in our documentation? And Ideally add a note to release notes too.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/test/SemaCXX/deprecated-copy.cpp:7 +#ifdef NO_USER_PROVIDED +// expected-no-diagnostics +#endif xbolva00 wrote: > Quuxplusone wrote: > > I'm fairly confident this should

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 marked 4 inline comments as done. xbolva00 added a comment. Thanks for initial comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:158 +def DeprecatedCopy : DiagGroup<"deprecated-copy", [DeprecatedCopyUserProvided]>; +def DeprecatedCopyDtor : DiagGroup

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Solves https://bugs.llvm.org/show_bug.cgi?id=45634 Be more agressive than GCC with -Wdeprecated-copy. Also provide -W(no-)deprecated-copy-user-provided options

[PATCH] D71142: [Sema] Validate large bitfields

xbolva00 added a comment. Any comments? @rsmith @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71142/new/ https://reviews.llvm.org/D71142 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

xbolva00 added a comment. Fix is easy, can you commit it as obvious? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

xbolva00 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:3100 } - F.TypeOffsets = (const uint32_t *)Blob.data(); + F.TypeOffsets = (const uint64_t *)Blob.data(); F.LocalNumTypes = Record[0]; use C++ cast style Re

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3673 +def warn_pointer_to_enum_cast : Warning< + "cast to smaller integer type %1 from %0">, + InGroup; You can reuse warning text: warn_pointer_to_int_cast.Text I th

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341 Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); // TODO: Remove the hack for the binop form when the unary op is optimized // pro

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341 Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); // TODO: Remove the hack for the binop form when the unary op is optimized // pro

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Ok, please commit to fix the bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74694/new/ https://reviews.llvm.org/D74694 __

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

xbolva00 added a comment. @nikic: Can you please do compile-time benchmarks w/o this patch with e.g. php ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73835/new/ https://reviews.llvm.org/D73835 ___ c

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added a comment. >> Perhaps we can also see what the defaults are for GCC and unify with those? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added a comment. Looks like this patch regressed the test-suite: https://lnt.llvm.org/db_default/v4/nts/recent_activity Now 45min+ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

xbolva00 added a comment. I think that this patch is needed since we need to deal with this situation somehow because fallthru comments are used in many real world code. But I am personally against extending it more and use comments to disable warnings generally. Repository: rG LLVM Github

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added a comment. Any plans to merge this feature to 10 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commit

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

xbolva00 added a comment. LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info added by clang will not increase power of LLVM. Or? Alignment info is useful I think. Comment at: clang/test/CodeGenCXX/builtin-operator-new-delete.cpp:54 } -// CHECK: dec

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

xbolva00 added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/ https://reviews.llvm.org/D73099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

xbolva00 added a subscriber: hans. xbolva00 added a comment. Yes, but minimal fix is better for release branch, so @hans should merge it. Handling your case probably needs more work and patches.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73007/

[PATCH] D72052: [UserManual] Update the C++ standard support

xbolva00 added a comment. +1 Comment at: clang/docs/UsersManual.rst:2557 clang fully implements all of standard C++98 except for exported +templates (which were removed in C++11), and all of standards C++11, C++14, Clang ? :) Repository: rG LLVM Github M

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

xbolva00 added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413 unsigned MaxRecurse) { - if (isa(Mask)) + if (all_of(Mask, [](int Elem) { return Elem == -1; })) return UndefValue::get(RetTy); -

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 _

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

xbolva00 added a comment. >> The diagnostic is not enabled by default But GCC enables it for C even without "-Wall or -Wextra". Clang should follow it.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.llvm.org/D72231 _

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2806 - // constructors. - if (VariableType.isPODType(SemaRef.Context)) return; Mordante wrote: > xbolva00 wrote: > > assert it? > Sorry I don't understand what you mean. What do you wa

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2806 - // constructors. - if (VariableType.isPODType(SemaRef.Context)) return; assert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

xbolva00 added a comment. Ah, true. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https://reviews.llvm.org/D71037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. (re-ping; I think this false positive for goto label case is important to be fixed before 10 release) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 ___

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

xbolva00 reopened this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Can you add a test case for that crash? Otherwise OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https://reviews.llvm.org/D71037 _

[PATCH] D71857: Fixes -Wrange-loop-analysis warnings

xbolva00 added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" NFC patch? Repository: rG LLVM Github Monorepo

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

xbolva00 added a comment. if(num != 0) memmove is missed optimization opportunity. Such branch can be removed (if profitable). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 ___ cfe-commits mailing

[PATCH] D69868: Allow "callbr" to return non-void values

xbolva00 added subscribers: aaron.ballman, xbolva00. xbolva00 added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1116 +if (auto *cbr = dyn_cast(getBasicBlock()->getTerminator())) + if (cbr->getDefaultDest() != bb) +for (unsigned i = 0, e =

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. All is fixed now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D59254: [RFC] Implementation of Clang randstruct

xbolva00 added a comment. Re-ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59254/new/ https://reviews.llvm.org/D59254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

xbolva00 added a comment. Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the whole patch stack. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579 ___ cfe-c

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added a comment. Hello @aaron.ballman / @rsmith, can you please take a look so this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing lis

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

xbolva00 added a comment. In D71486#1784079 , @sammccall wrote: > It should be possible to test this by adapting a test case from the original > ed8dadb > , but > I'm not certain...

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 added a comment. > @xbolva00 should I remove the lowering part and leave it to llvm? Probably okay to leave it + inbounds, but please add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 added a comment. LLVM already converts mempcpy to memcpy.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 added a comment. Please add a IR codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12631 - void VisitSequencedExpressions(Expr *SequencedBefore, Expr *SequencedAfter) { + void VisitSequencedExpressions(const Expr *SequencedBefore, + const Expr *Sequen

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

xbolva00 added a comment. Does the whole stack of patch need to be commited at once or maybe you can land them individually? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747 _

[PATCH] D71142: [Sema] Validate large bitfields

xbolva00 added a comment. Maybe a bit offtopic, but it would be good to diagnose this case too: enum A {a, b, c = 8}; struct T { enum A field : 2; }; GCC catches this bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71142/new/ ht

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. No other compiler ? GCC 9 introduced it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added inline comments. Comment at: clang/test/Parser/warn-misleading-indentation.cpp:209 +} \ No newline at end of file Please add newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https:

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. fbmem.c case reduced: https://godbolt.org/z/ma4aFA Looks like kernel uses tabs here So we have BinaryOperator If we use spaces: BinaryOperator 'int' '=' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https:

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. Looks better, thanks. Aaron ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1239 + ~MisleadingIndentationChecker() { +assert(!NeedsChecking && "Check Has not been called"); + } I dont think we need this. Tests will fail anyway if someone removes check() call

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. >> there is only one case in llvm's code in which this warning is more >> agressive thant GCC's. I think that's okay. If after-commit feedback shows this is bad, we can always tune this diagnostic more and do not warn in that case. CHANGES SINCE LAST ACTION https:/

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2269 +public: /// isCXXDeclarationStatement - C++-specialized function that disambiguates Extra change? Your code does not use isCXXDeclarationStatement. CHANGES SINCE LAST ACTI

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. Please land code fixes as NFC patch and then try to reland this patch. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2532 +if (Val.getAsLocSymbol() == Sym) { + const VarRegion *VR = MR->getBaseRegion()->getAs(); +

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 reopened this revision. xbolva00 added a subscriber: tstellar. xbolva00 added a comment. This revision is now accepted and ready to land. @tstellar reverted this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://revi

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

xbolva00 added a comment. I think this was commited too soon. You should receive LGTM from clang maintainer(s). In D70302#1747372 , @nickie wrote: > LGTM, for all that it's worth. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0619r4.html#3.2 So C++20 or C++23. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 _

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. Add copy ctor/op= manually. If you have a lot of warnings, you can use -Wno-deprecated-copy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 added a comment. Thank you for the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70624/new/ https://reviews.llvm.org/D70624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4017670e19: [Diagnostics] Warn for comparison with string literals expanded from macro… (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 updated this revision to Diff 230797. xbolva00 added a comment. Added new tests. Improved recommendation how to fix warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70624/new/ https://reviews.llvm.org/D70624 Files: clang/include/c

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

xbolva00 added inline comments. Comment at: clang/test/Modules/Inputs/merge-lifetime-extended-temporary/module.modulemap:15 +} \ No newline at end of file Add newline here. Dtto in other tests above. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7019

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 marked 2 inline comments as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8431 "result of comparison against %select{a string literal|@encode}0 is " - "unspecified (use strncmp instead)">, - InGroup; + "unspecifi

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. In D68912#1754660 , @xbolva00 wrote: > I think you can commit it, you already fixed some warnings. Oh, I hit this (-Werror bots) hard :D Some bots use -Werror. So when build is warning-free, then please commit this patch. CHA

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/test/Sema/warn-stringcompare.c:4-6 +#define DELIM "/" +#define NULL (void *)0 + Current behaviour: https://godbolt.org/z/7nYH6N Repository: rG LLVM Github Monorepo C

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 created this revision. xbolva00 added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/test/Sema/warn-stringcompare.c:4-6 +#defin

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

This revision was automatically updated to reflect the committed changes. Closed by commit rG9353c5dd0664: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D70603: Change while to do-while

xbolva00 added a comment. This is fine as NFC/NFCI patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added a comment. https://reviews.llvm.org/rG397fa687691876de9ff0fbaaf0def3ac5a48899c Commited? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. I think you can commit it, you already fixed some warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 updated this revision to Diff 229660. xbolva00 added a comment. Newline fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. In D70342#1748555 , @rsmith wrote: > Generally OK, but I'm concerned about including this in `-Wextra`. In > particular, the deprecation of copy/move operations when a destructor is > explicitly declared has experimentally been

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 updated this revision to Diff 229658. xbolva00 added a comment. Added -Wdeprecated-copy-dtor (not part of -Wextra). Now we should be fully compatible with GCC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC 9 added -Wdeprecated-copy (as part of -Wextra). This diagnostic is already implemented in Clang too, just hidden under -Wdeprecated (not on by default). Th

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 abandoned this revision. xbolva00 added a comment. https://reviews.llvm.org/D70342 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68185/new/ https://reviews.llvm.org/D68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D70157: Align branches within 32-Byte boundary

xbolva00 added a comment. > Even though core2 isn't affected by the erratum, core2 code can run on CPUs > that do have the bug (and core2 is a popular target for code that needs to > run "everywhere"), therefore all target CPUs that predate a hardware fix > really So perf of all code/generic c

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. So use similar fix as I did: https://reviews.llvm.org/D69708 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Yes, i will prepare a new patch and add him as a reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68185/new/ https://reviews.llvm.org/D68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Ah, Clang has it under -Wdeprecated. https://clang.llvm.org/docs/DiagnosticsReference.html#wdeprecated. But combo -Wall -Wextra does not enable this warning, sadly. This should be extracted to -Wdeprecated-copy and put into -Wextra. Seems fine for you? CHANGES SINCE

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Should we reconsider this as a clang warning? I found that the newest GCC can diagnose it. GCC 9+: -Wdeprecated-copy, implied by -Wextra, warns about the C++11 deprecation of implicitly declared copy constructor and assignment operator if one of them is user-provided

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

This revision was automatically updated to reflect the committed changes. Closed by commit rG1da13237a41a: [Diagnostics] Try to improve warning message for -Wreturn-type (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 updated this revision to Diff 228578. xbolva00 added a comment. Herald added a subscriber: arphaman. Added FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 Files: clang/include/clang/Basic/

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6860 "lambda declared 'noreturn' should not return">; def warn_maybe_falloff_nonvoid_lambda : Warning< +"non-void lambda does not re

[PATCH] D69792: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.

xbolva00 added a comment. Can you please land it? These warnings are quite annoying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69792/new/ https://reviews.llvm.org/D69792 ___ cfe-commits mailing lis

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 updated this revision to Diff 228514. xbolva00 added a comment. Fixed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cl

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 added a comment. Looking at Sema/AnalysisBasedWarnings.cpp, reworking it to "select" would take some time so I will prepare just simple patch without "select". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 added a comment. We cannot use it for block; it is a hard error. Corountine and function can be merged as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 _

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. Thanks. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG01b10bc7b149: [Diagnostics] Teach -Wnull-dereference about address_space attribute (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6966

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228301. xbolva00 added a comment. Removed unused variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs

<    1   2   3   4   5   6   7   8   9   10   >