Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

2015-09-23 Thread Daniel Cheng via cfe-commits
dcheng abandoned this revision. dcheng added a comment. OK, thanks for highlighting the proposed resolution. http://reviews.llvm.org/D13080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

2015-09-22 Thread Daniel Cheng via cfe-commits
dcheng added a comment. In http://reviews.llvm.org/D13080#251324, @dblaikie wrote: > I'd still be curious to see a stronger justification from the standard > about this. > > I know you mentioned/quoted the definition of ~unique_ptr in the standard - > but I'm not sure that is meant to imply obs

[PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

2015-09-22 Thread Daniel Cheng via cfe-commits
dcheng created this revision. dcheng added a reviewer: thakis. dcheng added a subscriber: cfe-commits. This better matches the behavior of MSVC and libstdc++: neither standard library sets the stored pointer to null when destroying the unique_ptr. http://reviews.llvm.org/D13080 Files: include/