[PATCH] D159540: [Basic] X86 backend changes for UEFI

mysterymath added a comment. There should also be tests for this behavior in llvm/test/CodeGen/X86. I wouldn't think it necessary to fully test the calling convention; that should already be well covered; just something in those key test files (e.g., `sse-regcall.ll`) to verify that the `uefi`

[PATCH] D159540: [Basic] X86 backend changes for UEFI

mysterymath added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:522 // Mingw64 and native Win64 use Win64 CC CCIfSubtarget<"isTargetWin64()", CCDelegateTo>, You'll need to add switching for Win64 here too; this appears to be the

[PATCH] D148577: [CMake] Switch back to -fPIC for Fuchsia Toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37a6218f8a0: [CMake] Switch back to -fPIC for Fuchsia Toolchain (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148577/new/

[PATCH] D148577: [CMake] Switch back to -fPIC for Fuchsia Toolchain

mysterymath created this revision. mysterymath added reviewers: abrachet, phosek. Herald added a subscriber: ekilmer. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mysterymath marked an inline comment as done. Closed by commit rG0430324289f2: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS. (authored by mysterymath).

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

mysterymath marked an inline comment as done. mysterymath added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:3 +option(FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS "Use multiple distributions") +option(FUCHSIA_ENABLE_LLDB "Enable LLDB") phosek

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

mysterymath created this revision. mysterymath added reviewers: haowei, phosek. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag causes the toolchain

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath abandoned this revision. mysterymath added a comment. Given that we didn't reach a consensus on this one, I'll abandon this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121175/new/ https://reviews.llvm.org/D121175

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

mysterymath added a comment. It looks like these tests don't pass when LLVM_ENABLE_LINKER_BUILD_ID is set; I've issued a revert until this can be fixed to unblock the Fuchsia toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145227/new/

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

mysterymath added a comment. This is also causing a breakage on the Linux and Mac Fuchsia toolchain builds: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8786633328903858561/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145818: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2998a5551e29: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145818: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS.

mysterymath created this revision. mysterymath added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stage2-check-lldb should be run in a

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0e9c55db3b6: [Fuchsia] Add LLDB options to stage 1 cmake. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145449/new/

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

mysterymath added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif() haowei wrote: > You probably need a `string(REPLACE ";" "|" value >

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

mysterymath created this revision. mysterymath added reviewers: phosek, haowei. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM_ENABLE_PROJECTS is

[PATCH] D145187: [Fuchsia] Add other necessary components to LLDB install.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc65fb80b73aa: [Fuchsia] Add other necessary components to LLDB install. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145187/new/

[PATCH] D145187: [Fuchsia] Add other necessary components to LLDB install.

mysterymath created this revision. mysterymath added reviewers: phosek, haowei. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fecac18ffad: [Clang] [AVR] Fix USHRT_MAX for 16-bit int. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath added a comment. Thanks for your help in getting this right! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 ___ cfe-commits mailing list

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500861. mysterymath marked an inline comment as done. mysterymath added a comment. Add C++ version of test for AVR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500442. mysterymath added a comment. Minor clarification to release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500264. mysterymath marked an inline comment as done. mysterymath added a comment. Update condition; move release note to AVR section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath added inline comments. Comment at: clang/docs/ReleaseNotes.rst:43-45 +- The definition of ``USHRT_MAX`` in the freestanding no longer + overflows on AVR (where ``sizeof(unsigned int) == sizeof(unsigned short)``). + The type of ``USHRT_MAX`` on AVR is now

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 499922. mysterymath added a comment. Use #if to select between signed and unsigned USHRT_MAX. Add tests for the types of limit macros specified by the standard. Add tests that limit macros can be used in #if. Repository: rG LLVM Github Monorepo

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath marked an inline comment as done. mysterymath added inline comments. Comment at: clang/lib/Headers/limits.h:55 #define UCHAR_MAX (__SCHAR_MAX__*2 +1) -#define USHRT_MAX (__SHRT_MAX__ *2 +1) +#define USHRT_MAX (__SHRT_MAX__ * 2U + 1U) #define UINT_MAX

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath marked an inline comment as done. mysterymath added inline comments. Comment at: clang/lib/Headers/limits.h:55 #define UCHAR_MAX (__SCHAR_MAX__*2 +1) -#define USHRT_MAX (__SHRT_MAX__ *2 +1) +#define USHRT_MAX (__SHRT_MAX__ * 2U + 1U) #define UINT_MAX

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 499659. mysterymath added a comment. Corrected type of USHRT_MAX. Added tests and release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 Files:

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath created this revision. mysterymath added reviewers: aaron.ballman, aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For AVR, the

[PATCH] D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bc9dc26bc9b: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143794/new/

[PATCH] D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

mysterymath updated this revision to Diff 497048. mysterymath added a comment. _FUCHSIA_DISTRIBUTION_COMPONENTS should not be a CACHE variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143794/new/ https://reviews.llvm.org/D143794 Files:

[PATCH] D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

mysterymath created this revision. mysterymath added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This CMake option builds/installs LLDB

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

mysterymath added a comment. This also appears to be breaking the Darwin build for the Fuchsia toolchain, with similar test failures to those seen by @thakis. Given the scope of the breakages, can we revert this and reland later? See:

[PATCH] D136078: Use-after-return sanitizer binary metadata

mysterymath added a comment. Hi, it looks like this change is causing Fuchsia's linux-x64 clang builders to fail: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8796062278266465473/overview Would you mind taking a look and fixing forward, or that ends up

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath added a comment. Herald added a subscriber: StephenFan. Wanted to circle back around to this one, since this feature would still really help improve the workflow for ignoring warnings on build systems without deep compiler examination capabilities. Can we move forward with this?

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath created this revision. mysterymath added reviewers: phosek, MaskRay. Herald added a subscriber: dexonsmith. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These options allow guarding a