[PATCH] D144135: [clang-tidy] Add performance-enum-size check

2023-07-05 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/EnumSizeCheck.cpp:127-128 + + diag(MatchedDecl->getLocation(), "enum %0 derive from %1 of size %2 bytes, " + "derive from '%3' to reduce it size to %4") +

[PATCH] D124669: [flang][driver] Add support for -save-temps

2022-05-02 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; rovka wrote: > awarzynski

[PATCH] D124669: [flang][driver] Add support for -save-temps

2022-04-29 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; Why not to add `FC1Option`

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

2022-04-06 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung added a comment. @ekieri, hello! Thank you for the comment, it is really helpful! It turns out that I've researched the issue poorly. Actually, `nvfortran` compiler forbids to use `INTENT` attribute on local variables, even though a "mod" file can be generated. It generates a

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

2022-04-05 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung updated this revision to Diff 420437. unterumarmung added a comment. Fixed commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123113/new/ https://reviews.llvm.org/D123113 Files: clang/include/clang/Driver/Options.td

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

2022-04-05 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung updated this revision to Diff 420436. unterumarmung retitled this revision from "[Flang] Add `INTENT` for non-dummy arguments extension nvfortran compiler supports using INTENT attributes for non-dummy arguments. For example, for local variables." to "[Flang] Add `INTENT` for

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension nvfortran compiler supports using INTENT attributes for non-dummy arguments. For example, for local variables.

2022-04-05 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung created this revision. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. unterumarmung requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, jdoerfert, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang. This