[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

2022-03-27 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 added a comment. In D120129#3410514 , @jdoerfert wrote: > Our internal build bots and CI for some projects are broken for 3 days. I > wish to unbreak them so we get actual meaningful results, e.g., see if > something else is breaking our

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

2022-03-27 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 added a comment. In D120129#3410510 , @jdoerfert wrote: > The two assertions introduced here do not hold for the libdevice.bc above. So > whenever we link the above we will cause the assertions to fail. That's what > I mean with break.

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

2022-03-27 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 added a comment. In D120129#3410479 , @jdoerfert wrote: > Please revert this commit. It breaks any code using the cuda.11.0.2 > libdevice.bc file, the source of the `null` `nvvm.annotations` and the > annotations with 5 arguments. See below. >

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

2022-03-25 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 added a comment. In D120129#3408168 , @jdoerfert wrote: > You don't need to run it. If you use this command line it doesn't crash? Yes, I run the same command (with sm_75 instead of sm_80 because I don't have libomptarget-nvptx-sm_80.bc), and

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

2022-03-25 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 added a comment. In D120129#3408088 , @jdoerfert wrote: > Godbold seems to not have included this: > > $ cat test.cpp > int main(){return 0;} > $ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target -march=sm_80 > test.cpp > ...

[PATCH] D121549: [CodeGen] Define ABI breaking class members correctly

2022-03-24 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 updated this revision to Diff 417858. kovdan01 added a comment. Accidentally placed this revision ID in commit message related to other patch. Reverted that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files:

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

2022-03-24 Thread Daniil Kovalev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kovdan01 marked 2 inline comments as done. Closed by commit rG828b63c30943: [NVPTX] Enhance vectorization of ld.param st.param (authored by kovdan01). Herald added a

[PATCH] D121549: Define ABI breaking class members correctly

2022-03-24 Thread Daniil Kovalev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf854434f0f2a: [NVPTX] Enhance vectorization of ld.param st.param (authored by kovdan01). Herald added subscribers: asavonic, StephenFan,

[PATCH] D121549: Define ABI breaking class members correctly

2022-03-14 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 updated this revision to Diff 415049. kovdan01 marked an inline comment as done. kovdan01 removed projects: MLIR, clang. kovdan01 added a comment. Fix formatting problems found on pre-merge checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/

[PATCH] D121549: Define ABI breaking class members correctly

2022-03-14 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 marked an inline comment as done. kovdan01 added inline comments. Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601 + // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS #ifndef NDEBUG mehdi_amini wrote: > This is a

[PATCH] D121549: Define ABI breaking class members correctly

2022-03-14 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 updated this revision to Diff 415022. kovdan01 added a comment. Keep private headers untouched CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: llvm/include/llvm/CodeGen/GlobalISel/GISelWorkList.h

[PATCH] D121549: Define ABI breaking class members correctly

2022-03-13 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 updated this revision to Diff 414929. kovdan01 added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: clang/lib/Sema/TypeLocBuilder.cpp clang/lib/Sema/TypeLocBuilder.h

[PATCH] D121549: Define ABI breaking class members correctly

2022-03-13 Thread Daniil Kovalev via Phabricator via cfe-commits
kovdan01 created this revision. kovdan01 added reviewers: dexonsmith, craig.topper. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, ecnelises, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik,