[PATCH] D131789: [clang-tools-extra][NFC] Rewrite prints in python3 compatible way

2022-08-15 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. Please, commit this patch for me I don't have an access to commit the patch by myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131789/new/ https://reviews.llvm.org/D131789

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

2022-08-14 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine updated this revision to Diff 452513. eoanermine added a comment. - Add examples to comments - Reformat comments right Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129926/new/ https://reviews.llvm.org/D129926 Files:

[PATCH] D129628: [clang-format] Fix aligning of java-style declarations

2022-08-14 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. I don't have an access to commit the patch by myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129628/new/ https://reviews.llvm.org/D129628 ___ cfe-commits mailing list

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

2022-08-14 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. In D129926#3705342 , @MyDeveloperDay wrote: > Can we land this for you? Yes Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2869-2870 + // Handle array initialization syntax if

[PATCH] D131789: [clang-tools-extra] Rewrite prints in python3 compatible way

2022-08-12 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine created this revision. eoanermine added reviewers: klimek, HazardyKnusperkeks. eoanermine added a project: clang-tools-extra. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

2022-07-16 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine created this revision. eoanermine added reviewers: owenpan, HazardyKnusperkeks, MyDeveloperDay. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Handle constructor

[PATCH] D129892: Fix aligning of trailing comments after comment at the end of a namespace

2022-07-15 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine created this revision. eoanermine added reviewers: owenpan, HazardyKnusperkeks, curdeius, MyDeveloperDay. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Fix aligning

[PATCH] D129845: Allow custom attributes in access specifiers

2022-07-15 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine created this revision. eoanermine added reviewers: owenpan, HazardyKnusperkeks, curdeius. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Allow custom attributes in

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-14 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine updated this revision to Diff 444556. eoanermine edited the summary of this revision. eoanermine added a comment. - Rename AlignRequiresClauseBody to RequiresExpressionIndentation - Introduce RequiresExpressionIndentationKind as a type of RequiresExpressionIndentation - Add more tests

[PATCH] D129628: Fix aligning of java-style declarations

2022-07-13 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. I found that the problem was that `TokenAnnotator` doesn't handle Java-style array declarations fine. It doesn't consider identifier after square brackets as a StartOfName. I fixed it, it seems valid, but I'm not a hundred percent sure about it. Repository: rG

[PATCH] D129628: Fix aligning of java-style declarations

2022-07-13 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine created this revision. eoanermine added reviewers: MyDeveloperDay, owenpan, HazardyKnusperkeks, curdeius. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Modify

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-12 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. In D129443#3644795 , @eoanermine wrote: > Add tests for AlignRequiresClauseBody option Are these tests fine? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-12 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine updated this revision to Diff 443895. eoanermine added a comment. Add tests for AlignRequiresClauseBody option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 Files:

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-12 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. In D129443#3641571 , @curdeius wrote: > Haven't you forgotten to add formatting tests? :) Yes, I have. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-10 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine created this revision. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Add an option whether requires clause body should be aligned with `requires` keyword Fixes