[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba6e747f9b05: [clang] Set ShowInSystemHeader for module-build and module-import remarks (authored by kastiglione). Repository: rG LLVM Github

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione updated this revision to Diff 510141. kastiglione added a comment. minor cleanup of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 Files:

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione updated this revision to Diff 510138. kastiglione added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

kastiglione added a comment. I understand the potential for a use after free, since `OutputStream` is a raw pointer, but I don't understand the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione added a comment. > We could have a separate `-Ruser-module-{build,import}` (and maybe > `-Rsystem-module-{build,import}`) besides the `-Rmodule-{build,import}` (that > would now include both). that sounds good to me. I'll add tests if there are no objections. Repository: rG

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione added a comment. > Also, do you think this should be configurable on the command line? Do you have a flag in mind? I have worked around the current behavior with `-Wno-system-header`, but there are two problems with that: first, it's not obvious that it's needed (I had to debug

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione created this revision. kastiglione added a reviewer: jansvoboda11. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this change, the use of `-Rmodule-build` and `-Rmodule-import`

[PATCH] D129456: [lldb] Add image dump pcm-info command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5ccfeb6bfbb: [lldb] Add image dump pcm-info command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione updated this revision to Diff 444057. kastiglione added a comment. simplify error handling by checking for .pcm extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files:

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione updated this revision to Diff 443830. kastiglione added a comment. added error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include/clang/Frontend/FrontendActions.h

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione added a comment. @JDevlieghere I had it as `dump pcm` at first, but switched it to `pcm-info` for two reasons 1. it doesn't dump the whole pcm, the actual ast itself is not dumped 2. to match the clang flag `-module-file-info` I agree that `pcm` is better, but I was worried it

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione added a reviewer: Michael137. kastiglione added inline comments. Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( mib wrote: > Left over ? yep thanks! Repository: rG LLVM

[PATCH] D129456: [lldb] Add image dump pcm command

kastiglione updated this revision to Diff 443532. kastiglione added a comment. remove commented-out code in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files:

[PATCH] D129456: [lldb] Add image dump pcm command

kastiglione updated this revision to Diff 443531. kastiglione added a comment. add @skipUnlessDarwin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files:

[PATCH] D129456: [lldb] Add image dump pcm command

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, augusto2112. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. kastiglione requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits,

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG65aa47301372: [clang][utils] Remove StringRef lldb summary provider (authored by kastiglione). Repository: rG LLVM

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

kastiglione added a comment. The StringRef provider was improved in D117779 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116987/new/ https://reviews.llvm.org/D116987

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

kastiglione created this revision. kastiglione added reviewers: akyrtzi, jingham. Herald added subscribers: usaxena95, arphaman. kastiglione requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the `StringRef` summary provider in favor

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

kastiglione added a comment. Herald added a subscriber: carlosgalvezp. +1 to committing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 ___ cfe-commits

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

kastiglione added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4697 // Always use the first input as the base input. const char *BaseInput = InputInfos[0].getBaseInput(); maybe adjust this comment to emphasize first _file_ input

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

kastiglione added a comment. @Tyker in case you didn't see my previous message, I'm curious if you'd be willing to take a look at the bug. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

kastiglione added a comment. @Tyker Hi, I noticed a case that isn't caught by `-Wmisleading-indentation`. In code that uses two space indents, there's a corner case that isn't caught when the preceding `if` uses curly braces. I've noticed a couple instances of this in lldb. For example: if

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

kastiglione added a comment. Is there any reason that `-include-pch` shouldn't follow the precedent of `-include`, which can be used multiple times? If not, then the end goal should be to support multiple uses, but in the mean time a warning is helpful. Repository: rG LLVM Github Monorepo

[PATCH] D91669: Don’t break before nested block param when prior param is not a block

kastiglione accepted this revision. kastiglione added a comment. The purpose and the tests LGTM! Hopefully someone will weigh in on the implementation in ContinuationIndenter.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91669/new/

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. Reverted here: 4cb4db11ee1323c5d4bf66d21deb046970f4e516 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89318/new/ https://reviews.llvm.org/D89318

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. @martong here's a partial backtrace: 3: LLDB`llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) 4: LLDB`clang::AttributeCommonInfo::calculateAttributeSpellingListIndex() const 5: LLDB`clang::ASTImporter::Import(clang::Attr const*) 6:

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. @martong hi, this caused a test regression. In `TestImportBuiltinFileID.py`, this unreachable assertion is hit: Ignored/unknown shouldn't get here UNREACHABLE executed at tools/clang/include/clang/Sema/AttrSpellingListIndex.inc:13! See

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

kastiglione added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:2181 + /// This is true iff the protocol is tagged with the `objc_static_protocol` + /// attribute. This comment refers to the original spelling. Repository: rG LLVM Github

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

This revision was automatically updated to reflect the committed changes. Closed by commit rGb36bdfe5ca0c: [cmake] Centralize LLVM_ENABLE_WARNINGS option (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. for context this caused standalone swift-lldb builds to have warnings disabled via `-w` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. @compnerd Saleem, what do you think? (see also my reply to you) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 ___ cfe-commits

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione updated this revision to Diff 290597. kastiglione edited the summary of this revision. kastiglione added a comment. Add LLVM_ENABLE_WARNINGS to LLVMConfig.cmake.in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. If another project defines `LLVM_ENABLE_WARNINGS` before loading `HandleLLVMOptions`, it seems correct to me that the first one is used. This change ensures the default value of ON is setup at the last possible opportunity, before `LLVM_ENABLE_WARNINGS` is read and

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. If an LLVM install disabled `LLVM_ENABLE_WARNINGS`, should other builds inherit that? I would think no, but is there's a precedent for that that to be the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. The `LLVM_ENABLE_WARNINGS` variable is read only within `HandleLLVMOptions.cmake`. Outside declarations/defaults have effect only when `HandleLLVMOptions` is loaded, one way or another. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. @lebedev.ri `clang/CMakeLists.txt` contains `include(HandleLLVMOptions)` for its standalone build, I think this covers the issue you're pointing out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione created this revision. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits, mgorny. Herald added a reviewer: DavidTruby. Herald added projects: clang, libunwind, LLVM. Herald added a reviewer: libunwind. kastiglione requested review of this revision. Repository: rG

[PATCH] D40024: Fix skipping of flags in getClangStripDependencyFileAdjuster

This revision was automatically updated to reflect the committed changes. Closed by commit rL318529: Fix skipping of flags in getClangStripDependencyFileAdjuster (authored by kastiglione). Repository: rL LLVM https://reviews.llvm.org/D40024 Files:

[PATCH] D40024: Fix skipping of flags in getClangStripDependencyFileAdjuster

kastiglione updated this revision to Diff 123131. kastiglione added a comment. Add tests https://reviews.llvm.org/D40024 Files: lib/Tooling/ArgumentsAdjusters.cpp unittests/Tooling/ToolingTest.cpp Index: unittests/Tooling/ToolingTest.cpp

[PATCH] D39948: Make isDefinition matcher support ObjCMethodDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL318152: Make isDefinition matcher support ObjCMethodDecl (authored by kastiglione). Repository: rL LLVM https://reviews.llvm.org/D39948 Files: cfe/trunk/docs/LibASTMatchersReference.html

[PATCH] D39948: Make isDefinition matcher support ObjCMethodDecl

kastiglione updated this revision to Diff 122831. kastiglione added a comment. Regenerate AST Matcher docs https://reviews.llvm.org/D39948 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp Index:

[PATCH] D39948: Make isDefinition matcher support ObjCMethodDecl

kastiglione updated this revision to Diff 122830. kastiglione added a comment. Update isDefinition comment docs to reflect addition of ObjCMethodDecl https://reviews.llvm.org/D39948 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D40024: Fix skipping of flags in getClangStripDependencyFileAdjuster

kastiglione updated this revision to Diff 122829. kastiglione added a comment. Add a continue; https://reviews.llvm.org/D40024 Files: lib/Tooling/ArgumentsAdjusters.cpp Index: lib/Tooling/ArgumentsAdjusters.cpp === ---

[PATCH] D40024: Fix skipping of flags in getClangStripDependencyFileAdjuster

kastiglione created this revision. The ArgumentsAdjuster returned from `getClangStripDependencyFileAdjuster` will skip dependency flags, and also their associated values for those flags that take an argument. This change corrects the handling of the `-MD` and `-MMD` flags, which do not take an

[PATCH] D39948: Make isDefinition matcher support ObjCMethodDecl

kastiglione created this revision. Herald added a subscriber: klimek. Allow the `isDefinition()` matcher to apply to `ObjCMethodDecl` nodes, in addition to those it already supports. For whatever reason, `ObjCMethodDecl` does not inherit from `FunctionDecl` and so this is specialization is

[PATCH] D39940: Add ObjC exception statement AST matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rL317992: Add ObjC exception statement AST matchers (authored by kastiglione). Repository: rL LLVM https://reviews.llvm.org/D39940 Files: cfe/trunk/docs/LibASTMatchersReference.html

[PATCH] D39940: Add ObjC exception statement AST matchers

kastiglione created this revision. Herald added a subscriber: klimek. Add AST matchers for Objective-C @throw, @try, @catch and @finally. https://reviews.llvm.org/D39940 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D39509: Vary Windows toolchain selection by -fuse-ld

This revision was automatically updated to reflect the committed changes. Closed by commit rL317511: Vary Windows toolchain selection by -fuse-ld (authored by kastiglione). Repository: rL LLVM https://reviews.llvm.org/D39509 Files: cfe/trunk/lib/Driver/Driver.cpp

[PATCH] D39509: Vary Windows toolchain selection by -fuse-ld

kastiglione updated this revision to Diff 121196. kastiglione added a comment. Inline the arg variable https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp test/Driver/Inputs/Windows/usr/bin/ld.bfd test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c

[PATCH] D39509: Vary Windows toolchain selection by -fuse-ld

kastiglione updated this revision to Diff 121194. kastiglione added a comment. Base decision on "bfd" prefix https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp test/Driver/Inputs/Windows/usr/bin/ld.bfd test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c

[PATCH] D39509: Vary Windows toolchain selection by -fused-ld

kastiglione updated this revision to Diff 121185. kastiglione added a comment. Use "link" as default when inspecting -fuse-ld= https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp test/Driver/Inputs/Windows/usr/bin/ld.bfd test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c

[PATCH] D39509: Vary toolchain selection by -fused-ld

kastiglione created this revision. This change allows binutils to be used for linking with MSVC. Currently, when using an MSVC target and `-fuse-ld=bfd`, the driver produces an invalid linker invocation. https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp

[PATCH] D39293: Add objcCategoryImplDecl matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL316670: Add objcCategoryImplDecl matcher (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D39293?vs=120269=120431#toc Repository: rL LLVM https://reviews.llvm.org/D39293

[PATCH] D39293: Add objcCategoryImplDecl matcher

kastiglione created this revision. Herald added a subscriber: klimek. Add `objcCategoryImplDecl` which matches ObjC category definitions (`@implementation`). This matcher complements `objcCategoryDecl` (`@interface`) which was added in https://reviews.llvm.org/D30854.

[PATCH] D37643: Add objcImplementationDecl matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL312889: Add objcImplementationDecl matcher (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D37643?vs=114442=114526#toc Repository: rL LLVM

[PATCH] D37643: Add objcImplementationDecl matcher

kastiglione created this revision. Herald added a subscriber: klimek. Add the `objcImplementationDecl` matcher. See related: https://reviews.llvm.org/D30854 Tested with: ./tools/clang/unittests/ASTMatchers/ASTMatchersTests https://reviews.llvm.org/D37643 Files:

[PATCH] D37346: Register linkageSpecDecl matcher

kastiglione added a comment. thanks @aaron.ballman Repository: rL LLVM https://reviews.llvm.org/D37346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37346: Register linkageSpecDecl matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL312283: Register linkageSpecDecl matcher (authored by kastiglione). Repository: rL LLVM https://reviews.llvm.org/D37346 Files: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Index:

[PATCH] D37346: Register linkageSpecDecl matcher

kastiglione created this revision. Herald added a subscriber: klimek. This allows `linkageSpecDecl` to be used from `clang-query`. See also https://reviews.llvm.org/D31869 which similary adds `isStaticStorageClass`. https://reviews.llvm.org/D37346 Files:

[PATCH] D34909: Driver: consume -nostdinc++ along with -nostdinc

kastiglione added a comment. There are other drivers with the same issue. If there's no opposition to this, I can update those here as well. https://reviews.llvm.org/D34909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34909: Driver: consume -nostdinc++ along with -nostdinc

kastiglione created this revision. Using both -nostdinc and -nostdinc++ should not emit diagnostics. https://reviews.llvm.org/D34909 Files: lib/Driver/ToolChains/CrossWindows.cpp test/Driver/windows-cross.c Index: test/Driver/windows-cross.c

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

kastiglione updated this revision to Diff 104750. kastiglione added a comment. fixup a test https://reviews.llvm.org/D34839 Files: lib/Driver/ToolChains/CrossWindows.cpp test/Driver/windows-cross.c Index: test/Driver/windows-cross.c

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

kastiglione created this revision. This changes CrossWindows to look for `-nostdinc` instead of `-nostdlibinc`. In addition, fixes a bug where `-isystem-after` options would be dropped when called with `-nostdinc`. https://reviews.llvm.org/D34839 Files: lib/Driver/ToolChains/CrossWindows.cpp

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

kastiglione added a comment. Thanks @rnk. I don't have commit access; @compnerd, @rnk would either of you mind committing this? Thanks in advance! https://reviews.llvm.org/D34580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

kastiglione updated this revision to Diff 103994. kastiglione added a comment. CHECK load and call https://reviews.llvm.org/D34580 Files: lib/CodeGen/CGDecl.cpp test/CodeGenObjCXX/arc-indirect.mm Index: test/CodeGenObjCXX/arc-indirect.mm

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

kastiglione created this revision. When generating a prolog, add loads for ARC arguments passed indirectly. https://reviews.llvm.org/D34580 Files: lib/CodeGen/CGDecl.cpp test/CodeGenObjCXX/arc-indirect.mm Index: test/CodeGenObjCXX/arc-indirect.mm

[PATCH] D31869: Register isStaticStorageClass matcher

kastiglione added a comment. thanks @aaron.ballman :) https://reviews.llvm.org/D31869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31869: Register isStaticStorageClass matcher

kastiglione added a comment. Thanks! I don't have commit access, so if anyone wants to commit this, that would be great. https://reviews.llvm.org/D31869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31869: Register isStaticStorageClass matcher

kastiglione created this revision. Herald added a subscriber: klimek. I noticed I couldn't `isStaticStorageClass()` from `clang-query`. This change fixed that. https://reviews.llvm.org/D31869 Files: lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added a comment. @aaron.ballman @malcolm.parsons Thanks for the reviews and the commit. I plan to do follow ups for more ObjC ASTMatcher support. https://reviews.llvm.org/D30854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:64 const std::string , const T , bool ExpectMatch, -llvm::StringRef CompileArg, +std::vector Args, const FileContentMappings = FileContentMappings(),

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione updated this revision to Diff 91914. kastiglione added a comment. Use ArrayRef https://reviews.llvm.org/D30854 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersNodeTest.cpp

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:64 const std::string , const T , bool ExpectMatch, -llvm::StringRef CompileArg, +std::vector Args, const FileContentMappings = FileContentMappings(),

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione updated this revision to Diff 91801. kastiglione added a comment. Overload matchesConditionally() for multiple compiler args https://reviews.llvm.org/D30854 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547 + std::string ObjCString = +"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n" +"@protocol Proto " aaron.ballman wrote: > kastiglione wrote: > >

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione updated this revision to Diff 91740. kastiglione added a comment. Use -fobjc-nonfragile-abi https://reviews.llvm.org/D30854 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547 + std::string ObjCString = +"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n" +"@protocol Proto " kastiglione wrote: > aaron.ballman wrote: > >

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1501 - std::string Objc1String = + std::string ObjCString = +"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n" aaron.ballman wrote: > These changes are

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added a comment. Thanks @malcolm.parsons. I don't have commit access, will you be able to commit this? https://reviews.llvm.org/D30854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added a comment. I'd like to add more ObjC specific matcher functionality in follow up diffs. This diff is to to start somewhere, and get feedback. https://reviews.llvm.org/D30854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione created this revision. This adds matchers for `ObjCProtocolDecl`, `ObjCCategoryDecl`, `ObjCMethodDecl`, `ObjCIvarDecl`, and `ObjCPropertyDecl`. These matchers complement the existing matcher for `ObjCInterfaceDecl`. https://reviews.llvm.org/D30854 Files:

[PATCH] D28407: Refer to _LIBCPP_MSVC macro where applicable

kastiglione updated this revision to Diff 83400. kastiglione added a comment. Revert change to Google Benchmark https://reviews.llvm.org/D28407 Files: include/__config include/__undef___deallocate include/__undef_min_max include/ext/hash_map include/ext/hash_set src/exception.cpp

[PATCH] D28407: Refer to _LIBCPP_MSVC macro where applicable

kastiglione created this revision. kastiglione added reviewers: mclow.lists, EricWF, compnerd, smeenai. kastiglione added a subscriber: cfe-commits. Replace preprocess conditions of `defined(_MSC_VER) && !defined(__clang__)` with `defined(_LIBCPP_MSVC)`. No functional change.