Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

On Mon, Feb 28, 2022 at 10:12 AM Reid Kleckner wrote: > I agree, but clearly this person chose a particular style, and I wasn't > trying to revise their code style, just to fix some the Bazel build, which > uses -Werror. > Oh, wow, yeah, this file/corner of the codebase is deep into lambdas,

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

FWIW, I think it's probably simpler/more maintainable to default capture by reference ("[&]") if a lambda doesn't escape its scope (if it's never type erased/put in a std::function or equivalent). Avoids assert/non-assert unused issues, having to maintain/update the list when the code changes and

[clang] 1ea3266 - DebugInfo: Don't simplify template names using _BitInt(N)

Author: David Blaikie Date: 2022-02-15T11:58:40-08:00 New Revision: 1ea326634b582f5574e0b22b85e5b0c631b30dcf URL: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf DIFF: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf.diff

[clang] 26c5cf8 - Fix Windows build that fails if a class has a member with the same naem

Author: David Blaikie Date: 2022-02-10T15:27:31-08:00 New Revision: 26c5cf8fa031f5143fd180fdc8d9dbc26a88e89e URL: https://github.com/llvm/llvm-project/commit/26c5cf8fa031f5143fd180fdc8d9dbc26a88e89e DIFF: https://github.com/llvm/llvm-project/commit/26c5cf8fa031f5143fd180fdc8d9dbc26a88e89e.diff

[clang] 275c562 - Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"

Author: David Blaikie Date: 2022-01-31T17:34:51-08:00 New Revision: 275c56226d7fbd6a4d554807374f78d323aa0c1c URL: https://github.com/llvm/llvm-project/commit/275c56226d7fbd6a4d554807374f78d323aa0c1c DIFF: https://github.com/llvm/llvm-project/commit/275c56226d7fbd6a4d554807374f78d323aa0c1c.diff

[clang] 2771233 - GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

Author: David Blaikie Date: 2022-01-28T11:04:20-08:00 New Revision: 277123376ce08c98b07c154bf83e4092a5d4d3c6 URL: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6 DIFF: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6.diff

[clang] 9c62728 - Default to DWARFv4 on Windows

Author: David Blaikie Date: 2022-01-26T18:01:07-08:00 New Revision: 9c6272861032f511a23784ce0c5cc8f6ac2f625b URL: https://github.com/llvm/llvm-project/commit/9c6272861032f511a23784ce0c5cc8f6ac2f625b DIFF: https://github.com/llvm/llvm-project/commit/9c6272861032f511a23784ce0c5cc8f6ac2f625b.diff

[clang] 87e68ca - Improve relnotes for the DWARFv5 default change

Author: David Blaikie Date: 2022-01-25T09:56:07-08:00 New Revision: 87e68cae50d7ca28975ca6fb456cf0ab2ac915a1 URL: https://github.com/llvm/llvm-project/commit/87e68cae50d7ca28975ca6fb456cf0ab2ac915a1 DIFF: https://github.com/llvm/llvm-project/commit/87e68cae50d7ca28975ca6fb456cf0ab2ac915a1.diff

Re: [clang] d3b26de - Clang: Change the default DWARF version to 5

It also reproduces on Chromium's builders, e.g. >> >> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8824141369391584977/+/u/package_clang/stdout >> >> Filed https://github.com/llvm/llvm-project/issues/53387 >> >> >> On Mon, Jan 24, 2022 at 5:50

Re: [clang] d3b26de - Clang: Change the default DWARF version to 5

t; really sure which ones test this runtime. > > It also reproduces on Chromium's builders, e.g. > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8824141369391584977/+/u/package_clang/stdout > > Filed https://github.com/llvm/llvm-project/issues/53387 > > &

[clang] 90abe18 - Add missing function implementation from DWARF default change

Author: David Blaikie Date: 2022-01-23T21:10:16-08:00 New Revision: 90abe181da7c61d982e4873c97fd12bc06fefe09 URL: https://github.com/llvm/llvm-project/commit/90abe181da7c61d982e4873c97fd12bc06fefe09 DIFF: https://github.com/llvm/llvm-project/commit/90abe181da7c61d982e4873c97fd12bc06fefe09.diff

[clang] d3b26de - Clang: Change the default DWARF version to 5

Author: David Blaikie Date: 2022-01-23T20:49:57-08:00 New Revision: d3b26dea16108c427b19b5480c9edc76edf8f5b4 URL: https://github.com/llvm/llvm-project/commit/d3b26dea16108c427b19b5480c9edc76edf8f5b4 DIFF: https://github.com/llvm/llvm-project/commit/d3b26dea16108c427b19b5480c9edc76edf8f5b4.diff

[clang] baa9b7c - unique_ptrify the ModuleManager's VisitState linked list

Author: David Blaikie Date: 2022-01-19T09:57:46-08:00 New Revision: baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810 URL: https://github.com/llvm/llvm-project/commit/baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810 DIFF: https://github.com/llvm/llvm-project/commit/baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810.diff

[clang] e1e74f6 - -Wmissing-prototypes: Don't warn in named namespaces nested in anonymous namespaces

Author: David Blaikie Date: 2022-01-04T10:08:23-08:00 New Revision: e1e74f6cd6ce41ce8303a5a91f29736808fccc36 URL: https://github.com/llvm/llvm-project/commit/e1e74f6cd6ce41ce8303a5a91f29736808fccc36 DIFF: https://github.com/llvm/llvm-project/commit/e1e74f6cd6ce41ce8303a5a91f29736808fccc36.diff

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

On Wed, Dec 22, 2021 at 11:47 AM Jeremy Morse wrote: > On Wed, Dec 22, 2021 at 4:34 PM David Blaikie via cfe-commits > wrote: > > Is there a way to turn this off now, if it's broken for some user/use > case? I guess using an -mllvm flag, instead of an -Xclang flag? >

Re: [clang] ea22fdd - [Clang][DebugInfo] Cease turning instruction-referencing off by default

Is there a way to turn this off now, if it's broken for some user/use case? I guess using an -mllvm flag, instead of an -Xclang flag? Generally I think for a significant change like this the process would be to add it under a flag, off by default, encourage people to test it by opting in via the

Re: [clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4

Guess this is untestable right now, since it's overriding with the same value? Maybe worth adding an explicit test for the PS4 default - so that the test would fail /if/ the generic (non-PS4) default was changed (which we'll hopefully change in the near future)? On Tue, Nov 30, 2021 at 8:59 AM

[clang] 50fdd7d - Add more test coverage for D77598

Author: David Blaikie Date: 2021-11-14T21:09:11-08:00 New Revision: 50fdd7df827137c8465abafa82a6bae7c87096c5 URL: https://github.com/llvm/llvm-project/commit/50fdd7df827137c8465abafa82a6bae7c87096c5 DIFF: https://github.com/llvm/llvm-project/commit/50fdd7df827137c8465abafa82a6bae7c87096c5.diff

[clang] b2589e3 - ast-print: Avoid extra whitespace before function opening brace

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: b2589e326ba4407d8314938a4f7498086e2203ea URL: https://github.com/llvm/llvm-project/commit/b2589e326ba4407d8314938a4f7498086e2203ea DIFF: https://github.com/llvm/llvm-project/commit/b2589e326ba4407d8314938a4f7498086e2203ea.diff

[clang] 604446a - ast-dump: Add missing identation of class template specializations

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: 604446aa6b41461e2691c9f4253e9ef70a5d68e4 URL: https://github.com/llvm/llvm-project/commit/604446aa6b41461e2691c9f4253e9ef70a5d68e4 DIFF: https://github.com/llvm/llvm-project/commit/604446aa6b41461e2691c9f4253e9ef70a5d68e4.diff

[clang] 400eb59 - Add test for a case in D77598

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: 400eb59adf43b29af3117c163cf770e6d6e514f7 URL: https://github.com/llvm/llvm-project/commit/400eb59adf43b29af3117c163cf770e6d6e514f7 DIFF: https://github.com/llvm/llvm-project/commit/400eb59adf43b29af3117c163cf770e6d6e514f7.diff

[clang] 5de3690 - Follow-up to D77598: Simplify API by passing template parameters only when used/to imply "TemplOverloaded/overloadable"

Author: David Blaikie Date: 2021-11-14T13:35:22-08:00 New Revision: 5de369056dee2c4de81625cb05a5c212a0bdc053 URL: https://github.com/llvm/llvm-project/commit/5de369056dee2c4de81625cb05a5c212a0bdc053 DIFF: https://github.com/llvm/llvm-project/commit/5de369056dee2c4de81625cb05a5c212a0bdc053.diff

[clang] 6512098 - DebugInfo/Printing: Improve name of policy for including types for template arguments

Author: David Blaikie Date: 2021-11-11T21:59:27-08:00 New Revision: 6512098877c3a230bbd38bc81b14a4e5844739ff URL: https://github.com/llvm/llvm-project/commit/6512098877c3a230bbd38bc81b14a4e5844739ff DIFF: https://github.com/llvm/llvm-project/commit/6512098877c3a230bbd38bc81b14a4e5844739ff.diff

[clang] 8bf1244 - DebugInfo: workaround for context-sensitive use of non-type-template-parameter integer suffixes

Author: David Blaikie Date: 2021-11-01T17:08:26-07:00 New Revision: 8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa URL: https://github.com/llvm/llvm-project/commit/8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa DIFF: https://github.com/llvm/llvm-project/commit/8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa.diff

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

Ping On Tue, Sep 21, 2021 at 7:58 PM David Blaikie wrote: > Ping > > On Sun, Sep 5, 2021 at 11:28 AM David Blaikie wrote: > >> Hey Richard - was just going back over some of the modular codegen code >> (due to a discussion on the EWG mailing list about file extensions that >> ended up touching

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

gt;> On Tue, Sep 14, 2021 at 10:04 AM Richard Smith >>>> wrote: >>>> >>>>> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < >>>>> cfe-commits@lists.llvm.org> wrote: >>>>> >>>>>> >>>&g

[clang] 8c13680 - PR18733: Remove -Wweak-template-vtables

Author: David Blaikie Date: 2021-10-21T14:50:20-07:00 New Revision: 8c136805242014b6ad9ff1afcac9d7f4a18bec3f URL: https://github.com/llvm/llvm-project/commit/8c136805242014b6ad9ff1afcac9d7f4a18bec3f DIFF: https://github.com/llvm/llvm-project/commit/8c136805242014b6ad9ff1afcac9d7f4a18bec3f.diff

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Tue, Oct 12, 2021 at 7:35 PM David Blaikie wrote: > On Mon, Oct 11, 2021 at 2:46 PM Richard Smith > wrote: > >> On Wed, 15 Sept 2021 at 13:52, David Blaikie wrote: >> >>> On Tue, Sep 14, 2021 at 10:04 AM Richard Smith >>> wrote: >>> >>&

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Mon, Oct 11, 2021 at 2:46 PM Richard Smith wrote: > On Wed, 15 Sept 2021 at 13:52, David Blaikie wrote: > >> On Tue, Sep 14, 2021 at 10:04 AM Richard Smith >> wrote: >> >>> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < &

[clang] 3909327 - Improve printing of const variable sized arrays

Author: David Blaikie Date: 2021-10-12T19:04:53-07:00 New Revision: 39093279f2ede4af9048b89d048d7fe9182a50f8 URL: https://github.com/llvm/llvm-project/commit/39093279f2ede4af9048b89d048d7fe9182a50f8 DIFF: https://github.com/llvm/llvm-project/commit/39093279f2ede4af9048b89d048d7fe9182a50f8.diff

[clang] f6a561c - DebugInfo: Use clang's preferred names for integer types

Author: David Blaikie Date: 2021-10-06T16:02:34-07:00 New Revision: f6a561c4d6754b13165a49990e8365d819f64c86 URL: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86 DIFF: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86.diff

[clang] 85f612e - DebugInfo: Use sugared function type when emitting function declarations for call sites

Author: David Blaikie Date: 2021-09-28T10:44:35-07:00 New Revision: 85f612efeb352e759f120ee183bf31b1fd7e801a URL: https://github.com/llvm/llvm-project/commit/85f612efeb352e759f120ee183bf31b1fd7e801a DIFF: https://github.com/llvm/llvm-project/commit/85f612efeb352e759f120ee183bf31b1fd7e801a.diff

Re: [clang] 76d845c - [clang-format] Fix unittest failures with -Werror

FWIW, a common way to address this issue is to use the 'unsigned' suffix, as in: EXPECT_EQ(x, 5u); On Thu, Sep 23, 2021 at 4:24 PM Nemanja Ivanovic via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Nemanja Ivanovic > Date: 2021-09-23T18:24:39-05:00 > New Revision:

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

Ping on this On Wed, Sep 15, 2021 at 1:52 PM David Blaikie wrote: > > > On Tue, Sep 14, 2021 at 10:04 AM Richard Smith > wrote: > >> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >

Re: [clang] 38c09ea - DebugInfo: Add (initially no-op) -gsimple-template-names={simple, mangled}

parseable only by llvm-dwarfdump... > > In which case it seems like it should be a -cc1 option not a > > driver option. > Yep, sounds fair - done that in 8ec7d9b8f875368a5f92596332cd05059df6bbd2 > --paulr > > > > > -Original Message- > > > F

[clang] 8ec7d9b - DebugInfo: Move the '=' version of -gsimple-template-names to the frontend

Author: David Blaikie Date: 2021-09-24T11:18:10-07:00 New Revision: 8ec7d9b8f875368a5f92596332cd05059df6bbd2 URL: https://github.com/llvm/llvm-project/commit/8ec7d9b8f875368a5f92596332cd05059df6bbd2 DIFF: https://github.com/llvm/llvm-project/commit/8ec7d9b8f875368a5f92596332cd05059df6bbd2.diff

[clang] 165926a - Fix that same path separator issue again...

Author: David Blaikie Date: 2021-09-23T21:15:01-07:00 New Revision: 165926aa4ce9f05572cf8828210a1af5ce286bdb URL: https://github.com/llvm/llvm-project/commit/165926aa4ce9f05572cf8828210a1af5ce286bdb DIFF: https://github.com/llvm/llvm-project/commit/165926aa4ce9f05572cf8828210a1af5ce286bdb.diff

[clang] 8d9ddd4 - DebugInfo: STN: Handle unreconstitutable types in function types

Author: David Blaikie Date: 2021-09-23T21:13:16-07:00 New Revision: 8d9ddd4f509c54d05a38427d7999c061d88ca35c URL: https://github.com/llvm/llvm-project/commit/8d9ddd4f509c54d05a38427d7999c061d88ca35c DIFF: https://github.com/llvm/llvm-project/commit/8d9ddd4f509c54d05a38427d7999c061d88ca35c.diff

[clang] e70082e - Remove non-portable directory separator from test

Author: David Blaikie Date: 2021-09-23T20:47:19-07:00 New Revision: e70082e9add7e82e580148fbd4c0a5a832763cb6 URL: https://github.com/llvm/llvm-project/commit/e70082e9add7e82e580148fbd4c0a5a832763cb6 DIFF: https://github.com/llvm/llvm-project/commit/e70082e9add7e82e580148fbd4c0a5a832763cb6.diff

[clang] 25ac0d3 - DebugInfo: Implement the -gsimple-template-names functionality

Author: David Blaikie Date: 2021-09-23T19:58:32-07:00 New Revision: 25ac0d3c73d68c017546eb622ba7632c6b581bfb URL: https://github.com/llvm/llvm-project/commit/25ac0d3c73d68c017546eb622ba7632c6b581bfb DIFF: https://github.com/llvm/llvm-project/commit/25ac0d3c73d68c017546eb622ba7632c6b581bfb.diff

[clang] 38c09ea - DebugInfo: Add (initially no-op) -gsimple-template-names={simple,mangled}

Author: David Blaikie Date: 2021-09-22T11:11:49-07:00 New Revision: 38c09ea2d279eabe3602e2002f8cdfcc5380 URL: https://github.com/llvm/llvm-project/commit/38c09ea2d279eabe3602e2002f8cdfcc5380 DIFF: https://github.com/llvm/llvm-project/commit/38c09ea2d279eabe3602e2002f8cdfcc5380.diff

[clang] 2ff049b - DebugInfo: Don't use preferred template names in debug info

Author: David Blaikie Date: 2021-09-21T20:08:16-07:00 New Revision: 2ff049b12ee3fb60581835a28bf9d0acc1723f23 URL: https://github.com/llvm/llvm-project/commit/2ff049b12ee3fb60581835a28bf9d0acc1723f23 DIFF: https://github.com/llvm/llvm-project/commit/2ff049b12ee3fb60581835a28bf9d0acc1723f23.diff

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

Ping On Sun, Sep 5, 2021 at 11:28 AM David Blaikie wrote: > Hey Richard - was just going back over some of the modular codegen code > (due to a discussion on the EWG mailing list about file extensions that > ended up touching on the nature of how modules are built) - and I came > across this

[clang] db6f1e8 - DebugInfo: Don't suppress inline namespaces when printing template template parameter names

Author: David Blaikie Date: 2021-09-21T19:30:13-07:00 New Revision: db6f1e8a8857ccaa339304131373f3150528e812 URL: https://github.com/llvm/llvm-project/commit/db6f1e8a8857ccaa339304131373f3150528e812 DIFF: https://github.com/llvm/llvm-project/commit/db6f1e8a8857ccaa339304131373f3150528e812.diff

[clang] d31dfc3 - DebugInfo: Unify some printing policy adjustments

Author: David Blaikie Date: 2021-09-21T19:30:12-07:00 New Revision: d31dfc30115705332034a81b6b2ab904ca1cf029 URL: https://github.com/llvm/llvm-project/commit/d31dfc30115705332034a81b6b2ab904ca1cf029 DIFF: https://github.com/llvm/llvm-project/commit/d31dfc30115705332034a81b6b2ab904ca1cf029.diff

[clang] 131e878 - Print nullptr_t namespace qualified within std::

Author: David Blaikie Date: 2021-09-21T11:21:40-07:00 New Revision: 131e8786640a49daf533b7ead4d3b5b82e0aea2a URL: https://github.com/llvm/llvm-project/commit/131e8786640a49daf533b7ead4d3b5b82e0aea2a DIFF: https://github.com/llvm/llvm-project/commit/131e8786640a49daf533b7ead4d3b5b82e0aea2a.diff

[clang] 8264846 - Senticify some comments - post-commit review for e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e

Author: David Blaikie Date: 2021-09-15T13:59:11-07:00 New Revision: 8264846c0ef847adeacca9b8fe0f867a8a378c5e URL: https://github.com/llvm/llvm-project/commit/8264846c0ef847adeacca9b8fe0f867a8a378c5e DIFF: https://github.com/llvm/llvm-project/commit/8264846c0ef847adeacca9b8fe0f867a8a378c5e.diff

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Tue, Sep 14, 2021 at 10:04 AM Richard Smith wrote: > On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: David Blaikie >> Date: 2021-09-13T19:17:05-07:00 >> New Revision: 2bd84938470

[clang] 40acc0a - Improve type printing of size-dependent const arrays to normalize array-of-const and const-array

Author: David Blaikie Date: 2021-09-15T13:46:37-07:00 New Revision: 40acc0adad59ac39e9a7a02fcd93161298500c00 URL: https://github.com/llvm/llvm-project/commit/40acc0adad59ac39e9a7a02fcd93161298500c00 DIFF: https://github.com/llvm/llvm-project/commit/40acc0adad59ac39e9a7a02fcd93161298500c00.diff

[clang] 13e34f9 - Fixup some formatting from a recent commit

Author: David Blaikie Date: 2021-09-14T00:41:19-07:00 New Revision: 13e34f9fc13fbe08af69b206eacac2e0008dd126 URL: https://github.com/llvm/llvm-project/commit/13e34f9fc13fbe08af69b206eacac2e0008dd126 DIFF: https://github.com/llvm/llvm-project/commit/13e34f9fc13fbe08af69b206eacac2e0008dd126.diff

[clang] e4b9f5e - DebugInfo: Add support for template parameters with reference qualifiers

Author: David Blaikie Date: 2021-09-14T00:39:47-07:00 New Revision: e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e URL: https://github.com/llvm/llvm-project/commit/e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e DIFF: https://github.com/llvm/llvm-project/commit/e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e.diff

[clang] db4ff98 - DebugInfo: Add support for template parameters with qualifiers

Author: David Blaikie Date: 2021-09-14T00:04:40-07:00 New Revision: db4ff98bf9733605c713e75ab6677523e6d267cb URL: https://github.com/llvm/llvm-project/commit/db4ff98bf9733605c713e75ab6677523e6d267cb DIFF: https://github.com/llvm/llvm-project/commit/db4ff98bf9733605c713e75ab6677523e6d267cb.diff

[clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

Author: David Blaikie Date: 2021-09-13T19:17:05-07:00 New Revision: 2bd84938470bf2e337801faafb8a67710f46429d URL: https://github.com/llvm/llvm-project/commit/2bd84938470bf2e337801faafb8a67710f46429d DIFF: https://github.com/llvm/llvm-project/commit/2bd84938470bf2e337801faafb8a67710f46429d.diff

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

Hey Richard - was just going back over some of the modular codegen code (due to a discussion on the EWG mailing list about file extensions that ended up touching on the nature of how modules are built) - and I came across this code & had the same question I see I wrote up here already but got lost

[clang-tools-extra] 5fb3f43 - Fully qualify template template parameters when printing

Author: David Blaikie Date: 2021-09-02T15:04:34-07:00 New Revision: 5fb3f43778f85ebea48e880eef9493d188253890 URL: https://github.com/llvm/llvm-project/commit/5fb3f43778f85ebea48e880eef9493d188253890 DIFF: https://github.com/llvm/llvm-project/commit/5fb3f43778f85ebea48e880eef9493d188253890.diff

[clang] 4f3a92c - DebugInfo: Refactor/deduplicate various template argument list emission

Author: David Blaikie Date: 2021-08-30T22:39:46-07:00 New Revision: 4f3a92ca0aff115ee17649610c46d8705e550a03 URL: https://github.com/llvm/llvm-project/commit/4f3a92ca0aff115ee17649610c46d8705e550a03 DIFF: https://github.com/llvm/llvm-project/commit/4f3a92ca0aff115ee17649610c46d8705e550a03.diff

[clang] 0e42ec1 - DebugInfo: Correct printing empty template parameter packs

Author: David Blaikie Date: 2021-08-30T10:20:12-07:00 New Revision: 0e42ec1add336e7fbf6cc1f82f663cabe48bf55e URL: https://github.com/llvm/llvm-project/commit/0e42ec1add336e7fbf6cc1f82f663cabe48bf55e DIFF: https://github.com/llvm/llvm-project/commit/0e42ec1add336e7fbf6cc1f82f663cabe48bf55e.diff

[clang] 32b2808 - TypePrinter:printTo remove redundant parameter (IsPack/SkipBrackets)

Author: David Blaikie Date: 2021-08-27T17:12:42-07:00 New Revision: 32b280809f4755177feb8a82fc7a632efa3bf469 URL: https://github.com/llvm/llvm-project/commit/32b280809f4755177feb8a82fc7a632efa3bf469 DIFF: https://github.com/llvm/llvm-project/commit/32b280809f4755177feb8a82fc7a632efa3bf469.diff

Re: [clang] c411c1b - Fix missing qualifier in template type diffing

Perhaps the test case could be stripped down a bit? template class Array {}; template class S {}; template Array Make(); void Call() { Array> v = Make>(); } Seems to exhibit the same issue, by the looks of it. On Mon, Aug 16, 2021 at 6:38 PM via cfe-commits wrote: > > Author:

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Ah, thanks for the details! On Mon, Aug 16, 2021 at 1:26 PM Kostya Kortchinsky wrote: > Apologies. > As explained in another thread, this was a mistake of mine as I reverted 2 > CLs instead of 1 (mine). > This was resolved with the original author. > My own CL ended up breaking some 32-bit

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Please include in the commit message a reason for a revert. On Mon, Aug 16, 2021 at 11:14 AM Kostya Kortchinsky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kostya Kortchinsky > Date: 2021-08-16T11:13:05-07:00 > New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384 > > URL:

[clang] 8322593 - PR51158: Don't emit -Wswitch or -Wcovered-switch-default for empty enums

Author: David Blaikie Date: 2021-07-22T14:51:56-07:00 New Revision: 83225936af317e6bdd7103a8a039c51a29ce9f57 URL: https://github.com/llvm/llvm-project/commit/83225936af317e6bdd7103a8a039c51a29ce9f57 DIFF: https://github.com/llvm/llvm-project/commit/83225936af317e6bdd7103a8a039c51a29ce9f57.diff

[clang-tools-extra] a46c63c - Fix assigned-but-unused (except in an assert) warning with a void cast

Author: David Blaikie Date: 2021-07-21T17:12:22-07:00 New Revision: a46c63c878a9e82ac2646926bb3d8237293ad15d URL: https://github.com/llvm/llvm-project/commit/a46c63c878a9e82ac2646926bb3d8237293ad15d DIFF: https://github.com/llvm/llvm-project/commit/a46c63c878a9e82ac2646926bb3d8237293ad15d.diff

Re: [clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

On Tue, Jul 20, 2021 at 11:52 AM Nikita Popov wrote: > On Tue, Jul 20, 2021 at 8:27 PM David Blaikie wrote: > >> Any chance some of this series of patches could have test coverage >> included? (like small clang test cases that exercise only a narrow part of >> the codegen & works with

Re: [clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

Any chance some of this series of patches could have test coverage included? (like small clang test cases that exercise only a narrow part of the codegen & works with force-opaque-pointers due to these changes?) On Sat, Jul 17, 2021 at 9:48 AM Nikita Popov via cfe-commits <

[clang] dac582a - DebugInfo: Name class templates with default arguments consistently (both direct naming, and as a template argument for a function template)

Author: David Blaikie Date: 2021-07-17T23:58:15-07:00 New Revision: dac582ad3a78b18bdd2e6615f1ec105ee05adfe1 URL: https://github.com/llvm/llvm-project/commit/dac582ad3a78b18bdd2e6615f1ec105ee05adfe1 DIFF: https://github.com/llvm/llvm-project/commit/dac582ad3a78b18bdd2e6615f1ec105ee05adfe1.diff

[clang] 768e3af - PR51034: Debug Info: Remove 'prototyped' from K function declarations

Author: David Blaikie Date: 2021-07-09T12:07:36-07:00 New Revision: 768e3af6345a532d383205049679aaaccca26628 URL: https://github.com/llvm/llvm-project/commit/768e3af6345a532d383205049679aaaccca26628 DIFF: https://github.com/llvm/llvm-project/commit/768e3af6345a532d383205049679aaaccca26628.diff

Re: [clang] 6c9559b - DebugInfo: Mangle K declarations for debug info linkage names

t; -Original Message- > From: cfe-commits On Behalf Of David > Blaikie via cfe-commits > Sent: Tuesday, July 6, 2021 16:28 > To: cfe-commits@lists.llvm.org > Subject: [clang] 6c9559b - DebugInfo: Mangle K declarations for debug > info linkage names > > > Author: Da

[clang-tools-extra] 1def257 - PR51018: Remove explicit conversions from SmallString to StringRef to future-proof against C++23

Author: David Blaikie Date: 2021-07-08T13:37:57-07:00 New Revision: 1def2579e10dd84405465f403e8c31acebff0c97 URL: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97 DIFF: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97.diff

[clang] 1def257 - PR51018: Remove explicit conversions from SmallString to StringRef to future-proof against C++23

Author: David Blaikie Date: 2021-07-08T13:37:57-07:00 New Revision: 1def2579e10dd84405465f403e8c31acebff0c97 URL: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97 DIFF: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97.diff

[clang] 6c9559b - DebugInfo: Mangle K declarations for debug info linkage names

Author: David Blaikie Date: 2021-07-06T16:28:02-07:00 New Revision: 6c9559b67b91966bfeff9e17808a3e84a92e64a0 URL: https://github.com/llvm/llvm-project/commit/6c9559b67b91966bfeff9e17808a3e84a92e64a0 DIFF: https://github.com/llvm/llvm-project/commit/6c9559b67b91966bfeff9e17808a3e84a92e64a0.diff

[clang-tools-extra] 632e15e - Conditionalize function only used in an assert to address -Wunused-function

Author: David Blaikie Date: 2021-06-29T16:39:59-07:00 New Revision: 632e15e766ee625ae367b2e872f3df903e507bfb URL: https://github.com/llvm/llvm-project/commit/632e15e766ee625ae367b2e872f3df903e507bfb DIFF: https://github.com/llvm/llvm-project/commit/632e15e766ee625ae367b2e872f3df903e507bfb.diff

[clang] e1b8fde - Revert "[Clang] Add option to handle behaviour of vector bool/vector pixel."

Author: David Blaikie Date: 2021-06-28T22:57:21-07:00 New Revision: e1b8fde1cbfc031d67d9b316f1b4ac3ab9c8801f URL: https://github.com/llvm/llvm-project/commit/e1b8fde1cbfc031d67d9b316f1b4ac3ab9c8801f DIFF: https://github.com/llvm/llvm-project/commit/e1b8fde1cbfc031d67d9b316f1b4ac3ab9c8801f.diff

Re: [clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

Ah, found it in https://reviews.llvm.org/D104819 - good to leave that in in the "Differential Revision: " part of the commit message (or if you end up splitting patches off from a review, such that it doesn't necessarily make sense for it to close the review (preparatory patches, etc) then linking

Re: [clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

Was this design/code reviewed (there's no mention in the commit message of a link to a phab review, for instance)? Probably worth some discussion - if there was a review, could you link it here in a reply? On Thu, Jun 24, 2021 at 2:23 PM Martin Storsjö via cfe-commits <

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

(ping on this) On Mon, May 10, 2021 at 8:37 AM David Blaikie wrote: > Christopher - had a chance to look into this any further? > > Roman - I'm OK either way on that. I don't think it's the most costly > false positive - not too much code is probably freeing via a reference > (rather than a

[clang] c5d56fe - NFC: .clang-tidy: Inherit configs from parents to improve maintainability

Author: David Blaikie Date: 2021-06-08T08:25:59-07:00 New Revision: c5d56fec502f36a0c994835ca23bc93a6c682d95 URL: https://github.com/llvm/llvm-project/commit/c5d56fec502f36a0c994835ca23bc93a6c682d95 DIFF: https://github.com/llvm/llvm-project/commit/c5d56fec502f36a0c994835ca23bc93a6c682d95.diff

Re: [clang] b89e09a - Silence "Undefined or garbage value returned to caller" static analysis warning. NFCI.

If this is meant to be NFC, I guess the function is never meant to return null? (it's meant to be an invariant of the code that at least one of the builders is valid) - if that's the case, I'm not sure if this is good change. If there is a bug in the future that causes there to be an no valid

[clang-tools-extra] 1746068 - Clangd Matchers.h: Fix -Wdeprecated-copy by making the defaulted copy ctor and deleted copy assignment operators explicit

Author: David Blaikie Date: 2021-05-10T14:31:11-07:00 New Revision: 174606877df46f3e8ce0c60a4c744687d3ee3271 URL: https://github.com/llvm/llvm-project/commit/174606877df46f3e8ce0c60a4c744687d3ee3271 DIFF: https://github.com/llvm/llvm-project/commit/174606877df46f3e8ce0c60a4c744687d3ee3271.diff

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Christopher - had a chance to look into this any further? Roman - I'm OK either way on that. I don't think it's the most costly false positive - not too much code is probably freeing via a reference (rather than a pointer) to allocated memory. On Fri, Apr 30, 2021 at 10:08 AM Roman Lebedev

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Ping on this - have you had a chance to look at this false positive? On Sat, Apr 3, 2021 at 4:29 PM David Blaikie wrote: > > Looks like this has a false positive (that's firing on some mlir code, > committed a workaround in 499571ea835daf786626a0db1e12f890b6cd8f8d ) > like this: > > $ cat

Re: [clang] c965e14 - Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions."

Please include some details about why a patch is being reverted in the patch description - helps with history & triage (if someone's seeing a local failure they'll have an idea whether this patch will address their issue, if someone wants to do the same kind of work in the future they'd know the

[clang] eb8a28e - DebugInfo: Include inline namespaces in template specialization parameter names

Author: David Blaikie Date: 2021-04-08T17:37:55-07:00 New Revision: eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679 URL: https://github.com/llvm/llvm-project/commit/eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679 DIFF: https://github.com/llvm/llvm-project/commit/eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679.diff

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Looks like this has a false positive (that's firing on some mlir code, committed a workaround in 499571ea835daf786626a0db1e12f890b6cd8f8d ) like this: $ cat test.cpp #include void f1(int & x) { free(); } int main() { f1(*(int*)malloc(sizeof(int))); } Could you fix that? (& then revert the

[clang] 2458aa0 - Add missing override to clang tblgen AttrEmitter

Author: David Blaikie Date: 2021-04-02T20:47:49-07:00 New Revision: 2458aa0b9136e7616f529b027d1d478cf699340f URL: https://github.com/llvm/llvm-project/commit/2458aa0b9136e7616f529b027d1d478cf699340f DIFF: https://github.com/llvm/llvm-project/commit/2458aa0b9136e7616f529b027d1d478cf699340f.diff

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

On Thu, Apr 1, 2021 at 1:29 PM Florian Hahn wrote: > > > > On Thu, Apr 1, 2021 at 8:11 PM David Blaikie wrote: >> >> On Thu, Apr 1, 2021 at 1:16 AM Florian Hahn wrote: >> > >> > Hi, >> > >> > On Tue, Mar 30, 2021 at 7:52 PM David Blaikie wrote: >> >> >> >> Is there a more reliable remark that

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

On Thu, Apr 1, 2021 at 1:16 AM Florian Hahn wrote: > > Hi, > > On Tue, Mar 30, 2021 at 7:52 PM David Blaikie wrote: >> >> Is there a more reliable remark that could be tested for? (Clang shouldn't >> be testing all remarks - just that the remark infrastructure in general is >> wired up

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

Is there a more reliable remark that could be tested for? (Clang shouldn't be testing all remarks - just that the remark infrastructure in general is wired up (specific remarks should be tested in llvm) - so picking some really stable remark would be great) maybe there's a remark for "this

Re: [clang] a00d440 - [AST] Hide errors from the attempt to introspect nodes

Is this missing a test case? On Tue, Mar 16, 2021 at 4:47 PM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2021-03-16T23:46:31Z > New Revision: a00d44012820e9ed2eba623dd61ca9cf5a2ce115 > > URL: >

Re: [clang] 5c689e4 - Improve documentation for the [[clang::lifetimebound]] attribute.

On Thu, Mar 18, 2021 at 7:58 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2021-03-18T19:58:21-07:00 > New Revision: 5c689e4bb0473e08645547ddbf9874b5e2fa04d0 > > URL: >

Re: [clang] 774b707 - Revert "Workaround a -Wmisleading-indentation warning"

Would be great to include details of why the patch was reverted - helps folks understand if this patch will address any issues they're seeing, or help avoid someone causing the same problem with a similar patch in the future. On Wed, Mar 10, 2021 at 3:36 PM Stephen Kelly via cfe-commits <

[clang] bd2bdad - void cast to suppress -Wunused-variable in non-asserts build

Author: David Blaikie Date: 2021-03-11T17:51:31-08:00 New Revision: bd2bdad19e5a3bf910da7c2d1936a7e18b47c084 URL: https://github.com/llvm/llvm-project/commit/bd2bdad19e5a3bf910da7c2d1936a7e18b47c084 DIFF: https://github.com/llvm/llvm-project/commit/bd2bdad19e5a3bf910da7c2d1936a7e18b47c084.diff

[clang] cedc532 - Fix clang for header move in LLVM/IR

Author: David Blaikie Date: 2021-03-04T16:20:44-08:00 New Revision: cedc53254a5d2e04e79cc0e7bf5a8c71fafa295e URL: https://github.com/llvm/llvm-project/commit/cedc53254a5d2e04e79cc0e7bf5a8c71fafa295e DIFF: https://github.com/llvm/llvm-project/commit/cedc53254a5d2e04e79cc0e7bf5a8c71fafa295e.diff

[clang] 7c926fe - Improve attribute documentation for nodebug on typedefs

Author: David Blaikie Date: 2021-02-24T16:25:37-08:00 New Revision: 7c926fee930012f9ec19cdaab23b7e154a3845ba URL: https://github.com/llvm/llvm-project/commit/7c926fee930012f9ec19cdaab23b7e154a3845ba DIFF: https://github.com/llvm/llvm-project/commit/7c926fee930012f9ec19cdaab23b7e154a3845ba.diff

Re: [PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

On Wed, Jan 13, 2021 at 6:26 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added a comment. > > In D80391#2497018 , @inglorion > wrote: > > > For Chrome on Chrome OS, this is https://crbug.com/1158215 > > > > Here, we saw our

[clang] 33c8e16 - PR47391: Canonicalize DIFiles

Author: Umesh Kalappa Date: 2021-01-08T22:11:16-08:00 New Revision: 33c8e16f660de9bbe177c1bf821063c146278d8e URL: https://github.com/llvm/llvm-project/commit/33c8e16f660de9bbe177c1bf821063c146278d8e DIFF: https://github.com/llvm/llvm-project/commit/33c8e16f660de9bbe177c1bf821063c146278d8e.diff

Re: [clang] d2ddc69 - Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""

I've reverted this in b12f26733a4259c90e5f387aceb9f23c35e003b8 On Thu, Jan 7, 2021 at 3:04 PM David Blaikie wrote: > > > > On Thu, Jan 7, 2021 at 12:29 AM Artem Dergachev via cfe-commits > wrote: >> >> >> Author: Artem Dergachev >> Date: 2021-01-07T00:28:22-08:00 >> New Revision:

[clang] b12f267 - Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."""

Author: David Blaikie Date: 2021-01-07T18:18:23-08:00 New Revision: b12f26733a4259c90e5f387aceb9f23c35e003b8 URL: https://github.com/llvm/llvm-project/commit/b12f26733a4259c90e5f387aceb9f23c35e003b8 DIFF: https://github.com/llvm/llvm-project/commit/b12f26733a4259c90e5f387aceb9f23c35e003b8.diff

Re: [clang] d2ddc69 - Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""

On Thu, Jan 7, 2021 at 12:29 AM Artem Dergachev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Artem Dergachev > Date: 2021-01-07T00:28:22-08:00 > New Revision: d2ddc694ff94743d9735aaf07edcaf6db8aaca04 > > URL: >

Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

oh, fair - I didn't stop to notice this was over in Clang/non-llvm-namespace'd code, so yeah, sounds good! On Mon, Dec 21, 2020 at 10:49 PM Sam McCall wrote: > Yeah. I don't actually know those details, the phab revision referenced > (should have been a URL, oops) is all I know. > > The new

<    1   2   3   4   5   6   7   8   9   10   >