[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

davidchisnall wrote: Yup, it’s just an optimisation. The runtime does a slightly more complex deduplication pass during loading, this just does a best effort merge so that we don’t end up with hundreds of copies of common selectors as we did with the GCC ABI. If we don’t do it, it isn’t an

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

https://github.com/davidchisnall closed https://github.com/llvm/llvm-project/pull/78030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

https://github.com/davidchisnall updated https://github.com/llvm/llvm-project/pull/78030 >From 008814b0aeee4b1a853fa4544c0dba89252425ce Mon Sep 17 00:00:00 2001 From: David Chisnall Date: Sun, 7 Jan 2024 14:53:48 + Subject: [PATCH] Enable direct methods and fast alloc calls for libobjc2.

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

davidchisnall wrote: Thanks, all review comments should now be resolved. https://github.com/llvm/llvm-project/pull/78030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

https://github.com/davidchisnall updated https://github.com/llvm/llvm-project/pull/78030 >From 02123c6557c7deea3f04f96bce7230f9d45e4ddb Mon Sep 17 00:00:00 2001 From: David Chisnall Date: Sun, 7 Jan 2024 14:53:48 + Subject: [PATCH] Enable direct methods and fast alloc calls for libobjc2.

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

davidchisnall wrote: Formatting issues were introduced by running clang-format15, should now be fixed. https://github.com/llvm/llvm-project/pull/78030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

https://github.com/davidchisnall updated https://github.com/llvm/llvm-project/pull/78030 >From c8d733479ee8d0fd7c75c4a623f8c1bc2f132c61 Mon Sep 17 00:00:00 2001 From: David Chisnall Date: Sun, 7 Jan 2024 14:53:48 + Subject: [PATCH] Enable direct methods and fast alloc calls for libobjc2.

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

https://github.com/davidchisnall created https://github.com/llvm/llvm-project/pull/78030 These will be supported in the upcoming 2.2 release and so are gated on that version. Direct methods call `objc_send_initialize` if they are class methods that may not have called initialize. This is

[clang] [ObjC]: Make type encoding safe in symbol names (PR #77797)

https://github.com/davidchisnall closed https://github.com/llvm/llvm-project/pull/77797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC]: Make type encoding safe in symbol names (PR #77797)

https://github.com/davidchisnall approved this pull request. https://github.com/llvm/llvm-project/pull/77797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC]: Make type encoding safe in symbol names (PR #77797)

@@ -1,5 +1,14 @@ // RUN: %clang_cc1 -triple x86_64-apple-darwin -emit-llvm -o %t %s -// RUN: FileCheck < %t %s +// RUN: FileCheck -check-prefix CHECK-DWARF < %t %s + +// RUN: %clang_cc1 -triple x86_64-w64-windows-gnu -emit-llvm -fobjc-runtime=gnustep-2.0 -o %t %s +// RUN:

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/davidchisnall closed https://github.com/llvm/llvm-project/pull/77255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

davidchisnall wrote: It looks as if three tests are failing in CI: Clang :: CodeGenObjC/2007-04-03-ObjcEH.m Clang :: CodeGenObjC/exceptions-personality.m Clang :: Coverage/codegen-gnu.m https://github.com/llvm/llvm-project/pull/77255 ___

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

davidchisnall wrote: I'd like CI to be green. Hopefully the failure is transient, but I don't seem to be able to kick off a rerun. Maybe once others start passing, you can squash the two commits and force push to restart it? https://github.com/llvm/llvm-project/pull/77255

[clang] Set dllstorage on ObjectiveC ivar offsets (PR #77385)

https://github.com/davidchisnall closed https://github.com/llvm/llvm-project/pull/77385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Set dllstorage on ObjectiveC ivar offsets (PR #77385)

davidchisnall wrote: I didn’t intentional hit close, not sure what happened there. https://github.com/llvm/llvm-project/pull/77385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Set dllstorage on ObjectiveC ivar offsets (PR #77385)

https://github.com/davidchisnall reopened https://github.com/llvm/llvm-project/pull/77385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Set dllstorage on ObjectiveC ivar offsets (PR #77385)

https://github.com/davidchisnall closed https://github.com/llvm/llvm-project/pull/77385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Set dllstorage on ObjectiveC ivar offsets (PR #77385)

https://github.com/davidchisnall approved this pull request. https://github.com/llvm/llvm-project/pull/77385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

@@ -2210,7 +2219,12 @@ CGObjCGNU::CGObjCGNU(CodeGenModule , unsigned runtimeABIVersion, // void objc_exception_throw(id); ExceptionThrowFn.init(, "objc_exception_throw", VoidTy, IdTy); - ExceptionReThrowFn.init(, "objc_exception_throw", VoidTy, IdTy); + if

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

davidchisnall wrote: The failing format CI isn’t in this PR, rebasing to (hopefully) fix it https://github.com/llvm/llvm-project/pull/77255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/davidchisnall updated https://github.com/llvm/llvm-project/pull/77255 >From 6195e6c57b5b461dda2bffec0e5497ceb659f82c Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Thu, 4 Jan 2024 11:10:05 -0800 Subject: [PATCH] Objective C: use C++ exceptions on MinGW+GNUstep The

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

@@ -2210,7 +2219,12 @@ CGObjCGNU::CGObjCGNU(CodeGenModule , unsigned runtimeABIVersion, // void objc_exception_throw(id); ExceptionThrowFn.init(, "objc_exception_throw", VoidTy, IdTy); - ExceptionReThrowFn.init(, "objc_exception_throw", VoidTy, IdTy); + if

[clang] 94c3b16 - Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

Author: David Chisnall Date: 2022-07-24T13:59:45+01:00 New Revision: 94c3b169785c0a0ae650c724dcf2c22ff65f5e24 URL: https://github.com/llvm/llvm-project/commit/94c3b169785c0a0ae650c724dcf2c22ff65f5e24 DIFF:

[clang] d1ed670 - [GNU ObjC] Fix a regression listing methods twice.

Author: David Chisnall Date: 2020-12-01T09:50:18Z New Revision: d1ed67037de6f3f44dc446784f74f0e02adec9b5 URL: https://github.com/llvm/llvm-project/commit/d1ed67037de6f3f44dc446784f74f0e02adec9b5 DIFF: https://github.com/llvm/llvm-project/commit/d1ed67037de6f3f44dc446784f74f0e02adec9b5.diff

[clang] bdd88b7 - Add support for __declspec(guard(nocf))

Author: Andrew Paverd Date: 2020-01-10T16:04:12Z New Revision: bdd88b7ed3956534a0a71b1ea2bc88c69d48f9b7 URL: https://github.com/llvm/llvm-project/commit/bdd88b7ed3956534a0a71b1ea2bc88c69d48f9b7 DIFF: https://github.com/llvm/llvm-project/commit/bdd88b7ed3956534a0a71b1ea2bc88c69d48f9b7.diff

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

Hi, I think the assumption that intrinsics can't read any global is, indeed, the problem here. `@llvm.objc.autoreleasePoolPop` may call any number of `-dealloc` methods with arbitrary side effects (though if they cause resurrection then that's undefined behaviour), so there should be no

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

Hi, Yes, I believe it does still reproduce (at least, with the most recent build that I tried). We worked around the clang bug to make the test pass: https://github.com/gnustep/libobjc2/commit/eab35fce379eb6ab1423dbb6d7908cb782f13458#diff-7f1eea7fdb5c7c3bf21f08d1cfe98a19 Reintroducing the

r357363 - COMDAT-fold block descriptors.

Author: theraven Date: Sun Mar 31 04:22:26 2019 New Revision: 357363 URL: http://llvm.org/viewvc/llvm-project?rev=357363=rev Log: COMDAT-fold block descriptors. Without this change, linking multiple objects containing block descriptors together on Windows will generate duplicate symbol errors.

r357364 - [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

Author: theraven Date: Sun Mar 31 04:22:33 2019 New Revision: 357364 URL: http://llvm.org/viewvc/llvm-project?rev=357364=rev Log: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs. Summary: Based on a patch by Dustin Howett, modified to not change the ABI for ELF platforms. Use more

r357362 - [objc-gnustep] Use .init_array not .ctors when requested.

Author: theraven Date: Sun Mar 31 04:22:19 2019 New Revision: 357362 URL: http://llvm.org/viewvc/llvm-project?rev=357362=rev Log: [objc-gnustep] Use .init_array not .ctors when requested. This doesn't make a difference most of the time but FreeBSD/ARM doesn't run anything in the .ctors array.

r352995 - [objc-gnustep] Fix encoding of ivar size for _Bool.

Author: theraven Date: Sun Feb 3 07:05:52 2019 New Revision: 352995 URL: http://llvm.org/viewvc/llvm-project?rev=352995=rev Log: [objc-gnustep] Fix encoding of ivar size for _Bool. Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp cfe/trunk/test/CodeGenObjC/gnustep2-ivar-offset.m Modified:

r350130 - [objc-gnustep2] Fix a bug in category generation.

Author: theraven Date: Fri Dec 28 09:44:54 2018 New Revision: 350130 URL: http://llvm.org/viewvc/llvm-project?rev=350130=rev Log: [objc-gnustep2] Fix a bug in category generation. We were not emitting a protocol definition while generating the category method list. This was fine in most cases,

r350092 - [objc-gnustep] Fix a copy-and-paste error.

Author: theraven Date: Thu Dec 27 06:44:36 2018 New Revision: 350092 URL: http://llvm.org/viewvc/llvm-project?rev=350092=rev Log: [objc-gnustep] Fix a copy-and-paste error. We were emitting the null class symbol in the wrong section, which meant that programs that contained no Objective-C

r341352 - Revert "Disable the GNUstep v2 ABI on Windows."

Author: theraven Date: Tue Sep 4 03:07:27 2018 New Revision: 341352 URL: http://llvm.org/viewvc/llvm-project?rev=341352=rev Log: Revert "Disable the GNUstep v2 ABI on Windows." This reverts commit b4547c9cadd2f8adfe3f3182e4c56e466c5256cb. Apparently git llvm push from the monorepo does not

r341350 - Disable the GNUstep v2 ABI on Windows.

Author: theraven Date: Tue Sep 4 02:23:18 2018 New Revision: 341350 URL: http://llvm.org/viewvc/llvm-project?rev=341350=rev Log: Disable the GNUstep v2 ABI on Windows. The code remains so that we can potentially reenable it in a point release, but the driver will reject it. Several issues were

r339668 - [gnu-objc] Make selector order deterministic.

Author: theraven Date: Tue Aug 14 03:05:25 2018 New Revision: 339668 URL: http://llvm.org/viewvc/llvm-project?rev=339668=rev Log: [gnu-objc] Make selector order deterministic. Summary: This probably fixes PR35277, though there may be other sources of nondeterminism (this was the only case of

r339667 - Add a stub mangling for ObjC selectors in the Microsoft ABI.

Author: theraven Date: Tue Aug 14 03:04:36 2018 New Revision: 339667 URL: http://llvm.org/viewvc/llvm-project?rev=339667=rev Log: Add a stub mangling for ObjC selectors in the Microsoft ABI. This mangling is used only for outlined SEH finally blocks, which have internal linkage. This fixes the

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

ng Tests (1): > Clang :: CodeGenObjC/gnu-init.m > > Expected Passes: 30627 > Expected Failures : 65 > Unsupported Tests : 12223 > Unexpected Failures: 1 > > Thanks > > Tom Weaver > > On 10 August 2018 at 13:53, David Chisnall via cfe

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

.m > > Expected Passes: 30627 > Expected Failures : 65 > Unsupported Tests : 12223 > Unexpected Failures: 1 > > > Thanks > > Tom Weaver > > On 10 August 2018 at 13:53, David Chisnall via cfe-commits > wrote: > Author: theraven > Date:

r339429 - Fix a deprecated warning in the last commit.

Author: theraven Date: Fri Aug 10 05:53:18 2018 New Revision: 339429 URL: http://llvm.org/viewvc/llvm-project?rev=339429=rev Log: Fix a deprecated warning in the last commit. Done as a separate commit to make it easier to cherry pick the changes to the release branch. Modified:

r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

Author: theraven Date: Fri Aug 10 05:53:13 2018 New Revision: 339428 URL: http://llvm.org/viewvc/llvm-project?rev=339428=rev Log: Add Windows support for the GNUstep Objective-C ABI V2. Summary: Introduces funclet-based unwinding for Objective-C and fixes an issue where global blocks can't have

r339317 - Correctly initialise global blocks on Windows.

Author: theraven Date: Thu Aug 9 01:02:42 2018 New Revision: 339317 URL: http://llvm.org/viewvc/llvm-project?rev=339317=rev Log: Correctly initialise global blocks on Windows. Summary: Windows does not allow globals to be initialised to point to globals in another DLL. Exported globals may be

r339128 - [objc-gnustep] Don't emit .guess ivar offset vars.

Author: theraven Date: Tue Aug 7 05:02:46 2018 New Revision: 339128 URL: http://llvm.org/viewvc/llvm-project?rev=339128=rev Log: [objc-gnustep] Don't emit .guess ivar offset vars. These were intended to allow non-fragile and fragile ABI code to be mixed, as long as the fragile classes were

Re: r332963 - Revert "Revert r332955 "GNUstep Objective-C ABI version 2""

On 23 May 2018, at 08:38, Hans Wennborg <h...@chromium.org> wrote: > > Hi David, > > On Tue, May 22, 2018 at 12:13 PM, David Chisnall via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> Author: theraven >> Date: Tue May 22 03:13:06 2018 >> New

r332964 - [objc-gnustep2] Use isalnum instead of a less efficient and nonportable equivalent.

Author: theraven Date: Tue May 22 03:13:11 2018 New Revision: 332964 URL: http://llvm.org/viewvc/llvm-project?rev=332964=rev Log: [objc-gnustep2] Use isalnum instead of a less efficient and nonportable equivalent. Patch by Hans Wennborg! Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp

r332966 - [objc-gnustep2] Use unsigned char to avoid potential UB in isalnum.

Author: theraven Date: Tue May 22 03:13:17 2018 New Revision: 332966 URL: http://llvm.org/viewvc/llvm-project?rev=332966=rev Log: [objc-gnustep2] Use unsigned char to avoid potential UB in isalnum. Suggested by Gabor Buella. Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp Modified:

r332965 - [objc-gnu] Fix test.

Author: theraven Date: Tue May 22 03:13:14 2018 New Revision: 332965 URL: http://llvm.org/viewvc/llvm-project?rev=332965=rev Log: [objc-gnu] Fix test. The test was implicitly capturing the local filesystem layout. Patch by Hans Wennborg! Modified: cfe/trunk/test/CodeGenObjC/gnu-init.m

r332955 - Add cctype include.

Author: theraven Date: Tue May 22 00:22:50 2018 New Revision: 332955 URL: http://llvm.org/viewvc/llvm-project?rev=332955=rev Log: Add cctype include. This appears to leak in already on libc++ platforms, but is breaking on some other targets. Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp

Re: r329882 - ObjCGNU: Fix empty v3 protocols being emitted two fields short

rom: cfe-commits <cfe-commits-boun...@lists.llvm.org> on behalf of David > Chisnall via cfe-commits <cfe-commits@lists.llvm.org> > Reply-To: David Chisnall <csda...@swan.ac.uk> > Date: Wednesday, April 11, 2018 at 11:49 PM > To: "cfe-commits@lists.llvm.org" <cfe

r329882 - ObjCGNU: Fix empty v3 protocols being emitted two fields short

Author: theraven Date: Wed Apr 11 23:46:15 2018 New Revision: 329882 URL: http://llvm.org/viewvc/llvm-project?rev=329882=rev Log: ObjCGNU: Fix empty v3 protocols being emitted two fields short Summary: Protocols that were being referenced but could not be fully realized were being emitted

[PATCH] D25431: [libcxx] Convert Solaris support library to C++ to fix -std=c++11 build

theraven added a comment. Looks like a much better change to me. https://reviews.llvm.org/D25431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25431: [libcxx] [CMake] Build Solaris compat as separate C lib, to avoid -std= issues

theraven added a comment. It sounds as if the bug here is either that the .c files are being treated as c++, or that we're sticking -std=c++{whatever} in CFLAGS as well as CXXFLAGS. This is probably the bug that should be fixed. https://reviews.llvm.org/D25431

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

theraven added a comment. Looks fine to me, though I wonder if we want to move to the new ABI for FreeBSD11 and use the old one for <=10. http://reviews.llvm.org/D21329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [cfe-dev] RFC: Default language standard mode policy

On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev wrote: > > Yes, those are real problems, but it's not reasonable for us to keep the > default at C++98/03 forever. GCC has already taken the plunge here, so a lot > of open-source code that doesn't work in C++11

Re: [PATCH] D11781: Refactored pthread usage in libcxx

theraven added a comment. In http://reviews.llvm.org/D11781#403335, @rmaprath wrote: > For us (ARM), a threads porting layer is important on several RTOSes (where a > full-blown pthreads implementations is not available). I will see if I can > publish one of those porting layer

Re: [PATCH] D11781: Refactored pthread usage in libcxx

theraven added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ espositofulvio wrote: jroelofs wrote: espositofulvio wrote: jroelofs wrote:

Re: [PATCH] D11781: Refactored pthread usage in libcxx

theraven added inline comments. Comment at: include/__mutex_base:246 @@ -266,3 +245,3 @@ -class _LIBCPP_TYPE_VIS condition_variable +class _LIBCPP_TYPE_VIS condition_variable : private __libcxx_support::condition_variable { espositofulvio wrote: theraven