[PATCH] D112177: [clang] Do not duplicate "EnableSplitLTOUnit" module flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG53adfa8750ea: [clang] Do not duplicate EnableSplitLTOUnit module flag (authored by greened). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112177/new/

[PATCH] D112177: [clang] Do not duplicate "EnableSplitLTOUnit" module flag

greened created this revision. greened added reviewers: noajshu, phosek, eli.friedman, tejohnson. greened added a project: LLVM. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. greened requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2290157 , @greened wrote: > In D83004#2287851 , @dmajor wrote: > >> The expensive-checks bots have been red for several days. Could you please >> take a look or revert? > >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2287851 , @dmajor wrote: > The expensive-checks bots have been red for several days. Could you please > take a look or revert? Working on it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2278681 , @arichardson wrote: > Maybe add another test that checks for the @__cxx_global_var_init() > constructor function? > E.g. something like this: > > int init_func(int arg) { > return arg + 1; > } > >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:274-277 prefixes = p[0] for prefix in prefixes: func_dict.update({prefix: dict()}) +func_order.update({prefix: []}) arichardson wrote: > This should

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2274687 , @jdoerfert wrote: > >> Do you mean a test for recognizing the option in `common.py`? I'm not sure >> what you're asking for here. > > The function is recognized in common.py, right? Can't you run the >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2168427 , @jdoerfert wrote: > Due to D82995 I realized we should have a > test of this in `llvm/test/tools/UpdateTestChecks` as well. Do you mean a test for recognizing the option in

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2250897 , @jdoerfert wrote: > reverse ping? Heh. Getting back to this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened updated this revision to Diff 279932. greened added a comment. Updated to move the option into `common.py`. Also had to rework the output loop to account for differences between python 2 and 3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2134303 , @greened wrote: > > I don't particularly like this mode dichotomy but unifying it would > necessitate updating a whole lot of clang tests. Axtually that's not strictly true, It would just change the

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2129362 , @jdoerfert wrote: > This is great! Just a few days ago I added a TODO in one of the tests I > created asking for this: D82722 :) Glad to help! > Will this work for all test

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened updated this revision to Diff 275831. greened added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed various bugs, added tests. This now has two modes because generated function output can't be ordered with respect to source file functions. When

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

greened added a comment. In D78565#1997372 , @greened wrote: > In D78565#1996297 , @SjoerdMeijer > wrote: > > > Fair enough, perhaps the audience is too small here on llvm.org for this > > and this is too niche.

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

greened added a comment. In D78565#1996297 , @SjoerdMeijer wrote: > Fair enough, perhaps the audience is too small here on llvm.org for this and > this is too niche. In A-profile we have the same problem, so could the > exercise for an A-core here, but

[PATCH] D69088: [Lex] #pragma clang transform

greened added a comment. In D69088#1772141 , @rjmccall wrote: > This is a major new language feature, and code review is probably not the > right venue for reviewing it; there should be a thread on cfe-dev. My > apologies if that's already been

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

greened accepted this revision. greened added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67550/new/ https://reviews.llvm.org/D67550 ___ cfe-commits mailing list

[PATCH] D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics

greened added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67551/new/ https://reviews.llvm.org/D67551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

greened added inline comments. Comment at: lib/Target/AArch64/SVEInstrFormats.td:836 class sve_int_perm_unpk sz16_64, bits<2> opc, string asm, -ZPRRegOp zprty1, ZPRRegOp zprty2> +ZPRRegOp zprty1, ZPRRegOp zprty2, SDPatternOperator

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

greened added inline comments. Comment at: docs/LangRef.rst:3818 +- ``Upl``: One of the low eight SVE predicate registers (P0 to P7) +- ``Upa``: Any of the SVE predicate registers (P0 to P15) What do these names mean? " predicate lower|all?" I see they are

[PATCH] D58548: IR: Support parsing numeric block ids, and emit them in textual output.

greened added a comment. +1. Is there any reason not to use "%4" in the definition? define i32 @f(i32, i32) { %3 = add i32 %0, %1 br label %4 %4: ret i32 %3 } Maybe it creates an ambiguity in the grammar or something. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D53770: Support g++ headers in include/g++

greened added a comment. Oops, I didn't realize this hadn't been formally accepted yet. Still learning the Phab process. Let me know if you want it reverted for a formal accept. Repository: rL LLVM https://reviews.llvm.org/D53770 ___

[PATCH] D53770: Support g++ headers in include/g++

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL346802: [Driver] Support g++ headers in include/g++ (authored by greened, committed by ). Herald added a subscriber:

[PATCH] D53770: Support g++ headers in include/g++

greened updated this revision to Diff 171801. greened edited the summary of this revision. greened added a comment. Explain that Cray packages gcc such that headers are in include/g++. Repository: rC Clang https://reviews.llvm.org/D53770 Files: lib/Driver/ToolChains/Linux.cpp Index:

[PATCH] D53770: Support g++ headers in include/g++

greened added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:927-928 LibDir.str() + "/../include/c++", + // Some gcc installations put headers under "g++" without a + // version suffix. + LibDir.str() + "/../include/g++",

[PATCH] D53770: Support g++ headers in include/g++

greened created this revision. greened added reviewers: danalbert, dlj, atanasyan, phosek. Herald added a subscriber: cfe-commits. Some gcc installations put C++ headers in PREFIX/include/g++ without indicating a gcc version at all. Typically this is because the version is encoded somewhere in

[PATCH] D49244: Always search sysroot for GCC installs

greened closed this revision. greened added a comment. Fixed in r344901. Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping. This is impacting our ability to get clang functioning. Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49244: Always search sysroot for GCC installs

greened updated this revision to Diff 168472. greened added a comment. Updated to implement option 2. I'm not totally happy with passing a StringRef just to check if it's non-empty but opted to reduce the size of the diff rather than refactor a bunch of stuff. Repository: rC Clang

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. I agree that option 2 seems best. It's consistent with options overriding more general configuration/environment variables and more specific options overriding more general options. If it turns out option 1 is needed in the future, it should be a simple change given

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping. It's been well over a month now. What's the best way to get this reviewed? Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

This revision was automatically updated to reflect the committed changes. Closed by commit rC339158: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp) (authored by greened, committed by ). Repository: rC Clang https://reviews.llvm.org/D49897 Files:

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

greened added a comment. In https://reviews.llvm.org/D49897#1189688, @sbc100 wrote: > But in the CL description you say "..when configuring clang to use a > different linker by default". How is this possible?i.e. do you have a > config where these tests are currently failing? Yes, I do.

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

greened added a comment. In https://reviews.llvm.org/D49897#1180338, @sbc100 wrote: > How do you configure clang to use a different linker? It looks like > getDefaultLinker() is hardcoded, but maybe I'm missing something. I pass -fuse-ld in the test RUN lines. Repository: rC Clang

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping... Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49899: Force test/Driver/fuchsia.c(pp) to use lld

This revision was automatically updated to reflect the committed changes. Closed by commit rL339036: Force test/Driver/fuchsia.c(pp) to use lld (authored by greened, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

greened closed this revision. greened added a comment. Committed in 338290. Repository: rC Clang https://reviews.llvm.org/D49898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

greened added a comment. I think I need an accept before this can proceed. Repository: rC Clang https://reviews.llvm.org/D49898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49899: Force test/Driver/fuchsia.c(pp) to use lld

greened added a comment. In https://reviews.llvm.org/D49899#1178545, @ruiu wrote: > > The Fuchsia driver relies on lld so invoke clang with -fuse-ld=lld. This > > gets the test passing when the clang default linker is something other than > > lld. > > Does it work if lld is not installed at

[PATCH] D49899: Make test/Driver/fuchsia.c(pp) work with lld or gold

greened updated this revision to Diff 157689. greened added a comment. The Fuchsia driver relies on lld so invoke clang with -fuse-ld=lld. This gets the test passing when the clang default linker is something other than lld. https://reviews.llvm.org/D49899 Files: test/Driver/fuchsia.c

[PATCH] D49899: Make test/Driver/fuchsia.c(pp) work with lld or gold

greened created this revision. greened added reviewers: phosek, rsmith. Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini. These tests don't appear to depend on lld. They are invoking lto, so we should ensure the linker is capable of that. Therefore, allow gold in addition to lld

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

greened created this revision. greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu. Herald added a subscriber: cfe-commits. This test fails if clang is configure with, for example, gold as the default linker. It does not appear that this test really relies on lld so make the

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

greened created this revision. greened added reviewers: sbc100, sunfish. Herald added subscribers: cfe-commits, aheejin, jgravelle-google, dschuff. lld is the only supported linker that works for WebAssembly, so ensure clang is using it for this test. This gets the tests passing when

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49244: Always search sysroot for GCC installs

greened created this revision. greened added reviewers: rsmith, mcrosier, danalbert. greened added a project: clang. Herald added a subscriber: cfe-commits. Previously, if clang was configured with -DGCC_INSTALL_PREFIX, then it would not search a provided sysroot for a gcc install. This caused

[PATCH] D48487: [X86][AVX512] Lowering _mm512_[max|min]_p[s|d] to native IR

greened added a comment. In https://reviews.llvm.org/D48487#1140703, @RKSimon wrote: > I haven't used the AVX512 versions, but I do know plenty of cases that rely > on the 'use the second op if there is a NAN or both zeros' special cases in > the SSE version of these FMIN/FMAX intrinsics.