Re: r338641 - [AST][4/4] Move the bit-fields from ObjCMethodDecl and ObjCContainerDecl into DeclContext

2018-08-01 Thread David Jones via cfe-commits
(And it was fixed in r338648) On Wed, Aug 1, 2018 at 3:24 PM David Jones wrote: > FYI, this breaks clang: > > .../llvm/tools/clang/lib/AST/DeclObjC.cpp:793:7: error: static_assert > expression is not an integral constant expression > static_cast(ObjCMethodDeclBits.ObjCMethodFamilyBitWidth)

Re: r338641 - [AST][4/4] Move the bit-fields from ObjCMethodDecl and ObjCContainerDecl into DeclContext

2018-08-01 Thread David Jones via cfe-commits
FYI, this breaks clang: .../llvm/tools/clang/lib/AST/DeclObjC.cpp:793:7: error: static_assert expression is not an integral constant expression static_cast(ObjCMethodDeclBits.ObjCMethodFamilyBitWidth) == ^ .../llvm/too

Re: r335084 - Append new attributes to the end of an AttributeList.

2018-06-25 Thread David Jones via cfe-commits
(Sorry for the late reply...) On Mon, Jun 25, 2018 at 2:45 PM Michael Kruse via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I just revert if to have further discussions (r335516) > > Michael > > 2018-06-25 14:58 GMT-05:00 Eric Christopher : > > > > > > On Mon, Jun 25, 2018 at 12:21 PM Rich