[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

DavidTruby added a comment. This looks good to me (minus the issue @tblah mentioned), while this will mean that we also error on gfortran options we don't recognize, I don't personally think that's a problem as in my personal experience Fortran users are used to different compilers accepting

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb81c5070d545: [flang] add -flang-experimental-polymorphism flag to flang-new (authored by DavidTruby). Changed prior to commit:

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

DavidTruby created this revision. DavidTruby added reviewers: tblah, vzakhari, awarzynski. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. DavidTruby requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert,

[PATCH] D143560: clang-format.el: fix warnings

DavidTruby accepted this revision. DavidTruby added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143560: clang-format.el: fix warnings

DavidTruby added a comment. I think the other suggestion from the warning should be applied, as I don't think it _is_ intended that "quote" is matched by either of these. It would actually be odd if it did as you'd have two matches. Comment at:

[PATCH] D136080: [flang] Add -ffp-contract option processing

DavidTruby added a comment. Glad to see this flag being added to `flang-new`! As a note to self I've written some tests that should be updated once this lands that currently don't pass through the `flang-new` driver. Comment at: flang/test/Driver/driver-help.f90:108 !

[PATCH] D129156: Add -fpass-plugin option to Flang

DavidTruby added a comment. This is also causing phabricator's pre-commit CI builds to fail, for example this build for my patch: https://buildkite.com/llvm-project/premerge-checks/builds/115370#0183a8a5-6684-4602-952f-81bde55220ea Could we revert this until it is fixed? I think the CI passing

[PATCH] D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors

This revision was automatically updated to reflect the committed changes. DavidTruby marked an inline comment as done. Closed by commit rG13a784f368ef: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The

[PATCH] D130984: [clang][AArch64][SVE] Add unary +/- operators for SVE types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG286d59ef6f71: [clang][AArch64][SVE] Add unary +/- operators for SVE types (authored by DavidTruby). Changed prior to commit:

[PATCH] D130984: [clang][AArch64][SVE] Add unary +/- operators for SVE types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4f2f7bebd29: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13591-13595 +if (!Target->isVLSTBuiltinType() && !isa(OriginalTarget)) { + if (S.SourceMgr.isInSystemMacro(CC)) +return; + return DiagnoseImpCast(S, E, T, CC,

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13591-13595 +if (!Target->isVLSTBuiltinType() && !isa(OriginalTarget)) { + if (S.SourceMgr.isInSystemMacro(CC)) +return; + return DiagnoseImpCast(S, E, T, CC,

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby updated this revision to Diff 435553. DavidTruby added a comment. Remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126380/new/ https://reviews.llvm.org/D126380 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby updated this revision to Diff 434445. DavidTruby added a comment. Clean up code based on review comments Move additional tests to existing file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126380/new/ https://reviews.llvm.org/D126380

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13582 +// Need the original target type for vector type checks +const Type *OriginalTarget = S.Context.getCanonicalType(T).getTypePtr(); +// Handle conversion from scalable to fixed when

[PATCH] D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10614 + (!RHSType->isVLSTBuiltinType() && !RHSType->isRealType())) { +Diag(Loc, diag::err_typecheck_vector_not_convertable_non_scalar) +<< LHSType << RHSType << LHS.get()->getSourceRange()

[PATCH] D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10609-10614 - if (RHSType->isVLSTBuiltinType() && !LHSType->isVLSTBuiltinType()) { -auto DestType = tryScalableVectorConvert((IsCompAssign ? nullptr : ), -

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby abandoned this revision. DavidTruby added a comment. I've resubmitted this split from the diagnostic changes as D126380 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124860/new/

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added a comment. In D124860#3533878 , @c-rhodes wrote: > can the diagnostics improvements be broke out into separate patches? I think > it would make this easier to review I've split the diagnostic changes from this out as D126377

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added a comment. I think this needs more tests to ensure every diagnostic is being triggered correctly so I will be adding those in another patch, but I wanted to put up the fix for the original issue as soon as possible! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc29d14273b: [clang][AArch64][SVE] Implement conditional operator for SVE vectors (authored by DavidTruby). Changed prior to commit:

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidTruby updated this revision to Diff 425541. DavidTruby added a comment. Fix crash where condition and splatted result don't have the same width Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124091/new/ https://reviews.llvm.org/D124091 Files:

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidTruby updated this revision to Diff 424193. DavidTruby added a comment. Add additional tests for vector splats Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124091/new/ https://reviews.llvm.org/D124091 Files:

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang.

[PATCH] D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rG66c44b20b4a5: [Clang][AArch64][SVE] Add shift operators for SVE vector types (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rG53fd8db79192: [Clang][AArch64][SVE] Allow subscript operator for SVE types (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rG4be1ec9fb5ca: [clang][AArc64][SVE] Add support for comparison operators on SVE types (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

DavidTruby added a comment. > Not sure what you mean by this; LLVM supports extractelement on ` x i1>` vectors. I guess the fact that it's a "vscale x 16" element vector > might not be intuitive? It's a native operation at the LLVM level but not at the ISA level, unlike the data registers.

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

DavidTruby created this revision. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Undefined behaviour is

[PATCH] D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comparison operators on SVE

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG683fc6203cfa: [clang][AArc64][SVE] Implement vector-scalar operators (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby updated this revision to Diff 416889. DavidTruby added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/ https://reviews.llvm.org/D121829 Files: clang/include/clang/Sema/Sema.h

[PATCH] D121119: [clang][SVE] Add support for bitwise operators on SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rGf47e7e4a3480: [clang][SVE] Add support for bitwise operators on SVE types (authored by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D121119?vs=415858=416496#toc Repository: rG LLVM

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby updated this revision to Diff 416487. DavidTruby added a comment. Fix non-valid operation diagnostics Add correct float tests Add negative tests for invalid types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby planned changes to this revision. DavidTruby added a comment. When updating the float tests it seems this is causing some issues with fp16 support, which I am investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby added a comment. In D121829#3386736 , @paulwalker-arm wrote: > It looks like the issue you fixed for the integer tests also need fixing for > the floating point variants. Yeah, this is what you get when you think you're being really smart

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby updated this revision to Diff 415896. DavidTruby added a comment. Fix mistake in unsigned tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/ https://reviews.llvm.org/D121829 Files: clang/include/clang/Sema/Sema.h

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extends the

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rG3aca0ffd5092: [clang][SVE] Add support for arithmetic operators on SVE types (authored by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D120323?vs=413470=414656#toc Repository: rG

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

DavidTruby updated this revision to Diff 413470. DavidTruby added a comment. Add tests for in-place operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120323/new/ https://reviews.llvm.org/D120323 Files: clang/include/clang/AST/Type.h

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

DavidTruby added a comment. In D120323#3341468 , @efriedma wrote: > Is there a corresponding ARM specification update for this? We are planning on updating the specification in future for this but are waiting on some other changes first. What we're

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, tschuett. Herald added a reviewer: efriedma. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements support for the +, -, *, / and %

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5f51fdd650c: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate (authored by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D92751?vs=315788=316181#toc

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 315788. DavidTruby marked an inline comment as done. DavidTruby added a comment. Fix tests to use check-label correctly and add proper precondition on aarch64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby marked 2 inline comments as done. DavidTruby added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5137 + + if (!isHomogeneousAggregateForABI(CXXRD)) +return false; rnk wrote: > Apologies for moving the goalposts, but after

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 315042. DavidTruby added a comment. Refactor based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/CGCXXABI.h

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 314357. DavidTruby added a comment. Switch from CHECK to CHECK-LABEL in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp:493 +struct Empty {}; +// A class with a base is returned in standard registers by MSVC +struct HasEmptyBase : public Empty { rnk wrote: > This comment doesn't

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby marked an inline comment as done. DavidTruby added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5158-5160 // For compatibility with GCC, ignore empty bitfields in C++ mode. if (getContext().getLangOpts().CPlusPlus &&

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 314356. DavidTruby added a comment. Refactor based on review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 311938. DavidTruby added a comment. Add additional callee-side tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/CGCXXABI.cpp

[PATCH] D92751: Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 311906. DavidTruby added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added extra tests for additional conditions and IR -> assembly tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92751: Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby created this revision. Herald added a subscriber: kristof.beyls. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC on WoA64 includes isCXX14Aggregate in its definition. This is de-facto specification on that

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

DavidTruby accepted this revision. DavidTruby added a comment. LGTM and seems to work from the flang side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 ___

[PATCH] D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

DavidTruby accepted this revision. DavidTruby added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86132/new/ https://reviews.llvm.org/D86132

[PATCH] D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

DavidTruby requested changes to this revision. DavidTruby added a comment. This revision now requires changes to proceed. On my clang line, when compiling a C file, this appears as "-cc1" not "cc1". I don't see a cc1as so I can't check that one but I assume it will be the same. Repository:

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

This revision was automatically updated to reflect the committed changes. Closed by commit rG35bee3503f4c: [clang-tidy] prevent generated checks from triggering assertions on anonymous… (authored by bogser01, committed by DavidTruby). Changed prior to commit:

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

DavidTruby accepted this revision. DavidTruby added a comment. This revision is now accepted and ready to land. LGTM - please wait for someone more familiar with clang-tidy to review as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85218/new/

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

DavidTruby accepted this revision. DavidTruby marked an inline comment as done. DavidTruby added a comment. LGTM but wait for someone else to approve Comment at: clang/lib/Driver/Driver.cpp:131 CCLogDiagnostics(false), CCGenDiagnostics(false), -

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

DavidTruby requested changes to this revision. DavidTruby added a comment. This revision now requires changes to proceed. If what I've suggested above doesn't work then the patch lgtm as is Comment at: clang/lib/Driver/Driver.cpp:131 CCLogDiagnostics(false),

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby added a comment. I don't have commit access so can't commit this myself, could you do it for me? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 ___ cfe-commits mailing list

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby updated this revision to Diff 209184. DavidTruby added a comment. Moved common VarLVal initialisation out of the if/else statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby created this revision. DavidTruby added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This adds a zero length array section mapping for each pointer captured by a lambda that is used in a target region, as per section