[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. denis-fatkulin marked 3 inline comments as done. Closed by commit rG04f4c4cc59db: [clangd] Move function body to out-of-line: unnamed class method incorrect… (authored

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

denis-fatkulin marked 3 inline comments as done. denis-fatkulin added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:395 // Bail out in templated classes, as it is hard to spell the class name, i.e // if the template

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

denis-fatkulin updated this revision to Diff 496375. denis-fatkulin added a comment. Review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143638/new/ https://reviews.llvm.org/D143638 Files:

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

denis-fatkulin created this revision. denis-fatkulin added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

denis-fatkulin added a comment. @hokein, could you please also merge my pacth to code base? I haven't such permissions yet. My git user name and address: Denis Fatkulin (fatkulin.de...@huawei.com) Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

denis-fatkulin updated this revision to Diff 452408. denis-fatkulin added a comment. Patch is updated with context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131088/new/ https://reviews.llvm.org/D131088 Files:

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

denis-fatkulin updated this revision to Diff 451624. denis-fatkulin added a comment. Broken tests are deleted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131091/new/ https://reviews.llvm.org/D131091 Files:

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

denis-fatkulin marked an inline comment as done. denis-fatkulin added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1276 (R.Availability == CXAvailability_Available || R.Availability ==

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

denis-fatkulin updated this revision to Diff 450929. denis-fatkulin added a comment. Patch is updatetd according to remarks by @kadircet. @kadircet, could you please also merge my pacth to code base? I haven't such permissions yet. My git user name and address: Denis Fatkulin

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

denis-fatkulin updated this revision to Diff 450111. denis-fatkulin added a comment. clangd unit test fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131091/new/ https://reviews.llvm.org/D131091 Files:

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

denis-fatkulin created this revision. denis-fatkulin added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber:

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

denis-fatkulin created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. FixIt don't switch to arrow in

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin updated this revision to Diff 448396. denis-fatkulin added a comment. Conflict with 'main' branch was solved CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin marked 2 inline comments as done. denis-fatkulin added a comment. They marked done. Thanks! Comment at: clang/unittests/Format/FormatTest.cpp:23555-23556 + FormatStyle Style = getLLVMStyle(); + verifyFormat("[]() -> auto { return Val; }", Style); +

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

denis-fatkulin added a comment. In D130299#3674586 , @HazardyKnusperkeks wrote: > Do you have commit access, or do you want to apply for it, or do you need > someone to push the change(s)? If the latter we need a name and mail for the > commit. I

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin updated this revision to Diff 447116. denis-fatkulin added a comment. Test cases for `auto &` and `auto *` are added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

denis-fatkulin updated this revision to Diff 447115. denis-fatkulin added a comment. Test cases for `auto &` and `auto *` are added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130299/new/ https://reviews.llvm.org/D130299 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin created this revision. denis-fatkulin added reviewers: HazardyKnusperkeks, curdeius. denis-fatkulin added a project: clang-format. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

denis-fatkulin updated this revision to Diff 447052. denis-fatkulin retitled this revision from "[clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists" to "[clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas". denis-fatkulin edited the

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

denis-fatkulin updated this revision to Diff 446916. denis-fatkulin added a comment. > Could you please add full git context? I updated the patch with properly git context. Thanks! > Was the problem due to misannotation of auto? If so, could you add an > annotator test? I'm not sure about the

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

denis-fatkulin created this revision. denis-fatkulin added a reviewer: rsmith. denis-fatkulin added a project: clang-format. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lambdas with trailing