This revision was automatically updated to reflect the committed changes.
Closed by commit rGdaac014fec42: [clang-tidy] Check functions called from catch
blocks (authored by denizevrenci).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
denizevrenci updated this revision to Diff 530296.
denizevrenci added a comment.
Rebase on main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
denizevrenci updated this revision to Diff 529140.
denizevrenci added a comment.
Sort tests out a bit more
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
denizevrenci updated this revision to Diff 529137.
denizevrenci added a comment.
Sort out tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
denizevrenci updated this revision to Diff 529134.
denizevrenci added a comment.
Rebase on main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152330/new/
https://reviews.llvm.org/D152330
Files:
denizevrenci added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136
if constexpr (ThrowInUnhandledException) {
throw 1;
+} else if constexpr (RethrowInUnhandledException) {
+ throw;
}
denizevrenci created this revision.
denizevrenci added reviewers: njames93, PiotrZSL, ChuanqiXu.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
denizevrenci requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber:
denizevrenci added a comment.
Hi @PiotrZSL if you are happy with the changes, could you commit the diff for
me as I don't have commit access to LLVM repo?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
denizevrenci updated this revision to Diff 526438.
denizevrenci added a comment.
- Rebase on trunk
- Remove unused helpers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
denizevrenci added a comment.
Addressed 1 and 3. As for the new methods in StmtCXX.h, I think they may be
used elsewhere too where we need to make a distinction between the visible body
of the coroutine and the desugared version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
denizevrenci updated this revision to Diff 526430.
denizevrenci added a comment.
- Update release notes
- Remove checks for no messages
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
denizevrenci added a comment.
@PiotrZSL & @ChuanqiXu may I request a re-review? I addressed all comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
___
denizevrenci updated this revision to Diff 526359.
denizevrenci added a comment.
Add tests for co_yield and co_await
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
denizevrenci updated this revision to Diff 522829.
denizevrenci added a comment.
Fix commit message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
denizevrenci updated this revision to Diff 522386.
denizevrenci added a comment.
a_shouldNotDiag -> b_shouldNotDiag
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
denizevrenci updated this revision to Diff 522381.
denizevrenci added a comment.
Herald added a project: clang.
Address comments. Implement a special case for coroutines in ExceptionAnalyzer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
denizevrenci added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79
+ // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown
in function 'b_ShouldNotDiag' which should not throw exceptions
+
denizevrenci added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79
+ // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown
in function 'b_ShouldNotDiag' which should not throw exceptions
+
denizevrenci added a comment.
I don't have commit access so after the review is complete, please commit this
diff in my place.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
denizevrenci updated this revision to Diff 510383.
denizevrenci added a comment.
Fix the line number for the warning
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
denizevrenci updated this revision to Diff 510378.
denizevrenci added a comment.
Remove line breaks in CHECK-MESSAGES lines
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
denizevrenci created this revision.
denizevrenci added a reviewer: njames93.
Herald added subscribers: PiotrZSL, carlosgalvezp, ChuanqiXu, xazax.hun.
Herald added a project: All.
denizevrenci requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber:
denizevrenci added a comment.
Author info for the commit: Deniz Evrenci (denizevre...@gmail.com)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144352/new/
https://reviews.llvm.org/D144352
___
denizevrenci added a comment.
@NoQ I don't have commit access. Should I leave landing the diff to you?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144352/new/
https://reviews.llvm.org/D144352
___
denizevrenci updated this revision to Diff 498695.
denizevrenci added a comment.
Added some throws that should be ignored.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144352/new/
https://reviews.llvm.org/D144352
Files:
denizevrenci created this revision.
denizevrenci added reviewers: NoQ, gribozavr.
Herald added a subscriber: ChuanqiXu.
Herald added a project: All.
denizevrenci requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes #48797
All exceptions
26 matches
Mail list logo
