https://github.com/diego-est updated
https://github.com/llvm/llvm-project/pull/84638
>From 114e22388508cd1ef5174bdda041564691b58032 Mon Sep 17 00:00:00 2001
From: Sunglas
Date: Sat, 9 Mar 2024 12:23:43 -0400
Subject: [PATCH 1/4] [analyzer] Turn NodeBuilderContext into a class
---
diego-est wrote:
Seems like it wasn't as easy as just making them private. I think I found all
the places where there were private member accesses. The tests passed on my
side again and the github-pull-requests action. The code_formatter action keeps
failing because of the documentation on
@@ -194,11 +194,12 @@ class CoreEngine {
};
// TODO: Turn into a class.
diego-est wrote:
Done.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/diego-est updated
https://github.com/llvm/llvm-project/pull/84638
>From 114e22388508cd1ef5174bdda041564691b58032 Mon Sep 17 00:00:00 2001
From: Sunglas
Date: Sat, 9 Mar 2024 12:23:43 -0400
Subject: [PATCH 1/3] [analyzer] Turn NodeBuilderContext into a class
---
diego-est wrote:
I added the appropriate functions and moved the class members into private.
Additionally I ran `make check-all` to make sure the now-private members
wouldn't cause any issues with the rest of the codebase, all the checks passed.
https://github.com/llvm/llvm-project/pull/84638
https://github.com/diego-est updated
https://github.com/llvm/llvm-project/pull/84638
>From 114e22388508cd1ef5174bdda041564691b58032 Mon Sep 17 00:00:00 2001
From: Sunglas
Date: Sat, 9 Mar 2024 12:23:43 -0400
Subject: [PATCH 1/2] [analyzer] Turn NodeBuilderContext into a class
---
https://github.com/diego-est created
https://github.com/llvm/llvm-project/pull/84638
>From issue #73088. I changed `NodeBuilderContext` into a class. Additionally,
>there were some other mentions of the former being a struct which I also
>changed into a class. This is my first time working
