[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

sidorovd added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10980 +/// Construct a SPIR-V target extension type for the given OpenCL image type. +static llvm::Type *getSPIRVType(llvm::LLVMContext , StringRef BaseType, +StringRef

[PATCH] D66850: Avoid crash when dumping NULL Type as JSON

sidorovd added a comment. LGTM. I'm not an expert in JSON, but may be it makes sense to move the change a line earlier before creation of pointer representation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850

[PATCH] D59493: [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint))

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added subscribers: cfe-commits, jdoerfert, dmgreen, zzheng. Herald added a project: clang. [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint)) For both

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > sidorovd wrote: > > Anastasia wrote: > > > sidorovd wrote: >

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > sidorovd wrote: > > Anastasia wrote: > > > Can we also test

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > Can we also test that macro `my_ext` is not defined here but

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd updated this revision to Diff 188338. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58666/new/ https://reviews.llvm.org/D58666 Files: lib/Headers/opencl-c.h test/Headers/opencl-c-header.cl test/SemaOpenCL/extension-begin.cl Index: test/SemaOpenCL/extension-begin.cl

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the code: #pragma OPENCL EXTENSION cl_intel_planar_yuv : begin // some declarations #pragma OPENCL EXTENSION cl_intel_planar_yuv :

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd updated this revision to Diff 176085. sidorovd marked an inline comment as done. sidorovd added a comment. Removed redundant lines in a comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54947/new/ https://reviews.llvm.org/D54947 Files: lib/CodeGen/CGCall.cpp

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3972 + // we don't want to perform address space cast for it, since that + // leads to casting __private * (default addr space in OpenCL) to + // __global * which is not valid. Create

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd updated this revision to Diff 175722. sidorovd marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54947/new/ https://reviews.llvm.org/D54947 Files: lib/CodeGen/CGCall.cpp test/CodeGenOpenCL/addr-space-struct-arg.cl Index:

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd added a comment. @yaxunl, since I'm partially reverting your change https://reviews.llvm.org/D34367 can you give a feedback on this? Comment at: lib/CodeGen/CGCall.cpp:3972 + // we don't want to perform address space cast for it, since that + //

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd created this revision. sidorovd added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. If a function argument is byval and RV is located in default or alloca address space an optimization of creating addrspacecast instead of memcpy is performed. That is not correct

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd added a comment. @Anastasia @yaxunl Hi, I am working on generalizing this patch and several questions have raised during this, so I want to discuss them with you: 1. Should #pragma OPENCL EXTENSION ext_name : begin enables the extension as well? For now I see it's not, as an example:

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd added a comment. Ping https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd updated this revision to Diff 169188. sidorovd added a comment. - Forgot to add clarification comments on conditional branching. Added. https://reviews.llvm.org/D51402 Files: Headers/opencl-c-header.cl Headers/opencl-c.h Index: Headers/opencl-c-header.cl

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd updated this revision to Diff 169187. sidorovd added a comment. Moved the test to test/Headers/opencl-c-header.cl https://reviews.llvm.org/D51402 Files: Headers/opencl-c-header.cl Headers/opencl-c.h Index: Headers/opencl-c-header.cl

[PATCH] D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h

sidorovd added a comment. In https://reviews.llvm.org/D52658#1252744, @Anastasia wrote: > Does it mean we should close https://reviews.llvm.org/D32896? Yes In https://reviews.llvm.org/D52658#1252744, @Anastasia wrote: > Would it make sense to keep this value as Clang implementation and if

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd added a comment. @Anastasia , since there is a problem I described, wouldn't you mind if I stay with the first iteration of the patch (adding the extension to OpenCLExtensions.def) and after we'll investigate what is wrong with -cl-ext approach? https://reviews.llvm.org/D51402

[PATCH] D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from the common header

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. PIPE_RESERVE_ID_VALID_BIT is implementation defined, so lets not keep it in the header. Previously the topic was discussed here: https://reviews.llvm.org/D32896 Repository:

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd added inline comments. Comment at: lib/Headers/opencl-c.h:26 +#if __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#ifndef cl_intel_planar_yuv +#define cl_intel_planar_yuv Anastasia wrote: > Anastasia wrote: > > @yaxunl, do you think we need to add some kind of

[PATCH] D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates

sidorovd updated this revision to Diff 166425. sidorovd added a comment. getOpenCLExtensionsFromTypeExtMap was added https://reviews.llvm.org/D52292 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/Sema.cpp lib/Sema/SemaOverload.cpp

[PATCH] D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates

sidorovd added inline comments. Comment at: include/clang/Sema/Sema.h:8576 + + /// Find and extension in an extension map and return its name + template Anastasia wrote: > and extension -> an extension ? Thanks! Comment at:

[PATCH] D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates

sidorovd updated this revision to Diff 166270. sidorovd marked an inline comment as done. https://reviews.llvm.org/D52292 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/Sema.cpp lib/Sema/SemaOverload.cpp test/SemaOpenCL/extension-begin.cl Index:

[PATCH] D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. Allowed extension name (that ought to be disabled) printing in the note message. This diagnostic was proposed here: https://reviews.llvm.org/D51341 Repository: rC Clang

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd added a comment. For now this patch is on hold since it adds no new functionality. Its future will be decided after @asavonic finished https://reviews.llvm.org/D51544 https://reviews.llvm.org/D51341 ___ cfe-commits mailing list

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

sidorovd updated this revision to Diff 164214. sidorovd added a comment. Reference to the Spec was added https://reviews.llvm.org/D51722 Files: lib/Sema/SemaExpr.cpp test/SemaOpenCL/block-array-capturing.cl Index: test/SemaOpenCL/block-array-capturing.cl

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd updated this revision to Diff 164169. sidorovd edited the summary of this revision. https://reviews.llvm.org/D51341 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/Sema/SemaOverload.cpp test/SemaOpenCL/half-double-overload.cl Index: test/SemaOpenCL/half-double-overload.cl

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6063 + // OpenCL: A candidate function that uses extentions that are not enabled or + // supported is not viable. + if (getLangOpts().OpenCL) {

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. sidorovd added a comment. Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I wasn't able to update it, so I created a new one with the comments applied.

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

sidorovd added a comment. Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I wasn't able to update it, so I created a new one with the comments applied. Repository: rC Clang https://reviews.llvm.org/D51722 ___

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd updated this revision to Diff 164157. sidorovd added a comment. I'm not sure if I put pragmas in an appropriate place (I mean in the very beginning of the header). https://reviews.llvm.org/D51402 Files: lib/Headers/opencl-c.h test/SemaOpenCL/extension-version.cl Index:

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd created this revision. sidorovd added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. Just adding a preprocessor #define for the extension. Patch by Alexey Sotkin Repository: rC Clang https://reviews.llvm.org/D51402 Files:

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd updated this revision to Diff 162812. https://reviews.llvm.org/D51341 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/Sema/SemaOverload.cpp test/SemaOpenCL/half-double-overload.cl Index: test/SemaOpenCL/half-double-overload.cl

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd created this revision. sidorovd added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. Overloadable function candidate should not be viable if it uses extensions (Half or Double type) that are not enabled or supported. Repository: rC Clang