hintonda created this revision.
hintonda added reviewers: majnemer, rsmith.
hintonda added a subscriber: cfe-commits.
Added checks to make sure the return type and parameter types for functions
declared as extern "C" have external linkage.
http://reviews.llvm.org/D17362
Files:
include/clang/Ba
hintonda added a comment.
Ping,..
Could someone commit this for me?
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7848
@@ -7842,2 +7847,3 @@
+ }
}
}
Got it...
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lis
hintonda updated this revision to Diff 48031.
hintonda added a comment.
- Added assert and additional test
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
rjmccall wrote:
> Could you add an assertion here that NonTemplateMatch is still null? That
> sh
hintonda added a comment.
Btw, I don't have commit access, so if accepted, could you please commit for me.
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
hintonda updated this revision to Diff 47999.
hintonda added a comment.
- Renamed variables to make code self-documenting
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
=
hintonda created this revision.
hintonda added a reviewer: majnemer.
hintonda added a subscriber: cfe-commits.
Sema allows max values up to 2**28, use unsigned instead of unsiged
short to hold values that large.
http://reviews.llvm.org/D17248
Files:
lib/CodeGen/CGValue.h
test/Sema/attr-align
hintonda updated this revision to Diff 47923.
hintonda added a comment.
- Only call HandleMemberFunctionDeclDelays() for valid NamedDecl pointers.
HandleMemberFunctionDeclDelays() adds LateParsedMethodDeclaration elements to
LateParsedDeclarations if the method has default args or
exception-s
hintonda updated this revision to Diff 47914.
hintonda added a comment.
- Simplify diff
http://reviews.llvm.org/D17143
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/pr25156-crash-on-invalid.cpp
Index: test/SemaCXX/pr25156-crash-on-invalid.cpp
hintonda created this revision.
hintonda added reviewers: lvoufo, rjmccall.
hintonda added a subscriber: cfe-commits.
Fix PR14211
Only add FunctionDecl's that are actual template methods to the set of
matches passed to getMostSpecializied() -- otherwise it will
assert/crash. If a match to a non-
hintonda added a comment.
Thanks Marshall.
Btw, I don't have commit access, so if approved, could someone commit this for
me?
http://reviews.llvm.org/D16946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
hintonda created this revision.
hintonda added reviewers: doug.gregor, majnemer.
hintonda added a subscriber: cfe-commits.
Fix crash from PR25156 where getDestructorName() calls LookupQualifiedName() on
incomplete type.
http://reviews.llvm.org/D17143
Files:
lib/Sema/SemaExprCXX.cpp
test/Sem
hintonda added a comment.
I don't have commit access, so if this patch is accepted, could someone please
commit it for me?
http://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hintonda added a comment.
I don't have commit access, so if this patch is accepted, could someone please
commit it for me?
http://reviews.llvm.org/D17072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hintonda updated this revision to Diff 47501.
hintonda added a comment.
- Added test for PR25181
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
test/SemaCXX/pr25181-crash-on-invalid.cpp
Index: test/SemaCXX/pr25181-crash-on-invalid.cpp
hintonda updated this revision to Diff 47499.
hintonda added a comment.
- Added test for PR26077
http://reviews.llvm.org/D16971
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr26077-crash-on-invalid.cpp
Index: test/SemaCXX/pr26077-crash-on-invalid.cpp
==
hintonda updated this revision to Diff 47456.
hintonda added a comment.
- Reformatted change with clang-format
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index: lib/Parse/ParseCXXInlineMethods.cpp
hintonda created this revision.
hintonda added reviewers: doug.gregor, rnk.
hintonda added a subscriber: cfe-commits.
Fixes crash referenced in PR25181 where dyn_cast is called on a null instance
of LM.Method.
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index: l
hintonda added a comment.
This patch fixes bug 26077.
https://llvm.org/bugs/show_bug.cgi?id=26077
http://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Great, thanks. Btw, I don't have commit access, so could you commit for me?
thanks don
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
hintonda added a comment.
ping
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Here's a snippet of code that will crash:
lass DB {};
template class RemovePolicy : public T {};
template >
class Crash : T, Policy {};
template
class Crash : public DB, public Policy {
public:
Crash(){}
};
http://reviews.llvm.org/D16971
hintonda created this revision.
hintonda added reviewers: doug.gregor, lvoufo.
hintonda added a subscriber: cfe-commits.
The code sets isPartialSpecialization = false instead of returning true, which
will cause a crash later when the missing template parameter is referenced.
http://reviews.llvm.
hintonda created this revision.
hintonda added reviewers: beanz, mclow.lists.
hintonda added a subscriber: cfe-commits.
A common error for new users it to checkout subprojects, like clang or
clang-tools-extra, into the wrong subdirectory. This change helps prevent
this, since the resulting buil
hintonda created this revision.
hintonda added a reviewer: mclow.lists.
hintonda added a subscriber: cfe-commits.
http://reviews.llvm.org/D16946
Files:
www/get_started.html
Index: www/get_started.html
===
--- www/get_started.html
hintonda added a comment.
Ah, great. That is simpler.
http://reviews.llvm.org/D16158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Sorry the previous change caused this configuration to break. However, I'm not
sure about adding LLVMExports here. Shouldn't that be handled in
llvm/CMakeLists.txt?
In fact, this looks like a cmake bug (or feature) that won't let you export a
target that depends on
hintonda created this revision.
hintonda added a reviewer: chapuni.
hintonda added a subscriber: cfe-commits.
ClangConfig requires LLVMConfig, so add find_package call in ClangConfig so
find_package(clang REQUIRED CONFIG) will just work. This makes it easier for
cmake based projects to use clan
hintonda added a comment.
Btw, I don't have commit access, so if you are happy with this change, could
you commit it for me?
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
hintonda updated this revision to Diff 36916.
hintonda added a comment.
Add support for cmake version 3, i.e., 3.0.0...
http://reviews.llvm.org/D13453
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeL
hintonda updated this revision to Diff 36889.
hintonda added a comment.
- add back check for standalone and add cmake version
http://reviews.llvm.org/D13453
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++
hintonda added a comment.
Installed cmake 2.8.12 and was able to reproduce error.
I'll look into it, but I'm tempted to only support newer versions of cmake, and
let older versions maintain current behavior.
http://reviews.llvm.org/D13453
___
cfe-
hintonda created this revision.
hintonda added a reviewer: chapuni.
hintonda added a subscriber: cfe-commits.
Always generate and install cmake config files.
Currently, cmake config files are only generated and installed when
CLANG_BUILD_STANDALONE set, which means config file will not be genera
hintonda added a comment.
Mainly aesthetic. It was the only one of the group, -Xassembler, -Xlinker,
-Xpreprocessor, and -Xclang, that didn't have a corresponding comma separated
option, so I figured it might be a good addition.
http://reviews.llvm.org/D13229
__
hintonda added a comment.
Here are a few examples from existing tests showing how this option could be
used:
-Xclang -analyzer-max-loop -Xclang 34
becomes:
-Wc,-analyzer-max-loop,34
-Xclang -analyzer-checker=debug.ConfigDumper -Xclang -analyzer-max-loop
-Xclang 34
becomes:
-Wc,-a
n Mon, Sep 28, 2015 at 09:54:53PM +, don hinton via cfe-commits wrote:
> > Add -Wc, option (similar to -Wl,) to go along with -Xclang.
> > This makes it easier to pass multiple options to cc1.
>
> How is this better than -mllvm and -Xclang? There is no precendence case
>
hintonda created this revision.
hintonda added a subscriber: cfe-commits.
Add -Wc, option (similar to -Wl,) to go along with -Xclang. This
makes it easier to pass multiple options to cc1.
http://reviews.llvm.org/D13229
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
Index: lib
hintonda added a comment.
Yes, please. thanks...
http://reviews.llvm.org/D12967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
hintonda added a reviewer: alexfh.
hintonda added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Fix example comments.
http://reviews.llvm.org/D12967
Files:
include/clang/Tooling/CommonOptionsParser.h
Index: include/clang/Tooling/CommonOptionsPar
hintonda added a comment.
Looks like Manuel cleaned it up along with another change on the 8th, r247018.
thanks again...
http://reviews.llvm.org/D12549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
hintonda added a comment.
I don't have commit access, so could you commit it for me?
thanks...
don
http://reviews.llvm.org/D12549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
In http://reviews.llvm.org/D12646#241493, @bob.wilson wrote:
> On Darwin platforms, the libc++ headers are expected to be installed
> alongside clang. If you're not doing that, then you're building it wrong.
> Adding more fallback options for finding the headers just m
hintonda added a comment.
> I think it works if you a) check out libcxx into llvm/projects/libcxx b) run
> `make install` and c) run the binary from your install directory.
Yes, that works. But why shouldn't users be able to use the installed version?
Also, if you want to force users to eithe
hintonda added a comment.
In http://reviews.llvm.org/D12646#241308, @kubabrecka wrote:
> In what scenario exactly are you seeing an issue? If it's a just-built clang
> that can't find C++ headers, then you should just build the libcxx project
> alongside.
clang++ defaults to -stdlib=libc++ f
Not sure why arc removed some reviewers when I added the latest diff, but
I've added them back.
Sorry for the noise...
On Mon, Sep 7, 2015 at 8:36 PM, don hinton wrote:
> hintonda updated this revision to Diff 34175.
> hintonda removed reviewers: thakis, EricWF, kubabrecka.
> hintonda added a c
hintonda updated this revision to Diff 34175.
hintonda removed reviewers: thakis, EricWF, kubabrecka.
hintonda added a comment.
Removed redundant code from InitHeaderSearch.cpp, it's handled more cleanly in
AddClangCXXStdlibIncludeArgs.
Also, newer versions of OSX add libc++ as the default. Per
hintonda created this revision.
hintonda added a reviewer: rsmith.
hintonda added a subscriber: cfe-commits.
Current behavior doesn't add c++ header path if libc++ wasn't installed via
macports in /usr. This change will try to locate c++ headers from various
locations, including in tree, via ma
gcc has -Wstrict-prototypes which will catch this, but clang doesn't
implement it.
however, both gcc and clang have -Wmissing-prototypes which should catch
these if users enable it.
On Sun, Aug 30, 2015 at 5:32 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Sun, Aug
201 - 249 of 249 matches
Mail list logo
