[clang] [Sema] Mark alias/ifunc targets used and consider mangled names (PR #87130)

emaste wrote: Giving this extra scrutiny is certainly warranted given the context, but #63957 is a legitimate bug. https://github.com/llvm/llvm-project/pull/87130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sema] Mark alias/ifunc targets used and consider mangled names (PR #87130)

@@ -0,0 +1,47 @@ +// RUN: %clang_cc1 -triple %itanium_abi_triple -Wunused -x c -verify %s emaste wrote: Git does not track file moves explicitly. You'll find that `git log --follow` will work equally well whether you use `git add` and `git rm` or `git mv`. It

[libcxx] [libunwind] [DRAFT][libc++] Switch FreeBSD to C++26 (PR #86658)

emaste wrote: > The C++26 job is part of the first jobs that get run' Oops, I did miss that. I think this would be the only buildkite job using `generic-cxx26` https://github.com/llvm/llvm-project/pull/86658 ___ cfe-commits mailing list

[libcxx] [libunwind] [DRAFT][libc++] Switch FreeBSD to C++26 (PR #86658)

@@ -39,6 +39,9 @@ # if defined(__HAIKU__) # define _LIBUNWIND_TARGET_HAIKU 1 # endif +#if defined(__FreeBSD__) emaste wrote: Yes, libunwind change was included by accident - I just let the CI jobs finish rather than restarting; I will update the pull req to

[libcxx] [libunwind] [DRAFT][libc++] Switch FreeBSD to C++26 (PR #86658)

https://github.com/emaste created https://github.com/llvm/llvm-project/pull/86658 As discussed in #86320; opening this PR for CI. It looks like (prior to this change) there are no C++26 jobs right now. >From 6cf1345feee41ec3bad51ba853091e35723c85ab Mon Sep 17 00:00:00 2001 From: Dmitry Chagin

[clang] [Driver] Remove support for FreeBSD 11.x (PR #73392)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/73392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove support for FreeBSD 11.x (PR #73392)

emaste wrote: I think this is OK; someone who really needs to target past-EOL FreeBSD with contemporary Clang could pass explicit flags to set the DWARF version etc. But let me ping @DimitryAndric for comment as well. https://github.com/llvm/llvm-project/pull/73392

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 emaste wrote: Maybe worth noting that in the commit message too but either

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/emaste edited https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/emaste commented: overall looks fine, no objection from FreeBSD. one open question. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 emaste wrote: why is this part here (before sparc64 is removed from

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -163,9 +163,9 @@ // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-mfpu=softvfp" // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-matpcs" -// RUN: %clang --target=sparc-unknown-freebsd -### %s -fpic -no-integrated-as 2>&1 \ -// RUN: | FileCheck --check-prefix=CHECK-SPARC-PIE %s -//

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -247,12 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple , switch (os) { case llvm::Triple::Linux: return std::make_unique>(Triple, Opts); -case llvm::Triple::FreeBSD: emaste wrote: OK - there are no supported FreeBSD releases

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/68011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

emaste wrote: > It handles both cases. It simply claims all the -stdlib= arguments. If I understand correctly this means in effect `-stdlib=` becomes a don't-care when linking C, and anyhow it already had no effect. https://github.com/llvm/llvm-project/pull/68011

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

emaste wrote: Yeah, I don't see any reason there'd be a problem with this. It seems a bit silly for build systems to pass this in, but if they do there's no value in reporting it. https://github.com/llvm/llvm-project/pull/68011 ___ cfe-commits

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/68011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove FreeBSD/riscv32 support (PR #67277)

https://github.com/emaste approved this pull request. Sure; we're generally moving away from supporting any 32-bit platforms so it is exceedingly unlikely that we would add riscv32 support. https://github.com/llvm/llvm-project/pull/67277 ___

[clang] b41bb6c - [Driver] Default to contemporary FreeBSD profiling behaviour

Author: Ed Maste Date: 2021-12-15T09:05:35-05:00 New Revision: b41bb6c1b715da77025962f736740c78128c78e1 URL: https://github.com/llvm/llvm-project/commit/b41bb6c1b715da77025962f736740c78128c78e1 DIFF: https://github.com/llvm/llvm-project/commit/b41bb6c1b715da77025962f736740c78128c78e1.diff

[clang] 2dec2aa - [Driver] Default to libc++ on FreeBSD

Author: Jan Beich Date: 2021-11-22T16:47:03-05:00 New Revision: 2dec2aa3ad083dbde838809f0e8c7ae31110e111 URL: https://github.com/llvm/llvm-project/commit/2dec2aa3ad083dbde838809f0e8c7ae31110e111 DIFF: https://github.com/llvm/llvm-project/commit/2dec2aa3ad083dbde838809f0e8c7ae31110e111.diff

[clang] a40dcd0 - [Driver] correct typo in FreeBSD 14 test

Author: Ed Maste Date: 2021-11-22T14:37:27-05:00 New Revision: a40dcd060e9d374d68df53b881d62e4de2bc310a URL: https://github.com/llvm/llvm-project/commit/a40dcd060e9d374d68df53b881d62e4de2bc310a DIFF: https://github.com/llvm/llvm-project/commit/a40dcd060e9d374d68df53b881d62e4de2bc310a.diff

[clang] 6609892 - [clang] allow -fstack-clash-protection on FreeBSD

Author: Ed Maste Date: 2021-08-24T21:02:36-04:00 New Revision: 6609892a2dcdd1a4f6adefe191b55524861f020c URL: https://github.com/llvm/llvm-project/commit/6609892a2dcdd1a4f6adefe191b55524861f020c DIFF: https://github.com/llvm/llvm-project/commit/6609892a2dcdd1a4f6adefe191b55524861f020c.diff

[clang] 699d474 - [Driver] do not link _p libs for -pg on FreeBSD 14 and later

Author: Ed Maste Date: 2021-06-26T17:47:54-04:00 New Revision: 699d47472c3f7c5799fe75486689545179cfba03 URL: https://github.com/llvm/llvm-project/commit/699d47472c3f7c5799fe75486689545179cfba03 DIFF: https://github.com/llvm/llvm-project/commit/699d47472c3f7c5799fe75486689545179cfba03.diff

[clang] 462cf39 - [Driver] Fix -gz=zlib options for linker also on FreeBSD

Author: Ed Maste Date: 2021-03-02T08:44:24-05:00 New Revision: 462cf39a5c180621b56f7602270ce33eb7b68d23 URL: https://github.com/llvm/llvm-project/commit/462cf39a5c180621b56f7602270ce33eb7b68d23 DIFF: https://github.com/llvm/llvm-project/commit/462cf39a5c180621b56f7602270ce33eb7b68d23.diff

[clang] cb17614 - clang: enable unwind tables on FreeBSD !amd64

Author: Ed Maste Date: 2019-11-15T10:37:45-05:00 New Revision: cb1761465a0d4c904f4fca489afe97478382b553 URL: https://github.com/llvm/llvm-project/commit/cb1761465a0d4c904f4fca489afe97478382b553 DIFF: https://github.com/llvm/llvm-project/commit/cb1761465a0d4c904f4fca489afe97478382b553.diff

r370779 - clang: default to DWARF 4 for FreeBSD 12.0 and later

Author: emaste Date: Tue Sep 3 09:30:21 2019 New Revision: 370779 URL: http://llvm.org/viewvc/llvm-project?rev=370779=rev Log: clang: default to DWARF 4 for FreeBSD 12.0 and later Older FreeBSD versions included GDB 6.1 and had other tools that were unable to handle debug information newer than

r344100 - clang: Allow ifunc resolvers to accept arguments

Author: emaste Date: Tue Oct 9 17:34:17 2018 New Revision: 344100 URL: http://llvm.org/viewvc/llvm-project?rev=344100=rev Log: clang: Allow ifunc resolvers to accept arguments When ifunc support was added to Clang (r265917) it did not allow resolvers to take function arguments. This was based

r343408 - Update ifunc attribute support documentation

Author: emaste Date: Sun Sep 30 08:08:18 2018 New Revision: 343408 URL: http://llvm.org/viewvc/llvm-project?rev=343408=rev Log: Update ifunc attribute support documentation Previously we documented GNU binutils and glibc versions required for ifunc support, but our own lld linker and FreeBSD's

[libunwind] r315814 - libunwind: document tested FreeBSD configs and sort OS list

Author: emaste Date: Sat Oct 14 10:04:04 2017 New Revision: 315814 URL: http://llvm.org/viewvc/llvm-project?rev=315814=rev Log: libunwind: document tested FreeBSD configs and sort OS list libunwind is known to work on FreeBSD i386, amd64 (x86_64) and arm64. It is the unwinder provided by the

r284259 - Revert r284256 due to test failure

Author: emaste Date: Fri Oct 14 13:20:12 2016 New Revision: 284259 URL: http://llvm.org/viewvc/llvm-project?rev=284259=rev Log: Revert r284256 due to test failure Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/openbsd.c Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

[PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL284256: Link static PIE programs against rcrt0.o on OpenBSD (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D22130?vs=68046=74718#toc Repository: rL LLVM

r284256 - Link static PIE programs against rcrt0.o on OpenBSD

Author: emaste Date: Fri Oct 14 12:59:53 2016 New Revision: 284256 URL: http://llvm.org/viewvc/llvm-project?rev=284256=rev Log: Link static PIE programs against rcrt0.o on OpenBSD Patch by Stefan Kempf. Differential Revision: https://reviews.llvm.org/D22130 Modified:

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

emaste added inline comments. Comment at: lib/abi/CHANGELOG.TXT:22 + Although this change removes symbols, it should still be non-ABI breaking + since all of the definitions removed are inline functions. + Should we also include in this comment the further

[libunwind] r282599 - libunwind: Add OpenBSD case for _Unwind_Ptr typedef

Author: emaste Date: Wed Sep 28 10:37:21 2016 New Revision: 282599 URL: http://llvm.org/viewvc/llvm-project?rev=282599=rev Log: libunwind: Add OpenBSD case for _Unwind_Ptr typedef Patch by Mark Kettenis Modified: libunwind/trunk/src/AddressSpace.hpp Modified:

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

emaste created this revision. emaste added reviewers: dim, brooks. emaste added a subscriber: cfe-commits. Herald added a subscriber: emaste. It seems a bad idea to change the default in the middle of a release branch due to possible changes in global ctor / dtor ordering between .ctors and

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

emaste added a comment. Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's toolchain. https://reviews.llvm.org/D22130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] r280103 - consistently add \n to log and trace messages

Author: emaste Date: Tue Aug 30 10:38:10 2016 New Revision: 280103 URL: http://llvm.org/viewvc/llvm-project?rev=280103=rev Log: consistently add \n to log and trace messages Previously most messages included a newline in the string, but a few of them were missing. Fix these and simplify by just

[libunwind] r280099 - libunwind: fix X86 register numbers for FreeBSD/i386

Author: emaste Date: Tue Aug 30 10:10:08 2016 New Revision: 280099 URL: http://llvm.org/viewvc/llvm-project?rev=280099=rev Log: libunwind: fix X86 register numbers for FreeBSD/i386 For historical reasons i386 has ebp and esp swapped in the eh_frame register numbering on at least Darwin. That

[libunwind] r280086 - libunwind: correct 'libuwind' typo

Author: emaste Date: Tue Aug 30 08:08:21 2016 New Revision: 280086 URL: http://llvm.org/viewvc/llvm-project?rev=280086=rev Log: libunwind: correct 'libuwind' typo There were several instances of libuwind (missing an "n"), dating to the initial import of libunwind. Modified:

[libunwind] r277215 - libunwind: correct return code in unwinding trace log message

Author: emaste Date: Fri Jul 29 16:24:19 2016 New Revision: 277215 URL: http://llvm.org/viewvc/llvm-project?rev=277215=rev Log: libunwind: correct return code in unwinding trace log message Modified: libunwind/trunk/src/Unwind-EHABI.cpp Modified: libunwind/trunk/src/Unwind-EHABI.cpp URL:

[libunwind] r276424 - Merge r276128: libunwind: limit stack usage in unwind cursor

Author: emaste Date: Fri Jul 22 10:00:42 2016 New Revision: 276424 URL: http://llvm.org/viewvc/llvm-project?rev=276424=rev Log: Merge r276128: libunwind: limit stack usage in unwind cursor Modified: libunwind/branches/release_39/ (props changed)

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added a comment. Note that the addition of the referenceCount at the beginning of `__cxa_exception` for 64-bit builds causes the `_Unwind_Exception unwindHeader` to become misaligned. libstdc++ had this same issue (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38732, now fixed) and

Re: [libunwind] r276128 - libunwind: limit stack usage in unwind cursor

On 20 July 2016 at 15:19, Ed Maste via cfe-commits <cfe-commits@lists.llvm.org> wrote: > Author: emaste > Date: Wed Jul 20 10:19:09 2016 > New Revision: 276128 > > URL: http://llvm.org/viewvc/llvm-project?rev=276128=rev > Log: > libunwind: limit stack usage in unwi

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added inline comments. Comment at: test/test_cxa_allocate_exception.pass.cpp:34 @@ +33,3 @@ +const std::size_t required_alignment = alignof(__cxa_exception); +const bool requires_over_alignment = max_alignment < required_alignment; +

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added a comment. As it happens on FreeBSD/i386 malloc returns a 16-byte-aligned pointer for allocations with size >= 16 so will not be affected by this issue. https://reviews.llvm.org/D12512 ___ cfe-commits mailing list

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added a comment. Is this going to be committed? Libunwind is about to grow the same alignment attribute (https://reviews.llvm.org/D22543) https://reviews.llvm.org/D12512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] r276128 - libunwind: limit stack usage in unwind cursor

Author: emaste Date: Wed Jul 20 10:19:09 2016 New Revision: 276128 URL: http://llvm.org/viewvc/llvm-project?rev=276128=rev Log: libunwind: limit stack usage in unwind cursor Obtained from FreeBSD SVN r302475 Differential Revision: https://reviews.llvm.org/D22570 Modified:

Re: [PATCH] D22543: [libunwind] Properly align _Unwind_Exception.

emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This revision is now accepted and ready to land. I've committed the alignment change to the copy of llvm libunwind in the FreeBSD base system now. https://reviews.llvm.org/D22543

[libunwind] r275997 - libunwind: sync some coments with NetBSD's version

Author: emaste Date: Tue Jul 19 12:28:38 2016 New Revision: 275997 URL: http://llvm.org/viewvc/llvm-project?rev=275997=rev Log: libunwind: sync some coments with NetBSD's version NetBSD's system unwinder is a modified version of LLVM's libunwind. Slightly reduce diffs by updating comments to

[libunwind] r275996 - libunwind: Use conventional DWARF capitalization in comments and errors

Author: emaste Date: Tue Jul 19 12:15:50 2016 New Revision: 275996 URL: http://llvm.org/viewvc/llvm-project?rev=275996=rev Log: libunwind: Use conventional DWARF capitalization in comments and errors Modified: libunwind/trunk/include/libunwind.h

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

emaste added a subscriber: emaste. Comment at: docs/Proposals/GitHub.rst:8-9 @@ +7,4 @@ + +This is a proposal to move our current revision control system from Subversion +to GitHub. Below are the financial and technical arguments as to why we need +such a move and how will people

Re: r271692 - Don't pass --build-id to ld by default.

On 3 June 2016 at 15:53, Nico Weber via cfe-commits wrote: > Can you add this to the release notes? It'll for example break chromium's > crash server (we can fix this on our end by explicitly passing > -Wl,--build-id for release builds, but we only saw this commit fly

Re: Don't pass --build-id by default.

On 2 June 2016 at 21:19, Hal Finkel via cfe-commits wrote: > - Original Message - >> From: "Rafael Espíndola" >> To: "Hal Finkel" >> Cc: "cfe-commits cfe" >> Sent: Thursday, June 2,

Re: [PATCH] D20791: Support SOURCE_DATE_EPOCH environment variable

emaste updated this revision to Diff 58977. emaste added a comment. Use gmtime to report in UTC when `SOURCE_DATE_EPOCH` is set. This follows GCC and makes sense given the purpose of `SOURCE_DATE_EPOCH`. For reference here is discussion on the GCC list when this was introduced there:

[PATCH] D20791: Support SOURCE_DATE_EPOCH environment variable

emaste created this revision. emaste added a subscriber: cfe-commits. `SOURCE_DATE_EPOCH` specifies a UNIX timestamp (number of seconds since 01 Jan 1970 00:00:00 UTC) to be used as the timestamp input for build processes e.g. `__DATE__` and `__TIME__` See

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

This revision was automatically updated to reflect the committed changes. Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for -static (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D19029?vs=53452=53460#toc Repository: rL LLVM

r266123 - Always use --eh-frame-hdr on FreeBSD, even for -static

Author: emaste Date: Tue Apr 12 16:11:46 2016 New Revision: 266123 URL: http://llvm.org/viewvc/llvm-project?rev=266123=rev Log: Always use --eh-frame-hdr on FreeBSD, even for -static FreeBSD uses LLVM's libunwind on FreeBSD/arm64 today (and is expected to use it more widely in the future), and

[PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

emaste created this revision. emaste added reviewers: dim, andrew, davide. emaste added a subscriber: cfe-commits. Herald added subscribers: emaste, aemerson. FreeBSD uses LLVM's libunwind on FreeBSD/arm64 today (and we expect to use it more widely in the future) and it requires the EH frame

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

emaste added a comment. Seems fine to me http://reviews.llvm.org/D17286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Linux-abi group

On 8 February 2016 at 18:08, Joseph Myers wrote: > On Mon, 8 Feb 2016, H.J. Lu wrote: > >> >> I was referring to program properties: >> >> >> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8 >> > >> > This looks more like an ELF topic to me, not really

Re: [PATCH] D15967: Turn off lldb debug tuning by default for FreeBSD

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. I advocated for the lldb tuning by default on FreeBSD originally, but I didn't fully understand the implications. It turns out we're just not ready yet. So, LGTM.

Re: [PATCH] D15967: Turn off lldb debug tuning by default for FreeBSD

emaste added a comment. > Sure, I was just making it the same as LLVM's default. Yeah, the defaults ought to be the same; it turns out this change was just premature. http://reviews.llvm.org/D15967 ___ cfe-commits mailing list

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

>> Is there a precendent for the option name? It should be -m* and not -f*, >> since it is not target independent. > > Yes, agreed, thanks for the catch Joerg. Presumably -ffixed_r9 should become -mfixed_r9 as well? ___ cfe-commits mailing list

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This LGTM http://reviews.llvm.org/D15899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15791: Disable generating movt on FreeBSD

emaste added a comment. > @davide, any idea whether lld will be able to handle movt correctly? If so, > we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ? I'm sure lld will handle everything we need eventually (if it does not already), but I'm not sure it's reasonable to

Re: [Diffusion] rL248379: Refactor library decision for -fopenmp support from Darwin into a

emaste added a subscriber: emaste. Users: joerg (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) http://reviews.llvm.org/rL248379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13820: [libunwind] Add FreeBSD _Unwind_Ptr typedef

emaste created this revision. emaste added a subscriber: cfe-commits. http://reviews.llvm.org/D13820 Files: src/AddressSpace.hpp Index: src/AddressSpace.hpp === --- src/AddressSpace.hpp +++ src/AddressSpace.hpp @@ -35,7 +35,11 @@

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

emaste added a subscriber: emaste. Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:4080 @@ +4079,3 @@ + SmallString<512> PS4SDKDir; + if (const char *EnvValue = getenv("SCE_PS4_SDK_DIR")) +if (!llvm::sys::fs::exists(EnvValue)) Looks like a missing { here

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

emaste added a comment. > Can we get this fixed or reversed out? Thanks! It's already reverted. Repository: rL LLVM http://reviews.llvm.org/D13482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r250252 - This patch adds missing pieces to clang, including the PS4 toolchain

On 13 October 2015 at 23:40, Ekaterina Romanova via cfe-commits wrote: > Author: kromanova > Date: Tue Oct 13 18:40:02 2015 > New Revision: 250252 > > URL: http://llvm.org/viewvc/llvm-project?rev=250252=rev > Log: > This patch adds missing pieces to clang, including