[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275316. eduucaldas added a comment. Herald added a subscriber: mgorny. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files:

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275318. eduucaldas added a comment. Revert mistake on last update, used `arc diff --update` with the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275315. eduucaldas added a comment. - Remove predicates in `CXXOperatorCallExpr`. - Implement getOperatorNodeKind to dispatch from `CXXOperatorCallExpr` to syntax constructs like `BinaryOperatorExpression`, `PrefixUnaryOperatorExpression`...

[PATCH] D82960: Add parenthesized expression to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbd78333fc6: Add parenthesized expression to SyntaxTree (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:82 + default: +return getNumArgs() == 1; + } riccibruno wrote: > This will be true for `operator->`. Thank you ! I had missed that! I'll

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas updated this revision to Diff 274796. eduucaldas added a comment. nitpick comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas updated this revision to Diff 274795. eduucaldas added a comment. Ordering nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas added a reviewer: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added a comment. Code that reproduces the crash Notice that when using a postfix unary operator ++ one argument is introduced to differ it from its prefix counterpart,

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82954 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprCXX.cpp clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 274769. eduucaldas added a comment. better comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/lib/AST/ExprCXX.cpp

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas added a reviewer: gribozavr2. eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/CXXOperatorCallExprTest.cpp:1 +//===- unittests/Tooling/CXXOperatorCallExprTest.cpp --===// +//

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 274720. eduucaldas added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/lib/AST/ExprCXX.cpp clang/unittests/Tooling/CMakeLists.txt

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82937 Files: clang/lib/AST/ExprCXX.cpp clang/unittests/Tooling/CMakeLists.txt

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:501 WalkUpFromStmt IntegerLiteral(1) -WalkUpFromBinaryOperator BinaryOperator(+) - WalkUpFromExpr BinaryOperator(+) -

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

eduucaldas added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:649 + case BO_##NAME: \ +if (isSameMethod(::TraverseBin##NAME, \ +

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:117 + recordDefaultImplementation( + __func__, [&, this]() { RecordingVisitorBase::WalkUpFromStmt(S); }); + return

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

eduucaldas added a comment. A more general feedback. From our conversation one of the issues was that the tests wre only surfacing overriden methods. For instance, whenever we recorded a WalkUpFromExpr, and thus the callback showed up in the test, we actually did **not** walk up. Now, in all

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas added a comment. In D82312#2116028 , @vvereschaka wrote: > Hello Eduardo, > > sorry, but one of your these commits break the clang unit tests on the > following builders: > > -

[PATCH] D82360: Add StringLiteral to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG466e8b7ea6e1: Add StringLiteral to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82360?vs=273346=273438#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b404b6d0031: Add `FloatingLiteral` to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82318?vs=273347=273437#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG221d7bbe49cc: Add `CharLiteral` to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82312?vs=273343=273436#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f7f8564808b: Add `BoolLiteralExpression` to SyntaxTree (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82310/new/

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 273347. eduucaldas marked an inline comment as done. eduucaldas added a comment. Fix indenting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82318/new/ https://reviews.llvm.org/D82318 Files:

[PATCH] D82360: Add StringLiteral to SyntaxTree

eduucaldas updated this revision to Diff 273346. eduucaldas added a comment. Add unicode tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82360/new/ https://reviews.llvm.org/D82360 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 273343. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. Add tests for unicode characters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82312/new/ https://reviews.llvm.org/D82312

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} gribozavr2 wrote: > eduucaldas wrote: > > gribozavr2 wrote: > > > C99 has bool literals, but the program should include stdbool.h. > > > > > > I

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas updated this revision to Diff 273310. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. isC -> hasBoolType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82310/new/ https://reviews.llvm.org/D82310 Files:

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:1 +//===--- clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp ---===// +// I find this name

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas updated this revision to Diff 273093. eduucaldas added a comment. remove union. or relation implemented as a parent-child relation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82302/new/ https://reviews.llvm.org/D82302 Files:

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas updated this revision to Diff 273096. eduucaldas added a comment. Polishing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82302/new/ https://reviews.llvm.org/D82302 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index:

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1266 + +TEST_P(SyntaxTreeTest, CharacterLiteralCxx11) { + if (!GetParam().isCXX11OrLater()) { Rename to `CharacterLiteralUtf`?

[PATCH] D82360: Add StringLiteral to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82360 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas added a reviewer: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:72-75 + bool isCXX17OrLater() const { +return Language == Lang_CXX17 || Language == Lang_CXX20; +

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} gribozavr2 wrote: > C99 has bool literals, but the program should include stdbool.h. > > I feel

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas updated this revision to Diff 272492. eduucaldas added a comment. removing automatically added include Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82318

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 272492. eduucaldas added a comment. removing automatically added include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82318/new/ https://reviews.llvm.org/D82318 Files:

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82312 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas marked 3 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:268 +/// Expression for boolean literals. C++ [lex.bool] +class BoolLiteralExpression final : public Expression { Homogenize

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82310 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas updated this revision to Diff 272445. eduucaldas added a comment. update comments, rollback references, and add them as proposition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82302/new/ https://reviews.llvm.org/D82302 Files:

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82302 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 271980. eduucaldas added a comment. Why does this work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Given an UserDefinedLiteral `1.2_w`: Problem: Lexer generates one Token for the literal, but ClangAST references two source locations Fix: Ignore the operator and interpret it as the

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271784. eduucaldas added a comment. change if -> asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; eduucaldas wrote: > gribozavr2 wrote: > > Should there be getters

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271744. eduucaldas marked 12 inline comments as done. eduucaldas added a comment. Aswering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271630. eduucaldas added a comment. Fix mistake on getting SourceRange for template-id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271620. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. - cleanup for upstreaming - better coverage for unqualified-id - Better coverage for qualified-id - Finish implementing unqualified-id. Repository: rG LLVM Github Monorepo

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked an inline comment as not done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; gribozavr2 wrote: > Should there be getters for various parts

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269422. eduucaldas edited the summary of this revision. eduucaldas added a comment. Answering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269423. eduucaldas added a comment. nswering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 6 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:618 + Builder.foldNode(Builder.getRange(it.getLocalSourceRange()), NS, nullptr); + Builder.markChild(NS, syntax::NodeRole::Unknown); +

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269129. eduucaldas added a comment. cleanup for upstreaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81280: (Incomplete)Add support for id-expression

eduucaldas updated this revision to Diff 269127. eduucaldas added a comment. Add support for DeclRefExpr in SyntaxTree, by generating IdExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81280/new/ https://reviews.llvm.org/D81280 Files:

[PATCH] D81280: (Incomplete)Add support for id-expression

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - TODO: Differ between NameQualifiers - TODO: Box all operators - Done: Treat NestedNameSpecifiers - Done: [Try] Unbox all operators Repository: rG LLVM Github Monorepo

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas updated this revision to Diff 268517. eduucaldas added a comment. `ArrowToken`, `ExternKeyword` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files:

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas updated this revision to Diff 268519. eduucaldas added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:94 /// a binary expression'. Used for implementing accessors. +// How to name NodeRole: +// If the child node is a token/keyword, end its name with 'Token'/'Keyword'

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829 +| | | | | `-:: +| | | | `-TypeSpecifier +| | | | |-S eduucaldas wrote: > Perhaps we shouldn't differ between specifiers as that is semantical >

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas updated this revision to Diff 268502. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Fix cout, add explanation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files:

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas updated this revision to Diff 268503. eduucaldas marked an inline comment as done. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829 +| | | | | `-:: +| | | | `-TypeSpecifier +| | | | |-S Perhaps we

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. eduucaldas marked an inline comment as not done.

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D81155: Rename arrow -> arrowToken for unified naming

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81155 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268428. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files:

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268420. eduucaldas added a comment. answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268403. eduucaldas added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268397. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81136: Define rules for naming NodeRole and apply them.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81136 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268382. eduucaldas added a comment. Add support for IntegerLiteral in SyntaxTree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files:

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D81092: Add support for `nullptr` in SyntaxTrees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81092 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1048 + syntax::Tree *ChildNode; + if (Expr *ChildExpr = dyn_cast(Child)) { +// This is an expression in a statement position, consume the trailing

[PATCH] D80822: Run syntax tree tests in many language modes

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:54-63 + bool isCXX() const { +return Language == Lang_CXX || Language == Lang_CXX11 || + Language == Lang_CXX14 || Language == Lang_CXX17 || + Language ==

[PATCH] D80812: Add support for Overloaded Binary Operators in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80812 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D80731: Improve test infrastructure in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. - Test if the code sourcing the SyntaxTree compiles - Output compiler errors and warnings to err - Fix tests with code that did not compile

[PATCH] D80624: Add support for UnaryOperator in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. gribozavr2 accepted this revision. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo

[PATCH] D80540: Add support for binary operators in Syntax Trees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80540 Files: clang/include/clang/Tooling/Syntax/Nodes.h

<    1   2   3   4   5