[clang-tools-extra] r358496 - [clangd] Check file path of declaring header when deciding whether to insert include.

2019-04-16 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Apr 16 07:35:49 2019 New Revision: 358496 URL: http://llvm.org/viewvc/llvm-project?rev=358496=rev Log: [clangd] Check file path of declaring header when deciding whether to insert include. Summary: Previously, we would use include spelling of the declaring header to

[clang-tools-extra] r358400 - [clangd] Wait for compile command in ASTWorker instead of ClangdServer

2019-04-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Apr 15 05:32:28 2019 New Revision: 358400 URL: http://llvm.org/viewvc/llvm-project?rev=358400=rev Log: [clangd] Wait for compile command in ASTWorker instead of ClangdServer Summary: This makes addDocument non-blocking and would also allow code completion (in fallback

r358378 - [Lookup] Invisible decls should not be ambiguous when renaming.

2019-04-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Apr 15 01:46:34 2019 New Revision: 358378 URL: http://llvm.org/viewvc/llvm-project?rev=358378=rev Log: [Lookup] Invisible decls should not be ambiguous when renaming. Summary: For example, a renamed type in a header file can conflict with declaration in a random file

[clang-tools-extra] r358159 - [clangd] Use identifiers in file as completion candidates when build is not ready.

2019-04-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Apr 11 02:36:36 2019 New Revision: 358159 URL: http://llvm.org/viewvc/llvm-project?rev=358159=rev Log: [clangd] Use identifiers in file as completion candidates when build is not ready. Summary: o Lex the code to get the identifiers and put them into a "symbol" index. o

[clang-tools-extra] r357916 - [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

2019-04-08 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Apr 8 07:53:16 2019 New Revision: 357916 URL: http://llvm.org/viewvc/llvm-project?rev=357916=rev Log: [clangd] Add fallback mode for code completion when compile command or preamble is not ready. Summary: When calling TUScehduler::runWithPreamble (e.g. in code

r357567 - [clang-format] Regroup #includes into blocks for Google style

2019-04-03 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Apr 3 02:25:16 2019 New Revision: 357567 URL: http://llvm.org/viewvc/llvm-project?rev=357567=rev Log: [clang-format] Regroup #includes into blocks for Google style Summary: Regrouping #includes in blocks separated by blank lines when sorting C++ #include headers was

r356446 - [Tooling] Add more scope specifiers until spelling is not ambiguous.

2019-03-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Mar 19 03:12:15 2019 New Revision: 356446 URL: http://llvm.org/viewvc/llvm-project?rev=356446=rev Log: [Tooling] Add more scope specifiers until spelling is not ambiguous. Summary: Previously, when the renamed spelling is ambiguous, we simply use the full-qualfied name

[clang-tools-extra] r355200 - [clangd] Enable SuggestMissingIncludes by default.

2019-03-01 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Mar 1 06:17:55 2019 New Revision: 355200 URL: http://llvm.org/viewvc/llvm-project?rev=355200=rev Log: [clangd] Enable SuggestMissingIncludes by default. Summary: This seems to work stably now. Turn on by default. Reviewers: kadircet Subscribers: ilya-biryukov,

[clang-tools-extra] r354963 - [clangd] Improve global code completion when scope specifier is unresolved.

2019-02-27 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 27 03:42:37 2019 New Revision: 354963 URL: http://llvm.org/viewvc/llvm-project?rev=354963=rev Log: [clangd] Improve global code completion when scope specifier is unresolved. Summary: Suppose `clangd::` is unresolved in the following example. Currently, we simply use

Re: [PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

2019-02-26 Thread Eric Liu via cfe-commits
Unfortunately, the evaluation tool I use only works on compilable code, so it doesn't capture the unsolved specifier case in this patch. I didn't try to collect the metrics because I think this is more of a bug fix than quality improvement. On Tue, Feb 26, 2019, 10:25 Kadir Cetinkaya via

r354570 - [CodeComplete] Collect visited contexts when scope specifier is invalid.

2019-02-21 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Feb 21 03:22:58 2019 New Revision: 354570 URL: http://llvm.org/viewvc/llvm-project?rev=354570=rev Log: [CodeComplete] Collect visited contexts when scope specifier is invalid. Summary: This will allow completion consumers to guess the specified scope by putting together

[clang-tools-extra] r354558 - [clangd] Handle another incomplete-type diagnostic case in IncludeFixer.

2019-02-21 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Feb 21 01:33:49 2019 New Revision: 354558 URL: http://llvm.org/viewvc/llvm-project?rev=354558=rev Log: [clangd] Handle another incomplete-type diagnostic case in IncludeFixer. Modified: clang-tools-extra/trunk/clangd/IncludeFixer.cpp

[clang-tools-extra] r354330 - [clangd] Handle unresolved scope specifier when fixing includes.

2019-02-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Feb 19 06:32:22 2019 New Revision: 354330 URL: http://llvm.org/viewvc/llvm-project?rev=354330=rev Log: [clangd] Handle unresolved scope specifier when fixing includes. Summary: In the following examples, "clangd" is unresolved, and the fixer will try to fix include for

[clang-tools-extra] r354268 - [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

2019-02-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Feb 18 05:12:10 2019 New Revision: 354268 URL: http://llvm.org/viewvc/llvm-project?rev=354268=rev Log: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type. Summary: Multiple diagnostics can be caused by the same unresolved

[clang-tools-extra] r353926 - [clangd] Handle a few more diag kinds in include fixer.

2019-02-13 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 13 00:58:54 2019 New Revision: 353926 URL: http://llvm.org/viewvc/llvm-project?rev=353926=rev Log: [clangd] Handle a few more diag kinds in include fixer. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags:

[clang-tools-extra] r353708 - [clangd] Prefer location from codegen files when merging symbols.

2019-02-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Feb 11 07:05:29 2019 New Revision: 353708 URL: http://llvm.org/viewvc/llvm-project?rev=353708=rev Log: [clangd] Prefer location from codegen files when merging symbols. Summary: For example, if an index symbol has location in a .proto file and an AST symbol has location

[clang-tools-extra] r353514 - [clangd] Fix an assertion in TypoCorrection.

2019-02-08 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Feb 8 05:27:47 2019 New Revision: 353514 URL: http://llvm.org/viewvc/llvm-project?rev=353514=rev Log: [clangd] Fix an assertion in TypoCorrection. Summary: https://github.com/clangd/clangd/issues/7 Reviewers: sammccall, hokein Subscribers: ilya-biryukov, MaskRay,

[clang-tools-extra] r353413 - [clangd] Use Dex for dynamic index by default.

2019-02-07 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Feb 7 07:34:37 2019 New Revision: 353413 URL: http://llvm.org/viewvc/llvm-project?rev=353413=rev Log: [clangd] Use Dex for dynamic index by default. Summary: Memory usage for a sample TU: Without Dex: 17.9M WithDex: 24.4M The memory increase is considerable but

[clang-tools-extra] r353380 - [clangd] Suggest adding missing includes for typos (like include-fixer).

2019-02-07 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Feb 7 01:23:22 2019 New Revision: 353380 URL: http://llvm.org/viewvc/llvm-project?rev=353380=rev Log: [clangd] Suggest adding missing includes for typos (like include-fixer). Summary: This adds include-fixer feature into clangd based on D56903. Clangd now captures

[clang-tools-extra] r353310 - [clangd] Add type boost to fuzzy find in Dex.

2019-02-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Feb 6 07:36:23 2019 New Revision: 353310 URL: http://llvm.org/viewvc/llvm-project?rev=353310=rev Log: [clangd] Add type boost to fuzzy find in Dex. Summary: No noticeable impact on code completions overall except some improvement on cross-namespace completion.

[clang-tools-extra] r352957 - [clangd] Fix heap-use-after-free after r352868

2019-02-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Sat Feb 2 02:35:39 2019 New Revision: 352957 URL: http://llvm.org/viewvc/llvm-project?rev=352957=rev Log: [clangd] Fix heap-use-after-free after r352868 Modified: clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp Modified:

r352865 - [CUDA] Relax lit test condition after r352798.

2019-02-01 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Feb 1 03:36:23 2019 New Revision: 352865 URL: http://llvm.org/viewvc/llvm-project?rev=352865=rev Log: [CUDA] Relax lit test condition after r352798. Clang executable doesn't match clang.* in all test environment. Modified: cfe/trunk/test/Driver/cuda-detect.cu

[clang-tools-extra] r352764 - [clangd] Append "(fix available)" to diagnostic message when fixes are present.

2019-01-31 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Jan 31 08:09:25 2019 New Revision: 352764 URL: http://llvm.org/viewvc/llvm-project?rev=352764=rev Log: [clangd] Append "(fix available)" to diagnostic message when fixes are present. Summary: This would make diagnostic fixits more discoverable, especially for plugins

r352755 - Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls"

2019-01-31 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Jan 31 06:20:02 2019 New Revision: 352755 URL: http://llvm.org/viewvc/llvm-project?rev=352755=rev Log: Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls" This reverts commit r352690. This causes clang to crash. Sent

Re: r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

2019-01-31 Thread Eric Liu via cfe-commits
And the stack trace is: ``` 1. parser at end of file [31/1788] 2. Code generation 3. Running pass 'Function Pass Manager' on module 'absl/base/internal/throw_delegate.cc'. 4. Running pass 'X86 DAG->DAG Instruction

r352618 - [OpenGL] Fix test on PPC after r352540

2019-01-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Jan 30 03:24:04 2019 New Revision: 352618 URL: http://llvm.org/viewvc/llvm-project?rev=352618=rev Log: [OpenGL] Fix test on PPC after r352540 Summary: Specify -triple like test/SemaOpenCL/logical-ops.cl. Otherwise, this test fails on PPC. Reviewers: bkramer

r352503 - [Tooling] Handle #pragma once header guard in include insertion.

2019-01-29 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jan 29 06:40:01 2019 New Revision: 352503 URL: http://llvm.org/viewvc/llvm-project?rev=352503=rev Log: [Tooling] Handle #pragma once header guard in include insertion. Reviewers: ilya-biryukov Subscribers: cfe-commits Differential Revision:

[clang-tools-extra] r352361 - [clangd] Suggest adding missing includes for incomplete type diagnostics.

2019-01-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jan 28 06:01:55 2019 New Revision: 352361 URL: http://llvm.org/viewvc/llvm-project?rev=352361=rev Log: [clangd] Suggest adding missing includes for incomplete type diagnostics. Summary: This enables clangd to intercept compiler diagnostics and attach fixes (e.g. by

[clang-tools-extra] r351813 - [clangd] NFC: reduce log noise from Diagnostics.

2019-01-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jan 22 04:55:27 2019 New Revision: 351813 URL: http://llvm.org/viewvc/llvm-project?rev=351813=rev Log: [clangd] NFC: reduce log noise from Diagnostics. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential

[clang-tools-extra] r349502 - [clangd] Try to fix buildbot failure after r349496

2018-12-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Dec 18 08:06:29 2018 New Revision: 349502 URL: http://llvm.org/viewvc/llvm-project?rev=349502=rev Log: [clangd] Try to fix buildbot failure after r349496 Increase timeout from 10ms to 100ms. See http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/27959

[clang-tools-extra] r349496 - [clangd] BackgroundIndex rebuilds symbol index periodically.

2018-12-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Dec 18 07:39:33 2018 New Revision: 349496 URL: http://llvm.org/viewvc/llvm-project?rev=349496=rev Log: [clangd] BackgroundIndex rebuilds symbol index periodically. Summary: Currently, background index rebuilds symbol index on every indexed file, which can be inefficient.

[clang-tools-extra] r349049 - [clangd] Enable cross-namespace completions by default in clangd

2018-12-13 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Dec 13 07:35:43 2018 New Revision: 349049 URL: http://llvm.org/viewvc/llvm-project?rev=349049=rev Log: [clangd] Enable cross-namespace completions by default in clangd Summary: Code completion will suggest symbols from any scope (incl. inaccessible scopes) when there's

[clang-tools-extra] r347983 - [clangd] Penalize destructor and overloaded operators in code completion.

2018-11-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Nov 30 03:17:15 2018 New Revision: 347983 URL: http://llvm.org/viewvc/llvm-project?rev=347983=rev Log: [clangd] Penalize destructor and overloaded operators in code completion. Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet,

[clang-tools-extra] r347982 - [clangd] Drop injected class name when class scope is not explicitly specified.

2018-11-30 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Nov 30 03:12:40 2018 New Revision: 347982 URL: http://llvm.org/viewvc/llvm-project?rev=347982=rev Log: [clangd] Drop injected class name when class scope is not explicitly specified. Summary: E.g. allow injected "A::A" in `using A::A^` but not in "A^". Reviewers:

[clang-tools-extra] r347755 - [clangd] Fix test broken in r347754.

2018-11-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Nov 28 06:00:09 2018 New Revision: 347755 URL: http://llvm.org/viewvc/llvm-project?rev=347755=rev Log: [clangd] Fix test broken in r347754. Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cpp URL:

[clang-tools-extra] r347754 - [clangd] Less penalty for cross-namespace completions.

2018-11-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Nov 28 05:45:25 2018 New Revision: 347754 URL: http://llvm.org/viewvc/llvm-project?rev=347754=rev Log: [clangd] Less penalty for cross-namespace completions. Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cpp

[clang-tools-extra] r347739 - [clangd] Canonicalize file path in URIForFile.

2018-11-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Nov 28 02:30:42 2018 New Revision: 347739 URL: http://llvm.org/viewvc/llvm-project?rev=347739=rev Log: [clangd] Canonicalize file path in URIForFile. Summary: File paths in URIForFile can come from index or local AST. Path from index goes through URI transformation and

[clang-tools-extra] r347548 - [clangd] Tune down scope boost for global scope

2018-11-26 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Nov 26 04:12:01 2018 New Revision: 347548 URL: http://llvm.org/viewvc/llvm-project?rev=347548=rev Log: [clangd] Tune down scope boost for global scope Summary: This improves cross-namespace completions and has ignorable impact on other completion types. Metrics ```

[clang-tools-extra] r347467 - [clangd] Cleanup: stop passing around list of supported URI schemes.

2018-11-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Nov 22 07:02:05 2018 New Revision: 347467 URL: http://llvm.org/viewvc/llvm-project?rev=347467=rev Log: [clangd] Cleanup: stop passing around list of supported URI schemes. Summary: Instead of passing around a list of supported URI schemes in clangd, we expose an

[clang-tools-extra] r347466 - [clangd] Cleanup: use index file instead of header in workspace symbols lit test.

2018-11-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Nov 22 06:59:22 2018 New Revision: 347466 URL: http://llvm.org/viewvc/llvm-project?rev=347466=rev Log: [clangd] Cleanup: use index file instead of header in workspace symbols lit test. Summary: The full path of the input header depends on the execution environment and

[clang-tools-extra] r346648 - [clangd] Remember to serialize AnyScope in FuzzyFindRequest json.

2018-11-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Nov 12 04:24:08 2018 New Revision: 346648 URL: http://llvm.org/viewvc/llvm-project?rev=346648=rev Log: [clangd] Remember to serialize AnyScope in FuzzyFindRequest json. Modified: clang-tools-extra/trunk/clangd/index/Index.cpp Modified:

[clang-tools-extra] r346224 - [clangd] Deduplicate query scopes.

2018-11-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Nov 6 03:17:40 2018 New Revision: 346224 URL: http://llvm.org/viewvc/llvm-project?rev=346224=rev Log: [clangd] Deduplicate query scopes. Summary: For example, when anonymous namespace is present, duplicated namespaces might be generated for the enclosing namespace.

[clang-tools-extra] r346223 - [clangd] Get rid of QueryScopes.empty() == AnyScope special case.

2018-11-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Nov 6 03:08:17 2018 New Revision: 346223 URL: http://llvm.org/viewvc/llvm-project?rev=346223=rev Log: [clangd] Get rid of QueryScopes.empty() == AnyScope special case. Reviewers: sammccall Reviewed By: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman,

[clang-tools-extra] r346221 - [clangd] auto-index stores symbols per-file instead of per-TU.

2018-11-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Nov 6 02:55:21 2018 New Revision: 346221 URL: http://llvm.org/viewvc/llvm-project?rev=346221=rev Log: [clangd] auto-index stores symbols per-file instead of per-TU. Summary: This allows us to deduplicate header symbols across TUs. File digests are collects when

[clang-tools-extra] r345140 - [clangd] Downrank members from base class

2018-10-24 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Oct 24 06:45:17 2018 New Revision: 345140 URL: http://llvm.org/viewvc/llvm-project?rev=345140=rev Log: [clangd] Downrank members from base class Reviewers: sammccall, ilya-biryukov Reviewed By: sammccall Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits

r345135 - [CodeComplete] Expose InBaseClass signal in code completion results.

2018-10-24 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Oct 24 05:57:27 2018 New Revision: 345135 URL: http://llvm.org/viewvc/llvm-project?rev=345135=rev Log: [CodeComplete] Expose InBaseClass signal in code completion results. Summary: No new tests as the existing tests for result priority should give us coverage. Also as

[clang-tools-extra] r344912 - [clangd] Support URISchemes configuration in BackgroundIndex.

2018-10-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 22 08:37:58 2018 New Revision: 344912 URL: http://llvm.org/viewvc/llvm-project?rev=344912=rev Log: [clangd] Support URISchemes configuration in BackgroundIndex. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits

[clang-tools-extra] r344897 - [change-namespace] Enhance detection of conflicting namespaces.

2018-10-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 22 05:48:49 2018 New Revision: 344897 URL: http://llvm.org/viewvc/llvm-project?rev=344897=rev Log: [change-namespace] Enhance detection of conflicting namespaces. Summary: For example: ``` namespace util { class Base; } namespace new { namespace util { class

r344889 - [CodeComplete] Fix accessibility of protected members when accessing members implicitly.

2018-10-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 22 01:47:31 2018 New Revision: 344889 URL: http://llvm.org/viewvc/llvm-project?rev=344889=rev Log: [CodeComplete] Fix accessibility of protected members when accessing members implicitly. Reviewers: ilya-biryukov Subscribers: arphaman, cfe-commits Differential

[clang-tools-extra] r344736 - [clangd] Names that are not spelled in source code are reserved.

2018-10-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 18 05:23:05 2018 New Revision: 344736 URL: http://llvm.org/viewvc/llvm-project?rev=344736=rev Log: [clangd] Names that are not spelled in source code are reserved. Summary: These are often not expected to be used directly e.g. ``` TEST_F(Fixture, X) { ^ //

[clang-tools-extra] r344688 - [clangd] Support scope proximity in code completion.

2018-10-17 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Oct 17 04:19:02 2018 New Revision: 344688 URL: http://llvm.org/viewvc/llvm-project?rev=344688=rev Log: [clangd] Support scope proximity in code completion. Summary: This should make all-scope completion more usable. Scope proximity for indexes will be added in followup

[clang-tools-extra] r344604 - [clangd] Allow disble down traversals from root.

2018-10-16 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 16 03:41:17 2018 New Revision: 344604 URL: http://llvm.org/viewvc/llvm-project?rev=344604=rev Log: [clangd] Allow disble down traversals from root. Summary: This is useful for symbo scope proximity, where down traversals from the global scope if not desired.

r344509 - [CodeComplete] Make sure keyword 'template' is added even when code pattern is disabled.

2018-10-15 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 15 05:37:23 2018 New Revision: 344509 URL: http://llvm.org/viewvc/llvm-project?rev=344509=rev Log: [CodeComplete] Make sure keyword 'template' is added even when code pattern is disabled. Reviewers: sammccall, hokein Subscribers: arphaman, cfe-commits Differential

r344335 - [Tooling] Expose ExecutorName option.

2018-10-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Oct 12 04:47:36 2018 New Revision: 344335 URL: http://llvm.org/viewvc/llvm-project?rev=344335=rev Log: [Tooling] Expose ExecutorName option. Modified: cfe/trunk/include/clang/Tooling/Execution.h cfe/trunk/lib/Tooling/Execution.cpp Modified:

r344267 - Revert "[Lex] TokenConcatenation now takes const Preprocessor"

2018-10-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 11 10:50:04 2018 New Revision: 344267 URL: http://llvm.org/viewvc/llvm-project?rev=344267=rev Log: Revert "[Lex] TokenConcatenation now takes const Preprocessor" This reverts commit r344262. This was an unintentional commit. Modified:

r344266 - clang-cl: set output of lit-test to a tmp file after r344234

2018-10-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 11 10:49:20 2018 New Revision: 344266 URL: http://llvm.org/viewvc/llvm-project?rev=344266=rev Log: clang-cl: set output of lit-test to a tmp file after r344234 Some test frameworks do not allow output file in CWD. Modified:

r344262 - [Lex] TokenConcatenation now takes const Preprocessor

2018-10-11 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Oct 11 10:35:29 2018 New Revision: 344262 URL: http://llvm.org/viewvc/llvm-project?rev=344262=rev Log: [Lex] TokenConcatenation now takes const Preprocessor Differential Revision: https://reviews.llvm.org/D52502 Modified:

[clang-tools-extra] r344055 - [clang-move] Fix broken json output.

2018-10-09 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 9 08:17:16 2018 New Revision: 344055 URL: http://llvm.org/viewvc/llvm-project?rev=344055=rev Log: [clang-move] Fix broken json output. Modified: clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp Modified:

[clang-tools-extra] r344024 - [clangd] Avoid cache main file status in preamble.

2018-10-09 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 9 01:27:31 2018 New Revision: 344024 URL: http://llvm.org/viewvc/llvm-project?rev=344024=rev Log: [clangd] Avoid cache main file status in preamble. Summary: Main file can certainly change when reusing preamble. Reviewers: sammccall Subscribers: ilya-biryukov,

[clang-tools-extra] r343982 - [clang-move] Dump whether a declaration is templated.

2018-10-08 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 8 10:22:50 2018 New Revision: 343982 URL: http://llvm.org/viewvc/llvm-project?rev=343982=rev Log: [clang-move] Dump whether a declaration is templated. Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp clang-tools-extra/trunk/clang-move/ClangMove.h

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Eric Liu via cfe-commits
ws10pro-fast\llvm.obj\tools\clang\tools\extra\unittests\clangd\..\lib\clang\8.0.0 >> >> Preamble for file C:\clangd-test\foo.cpp cannot be reused. Attempting to >> rebuild it. >> >> Built preamble of size 185492 for file C:\clangd-test\foo.cpp >> >>

[clang-tools-extra] r343637 - [clangd] Temporarily disable VFS stats cache test for windows.

2018-10-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 2 14:47:41 2018 New Revision: 343637 URL: http://llvm.org/viewvc/llvm-project?rev=343637=rev Log: [clangd] Temporarily disable VFS stats cache test for windows. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp Modified:

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Eric Liu via cfe-commits
0 matched, 1 returned. > > > > Can you please take a look? > > Douglas Yung > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > > Of Eric Liu via cfe-commits > > Sent: Tuesday, Oct

[clang-tools-extra] r343623 - [clangd] Try to fix windows buildbot after r343576

2018-10-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 2 13:00:32 2018 New Revision: 343623 URL: http://llvm.org/viewvc/llvm-project?rev=343623=rev Log: [clangd] Try to fix windows buildbot after r343576 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20347/steps/test/logs/stdio

[clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 2 03:43:55 2018 New Revision: 343576 URL: http://llvm.org/viewvc/llvm-project?rev=343576=rev Log: [clangd] Cache FS stat() calls when building preamble. Summary: The file stats can be reused when preamble is reused (e.g. code completion). It's safe to assume that

Re: r343573 - [Lex] TokenConcatenation now takes const Preprocessor

2018-10-02 Thread Eric Liu via cfe-commits
Sorry, I messed up my svn rebase somehow and committed and reverted this again (r343574) when landing r343575. On Tue, Oct 2, 2018 at 12:30 PM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date: Tue Oct 2 03:28:50 2018 > New Revision: 34357

r343573 - [Lex] TokenConcatenation now takes const Preprocessor

2018-10-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 2 03:28:50 2018 New Revision: 343573 URL: http://llvm.org/viewvc/llvm-project?rev=343573=rev Log: [Lex] TokenConcatenation now takes const Preprocessor Differential Revision: https://reviews.llvm.org/D52502 Modified:

r343575 - [CodeComplete] Re-fix accessibilty of protected members from base class.

2018-10-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 2 03:29:00 2018 New Revision: 343575 URL: http://llvm.org/viewvc/llvm-project?rev=343575=rev Log: [CodeComplete] Re-fix accessibilty of protected members from base class. Summary: The initial fix (r337453) had bug and was partially reverted (r338255). This simplies

r343574 - Revert untintentionally commited changes

2018-10-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 2 03:28:54 2018 New Revision: 343574 URL: http://llvm.org/viewvc/llvm-project?rev=343574=rev Log: Revert untintentionally commited changes Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h Modified:

[clang-tools-extra] r343448 - [clangd] Fix header mapping for std::string. NFC

2018-10-01 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Oct 1 01:50:49 2018 New Revision: 343448 URL: http://llvm.org/viewvc/llvm-project?rev=343448=rev Log: [clangd] Fix header mapping for std::string. NFC Some implementation has std::string declared in . Modified:

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

2018-09-28 Thread Eric Liu via cfe-commits
Biryukov >>> wrote: >>> >>>> Prtially reverted the commit in r338255 to fix a very frequent crash. >>>> The code seemed obviously wrong there (calling accessibility checking, >>>> passing a possibly unrelated class) and the tests didn't break afte

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

2018-09-28 Thread Eric Liu via cfe-commits
t; >> On Mon, Jul 30, 2018 at 5:22 PM Ilya Biryukov >> wrote: >> >>> Prtially reverted the commit in r338255 to fix a very frequent crash. >>> The code seemed obviously wrong there (calling accessibility checking, >>> passing a possibly unrelated class

Re: r338255 - [CodeComplete] Fix the crash in code completion on access checking

2018-09-28 Thread Eric Liu via cfe-commits
On Mon, Jul 30, 2018 at 5:19 PM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Mon Jul 30 08:19:05 2018 > New Revision: 338255 > > URL: http://llvm.org/viewvc/llvm-project?rev=338255=rev > Log: > [CodeComplete] Fix the crash in code completion on

[clang-tools-extra] r343248 - [clangd] Initial supoprt for cross-namespace global code completion.

2018-09-27 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 27 11:46:00 2018 New Revision: 343248 URL: http://llvm.org/viewvc/llvm-project?rev=343248=rev Log: [clangd] Initial supoprt for cross-namespace global code completion. Summary: When no scope qualifier is specified, allow completing index symbols from any scope and

[clang-tools-extra] r343247 - [clangd] Add more tracing to index queries. NFC

2018-09-27 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 27 11:23:23 2018 New Revision: 343247 URL: http://llvm.org/viewvc/llvm-project?rev=343247=rev Log: [clangd] Add more tracing to index queries. NFC Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential

r343224 - [Tooling] Get rid of uses of llvm::Twine::str which is slow. NFC

2018-09-27 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 27 07:50:24 2018 New Revision: 343224 URL: http://llvm.org/viewvc/llvm-project?rev=343224=rev Log: [Tooling] Get rid of uses of llvm::Twine::str which is slow. NFC Modified: cfe/trunk/lib/Tooling/Inclusions/HeaderIncludes.cpp Modified:

[clang-tools-extra] r343223 - [clangd] Make IncludeInserter less slow. NFC

2018-09-27 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 27 07:27:02 2018 New Revision: 343223 URL: http://llvm.org/viewvc/llvm-project?rev=343223=rev Log: [clangd] Make IncludeInserter less slow. NFC Modified: clang-tools-extra/trunk/clangd/Headers.cpp clang-tools-extra/trunk/clangd/Headers.h Modified:

Re: [clang-tools-extra] r342730 - [clangd] Remember to serialize symbol origin in YAML.

2018-09-26 Thread Eric Liu via cfe-commits
t; > LG to be consistent with binary serialization, the same question applies > to binary serialization. > > Again, the change itself seems fine, just nitpicking on whether putting > origin into a symbol at that level makes sense. > > > >>> Am I missing something

r342976 - [VFS] Add a proxy FS that delegates calls to underlying FS by default.

2018-09-25 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 25 07:02:01 2018 New Revision: 342976 URL: http://llvm.org/viewvc/llvm-project?rev=342976=rev Log: [VFS] Add a proxy FS that delegates calls to underlying FS by default. Summary: This is useful when derived file systems want to override some calls and still proxy

[clang-tools-extra] r342964 - [clangd] Fix build bot after r342961

2018-09-25 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 25 04:47:14 2018 New Revision: 342964 URL: http://llvm.org/viewvc/llvm-project?rev=342964=rev Log: [clangd] Fix build bot after r342961 Use llvm::isAlpha instead of std::isalpha etc. This should fix bot failure:

[clang-tools-extra] r342961 - [clangd] Check that scheme is valid when parsing URI.

2018-09-25 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 25 03:47:46 2018 New Revision: 342961 URL: http://llvm.org/viewvc/llvm-project?rev=342961=rev Log: [clangd] Check that scheme is valid when parsing URI. Reviewers: sammccall Reviewed By: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet,

Re: [PATCH] D52264: Deduplicate replacements from diagnostics.

2018-09-25 Thread Eric Liu via cfe-commits
I wasn't aware of the bug. I have just replied to the issue. Thanks for letting me know! On Tue, Sep 25, 2018 at 10:44 AM Stephen Kelly via Phabricator < revi...@reviews.llvm.org> wrote: > steveire added a comment. > > Was this motivated by https://bugs.llvm.org/show_bug.cgi?id=38910 ? > > >

[clang-tools-extra] r342951 - Deduplicate replacements from diagnostics.

2018-09-25 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 25 01:24:07 2018 New Revision: 342951 URL: http://llvm.org/viewvc/llvm-project?rev=342951=rev Log: Deduplicate replacements from diagnostics. Summary: After r329813, clang-apply-replacements stopped deduplicating identical replacements; however, tools like clang-tidy

Re: [clang-tools-extra] r342730 - [clangd] Remember to serialize symbol origin in YAML.

2018-09-25 Thread Eric Liu via cfe-commits
ndex, but that doesn't seem to work in general. I checked this in without review as I thought this was a trivial fix. The binary serialization also serializes the Origin field. > > Am I missing something? > > On Fri, Sep 21, 2018 at 3:06 PM Eric Liu via cfe-commits < > cfe-co

r342889 - [VFS] Use llvm::StringMap instead of std::map. NFC

2018-09-24 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Sep 24 07:52:11 2018 New Revision: 342889 URL: http://llvm.org/viewvc/llvm-project?rev=342889=rev Log: [VFS] Use llvm::StringMap instead of std::map. NFC Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp URL:

[clang-tools-extra] r342730 - [clangd] Remember to serialize symbol origin in YAML.

2018-09-21 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Sep 21 06:04:57 2018 New Revision: 342730 URL: http://llvm.org/viewvc/llvm-project?rev=342730=rev Log: [clangd] Remember to serialize symbol origin in YAML. Modified: clang-tools-extra/trunk/clangd/index/SymbolYAML.cpp

[clang-tools-extra] r342529 - [clangd] Store preamble macros in dynamic index.

2018-09-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Sep 19 02:35:04 2018 New Revision: 342529 URL: http://llvm.org/viewvc/llvm-project?rev=342529=rev Log: [clangd] Store preamble macros in dynamic index. Summary: Pros: o Loading macros from preamble for every completion is slow (see profile). o Calculating macro USR is

r342528 - [Sema] Do not load macros from preamble when LoadExternal is false.

2018-09-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Sep 19 02:34:55 2018 New Revision: 342528 URL: http://llvm.org/viewvc/llvm-project?rev=342528=rev Log: [Sema] Do not load macros from preamble when LoadExternal is false. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: cfe-commits Differential

[clang-tools-extra] r342473 - [clangd] Get rid of Decls parameter in indexMainDecls. NFC

2018-09-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 18 06:35:16 2018 New Revision: 342473 URL: http://llvm.org/viewvc/llvm-project?rev=342473=rev Log: [clangd] Get rid of Decls parameter in indexMainDecls. NFC It's already available in ParsedAST. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp

[clang-tools-extra] r342460 - [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

2018-09-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 18 03:30:44 2018 New Revision: 342460 URL: http://llvm.org/viewvc/llvm-project?rev=342460=rev Log: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC. Summary: FileIndex now provides explicit interfaces for preamble and main file updates. This avoids

[clang-tools-extra] r342452 - [clangd] Adapt API change after 342451.

2018-09-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 18 01:52:14 2018 New Revision: 342452 URL: http://llvm.org/viewvc/llvm-project?rev=342452=rev Log: [clangd] Adapt API change after 342451. Modified: clang-tools-extra/trunk/clangd/FindSymbols.cpp clang-tools-extra/trunk/clangd/XRefs.cpp

r342451 - [Index] Add an option to collect macros from preprocesor.

2018-09-18 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Sep 18 01:51:08 2018 New Revision: 342451 URL: http://llvm.org/viewvc/llvm-project?rev=342451=rev Log: [Index] Add an option to collect macros from preprocesor. Summary: Also added unit tests for the index library; lit+c-index-test is painful... Reviewers:

[clang-tools-extra] r342362 - [clangd] Get rid of AST matchers in SymbolCollector. NFC

2018-09-17 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Sep 17 00:43:49 2018 New Revision: 342362 URL: http://llvm.org/viewvc/llvm-project?rev=342362=rev Log: [clangd] Get rid of AST matchers in SymbolCollector. NFC Reviewers: ilya-biryukov, kadircet Subscribers: MaskRay, jkorous, arphaman, cfe-commits Differential

[clang-tools-extra] r342134 - [clangd] Clarify and hide -index flag.

2018-09-13 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 13 05:53:23 2018 New Revision: 342134 URL: http://llvm.org/viewvc/llvm-project?rev=342134=rev Log: [clangd] Clarify and hide -index flag. Summary: The wording implies global index support, which is confusing. As most users shouldn't care about this flag, also make it

Re: [PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

2018-09-12 Thread Eric Liu via cfe-commits
I mean `clangd-symbol-builder` On Wed, Sep 12, 2018 at 4:32 PM Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: > ioeric accepted this revision. > ioeric added a comment. > This revision is now accepted and ready to land. > > lgtm > > +1 to `clang-symbol-builder` > > > Repository: >

r342028 - [Tooling] Wait for all threads to finish before resetting CWD.

2018-09-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Sep 12 01:29:47 2018 New Revision: 342028 URL: http://llvm.org/viewvc/llvm-project?rev=342028=rev Log: [Tooling] Wait for all threads to finish before resetting CWD. Modified: cfe/trunk/lib/Tooling/AllTUsExecution.cpp Modified:

[clang-tools-extra] r341645 - [clangd] Canonicalize include paths in clangd.

2018-09-07 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Sep 7 02:40:36 2018 New Revision: 341645 URL: http://llvm.org/viewvc/llvm-project?rev=341645=rev Log: [clangd] Canonicalize include paths in clangd. Get rid of "../" and "../../". Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp

[clang-tools-extra] r341576 - [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

2018-09-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 6 11:52:26 2018 New Revision: 341576 URL: http://llvm.org/viewvc/llvm-project?rev=341576=rev Log: [clangd] Add "Deprecated" field to Symbol and CodeCompletion. Summary: Also set "deprecated" field in LSP CompletionItem. Reviewers: sammccall, kadircet Reviewed By:

[clang-tools-extra] r341534 - [clangd] Set SymbolID for sema macros so that they can be merged with index macros.

2018-09-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 6 02:59:37 2018 New Revision: 341534 URL: http://llvm.org/viewvc/llvm-project?rev=341534=rev Log: [clangd] Set SymbolID for sema macros so that they can be merged with index macros. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman,

[clang-tools-extra] r341488 - [clang-tidy] minor bug fix to AbseilMatcher.h

2018-09-05 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Sep 5 12:01:34 2018 New Revision: 341488 URL: http://llvm.org/viewvc/llvm-project?rev=341488=rev Log: [clang-tidy] minor bug fix to AbseilMatcher.h This missing directory is not yet released, but is causing some problems internally. It's gonna be released eventually and

  1   2   3   4   5   6   7   8   9   10   >