r341476 - [Sema] Store MacroInfo in CodeCompletionResult for macro results.

Author: ioeric Date: Wed Sep 5 07:59:17 2018 New Revision: 341476 URL: http://llvm.org/viewvc/llvm-project?rev=341476=rev Log: [Sema] Store MacroInfo in CodeCompletionResult for macro results. Summary: This provides information about the macro definition. For example, it can be used to compute

r341455 - [VFS] Cache the current working directory for the real FS.

Author: ioeric Date: Wed Sep 5 02:45:27 2018 New Revision: 341455 URL: http://llvm.org/viewvc/llvm-project?rev=341455=rev Log: [VFS] Cache the current working directory for the real FS. Reviewers: sammccall Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51641

[clang-tools-extra] r341449 - [clangd] Tune macro quality scoring for code completion.

Author: ioeric Date: Wed Sep 5 00:40:38 2018 New Revision: 341449 URL: http://llvm.org/viewvc/llvm-project?rev=341449=rev Log: [clangd] Tune macro quality scoring for code completion. x0.2 seems to be too much penalty, macros might be wanted in some cases; changing to 0.5x instead. The tuning

[clang-tools-extra] r341304 - [clangd] Support multiple #include headers in one symbol.

Author: ioeric Date: Mon Sep 3 03:18:21 2018 New Revision: 341304 URL: http://llvm.org/viewvc/llvm-project?rev=341304=rev Log: [clangd] Support multiple #include headers in one symbol. Summary: Currently, a symbol can have only one #include header attached, which might not work well if the

[clang-tools-extra] r340822 - [clangd] Use buffered llvm::errs() in the clangd binary.

Author: ioeric Date: Tue Aug 28 06:15:50 2018 New Revision: 340822 URL: http://llvm.org/viewvc/llvm-project?rev=340822=rev Log: [clangd] Use buffered llvm::errs() in the clangd binary. Summary: Unbuffered stream can cause significant (non-deterministic) latency for the logger. Reviewers:

[clang-tools-extra] r340604 - [clangd] Speculative code completion index request before Sema is run.

Author: ioeric Date: Fri Aug 24 04:23:56 2018 New Revision: 340604 URL: http://llvm.org/viewvc/llvm-project?rev=340604=rev Log: [clangd] Speculative code completion index request before Sema is run. Summary: For index-based code completion, send an asynchronous speculative index request, based

r340602 - Fix build bot after r340598.

Author: ioeric Date: Fri Aug 24 02:53:44 2018 New Revision: 340602 URL: http://llvm.org/viewvc/llvm-project?rev=340602=rev Log: Fix build bot after r340598. Revert to the original behavior: only calculate real file path when file is opened and avoid using InterndPath for real path calculation.

r340598 - [FileManager] Do not call 'real_path' in getFile().

Author: ioeric Date: Fri Aug 24 01:59:54 2018 New Revision: 340598 URL: http://llvm.org/viewvc/llvm-project?rev=340598=rev Log: [FileManager] Do not call 'real_path' in getFile(). Summary: This partially rolls back the change in D48903:

[clang-tools-extra] r339322 - [clangd] Try to fix buildbot after r339320.

Author: ioeric Date: Thu Aug 9 02:25:26 2018 New Revision: 339322 URL: http://llvm.org/viewvc/llvm-project?rev=339322=rev Log: [clangd] Try to fix buildbot after r339320. http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/5487 Modified:

[clang-tools-extra] r339320 - [clangd] Record the file being processed in a TUScheduler thread in context.

Author: ioeric Date: Thu Aug 9 02:05:45 2018 New Revision: 339320 URL: http://llvm.org/viewvc/llvm-project?rev=339320=rev Log: [clangd] Record the file being processed in a TUScheduler thread in context. Summary: This allows implementations like different symbol indexes to know what the current

r338832 - Fully qualify the renamed symbol if the shortened name is ambiguous.

Author: ioeric Date: Fri Aug 3 02:16:07 2018 New Revision: 338832 URL: http://llvm.org/viewvc/llvm-project?rev=338832=rev Log: Fully qualify the renamed symbol if the shortened name is ambiguous. Summary: For example, when renaming `a::b::x::foo` to `y::foo` below, replacing `x::foo()` with

[clang-tools-extra] r338696 - Replace hardcoded format styles in a few tools with the default style in libFormat.

Author: ioeric Date: Thu Aug 2 03:30:56 2018 New Revision: 338696 URL: http://llvm.org/viewvc/llvm-project?rev=338696=rev Log: Replace hardcoded format styles in a few tools with the default style in libFormat. Modified: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

; passing a possibly unrelated class) and the tests didn't break after > reverting it. > > Let me know if I missed anything. > > On Thu, Jul 19, 2018 at 3:37 PM Eric Liu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ioeric >> Date: Thu Jul 19

Re: r337850 - Revert "[VFS] Cleanups to VFS interfaces."

Thanks Jordan! On Wed, Jul 25, 2018 at 6:01 PM Jordan Rupprecht wrote: > On Wed, Jul 25, 2018 at 1:40 AM Eric Liu wrote: > >> Please also include a link to the test failure in the commit message or >> this email thread. >> > Sorry, I left the failure on the review thread ( >

Re: [PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

It would make it easier for your reviewers to look at the new changes if you just reopen this patch and update the diff :) On Wed, Jul 25, 2018 at 5:49 PM Simon Marchi via Phabricator < revi...@reviews.llvm.org> wrote: > simark added a comment. > > I uploaded a new version of this patch here: >

[clang-tools-extra] r337907 - [clangd] Use a sigmoid style function for #usages boost in symbol quality.

Author: ioeric Date: Wed Jul 25 04:26:35 2018 New Revision: 337907 URL: http://llvm.org/viewvc/llvm-project?rev=337907=rev Log: [clangd] Use a sigmoid style function for #usages boost in symbol quality. Summary: This has a shape to similar logarithm function but grows much slower for large

Re: r337850 - Revert "[VFS] Cleanups to VFS interfaces."

Please also include a link to the test failure in the commit message or this email thread. On Tue, Jul 24, 2018 at 10:28 PM Jordan Rupprecht via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rupprecht > Date: Tue Jul 24 13:28:07 2018 > New Revision: 337850 > > URL:

[clang-tools-extra] r337816 - [clangd] Tune down quality score for class constructors so that it's ranked after class types.

Author: ioeric Date: Tue Jul 24 01:51:52 2018 New Revision: 337816 URL: http://llvm.org/viewvc/llvm-project?rev=337816=rev Log: [clangd] Tune down quality score for class constructors so that it's ranked after class types. Summary: Currently, class constructors have the same score as the class

[clang-tools-extra] r337681 - [clangd] Penalize non-instance members when accessed via class instances.

Author: ioeric Date: Mon Jul 23 03:56:37 2018 New Revision: 337681 URL: http://llvm.org/viewvc/llvm-project?rev=337681=rev Log: [clangd] Penalize non-instance members when accessed via class instances. Summary: The following are metrics for explicit member access completions. There is no

r337529 - [Index] Set OrigD before D is changed.

Author: ioeric Date: Fri Jul 20 01:08:56 2018 New Revision: 337529 URL: http://llvm.org/viewvc/llvm-project?rev=337529=rev Log: [Index] Set OrigD before D is changed. Reviewers: akyrtzi, arphaman Reviewed By: akyrtzi Subscribers: cfe-commits Differential Revision:

r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

Author: ioeric Date: Thu Jul 19 06:32:00 2018 New Revision: 337453 URL: http://llvm.org/viewvc/llvm-project?rev=337453=rev Log: [CodeComplete] Fix accessibilty of protected members from base class. Summary: Currently, protected members from base classes are marked as inaccessible when completing

[clang-tools-extra] r337396 - [clangd] Also get scope for RK_pattern completion results.

Author: ioeric Date: Wed Jul 18 08:31:14 2018 New Revision: 337396 URL: http://llvm.org/viewvc/llvm-project?rev=337396=rev Log: [clangd] Also get scope for RK_pattern completion results. For exmaple, clas field candidates in constructor initializers can be RK_Pattern, but they can still have

r337394 - [CodeComplete] Allow getDeclaration on RK_Pattern result.

Author: ioeric Date: Wed Jul 18 08:17:52 2018 New Revision: 337394 URL: http://llvm.org/viewvc/llvm-project?rev=337394=rev Log: [CodeComplete] Allow getDeclaration on RK_Pattern result. Summary: RK_Pattern results can also have associated declarations e.g. field decls in constructor

r336928 - [Tooling] Make standalone executor support user-provided vfs.

Author: ioeric Date: Thu Jul 12 11:32:11 2018 New Revision: 336928 URL: http://llvm.org/viewvc/llvm-project?rev=336928=rev Log: [Tooling] Make standalone executor support user-provided vfs. Modified: cfe/trunk/include/clang/Tooling/StandaloneExecution.h

r336910 - [Tooling] Get working directory properly without assuming real file system.

Author: ioeric Date: Thu Jul 12 07:54:25 2018 New Revision: 336910 URL: http://llvm.org/viewvc/llvm-project?rev=336910=rev Log: [Tooling] Get working directory properly without assuming real file system. Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp

Re: r336807 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

fyi, I've reverted this commit with r336831 due to some other issues. On Wed, Jul 11, 2018 at 8:23 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Simon, > > This commit added broken tests to one of our builders: > >

r336831 - Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name"

Author: ioeric Date: Wed Jul 11 11:43:07 2018 New Revision: 336831 URL: http://llvm.org/viewvc/llvm-project?rev=336831=rev Log: Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name" This reverts commit r336807. This breaks users of

Re: [PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

Sounds good. Thanks for the suggestion! On Wed, Jul 11, 2018 at 3:45 PM Sam McCall wrote: > > > On Wed, Jul 11, 2018, 15:18 Eric Liu via Phabricator < > revi...@reviews.llvm.org> wrote: > >> ioeric added a comment. >> >> In https://reviews.llvm.org/D49175#1158562, @sammccall wrote: >> >> > I

[clang-tools-extra] r336801 - [clangd] Ignore sema code complete callback with recovery context.

Author: ioeric Date: Wed Jul 11 06:15:31 2018 New Revision: 336801 URL: http://llvm.org/viewvc/llvm-project?rev=336801=rev Log: [clangd] Ignore sema code complete callback with recovery context. Summary: Sema code complete in the recovery mode is generally useless. For many cases, sema first

r336584 - [Index] Ignore noop #undef's when handling macro occurrences.

Author: ioeric Date: Mon Jul 9 12:02:41 2018 New Revision: 336584 URL: http://llvm.org/viewvc/llvm-project?rev=336584=rev Log: [Index] Ignore noop #undef's when handling macro occurrences. Modified: cfe/trunk/lib/Index/IndexingAction.cpp Modified: cfe/trunk/lib/Index/IndexingAction.cpp

[clang-tools-extra] r336581 - [clangd] Make sure macro information exists before increasing usage count.

Author: ioeric Date: Mon Jul 9 11:54:51 2018 New Revision: 336581 URL: http://llvm.org/viewvc/llvm-project?rev=336581=rev Log: [clangd] Make sure macro information exists before increasing usage count. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified:

[clang-tools-extra] r336553 - [clangd] Support indexing MACROs.

Author: ioeric Date: Mon Jul 9 08:31:07 2018 New Revision: 336553 URL: http://llvm.org/viewvc/llvm-project?rev=336553=rev Log: [clangd] Support indexing MACROs. Summary: This is not enabled in the global-symbol-builder or dynamic index yet. Reviewers: sammccall Reviewed By: sammccall

r336532 - Try to fix build bot after r336524

Author: ioeric Date: Mon Jul 9 02:17:25 2018 New Revision: 336532 URL: http://llvm.org/viewvc/llvm-project?rev=336532=rev Log: Try to fix build bot after r336524 Modified: cfe/trunk/test/Index/Core/index-macros.c Modified: cfe/trunk/test/Index/Core/index-macros.c URL:

r336524 - [Index] Add indexing support for MACROs.

Author: ioeric Date: Mon Jul 9 01:44:05 2018 New Revision: 336524 URL: http://llvm.org/viewvc/llvm-project?rev=336524=rev Log: [Index] Add indexing support for MACROs. Reviewers: akyrtzi, arphaman, sammccall Reviewed By: sammccall Subscribers: malaperle, sammccall, cfe-commits Differential

r336427 - [SemaCodeComplete] Expose a method to create CodeCompletionString for macros.

Author: ioeric Date: Fri Jul 6 02:43:57 2018 New Revision: 336427 URL: http://llvm.org/viewvc/llvm-project?rev=336427=rev Log: [SemaCodeComplete] Expose a method to create CodeCompletionString for macros. Summary: The method only takes PPreprocessor and don't require structures that might not

[clang-tools-extra] r336321 - [clangd] Log sema completion context kind and query scopes. NFC

Author: ioeric Date: Thu Jul 5 01:29:33 2018 New Revision: 336321 URL: http://llvm.org/viewvc/llvm-project?rev=336321=rev Log: [clangd] Log sema completion context kind and query scopes. NFC Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits Differential Revision:

[clang-tools-extra] r336318 - [clangd] Treat class constructor as in the same scope as the class in ranking.

Author: ioeric Date: Thu Jul 5 01:14:04 2018 New Revision: 336318 URL: http://llvm.org/viewvc/llvm-project?rev=336318=rev Log: [clangd] Treat class constructor as in the same scope as the class in ranking. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits

[clang-tools-extra] r336260 - [clangd] only ignore collected symbols if TU has uncompilable errors.

Author: ioeric Date: Wed Jul 4 03:39:48 2018 New Revision: 336260 URL: http://llvm.org/viewvc/llvm-project?rev=336260=rev Log: [clangd] only ignore collected symbols if TU has uncompilable errors. Modified: clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp

r336255 - [SemaCodeComplete] Make sure visited contexts are passed to completion results handler.

Author: ioeric Date: Wed Jul 4 03:01:18 2018 New Revision: 336255 URL: http://llvm.org/viewvc/llvm-project?rev=336255=rev Log: [SemaCodeComplete] Make sure visited contexts are passed to completion results handler. Reviewers: ilya-biryukov Subscribers: cfe-commits Differential Revision:

[clang-tools-extra] r336253 - [clangd] Cleanup unittest: URIs. NFC.

Author: ioeric Date: Wed Jul 4 02:54:23 2018 New Revision: 336253 URL: http://llvm.org/viewvc/llvm-project?rev=336253=rev Log: [clangd] Cleanup unittest: URIs. NFC. Modified: clang-tools-extra/trunk/unittests/clangd/FileDistanceTests.cpp Modified:

[clang-tools-extra] r336252 - [clangd] Avoid collecting symbols from broken TUs in global-symbol-builder.

Author: ioeric Date: Wed Jul 4 02:43:35 2018 New Revision: 336252 URL: http://llvm.org/viewvc/llvm-project?rev=336252=rev Log: [clangd] Avoid collecting symbols from broken TUs in global-symbol-builder. Summary: For example, template parameter might not be resolved in a broken TU, which can

Re: [PATCH] D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring.

Hi Carlos, thanks for letting us know! I sent r336249 to fix the windows test. On Wed, Jul 4, 2018 at 9:51 AM Carlos Alberto Enciso via Phabricator < revi...@reviews.llvm.org> wrote: > CarlosAlbertoEnciso added a comment. > > Hi, > > It seems that your patch is causing an error in the tests for

[clang-tools-extra] r336249 - Try to fix FileDistance test on windows.

Author: ioeric Date: Wed Jul 4 02:08:40 2018 New Revision: 336249 URL: http://llvm.org/viewvc/llvm-project?rev=336249=rev Log: Try to fix FileDistance test on windows.

[clang-tools-extra] r336203 - [clangd] Use default format style and fallback style. NFC

Author: ioeric Date: Tue Jul 3 07:51:23 2018 New Revision: 336203 URL: http://llvm.org/viewvc/llvm-project?rev=336203=rev Log: [clangd] Use default format style and fallback style. NFC Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified:

[clang-tools-extra] r335874 - [clangd] Use log10 instead of the natural logrithm for usage boost.

Author: ioeric Date: Thu Jun 28 09:51:12 2018 New Revision: 335874 URL: http://llvm.org/viewvc/llvm-project?rev=335874=rev Log: [clangd] Use log10 instead of the natural logrithm for usage boost. Modified: clang-tools-extra/trunk/clangd/Quality.cpp

[clang-tools-extra] r335598 - [clangd] Use default clang-format styles.

Author: ioeric Date: Tue Jun 26 05:49:09 2018 New Revision: 335598 URL: http://llvm.org/viewvc/llvm-project?rev=335598=rev Log: [clangd] Use default clang-format styles. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified:

r335492 - [clang-format] Add a default format style that can be used by users of `getStyle`

Author: ioeric Date: Mon Jun 25 09:29:19 2018 New Revision: 335492 URL: http://llvm.org/viewvc/llvm-project?rev=335492=rev Log: [clang-format] Add a default format style that can be used by users of `getStyle` Summary: Tools that reformat code often call `getStyle` to decide the format style to

[clang-tools-extra] r335458 - [clangd] Always remove dots before converting paths to URIs in symbol collector.

Author: ioeric Date: Mon Jun 25 04:50:11 2018 New Revision: 335458 URL: http://llvm.org/viewvc/llvm-project?rev=335458=rev Log: [clangd] Always remove dots before converting paths to URIs in symbol collector. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified:

[clang-tools-extra] r335334 - [clangd] Expose qualified symbol names in CompletionItem (C++ structure only, no json).

Author: ioeric Date: Fri Jun 22 03:46:59 2018 New Revision: 335334 URL: http://llvm.org/viewvc/llvm-project?rev=335334=rev Log: [clangd] Expose qualified symbol names in CompletionItem (C++ structure only, no json). Summary: The qualified name can be used to match a completion item to its

[clang-tools-extra] r335218 - [clangd] Expose 'shouldCollectSymbol' helper from SymbolCollector.

Author: ioeric Date: Thu Jun 21 05:12:26 2018 New Revision: 335218 URL: http://llvm.org/viewvc/llvm-project?rev=335218=rev Log: [clangd] Expose 'shouldCollectSymbol' helper from SymbolCollector. Summary: This allows tools to examine symbols that would be collected in a symbol index. For

[clang-tools-extra] r335212 - [clangd] Fix proximity signal output format. NFC

Author: ioeric Date: Thu Jun 21 02:51:28 2018 New Revision: 335212 URL: http://llvm.org/viewvc/llvm-project?rev=335212=rev Log: [clangd] Fix proximity signal output format. NFC Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cpp URL:

[clang-tools-extra] r335035 - [clangd] Use workspace root path as hint path for resolving URIs in workspace/symbol

Author: ioeric Date: Tue Jun 19 02:33:53 2018 New Revision: 335035 URL: http://llvm.org/viewvc/llvm-project?rev=335035=rev Log: [clangd] Use workspace root path as hint path for resolving URIs in workspace/symbol Summary: Some URI schemes require a hint path to be provided, and workspace root

[clang-tools-extra] r334828 - [clangd] UI for completion items that would trigger include insertion.

Author: ioeric Date: Fri Jun 15 06:34:18 2018 New Revision: 334828 URL: http://llvm.org/viewvc/llvm-project?rev=334828=rev Log: [clangd] UI for completion items that would trigger include insertion. Summary: For completion items that would trigger include insertions (i.e. index symbols that are

[clang-tools-extra] r334810 - [clangd] Boost completion score according to file proximity.

Author: ioeric Date: Fri Jun 15 01:58:12 2018 New Revision: 334810 URL: http://llvm.org/viewvc/llvm-project?rev=334810=rev Log: [clangd] Boost completion score according to file proximity. Summary: Also move unittest: URI scheme to TestFS so that it can be shared by different tests. Reviewers:

[clang-tools-extra] r334809 - [clangd] Customizable URI schemes for dynamic index.

Author: ioeric Date: Fri Jun 15 01:55:00 2018 New Revision: 334809 URL: http://llvm.org/viewvc/llvm-project?rev=334809=rev Log: [clangd] Customizable URI schemes for dynamic index. Summary: This allows dynamic index to have consistent URI schemes with the static index which can have customized

[clang-tools-extra] r334485 - [clangd] Support proximity paths in index fuzzy find.

Author: ioeric Date: Tue Jun 12 01:48:20 2018 New Revision: 334485 URL: http://llvm.org/viewvc/llvm-project?rev=334485=rev Log: [clangd] Support proximity paths in index fuzzy find. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits Differential Revision:

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

Jun 4, 2018 at 12:04 PM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > > Date: Mon Jun 4 02:04:12 2018 > > New Revision: 333874 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=333874=rev > > Log: > > Reland "Move #include manipulatio

[clang-tools-extra] r333885 - [clangd] Avoid indexing decls associated with friend decls.

Author: ioeric Date: Mon Jun 4 04:31:55 2018 New Revision: 333885 URL: http://llvm.org/viewvc/llvm-project?rev=333885=rev Log: [clangd] Avoid indexing decls associated with friend decls. Summary: These decls are sometime used as the canonical declarations (e.g. for go-to-def), which seems to

[clang-tools-extra] r333875 - Reland "[clangd] Adapt file migration in r332720"

Author: ioeric Date: Mon Jun 4 02:04:19 2018 New Revision: 333875 URL: http://llvm.org/viewvc/llvm-project?rev=333875=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r332752 (i.e. reland r332721). Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

[clang-tools-extra] r333876 - Revert "Reland "[clangd] Adapt file migration in r332720""

Author: ioeric Date: Mon Jun 4 02:04:25 2018 New Revision: 333876 URL: http://llvm.org/viewvc/llvm-project?rev=333876=rev Log: Revert "Reland "[clangd] Adapt file migration in r332720"" This reverts commit r333533. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

Author: ioeric Date: Mon Jun 4 02:04:12 2018 New Revision: 333874 URL: http://llvm.org/viewvc/llvm-project?rev=333874=rev Log: Reland "Move #include manipulation code to new lib/Tooling/Inclusions." This reverts commit r333534 (i.e. reland r332720) after fixing module build. Differential

[clang-tools-extra] r333877 - Reland "[clangd] Adapt file migration in r332720"

Author: ioeric Date: Mon Jun 4 02:04:28 2018 New Revision: 333877 URL: http://llvm.org/viewvc/llvm-project?rev=333877=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r333535. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

[clang-tools-extra] r333535 - Revert "Reland "[clangd] Adapt file migration in r332720""

Author: ioeric Date: Wed May 30 05:10:07 2018 New Revision: 333535 URL: http://llvm.org/viewvc/llvm-project?rev=333535=rev Log: Revert "Reland "[clangd] Adapt file migration in r332720"" This reverts commit r333533. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

r333534 - Revert "Reland "Move #include manipulation code to new lib/Tooling/Inclusions.""

Author: ioeric Date: Wed May 30 05:09:58 2018 New Revision: 333534 URL: http://llvm.org/viewvc/llvm-project?rev=333534=rev Log: Revert "Reland "Move #include manipulation code to new lib/Tooling/Inclusions."" This reverts commit r333532. Revert for now to fix an internal bot issue. Added:

[clang-tools-extra] r333533 - Reland "[clangd] Adapt file migration in r332720"

Author: ioeric Date: Wed May 30 04:52:01 2018 New Revision: 333533 URL: http://llvm.org/viewvc/llvm-project?rev=333533=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r332752 (i.e. reland r332721). Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

r333532 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

Author: ioeric Date: Wed May 30 04:51:48 2018 New Revision: 333532 URL: http://llvm.org/viewvc/llvm-project?rev=333532=rev Log: Reland "Move #include manipulation code to new lib/Tooling/Inclusions." This reverts commit r332751 (i.e. reland r332720) after fixing module build. Differential

[clang-tools-extra] r333519 - [clangd] Avoid inserting new #include when declaration is present in the main file.

Author: ioeric Date: Wed May 30 02:03:39 2018 New Revision: 333519 URL: http://llvm.org/viewvc/llvm-project?rev=333519=rev Log: [clangd] Avoid inserting new #include when declaration is present in the main file. Summary: Also fix USR generation for classes in unit tests. The previous USR only

[clang-tools-extra] r333197 - [clangd] Add clangDriver dependency after r333188

Author: ioeric Date: Thu May 24 08:54:32 2018 New Revision: 333197 URL: http://llvm.org/viewvc/llvm-project?rev=333197=rev Log: [clangd] Add clangDriver dependency after r333188 Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

[clang-tools-extra] r333188 - [clangd] Skip .inc headers when canonicalizing header #include.

Author: ioeric Date: Thu May 24 07:40:24 2018 New Revision: 333188 URL: http://llvm.org/viewvc/llvm-project?rev=333188=rev Log: [clangd] Skip .inc headers when canonicalizing header #include. Summary: This assumes that .inc files are supposed to be included via headers that include them.

r333186 - Disable an in-memory vfs file path test on windows.

Author: ioeric Date: Thu May 24 06:52:48 2018 New Revision: 333186 URL: http://llvm.org/viewvc/llvm-project?rev=333186=rev Log: Disable an in-memory vfs file path test on windows. The test uses unix paths and doesn't make sense to run on windows. Fix bot failure caused by r333172:

[clang-tools-extra] r333174 - [clangd] Fix code completion in MACROs with stringification.

Author: ioeric Date: Thu May 24 04:20:19 2018 New Revision: 333174 URL: http://llvm.org/viewvc/llvm-project?rev=333174=rev Log: [clangd] Fix code completion in MACROs with stringification. Summary: Currently, we only handle the first callback from sema code completion and ignore results from

r333172 - [VFS] Implement getRealPath in InMemoryFileSystem.

Author: ioeric Date: Thu May 24 04:17:00 2018 New Revision: 333172 URL: http://llvm.org/viewvc/llvm-project?rev=333172=rev Log: [VFS] Implement getRealPath in InMemoryFileSystem. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D47262 Modified:

[clang-tools-extra] r332959 - [clangd] Correctly handle IWYU prama with verbatim #include header.

Author: ioeric Date: Tue May 22 01:33:30 2018 New Revision: 332959 URL: http://llvm.org/viewvc/llvm-project?rev=332959=rev Log: [clangd] Correctly handle IWYU prama with verbatim #include header. Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Sorry about the bad naming... I hope I could come up with something less confusing. Thanks for the clarification! On Fri, May 18, 2018 at 11:25 PM David Blaikie wrote: > > > On Fri, May 18, 2018 at 2:22 PM Eric Liu wrote: > >> Thanks a lot for looking

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Thanks a lot for looking into this Bruno! The fix looks promising; I'll give it a try next week :D On Fri, May 18, 2018 at 10:33 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I haven't looked in detail here, but in general: Don't split an > implementation and its

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

c/llvm.org >>> -master/llvm/tools/clang/include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:14: >>> /Users/vsk/src/llvm.org-master/llvm/tools/clang/include/clang/Tooling/Refactoring/AtomicChange.h:19:10: >>> fatal error: could not build module 'Clang_Format' >>

[clang-tools-extra] r332752 - Revert "[clangd] Adapt file migration in r332720"

Author: ioeric Date: Fri May 18 11:33:21 2018 New Revision: 332752 URL: http://llvm.org/viewvc/llvm-project?rev=332752=rev Log: Revert "[clangd] Adapt file migration in r332720" This reverts commit r332721 because the dependency r33270 will be reverted. Modified:

r332751 - Revert "Move #include manipulation code to new lib/Tooling/Inclusions."

Author: ioeric Date: Fri May 18 11:33:08 2018 New Revision: 332751 URL: http://llvm.org/viewvc/llvm-project?rev=332751=rev Log: Revert "Move #include manipulation code to new lib/Tooling/Inclusions." This reverts commit r332720. This break build bot with modules. Need to investigate. Revert the

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

clang/include/clang/Tooling/Refactoring/AtomicChange.h:19:10: >> fatal error: could not build module 'Clang_Format' >> #include "clang/Format/Format.h" >> ^~~ >> /Users/vsk/src/llvm.org-master/llvm/tools/clang/lib/Tooling/Execution.cpp:10:

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

e 'Clang_Format' > #include "clang/Format/Format.h" > ^~~ > /Users/vsk/src/llvm.org-master/llvm/tools/clang/lib/Tooling/Execution.cpp:10:10: > fatal error: could not build module 'Clang_Tooling' > #include "clang/Tooling/Execution.h"

r332734 - Fix unused variable warning in r332724

Author: ioeric Date: Fri May 18 09:29:42 2018 New Revision: 332734 URL: http://llvm.org/viewvc/llvm-project?rev=332734=rev Log: Fix unused variable warning in r332724 Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp URL:

[clang-tools-extra] r332732 - Trying to fix clang-move tests on windows build bot broken by r332717

Author: ioeric Date: Fri May 18 09:08:18 2018 New Revision: 332732 URL: http://llvm.org/viewvc/llvm-project?rev=332732=rev Log: Trying to fix clang-move tests on windows build bot broken by r332717 http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10702 Modified:

r332731 - [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

Author: ioeric Date: Fri May 18 09:06:19 2018 New Revision: 332731 URL: http://llvm.org/viewvc/llvm-project?rev=332731=rev Log: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS Summary: ... to support purely VFS-based tools. Reviewers: bkramer Subscribers: klimek, cfe-commits

[clang-tools-extra] r332721 - [clangd] Adapt file migration in r332720

Author: ioeric Date: Fri May 18 07:17:36 2018 New Revision: 332721 URL: http://llvm.org/viewvc/llvm-project?rev=332721=rev Log: [clangd] Adapt file migration in r332720 Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt clang-tools-extra/trunk/clangd/Headers.h Modified:

r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Author: ioeric Date: Fri May 18 07:16:37 2018 New Revision: 332720 URL: http://llvm.org/viewvc/llvm-project?rev=332720=rev Log: Move #include manipulation code to new lib/Tooling/Inclusions. Summary: clangToolingCore is linked into almost everything (incl. clang), but not few tools need #include

r332717 - [VFS] Implement getRealPath for OverlayFileSystem.

Author: ioeric Date: Fri May 18 06:22:49 2018 New Revision: 332717 URL: http://llvm.org/viewvc/llvm-project?rev=332717=rev Log: [VFS] Implement getRealPath for OverlayFileSystem. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D47060 Modified:

[clang-tools-extra] r332701 - Re-enable a clang-move test on windows.

Author: ioeric Date: Fri May 18 02:25:36 2018 New Revision: 332701 URL: http://llvm.org/viewvc/llvm-project?rev=332701=rev Log: Re-enable a clang-move test on windows. This was fixed by r332612. Modified: clang-tools-extra/trunk/test/clang-move/move-class.cpp Modified:

[clang-tools-extra] r332620 - Disable a failing clang-move test on windows.

Author: ioeric Date: Thu May 17 09:13:36 2018 New Revision: 332620 URL: http://llvm.org/viewvc/llvm-project?rev=332620=rev Log: Disable a failing clang-move test on windows. This was broken by r332590 but is likely caused by a bug in clang-move.

[clang-tools-extra] r332612 - Second attempt to fix clang-move tests broken by r332590 on windows

Author: ioeric Date: Thu May 17 07:59:15 2018 New Revision: 332612 URL: http://llvm.org/viewvc/llvm-project?rev=332612=rev Log: Second attempt to fix clang-move tests broken by r332590 on windows http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12010 Add back a path

[clang-tools-extra] r332603 - Attempt to fix clang-move tests broken by r332590 on windows

Author: ioeric Date: Thu May 17 05:40:50 2018 New Revision: 332603 URL: http://llvm.org/viewvc/llvm-project?rev=332603=rev Log: Attempt to fix clang-move tests broken by r332590 on windows http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12007 Modified:

r332590 - Add vfs::FileSystem::getRealPath

Author: ioeric Date: Thu May 17 03:26:23 2018 New Revision: 332590 URL: http://llvm.org/viewvc/llvm-project?rev=332590=rev Log: Add vfs::FileSystem::getRealPath Summary: And change `FileManager::getCanonicalName` to use getRealPath. Reviewers: bkramer Reviewed By: bkramer Subscribers:

Re: [clang-tools-extra] r332363 - [clangd] Populate #include insertions as additional edits in completion items.

angd/CodeComplete.cpp:710:6: >> error: in passing argument 3 of ‘bool >> clang::clangd::{anonymous}::semaCodeComplete(std::unique_ptr, >> const clang::CodeCompleteOptions&, const >> clang::clangd::{anonymous}::SemaCompleteInput&, >> std::unique_ptr*)’ >> >

[clang-tools-extra] r332520 - Second attempt to fix buildbot failure caused by r332363

Author: ioeric Date: Wed May 16 13:31:38 2018 New Revision: 332520 URL: http://llvm.org/viewvc/llvm-project?rev=332520=rev Log: Second attempt to fix buildbot failure caused by r332363 http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26501 Modified:

[clang-tools-extra] r332518 - [clang-move] Fix a potential bug where realpath doesn't work on VFS.

Author: ioeric Date: Wed May 16 13:10:10 2018 New Revision: 332518 URL: http://llvm.org/viewvc/llvm-project?rev=332518=rev Log: [clang-move] Fix a potential bug where realpath doesn't work on VFS. Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp Modified:

[clang-tools-extra] r332515 - Attempt to fix buildbot failure caused by r332363

Author: ioeric Date: Wed May 16 12:59:49 2018 New Revision: 332515 URL: http://llvm.org/viewvc/llvm-project?rev=332515=rev Log: Attempt to fix buildbot failure caused by r332363 Log: http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26399 Modified:

Re: [clang-tools-extra] r332363 - [clangd] Populate #include insertions as additional edits in completion items.

t; ^ > . . . > > Please have a look? > > It is not good idea to keep the bot red for too long. This hides new > problem which later hard to track down. > > Thanks > > > Galina > > > > On Tue, May 15, 2018 at 8:29 AM, Eric Liu via cfe-commits &

Re: r332436 - clang-format: Allow optimizer to break template declaration.

This should be fixed by r332465 On Wed, May 16, 2018 at 2:50 PM Eric Liu wrote: > OK, I'll send a fix for the index test. Please make sure you run all clang > tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a > patch! Thanks! > > On Wed, May 16, 2018

r332465 - Fix an Index test caused by a clang-format change (r332436).

Author: ioeric Date: Wed May 16 05:58:13 2018 New Revision: 332465 URL: http://llvm.org/viewvc/llvm-project?rev=332465=rev Log: Fix an Index test caused by a clang-format change (r332436). Modified: cfe/trunk/test/Index/overriding-ftemplate-comments.cpp Modified:

Re: r332436 - clang-format: Allow optimizer to break template declaration.

OK, I'll send a fix for the index test. Please make sure you run all clang tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a patch! Thanks! On Wed, May 16, 2018 at 2:32 PM Eric Liu wrote: > I can also reproduce on my local machine (Debian). > > On

Re: r332436 - clang-format: Allow optimizer to break template declaration.

I can also reproduce on my local machine (Debian). On Wed, May 16, 2018 at 1:01 PM David Zarzycki via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This change broke `test/Index/overriding-ftemplate-comments.cpp` on Red > Hat Fedora 28. Was this expected? > > > On May 16, 2018, at 4:25 AM,

<    1   2   3   4   5   6   7   8   9   10   >