[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81744563a53: [clang][ExtractAPI] Fix bool spelling coming from the macro definition. (authored by evelez7). Repository: rG LLVM Github Monorepo

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

evelez7 updated this revision to Diff 552504. evelez7 added a comment. Use clang instead of clang_cc1 like other C tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158474/new/ https://reviews.llvm.org/D158474 Files:

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f034f952fa: [clang][ExtractAPI] Add support for namespaces (authored by evelez7). Changed prior to commit:

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. getFragmentsForType resulted in a bool typeIdentifier

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 updated this revision to Diff 552155. evelez7 marked an inline comment as done. evelez7 added a comment. Move DetermineParentDecl to determineParentRecord in APIVisitor as a private method. Easier to just let it fetch the record for us and return nullptr if the parent is the

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

evelez7 added a comment. In D158031#4603363 , @dang wrote: > Did this change not affect ordering of the symbols in the generated JSON? > Looks pretty good to me otherwise! It only changed method ordering due to them not being grouped together, so

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bb485530869: [clang][ExtractAPI] Refactor C++ method and field visitation (authored by evelez7). Changed prior to commit:

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG634b2fd2cac2: [clang][ExtractAPI] Add support for C++ member templates (authored by evelez7). Changed prior to commit:

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e9c5d9cab5: [clang][ExtractAPI] Visit method templates with better scheme (authored by evelez7). Changed prior to commit:

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80b787e80329: [clang][ExtractAPI] Add support for C++ global function templates (authored by evelez7). Repository: rG LLVM Github Monorepo

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

evelez7 updated this revision to Diff 551642. evelez7 added a comment. Formatting changes, keep GlobalFunction has templates together and revert extraneous formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157579/new/

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8c8981cac0: [clang][ExtractAPI] Add support for C++ variable templates (authored by evelez7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba37f4e46a5: [clang][ExtractAPI] Add support for C++ class templates and concepts (authored by evelez7). Repository: rG LLVM Github Monorepo

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 551591. evelez7 added a comment. Fix formatting for introduced declarations in DeclarationFragments.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files:

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 updated this revision to Diff 551526. evelez7 added a comment. Revert extraneous formatting in API.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 added a comment. Note that this doesn't handle anonymous namespaces. Similar problems arise with anonymous classes/structs, being worked on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 updated this revision to Diff 551340. evelez7 added a comment. Remove unnecessary line break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Serialize namespaces, nested namespaces, and class

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

evelez7 updated this revision to Diff 551212. evelez7 added a comment. Fix passing Decl's template, introduced from parent updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158031/new/ https://reviews.llvm.org/D158031 Files:

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

evelez7 updated this revision to Diff 550958. evelez7 added a comment. Update to use the new Template class constructor instead of old getFragments. Also better functional style for appending. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 updated this revision to Diff 550953. evelez7 added a comment. Update Spec naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158027/new/ https://reviews.llvm.org/D158027 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 updated this revision to Diff 550950. evelez7 added a comment. Forgot Spec instance in SerializerBase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

evelez7 updated this revision to Diff 550948. evelez7 added a comment. Update instances of Spec to Specialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157579/new/ https://reviews.llvm.org/D157579 Files:

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 550945. evelez7 added a comment. Also rename traverseSpec* in SerializerBase.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files:

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 updated this revision to Diff 550944. evelez7 added a comment. Update all instances of Spec to Specialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 Files:

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 added a comment. We didn't handle inheriting from a template parameter, but now we do by serializing the relationship. The parameter does not produce a target USR so it falls back to its name. Comment at: clang/include/clang/ExtractAPI/DeclarationFragments.h:191

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 550937. evelez7 marked 5 inline comments as done. evelez7 added a comment. Address review feedback - Handle inheriting from a template parameter. - Add a new test to check inheriting from a template parameter. - Move base class gathering to a new private

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor visitation for C++ record children by following

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Visit and serialize C++ fields by checking if a var

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 updated this revision to Diff 550500. evelez7 added a comment. Fix arbitrary include changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158027/new/ https://reviews.llvm.org/D158027 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Visit and serialize method templates and template

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 updated this revision to Diff 550485. evelez7 added a comment. Get rid of unnecessary function for checking if global var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 Files:

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add records, serialization for global function templates

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 548862. evelez7 added a comment. Fix template arg identification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 548042. evelez7 added a comment. Add brackets for SerializerBase visit methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files:

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Serialize global C++ variable templates and

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547971. evelez7 added a comment. Refactor template arg name deduction to get as string for FragmentKind::typeIdentifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547389. evelez7 added a comment. Abstract the name deduction for generic template args to its own function. It's very helpful in other cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547314. evelez7 added a comment. Add documentation to template argument name deduction, add missing method declarations to visitor base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547265. evelez7 added a comment. Format DeclarationFragments.h, try to address buildbot fail on clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files:

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add has_template template, DeclarationFragmentBuilder

[PATCH] D157075: [clang][ExtractAPI] Add support for C++ class templates and concepts Depends on D157007

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add has_template template, DeclarationFragments, and

[PATCH] D157007: [clang][ExtractAPI] Add support for C++ classes with fix

evelez7 added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:612 + if (isa(Method)) { +Name = Method->getNameAsString(); +if (dyn_cast(Method)->isExplicit()) Minor change is here. Since `Name` is now an `std::string`, a cast

[PATCH] D157007: [clang][ExtractAPI] Add support for C++ classes with fix

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a subscriber: ChuanqiXu. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reintroduce

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546635. evelez7 added a comment. Reintroduce fix from f4de606ef271 and use clang frontend for C++ tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. @haowei Thank you for letting me know! That patch does seem to fix it, unfortunately it didn't fail on my end. Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. In D153557#4554980 , @haowei wrote: > Hi, we are seeing a test error on `Clang :: > ExtractAPI/constructor_destructor.cpp` after this patch was landed. Error > message: Hi! Sorry about that, I see you've made some changes. Do

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b76b44e46ac: [clang][ExtractAPI] Add support for C++ classes (authored by evelez7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546323. evelez7 added a comment. Add test for overloaded operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:770 +template <> +struct has_function_signature : public std::true_type {}; + dang wrote: > Does `CXXInstanceMethodRecord` need one of these as well? `CXXInstanceMethodRecord`

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546317. evelez7 marked 4 inline comments as done. evelez7 added a comment. Address review feedback, add tests, and small refactors. - Add tests for destructors, constructors, and conversion methods. - Remove redundant check-nots in existing tests. - Properly

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG422bcd10c48b: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON (authored by evelez7). Changed prior to commit:

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 updated this revision to Diff 536245. evelez7 marked an inline comment as done. evelez7 added a comment. Move semicolon line below After fragment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. There aren't any variables or fields in the tests currently, waiting on D154038 because of no semicolons in their fragments. Comment at: clang/lib/ExtractAPI/API.cpp:19 #include "clang/AST/RawCommentList.h"

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 536071. evelez7 added a comment. Add C++ class tests, fix exception spec fragments - Add tests for single and multiple inheritance, class methods, and functions with noexcept. - Exception spec fragments had a space included in it, moved it to separate

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 added a comment. These updated tests pass locally for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 ___ cfe-commits mailing list

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 535559. evelez7 marked 6 inline comments as done. evelez7 added a comment. Address some review feedback Remove RK_Struct, RK_Union from CXXClassRecord::classof, use std::string for AccessControl, style and remove unused imports Repository: rG LLVM

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 534141. evelez7 added a comment. Add conversion function and overloaded operator support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 534060. evelez7 added a comment. Fix duplicate visitation of CXXRecordDecls by overloading WalkUpFromCXXRecordDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 533799. evelez7 added a comment. Do not include return types for constructors/destructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 533788. evelez7 added a comment. Add access control serialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a subscriber: ChuanqiXu. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add ExtractAPI

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 526148. evelez7 added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151477/new/ https://reviews.llvm.org/D151477 Files:

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 abandoned this revision. evelez7 added inline comments. Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:28-31 +struct APISetVisitorOption { /// Do not include unnecessary whitespaces to save space. bool Compact; }; dang

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 created this revision. evelez7 added reviewers: dang, zixuw. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor SerializerBase and SymbolGraphSerializer

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 525652. evelez7 added a comment. Really address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151293/new/ https://reviews.llvm.org/D151293 Files:

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 525431. evelez7 marked 8 inline comments as done. evelez7 added a comment. Address some review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151293/new/ https://reviews.llvm.org/D151293 Files:

[PATCH] D151402: Address some review feedback

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Delete unnecessary includes, revert SymbolGraphSerializer

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor SerializerBase and SymbolGraphSerializer to use