[clang] b660abc - [ObjC] Add a command line flag that disables recognition of objc_direct for testability

2021-04-06 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2021-04-06T11:17:01-04:00 New Revision: b660abc80d0d0943c54e9440636ddfa89c2d626d URL: https://github.com/llvm/llvm-project/commit/b660abc80d0d0943c54e9440636ddfa89c2d626d DIFF:

[clang] 803b792 - [SemaObjC] Fix a -Wbridge-cast false-positive

2021-04-05 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2021-04-05T11:41:40-04:00 New Revision: 803b79221edfc2517e6bfc373e5f55609565b0e4 URL: https://github.com/llvm/llvm-project/commit/803b79221edfc2517e6bfc373e5f55609565b0e4 DIFF:

[clang] 1e8afba - [clang] Add support for attribute 'swift_async_error'

2021-02-10 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2021-02-10T13:18:13-05:00 New Revision: 1e8afba6f176653abcbda4f0485d9419c8407afb URL: https://github.com/llvm/llvm-project/commit/1e8afba6f176653abcbda4f0485d9419c8407afb DIFF:

[clang] c435567 - [Sema] Fix an assertion failure in -Wcompletion-handler

2021-01-25 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2021-01-25T13:02:02-05:00 New Revision: c4355670b4bb12bc7181a99345bf8d09af1c5762 URL: https://github.com/llvm/llvm-project/commit/c4355670b4bb12bc7181a99345bf8d09af1c5762 DIFF:

[clang] 92d6e80 - NFC: balance a quote in AttrDocs.td

2020-12-16 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-12-16T10:01:24-05:00 New Revision: 92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf URL: https://github.com/llvm/llvm-project/commit/92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf DIFF:

[clang] 95b2dab - [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

2020-12-16 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-12-16T10:01:24-05:00 New Revision: 95b2dab199100f5a86d3f73a995afea879886d65 URL: https://github.com/llvm/llvm-project/commit/95b2dab199100f5a86d3f73a995afea879886d65 DIFF:

[clang] 5a28e1d - [clang] Add support for attribute 'swift_async'

2020-12-07 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-12-07T17:19:26-05:00 New Revision: 5a28e1d9e50eb0b866351b5ab3213678fd28374b URL: https://github.com/llvm/llvm-project/commit/5a28e1d9e50eb0b866351b5ab3213678fd28374b DIFF:

[clang] 9cd2413 - [clang] Add a new nullability annotation for swift async: _Nullable_result

2020-12-07 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-12-07T17:19:20-05:00 New Revision: 9cd2413f1ca7a7f40132ea3c44f251851aa325c2 URL: https://github.com/llvm/llvm-project/commit/9cd2413f1ca7a7f40132ea3c44f251851aa325c2 DIFF:

[clang] 4fa0dbd - Fix a test failing on windows

2020-12-04 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-12-04T11:20:17-05:00 New Revision: 4fa0dbd6885bc4a48ceecdbb0fca9638792762cf URL: https://github.com/llvm/llvm-project/commit/4fa0dbd6885bc4a48ceecdbb0fca9638792762cf DIFF:

[clang] 090dd64 - [Sema] Fold VLAs to constant arrays in a few more contexts

2020-12-04 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-12-04T10:03:23-05:00 New Revision: 090dd647d98dc50a56a42fbba0f3f11b10a3a187 URL: https://github.com/llvm/llvm-project/commit/090dd647d98dc50a56a42fbba0f3f11b10a3a187 DIFF:

[clang] 3513171 - [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

2020-10-15 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-10-15T15:21:01-04:00 New Revision: 351317167e2b28aad03f8e45e0ed0acbbff18c61 URL: https://github.com/llvm/llvm-project/commit/351317167e2b28aad03f8e45e0ed0acbbff18c61 DIFF:

[clang] 498c7fa - [SemaObjC] Fix a crash on an invalid ternary with ARC pointers

2020-10-13 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-10-13T21:20:20-04:00 New Revision: 498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd URL: https://github.com/llvm/llvm-project/commit/498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd DIFF:

[clang] 0f1be87 - [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

2020-09-03 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-09-03T16:56:35-04:00 New Revision: 0f1be87e294751a0941f1d9b7785ebf4d8072149 URL: https://github.com/llvm/llvm-project/commit/0f1be87e294751a0941f1d9b7785ebf4d8072149 DIFF:

[clang] 2d11ae0 - Fix a -Wparenthesis warning in 8ff44e644bb7, NFC

2020-09-02 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-09-02T15:01:54-04:00 New Revision: 2d11ae0a40e209a7b91aeff0c9cf28fe41dce93c URL: https://github.com/llvm/llvm-project/commit/2d11ae0a40e209a7b91aeff0c9cf28fe41dce93c DIFF:

[clang] 9523cf0 - [AST] Fix handling of long double and bool in __builtin_bit_cast

2020-09-02 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-09-02T15:01:53-04:00 New Revision: 9523cf02c22a83bece8d81080693a0cbf4098bb5 URL: https://github.com/llvm/llvm-project/commit/9523cf02c22a83bece8d81080693a0cbf4098bb5 DIFF:

[clang] d46f2c5 - Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

2020-09-02 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-09-02T12:19:12-04:00 New Revision: d46f2c51e4c849683434bb5a0fb6164957474b8f URL: https://github.com/llvm/llvm-project/commit/d46f2c51e4c849683434bb5a0fb6164957474b8f DIFF:

[clang] 8ff44e6 - [IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method

2020-09-02 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-09-02T12:19:11-04:00 New Revision: 8ff44e644bb70dfb8decc397a42679df6e6f8ba1 URL: https://github.com/llvm/llvm-project/commit/8ff44e644bb70dfb8decc397a42679df6e6f8ba1 DIFF:

[clang] a9a6e62 - [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

2020-08-31 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-08-31T10:12:17-04:00 New Revision: a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f URL: https://github.com/llvm/llvm-project/commit/a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f DIFF:

[clang-tools-extra] fc915d1 - [clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests

2020-08-12 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-08-12T12:12:10-04:00 New Revision: fc915d13b8671ceddea06e3f2f2d0e18869c41fe URL: https://github.com/llvm/llvm-project/commit/fc915d13b8671ceddea06e3f2f2d0e18869c41fe DIFF:

[clang] dafc310 - [Sema] Emit a -Wformat warning for printf("%s", (void*)p)

2020-07-10 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-07-10T15:10:24-04:00 New Revision: dafc3106d2069b806a10e072306a2196f1cda585 URL: https://github.com/llvm/llvm-project/commit/dafc3106d2069b806a10e072306a2196f1cda585 DIFF:

[clang] 2f71cf6 - [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

2020-07-07 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-07-07T13:29:54-04:00 New Revision: 2f71cf6d77c5cc679968851080d0513d84ddccb6 URL: https://github.com/llvm/llvm-project/commit/2f71cf6d77c5cc679968851080d0513d84ddccb6 DIFF:

[clang] 7437a94 - [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

2020-07-07 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-07-07T13:29:54-04:00 New Revision: 7437a9496528b838e6939dbcbb69a0acb5e1332d URL: https://github.com/llvm/llvm-project/commit/7437a9496528b838e6939dbcbb69a0acb5e1332d DIFF:

[clang] 69d2fa9 - [SemaObjC] Fix a crash on invalid when 'auto' is used in a @property

2020-06-24 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-06-24T12:11:39-04:00 New Revision: 69d2fa9ed1c1aba6f473feb03cad257e69a0cf52 URL: https://github.com/llvm/llvm-project/commit/69d2fa9ed1c1aba6f473feb03cad257e69a0cf52 DIFF:

[clang] 95d7ccb - [PCH] Support writing BuiltinBitCastExprs to PCHs

2020-06-11 Thread Erik Pilkington via cfe-commits
Author: hyd-dev Date: 2020-06-11T13:37:01-04:00 New Revision: 95d7ccb70b9cbd53f1f137c0b2411852c42c122b URL: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b DIFF: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b.diff LOG:

[clang] 8b529e3 - [ObjC] Fix AST serialization for pseudo-strong parameters

2020-06-08 Thread Erik Pilkington via cfe-commits
Author: David Goldman Date: 2020-06-08T11:54:01-04:00 New Revision: 8b529e311a9052ee7a0676a1b517728efa44a3ba URL: https://github.com/llvm/llvm-project/commit/8b529e311a9052ee7a0676a1b517728efa44a3ba DIFF: https://github.com/llvm/llvm-project/commit/8b529e311a9052ee7a0676a1b517728efa44a3ba.diff

[clang] 86e50af - [AST] Print fixed enum type regardless of language mode

2020-05-05 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 86e50af72d0a0f5cddd2cb487681709eda7934e8 URL: https://github.com/llvm/llvm-project/commit/86e50af72d0a0f5cddd2cb487681709eda7934e8 DIFF:

[clang] 873e279 - [SemaObjC] Add a warning for dictionary literals with duplicate keys

2020-05-05 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 873e279095391df347b58ba4bab26dbfecab1262 URL: https://github.com/llvm/llvm-project/commit/873e279095391df347b58ba4bab26dbfecab1262 DIFF:

[clang] 2bb686b - [AST] Fix a crash on a dependent vector_size attribute

2020-04-28 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-04-28T12:54:49-04:00 New Revision: 2bb686b4b629e3565dab239fd53b49f3a882d856 URL: https://github.com/llvm/llvm-project/commit/2bb686b4b629e3565dab239fd53b49f3a882d856 DIFF:

[clang] 85cca94 - [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

2020-04-20 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-04-20T15:22:51-04:00 New Revision: 85cca945b4c93ecfd3f3bb7a7b2d5fa4104c3560 URL: https://github.com/llvm/llvm-project/commit/85cca945b4c93ecfd3f3bb7a7b2d5fa4104c3560 DIFF:

[clang] d33c7de - [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

2020-04-06 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-04-06T16:04:13-04:00 New Revision: d33c7de8e11f2727ef5e325d931ae94af8619bf9 URL: https://github.com/llvm/llvm-project/commit/d33c7de8e11f2727ef5e325d931ae94af8619bf9 DIFF:

[clang] 75af694 - [CodeGenObjC] Place property names in __objc_methname

2020-03-10 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-03-10T14:31:00-07:00 New Revision: 75af694a6da5157cc6a688c2fa77ff5200f46e11 URL: https://github.com/llvm/llvm-project/commit/75af694a6da5157cc6a688c2fa77ff5200f46e11 DIFF:

[clang] 7fbf15a - [CodeGenObjC] Privatize some ObjC metadata symbols

2020-03-09 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-03-09T15:40:24-07:00 New Revision: 7fbf15a8f2df039cd47de7f2e98c4cd655d82e41 URL: https://github.com/llvm/llvm-project/commit/7fbf15a8f2df039cd47de7f2e98c4cd655d82e41 DIFF:

[clang] 29a4239 - [Sema] Fix a crash when attaching comments to an implicit decl

2020-03-02 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-03-02T16:49:53-08:00 New Revision: 29a4239d31c6d8ccc557afbe0999aa096ca95cc6 URL: https://github.com/llvm/llvm-project/commit/29a4239d31c6d8ccc557afbe0999aa096ca95cc6 DIFF:

[clang] e392dcd - [Sema] Look through OpaqueValueExpr when checking implicit conversions

2020-03-02 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-03-02T11:24:36-08:00 New Revision: e392dcd5708b3bb188ff4043b09ae151472a7632 URL: https://github.com/llvm/llvm-project/commit/e392dcd5708b3bb188ff4043b09ae151472a7632 DIFF:

[clang] 2e4f5e6 - [Sema] Fix an assert when objc_externally_retained was applied to an unprototyped function

2020-02-28 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-02-28T15:49:16-08:00 New Revision: 2e4f5e629de8ba77ae6facba5c595ef23d95acf4 URL: https://github.com/llvm/llvm-project/commit/2e4f5e629de8ba77ae6facba5c595ef23d95acf4 DIFF:

[clang] e26c24b - Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas"

2020-02-12 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-02-12T12:26:46-08:00 New Revision: e26c24b849211f35a988d001753e0cd15e4a9d7b URL: https://github.com/llvm/llvm-project/commit/e26c24b849211f35a988d001753e0cd15e4a9d7b DIFF:

[clang] fafc6e4 - [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2020-02-07 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-02-07T14:39:31-08:00 New Revision: fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402 URL: https://github.com/llvm/llvm-project/commit/fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402 DIFF:

[clang] d5e66f0 - NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr.

2019-12-10 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2019-12-10T16:54:48-08:00 New Revision: d5e66f0e060da7f175cedf4f545fb4e13df7707e URL: https://github.com/llvm/llvm-project/commit/d5e66f0e060da7f175cedf4f545fb4e13df7707e DIFF:

[clang] d9957c7 - [Sema] Add a 'Semantic' parameter to Expr::isKnownToHaveBooleanValue

2019-11-20 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2019-11-20T16:29:31-08:00 New Revision: d9957c7405bc726422dbc2736ad62f704916fbe8 URL: https://github.com/llvm/llvm-project/commit/d9957c7405bc726422dbc2736ad62f704916fbe8 DIFF:

[clang] 8bfb353 - [Sema] Fix a -Wobjc-signed-char-bool false-positive

2019-11-18 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2019-11-18T12:15:20-08:00 New Revision: 8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4 URL: https://github.com/llvm/llvm-project/commit/8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4 DIFF:

r373774 - [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

2019-10-04 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Oct 4 12:20:27 2019 New Revision: 373774 URL: http://llvm.org/viewvc/llvm-project?rev=373774=rev Log: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic The warnings now in -Wformat-type-confusion don't align with how we interpret 'pedantic' in clang, and

r372631 - NFC: Fix a poorly-written test

2019-09-23 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Sep 23 10:16:55 2019 New Revision: 372631 URL: http://llvm.org/viewvc/llvm-project?rev=372631=rev Log: NFC: Fix a poorly-written test The author of r364954 foolishly forgot that == binds tighter than ?: Modified: cfe/trunk/test/SemaCXX/constexpr-builtin-bit-cast.cpp

r372247 - [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

2019-09-18 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Sep 18 12:05:14 2019 New Revision: 372247 URL: http://llvm.org/viewvc/llvm-project?rev=372247=rev Log: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd Also, add a diagnostic under -Wformat for printing a boolean value as a character.

r372183 - [Sema] Split of versions of -Wimplicit-{float, int}-conversion for Objective-C BOOL

2019-09-17 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Sep 17 14:11:51 2019 New Revision: 372183 URL: http://llvm.org/viewvc/llvm-project?rev=372183=rev Log: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL Also, add a diagnostic group, -Wobjc-signed-char-bool, to control all these related

r372152 - Use 'BOOL' instead of BOOL in diagnostic messages

2019-09-17 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Sep 17 11:02:45 2019 New Revision: 372152 URL: http://llvm.org/viewvc/llvm-project?rev=372152=rev Log: Use 'BOOL' instead of BOOL in diagnostic messages Type names should be enclosed in single quotes. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

2019-09-05 Thread Erik Pilkington via cfe-commits
Hi Alexandre, Looks like this commit is causing crashes on darwin, can you take a look please? Here is a failing bot: http://lab.llvm.org:8080/green/job/clang-stage1-RA/1671/ Thanks! Erik On Thu, Sep 5, 2019 at 11:23 AM Alexandre Ganea via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

r370270 - Fix a passing XFAIL test

2019-08-28 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Aug 28 15:38:36 2019 New Revision: 370270 URL: http://llvm.org/viewvc/llvm-project?rev=370270=rev Log: Fix a passing XFAIL test Now that we can gracefully handle stack exhaustion, this test was passing in darwin && asan. Instead, just unsupport it when threading is

Re: r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Erik Pilkington via cfe-commits
This commit is causing test failures on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/1464/consoleFull#-18314650158254eaf0-7326-4999-85b0-388101f2d404

r368878 - [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey

2019-08-14 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Aug 14 09:57:11 2019 New Revision: 368878 URL: http://llvm.org/viewvc/llvm-project?rev=368878=rev Log: [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey Only honour format_arg attributes on -[NSBundle localizedStringForKey] when its argument has a

r368754 - Add a missing header comment, NFC

2019-08-13 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Aug 13 15:01:39 2019 New Revision: 368754 URL: http://llvm.org/viewvc/llvm-project?rev=368754=rev Log: Add a missing header comment, NFC Modified: cfe/trunk/lib/AST/FormatStringParsing.h Modified: cfe/trunk/lib/AST/FormatStringParsing.h URL:

Re: r368600 - [Sema] Require a complete type for __builtin_bit_cast operands

2019-08-12 Thread Erik Pilkington via cfe-commits
Sure, I fixed this in r368610. Erik > On Aug 12, 2019, at 11:39 AM, Richard Smith wrote: > > On Mon, 12 Aug 2019 at 11:30, Erik Pilkington via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: epilk > Date: Mon Aug 12 11:31:27 2019 > New Revi

r368610 - [Sema] Check __builtin_bit_cast operand for completeness before materializing it.

2019-08-12 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Aug 12 12:29:43 2019 New Revision: 368610 URL: http://llvm.org/viewvc/llvm-project?rev=368610=rev Log: [Sema] Check __builtin_bit_cast operand for completeness before materializing it. This shouldn't be observable, but it doesn't make sense to materialize an incomplete

r368600 - [Sema] Require a complete type for __builtin_bit_cast operands

2019-08-12 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Aug 12 11:31:27 2019 New Revision: 368600 URL: http://llvm.org/viewvc/llvm-project?rev=368600=rev Log: [Sema] Require a complete type for __builtin_bit_cast operands Fixes llvm.org/PR42936 Modified: cfe/trunk/lib/Sema/SemaCast.cpp

r367708 - Remove a dead diagnostic, NFC

2019-08-02 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Aug 2 12:25:58 2019 New Revision: 367708 URL: http://llvm.org/viewvc/llvm-project?rev=367708=rev Log: Remove a dead diagnostic, NFC This was issued in Objective-C 1 mode, but we not longer support that, so this is just unreachable. Modified:

r367367 - [Sema] Actually map a variable template specialization from pattern to instantiation

2019-07-30 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Jul 30 16:38:18 2019 New Revision: 367367 URL: http://llvm.org/viewvc/llvm-project?rev=367367=rev Log: [Sema] Actually map a variable template specialization from pattern to instantiation We were previously just using a specialization in the class template instead of

r367346 - [Parser] Lambda capture lists can start with '*'

2019-07-30 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Jul 30 12:21:20 2019 New Revision: 367346 URL: http://llvm.org/viewvc/llvm-project?rev=367346=rev Log: [Parser] Lambda capture lists can start with '*' Fixes llvm.org/PR42778 Modified: cfe/trunk/lib/Parse/ParseInit.cpp

r365518 - [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

2019-07-09 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Jul 9 10:29:40 2019 New Revision: 365518 URL: http://llvm.org/viewvc/llvm-project?rev=365518=rev Log: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL rdar://51954400 Differential revision: https://reviews.llvm.org/D63912 Added:

r365408 - [ObjC] Add a -Wtautological-compare warning for BOOL

2019-07-08 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Jul 8 16:42:52 2019 New Revision: 365408 URL: http://llvm.org/viewvc/llvm-project?rev=365408=rev Log: [ObjC] Add a -Wtautological-compare warning for BOOL On macOS, BOOL is a typedef for signed char, but it should never hold a value that isn't 1 or 0. Any code that

r364954 - [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

2019-07-02 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Jul 2 11:28:13 2019 New Revision: 364954 URL: http://llvm.org/viewvc/llvm-project?rev=364954=rev Log: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast This commit adds a new builtin, __builtin_bit_cast(T, v), which performs a bit_cast from a value v to a

r364489 - [ObjC] Improve error message for a malformed objc-type-name

2019-06-26 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Jun 26 16:39:23 2019 New Revision: 364489 URL: http://llvm.org/viewvc/llvm-project?rev=364489=rev Log: [ObjC] Improve error message for a malformed objc-type-name If the type didn't exist, we used to emit a really bad error: t.m:3:12: error: expected ')' -(nullable

r360802 - [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

2019-05-15 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed May 15 13:15:01 2019 New Revision: 360802 URL: http://llvm.org/viewvc/llvm-project?rev=360802=rev Log: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary Any of these methods can be overridden, so we need to invoke these functions. Differential revision:

r360446 - [Sema] Mark array element destructors referenced during initialization

2019-05-10 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri May 10 10:52:26 2019 New Revision: 360446 URL: http://llvm.org/viewvc/llvm-project?rev=360446=rev Log: [Sema] Mark array element destructors referenced during initialization This fixes a crash where we would neglect to mark a destructor referenced for an

r358200 - Add support for attributes on @implementations in Objective-C

2019-04-11 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Apr 11 10:55:30 2019 New Revision: 358200 URL: http://llvm.org/viewvc/llvm-project?rev=358200=rev Log: Add support for attributes on @implementations in Objective-C We want to make objc_nonlazy_class apply to implementations, but ran into this. There doesn't seem to be

r358201 - Support objc_nonlazy_class attribute on Objective-C implementations

2019-04-11 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Apr 11 10:55:34 2019 New Revision: 358201 URL: http://llvm.org/viewvc/llvm-project?rev=358201=rev Log: Support objc_nonlazy_class attribute on Objective-C implementations Fixes rdar://49523079 Differential revision: https://reviews.llvm.org/D60544 Modified:

r358136 - Fix a test, NFC

2019-04-10 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Apr 10 14:18:21 2019 New Revision: 358136 URL: http://llvm.org/viewvc/llvm-project?rev=358136=rev Log: Fix a test, NFC This test was duplicated, and the last declaration had some syntax errors since the invalid attribute caused the @implementation to be skipped by the

r357515 - [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

2019-04-02 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Apr 2 12:48:07 2019 New Revision: 357515 URL: http://llvm.org/viewvc/llvm-project?rev=357515=rev Log: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue This ability was removed in r351487, but it's needed when a lambda appears as an OpaqueValueExpr

r357516 - [Sema] Fix a use-after-deallocate of a ParsedAttr

2019-04-02 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Apr 2 12:48:11 2019 New Revision: 357516 URL: http://llvm.org/viewvc/llvm-project?rev=357516=rev Log: [Sema] Fix a use-after-deallocate of a ParsedAttr moveAttrFromListToList only makes sense when moving an attribute to a list with a pool that's either equivalent, or has

r357304 - [Sema] Avoid sending a dependent expression to the constant evaluator.

2019-03-29 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Mar 29 12:53:41 2019 New Revision: 357304 URL: http://llvm.org/viewvc/llvm-project?rev=357304=rev Log: [Sema] Avoid sending a dependent expression to the constant evaluator. Fixes llvm.org/PR41286 Modified: cfe/trunk/lib/Sema/SemaChecking.cpp

r357040 - [Sema] Fix an assert when a block captures a constexpr local

2019-03-26 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Mar 26 16:21:19 2019 New Revision: 357040 URL: http://llvm.org/viewvc/llvm-project?rev=357040=rev Log: [Sema] Fix an assert when a block captures a constexpr local MarkVarDeclODRUsed indirectly calls captureInBlock, which creates a copy expression. The copy expression is

r357041 - Emit -Wfortify-source using DiagRuntimeBehaviour

2019-03-26 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Mar 26 16:21:22 2019 New Revision: 357041 URL: http://llvm.org/viewvc/llvm-project?rev=357041=rev Log: Emit -Wfortify-source using DiagRuntimeBehaviour This fixes a false positive on the following, where st is configured to have different sizes based on some preprocessor

r356600 - Add a __has_extension check for '#pragma clang attribute' as an external-declaration

2019-03-20 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Mar 20 12:26:37 2019 New Revision: 356600 URL: http://llvm.org/viewvc/llvm-project?rev=356600=rev Log: Add a __has_extension check for '#pragma clang attribute' as an external-declaration This was added in r356075. Modified:

r356599 - [Sema] Deduplicate some availability checking logic

2019-03-20 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Mar 20 12:26:33 2019 New Revision: 356599 URL: http://llvm.org/viewvc/llvm-project?rev=356599=rev Log: [Sema] Deduplicate some availability checking logic Before this commit, we emit unavailable errors for calls to functions during overload resolution, and for references

r356515 - Add a spelling of pass_object_size that uses __builtin_dynamic_object_size

2019-03-19 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Mar 19 13:44:18 2019 New Revision: 356515 URL: http://llvm.org/viewvc/llvm-project?rev=356515=rev Log: Add a spelling of pass_object_size that uses __builtin_dynamic_object_size The attribute pass_dynamic_object_size(n) behaves exactly like pass_object_size(n), but

r356397 - [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

2019-03-18 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Mar 18 12:23:45 2019 New Revision: 356397 URL: http://llvm.org/viewvc/llvm-project?rev=356397=rev Log: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics These diagnose overflowing calls to subset of fortifiable functions. Some functions, like sprintf or strcpy

r356187 - [Sema] Fix a use-after-free of a _Nonnull ParsedAttr

2019-03-14 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Mar 14 11:38:02 2019 New Revision: 356187 URL: http://llvm.org/viewvc/llvm-project?rev=356187=rev Log: [Sema] Fix a use-after-free of a _Nonnull ParsedAttr We were allocating the implicit attribute in the declarator's attribute pool, but putting into the declaration

r356103 - Revert "Add a new attribute, fortify_stdlib"

2019-03-13 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Mar 13 14:37:01 2019 New Revision: 356103 URL: http://llvm.org/viewvc/llvm-project?rev=356103=rev Log: Revert "Add a new attribute, fortify_stdlib" This reverts commit r353765. After talking with our c stdlib folks, we decided to use the existing pass_object_size

r356087 - Fix a failing test.

2019-03-13 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Mar 13 12:20:45 2019 New Revision: 356087 URL: http://llvm.org/viewvc/llvm-project?rev=356087=rev Log: Fix a failing test. Modified: cfe/trunk/test/Parser/pragma-attribute-context.cpp Modified: cfe/trunk/test/Parser/pragma-attribute-context.cpp URL:

r356075 - [Parse] Parse '#pragma clang attribute' as an external-declaration

2019-03-13 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Mar 13 11:30:59 2019 New Revision: 356075 URL: http://llvm.org/viewvc/llvm-project?rev=356075=rev Log: [Parse] Parse '#pragma clang attribute' as an external-declaration Previously, we parsed it only in the top level, which excludes namespaces and extern "C" blocks.

r355054 - [CodeGen] Fix some broken IR generated by -fsanitize=unsigned-integer-overflow

2019-02-27 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Feb 27 16:47:55 2019 New Revision: 355054 URL: http://llvm.org/viewvc/llvm-project?rev=355054=rev Log: [CodeGen] Fix some broken IR generated by -fsanitize=unsigned-integer-overflow I think the author of the function assumed that `GetInsertBlock()` wouldn't change from

r354826 - [CodeGenObjC] Fix a nullptr dyn_cast

2019-02-25 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Feb 25 13:35:14 2019 New Revision: 354826 URL: http://llvm.org/viewvc/llvm-project?rev=354826=rev Log: [CodeGenObjC] Fix a nullptr dyn_cast ObjCMessageExpr::getInstanceReceiver returns nullptr if the receiver is 'super'. Make this check more strict, since we don't care

r354192 - Fix some tests I broke in r354190

2019-02-15 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Feb 15 17:51:19 2019 New Revision: 354192 URL: http://llvm.org/viewvc/llvm-project?rev=354192=rev Log: Fix some tests I broke in r354190 This was breaking on MSVC, since long double and double have the same semantics there. Modified:

r354190 - [Sema] Diagnose floating point conversions based on target semantics

2019-02-15 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Feb 15 17:11:47 2019 New Revision: 354190 URL: http://llvm.org/viewvc/llvm-project?rev=354190=rev Log: [Sema] Diagnose floating point conversions based on target semantics ...instead of just comparing rank. Also, fix a bad warning about _Float16, since its declared out of

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

2019-02-14 Thread Erik Pilkington via cfe-commits
Hans, can you merge this diagnostic regression fix into LLVM 8? Thanks! > On Feb 14, 2019, at 2:48 PM, Erik Pilkington via cfe-commits > wrote: > > Author: epilk > Date: Thu Feb 14 14:48:01 2019 > New Revision: 354074 > > URL: http://llvm.org/viewvc/llvm-project?rev=3

r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

2019-02-14 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Feb 14 14:48:01 2019 New Revision: 354074 URL: http://llvm.org/viewvc/llvm-project?rev=354074=rev Log: [Sema] Fix-up a -Wfloat-conversion diagnostic We were warning on valid ObjC property reference exprs, and passing in the wrong arguments to DiagnoseFloatingImpCast

r354056 - [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available

2019-02-14 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Feb 14 11:58:37 2019 New Revision: 354056 URL: http://llvm.org/viewvc/llvm-project?rev=354056=rev Log: [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available This provides a code size win on the caller side, since the init message send is done in the

Re: r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

2019-02-13 Thread Erik Pilkington via cfe-commits
being fixed is, but it caught my eye. > > From: cfe-commits <mailto:cfe-commits-boun...@lists.llvm.org>> on behalf of Erik Pilkington via > cfe-commits mailto:cfe-commits@lists.llvm.org>> > Reply-To: Erik Pilkington <mailto:erik.pilking...@gmail.com>> > Date: Wednesda

r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

2019-02-13 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Feb 13 12:32:37 2019 New Revision: 353976 URL: http://llvm.org/viewvc/llvm-project?rev=353976=rev Log: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method This fixes a regression that was caused by r335084, which reversed the

r353765 - Add a new attribute, fortify_stdlib

2019-02-11 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Feb 11 15:21:39 2019 New Revision: 353765 URL: http://llvm.org/viewvc/llvm-project?rev=353765=rev Log: Add a new attribute, fortify_stdlib This attribute applies to declarations of C stdlib functions (sprintf, memcpy...) that have known fortified variants (__sprintf_chk,

r353115 - [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has Class type

2019-02-04 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Feb 4 15:30:57 2019 New Revision: 353115 URL: http://llvm.org/viewvc/llvm-project?rev=353115=rev Log: [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has Class type rdar://47713266 Differential revision: https://reviews.llvm.org/D57712

r352687 - [CodeGenObjC] Handle exceptions when calling objc_alloc or objc_allocWithZone

2019-01-30 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Jan 30 15:17:38 2019 New Revision: 352687 URL: http://llvm.org/viewvc/llvm-project?rev=352687=rev Log: [CodeGenObjC] Handle exceptions when calling objc_alloc or objc_allocWithZone objc_alloc and objc_allocWithZone may throw exceptions if the underlying method does. If

Re: r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

2019-01-30 Thread Erik Pilkington via cfe-commits
Hans, can you cherry-pick this into LLVM 8? Thanks! On 1/30/19 1:14 PM, Erik Pilkington via cfe-commits wrote: Author: epilk Date: Wed Jan 30 13:14:08 2019 New Revision: 352672 URL: http://llvm.org/viewvc/llvm-project?rev=352672=rev Log: Don't define __has_feature(objc_fixed_enum) in non-objc

r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

2019-01-30 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Jan 30 13:14:08 2019 New Revision: 352672 URL: http://llvm.org/viewvc/llvm-project?rev=352672=rev Log: Don't define __has_feature(objc_fixed_enum) in non-objc mode This is only a formal language feature in ObjC, otherwise its just an extension. Making this change was also

r352664 - Add a 'dynamic' parameter to the objectsize intrinsic

2019-01-30 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Jan 30 12:34:35 2019 New Revision: 352664 URL: http://llvm.org/viewvc/llvm-project?rev=352664=rev Log: Add a 'dynamic' parameter to the objectsize intrinsic This is meant to be used with clang's __builtin_dynamic_object_size. When 'true' is passed to this parameter, the

r352665 - Add a new builtin: __builtin_dynamic_object_size

2019-01-30 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Jan 30 12:34:53 2019 New Revision: 352665 URL: http://llvm.org/viewvc/llvm-project?rev=352665=rev Log: Add a new builtin: __builtin_dynamic_object_size This builtin has the same UI as __builtin_object_size, but has the potential to be evaluated dynamically. It is meant to

r352239 - [Sema] Improve a -Warray-bounds diagnostic

2019-01-25 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Jan 25 12:52:45 2019 New Revision: 352239 URL: http://llvm.org/viewvc/llvm-project?rev=352239=rev Log: [Sema] Improve a -Warray-bounds diagnostic Fix a bug where we would compare array sizes with incompatible element types, and look through explicit casts.

r351595 - [Sema] Suppress a warning about a forward-declared fixed enum in C mode

2019-01-18 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Jan 18 13:33:23 2019 New Revision: 351595 URL: http://llvm.org/viewvc/llvm-project?rev=351595=rev Log: [Sema] Suppress a warning about a forward-declared fixed enum in C mode As of r343360, we support fixed-enums in C. This lead to some warnings in project headers where a

r351461 - [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible

2019-01-17 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Jan 17 10:18:53 2019 New Revision: 351461 URL: http://llvm.org/viewvc/llvm-project?rev=351461=rev Log: [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible If a class inherits from NSObject and has an implementation, then we can assume that ivar

Re: r350856 - Split -Wdelete-non-virtual-dtor into two groups

2019-01-14 Thread Erik Pilkington via cfe-commits
be handy to summarize the changes from the previous reverted version of this patch (& mention the original commit revision and revert revision) - in the commit message is ideal, but in a reply to the commit after the fact will do in a pinch On Fri, Jan 11, 2019 at 4:06 AM Erik Pilkington via

r351108 - Improve a -Wunguarded-availability note

2019-01-14 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Jan 14 11:17:31 2019 New Revision: 351108 URL: http://llvm.org/viewvc/llvm-project?rev=351108=rev Log: Improve a -Wunguarded-availability note Mention the deployment target, and don't say "partial" which doesn't really mean anything to users. rdar://problem/33601513

r350856 - Split -Wdelete-non-virtual-dtor into two groups

2019-01-10 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Jan 10 10:03:07 2019 New Revision: 350856 URL: http://llvm.org/viewvc/llvm-project?rev=350856=rev Log: Split -Wdelete-non-virtual-dtor into two groups This group controls two diagnostics: deleting an abstract class with a non-virtual dtor, which is a guaranteed crash, and

  1   2   3   4   >