r330692 - [libclang] Only mark CXCursors for explicit attributes with a type

Author: erikjv Date: Tue Apr 24 01:39:46 2018 New Revision: 330692 URL: http://llvm.org/viewvc/llvm-project?rev=330692=rev Log: [libclang] Only mark CXCursors for explicit attributes with a type All attributes have a source range associated with it. However, implicit attributes are added by the

r319881 - [libclang] Add function to get the buffer for a file

Author: erikjv Date: Wed Dec 6 01:02:52 2017 New Revision: 319881 URL: http://llvm.org/viewvc/llvm-project?rev=319881=rev Log: [libclang] Add function to get the buffer for a file This can be used by clients in conjunction with an offset returned by e.g. clang_getFileLocation. Now those clients

r318142 - [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

Author: erikjv Date: Tue Nov 14 01:34:39 2017 New Revision: 318142 URL: http://llvm.org/viewvc/llvm-project?rev=318142=rev Log: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS Enabled crash recovery for some libclang operations on a calling thread even when LIBCLANG_NOTHREAD is

r317308 - [preamble] Also record the "skipping" state of the preprocessor

Author: erikjv Date: Fri Nov 3 02:40:07 2017 New Revision: 317308 URL: http://llvm.org/viewvc/llvm-project?rev=317308=rev Log: [preamble] Also record the "skipping" state of the preprocessor When a preamble ends in a conditional preprocessor block that is being skipped, the preprocessor needs

r316436 - Do not add a colon chunk to the code completion of class inheritance access modifiers

Author: erikjv Date: Tue Oct 24 06:46:58 2017 New Revision: 316436 URL: http://llvm.org/viewvc/llvm-project?rev=316436=rev Log: Do not add a colon chunk to the code completion of class inheritance access modifiers With enabled CINDEXTEST_CODE_COMPLETE_PATTERNS env option (which enables

r312785 - Don't show deleted function (constructor) candidates for code completion

Author: erikjv Date: Fri Sep 8 03:23:08 2017 New Revision: 312785 URL: http://llvm.org/viewvc/llvm-project?rev=312785=rev Log: Don't show deleted function (constructor) candidates for code completion In case of copy constructor is implicitly deleted it's still shown. PR34402 describes a way to

r312780 - Fix templated type alias completion when using global completion cache

Author: erikjv Date: Fri Sep 8 02:31:13 2017 New Revision: 312780 URL: http://llvm.org/viewvc/llvm-project?rev=312780=rev Log: Fix templated type alias completion when using global completion cache When we have enabled cache for global completions we did not have diagnostics for Bar and could

r311990 - [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

Author: erikjv Date: Tue Aug 29 02:08:02 2017 New Revision: 311990 URL: http://llvm.org/viewvc/llvm-project?rev=311990=rev Log: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit* Looks like this one was forgotten for clang_parseTranslationUnit*, as LIBCLANG_NOTHREADS is checked

r311445 - Revert r311442 (Fix templated type alias completion when using global completion cache)

Author: erikjv Date: Tue Aug 22 03:54:40 2017 New Revision: 311445 URL: http://llvm.org/viewvc/llvm-project?rev=311445=rev Log: Revert r311442 (Fix templated type alias completion when using global completion cache) Failing Tests (2): Clang :: CXX/dcl.dcl/dcl.spec/dcl.type/p3-0x.cpp

r311442 - Fix templated type alias completion when using global completion cache

Author: erikjv Date: Tue Aug 22 03:25:48 2017 New Revision: 311442 URL: http://llvm.org/viewvc/llvm-project?rev=311442=rev Log: Fix templated type alias completion when using global completion cache When we have enabled cache for global completions we did not have diagnostics for Bar and could

r308438 - Fix compilation problem introduced in r308433

Author: erikjv Date: Wed Jul 19 04:15:36 2017 New Revision: 308438 URL: http://llvm.org/viewvc/llvm-project?rev=308438=rev Log: Fix compilation problem introduced in r308433 Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp URL:

r308433 - Add default values for function parameter chunks

Author: erikjv Date: Wed Jul 19 03:45:40 2017 New Revision: 308433 URL: http://llvm.org/viewvc/llvm-project?rev=308433=rev Log: Add default values for function parameter chunks Append optional chunks with their default values. For example: before - "int i", after - "int i = 10" Patch by Ivan

r308012 - [analyzer] Add annotation for functions taking user-facing strings

Author: erikjv Date: Fri Jul 14 03:24:36 2017 New Revision: 308012 URL: http://llvm.org/viewvc/llvm-project?rev=308012=rev Log: [analyzer] Add annotation for functions taking user-facing strings There was already a returns_localized_nsstring annotation to indicate that the return value could be

Re: r304207 - Allow for unfinished #if blocks in preambles

> On 30. Jun 2017, at 16:31, Erik Verbruggen via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > >> On 23. Jun 2017, at 23:54, Richard Smith <rich...@metafoo.co.uk >> <mailto:rich...@metafoo.co.uk>> wrote: >> >> On 23 June 2017 at 1

r307134 - Fix invalid warnings for header guards in preambles

Author: erikjv Date: Wed Jul 5 02:44:07 2017 New Revision: 307134 URL: http://llvm.org/viewvc/llvm-project?rev=307134=rev Log: Fix invalid warnings for header guards in preambles Fixes https://bugs.llvm.org/show_bug.cgi?id=33574 Differential Revision: https://reviews.llvm.org/D34882

Re: r304207 - Allow for unfinished #if blocks in preambles

> On 23. Jun 2017, at 23:54, Richard Smith wrote: > > On 23 June 2017 at 13:34, Benjamin Kramer via cfe-commits > > wrote: > Since this change went in I'm seeing spurious errors whenever editing > a header

r305061 - Speed up preamble loading

Author: erikjv Date: Fri Jun 9 03:29:58 2017 New Revision: 305061 URL: http://llvm.org/viewvc/llvm-project?rev=305061=rev Log: Speed up preamble loading Cache filename - SourceLocation pairs to speed up preamble loading and global completion. This is especially relevant for windows, where

r304212 - [libclang] Allow to suspend a translation unit.

Author: erikjv Date: Tue May 30 09:25:54 2017 New Revision: 304212 URL: http://llvm.org/viewvc/llvm-project?rev=304212=rev Log: [libclang] Allow to suspend a translation unit. A suspended translation unit uses significantly less memory but on the other side does not support any other calls than

r304207 - Allow for unfinished #if blocks in preambles

Author: erikjv Date: Tue May 30 06:54:55 2017 New Revision: 304207 URL: http://llvm.org/viewvc/llvm-project?rev=304207=rev Log: Allow for unfinished #if blocks in preambles Previously, a preamble only included #if blocks (and friends like ifdef) if there was a corresponding #endif before any

r298905 - FileManager: mark virtual file entries as valid entries

Author: erikjv Date: Tue Mar 28 04:18:05 2017 New Revision: 298905 URL: http://llvm.org/viewvc/llvm-project?rev=298905=rev Log: FileManager: mark virtual file entries as valid entries The getVirtualFile method would create entries for e.g. libclang's CXUnsavedFile but not mark them as valid. The

r298903 - [libclang] Fix crash in member access code completion with implicit base

Author: erikjv Date: Tue Mar 28 02:22:21 2017 New Revision: 298903 URL: http://llvm.org/viewvc/llvm-project?rev=298903=rev Log: [libclang] Fix crash in member access code completion with implicit base If there is an unresolved member access AST node, and the base is implicit, do not access/use

r295301 - Cache FileID when translating diagnostics in PCH files

Author: erikjv Date: Thu Feb 16 03:49:30 2017 New Revision: 295301 URL: http://llvm.org/viewvc/llvm-project?rev=295301=rev Log: Cache FileID when translating diagnostics in PCH files Modules/preambles/PCH files can contain diagnostics, which, when used, are added to the current ASTUnit. For that

[PATCH] D25990: Sema: do not warn about unused const vars if main file is a header

erikjv closed this revision. erikjv added a comment. Committed as r285386. https://reviews.llvm.org/D25990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285386 - Sema: do not warn about unused const vars if main file is a header

Author: erikjv Date: Fri Oct 28 03:28:42 2016 New Revision: 285386 URL: http://llvm.org/viewvc/llvm-project?rev=285386=rev Log: Sema: do not warn about unused const vars if main file is a header If we pass a header to libclang, e.g. because it's open in an editor in an IDE, warnings about unused

r285295 - Do not print include_next/pragma once warnings when input is a header.

Author: erikjv Date: Thu Oct 27 09:17:10 2016 New Revision: 285295 URL: http://llvm.org/viewvc/llvm-project?rev=285295=rev Log: Do not print include_next/pragma once warnings when input is a header. r276653 suppressed the pragma once warning when generating a PCH file. This patch extends that to

[PATCH] D25989: Do not print include_next/pragma once warnings when input is a header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285295: Do not print include_next/pragma once warnings when input is a header. (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D25989?vs=75890=76024#toc Repository: rL LLVM

r285287 - Add const versions of Expr::getInits() and Expr::inits()

Author: erikjv Date: Thu Oct 27 07:12:08 2016 New Revision: 285287 URL: http://llvm.org/viewvc/llvm-project?rev=285287=rev Log: Add const versions of Expr::getInits() and Expr::inits() Modified: cfe/trunk/include/clang/AST/Expr.h Modified: cfe/trunk/include/clang/AST/Expr.h URL:

r285275 - Mark invalid RecordDecls as completed.

Author: erikjv Date: Thu Oct 27 03:37:14 2016 New Revision: 285275 URL: http://llvm.org/viewvc/llvm-project?rev=285275=rev Log: Mark invalid RecordDecls as completed. Sema::ActOnTag creates TagDecls for records. However, if those record declarations are invalid, and the parser is in C++ mode, it

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2061-2062 + auto Builder = Diag(R.getNameLoc(), diagnostic) << Name; + if (Name.isIdentifier()) +Builder << SourceRange(R.getNameLoc()); return true; rsmith wrote: > I'm indifferent on this

[PATCH] D25990: Sema: do not warn about unused const vars if main file is a header

erikjv created this revision. erikjv added a reviewer: bkramer. erikjv added a subscriber: cfe-commits. If we pass a header to libclang, e.g. because it's open in an editor in an IDE, warnings about unused const vars are not useful: other files that include the header might use those constants.

[PATCH] D25989: Do not print include_next/pragma once warnings when input is a header.

erikjv created this revision. erikjv added a reviewer: bkramer. erikjv added a subscriber: cfe-commits. r276653 suppressed the pragma once warning when generating a PCH file. This patch extends that to any main file for which clang is told (with the -x option) that it's a header file. It will

r285193 - [PP] Replace some index based for loops with range based ones

Author: erikjv Date: Wed Oct 26 08:06:13 2016 New Revision: 285193 URL: http://llvm.org/viewvc/llvm-project?rev=285193=rev Log: [PP] Replace some index based for loops with range based ones While in the area, also change some unsigned variables to size_t, and introduce an LLVM_FALLTHROUGH

[PATCH] D25982: [PP] Replace some index based for loops with range based ones

This revision was automatically updated to reflect the committed changes. Closed by commit rL285193: [PP] Replace some index based for loops with range based ones (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D25982?vs=75854=75867#toc Repository: rL LLVM

[PATCH] D25982: [PP] Replace some index based for loops with range based ones

erikjv updated this revision to Diff 75854. erikjv marked an inline comment as done. https://reviews.llvm.org/D25982 Files: lib/Lex/PPCaching.cpp lib/Lex/PPLexerChange.cpp lib/Lex/PPMacroExpansion.cpp lib/Lex/Pragma.cpp lib/Lex/TokenConcatenation.cpp lib/Lex/TokenLexer.cpp Index:

[PATCH] D25981: [PP] Remove another unused parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL285188: [PP] Remove another unused parameter (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D25981?vs=75850=75853#toc Repository: rL LLVM https://reviews.llvm.org/D25981

r285188 - [PP] Remove another unused parameter

Author: erikjv Date: Wed Oct 26 06:46:10 2016 New Revision: 285188 URL: http://llvm.org/viewvc/llvm-project?rev=285188=rev Log: [PP] Remove another unused parameter Differential Revision: http://reviews.llvm.org/D25981 Modified: cfe/trunk/include/clang/Lex/Preprocessor.h

[PATCH] D25982: [PP] Replace some index based for loops with range based ones

erikjv created this revision. erikjv added a reviewer: bkramer. erikjv added a subscriber: cfe-commits. Herald added subscribers: anna, nemanjai. While in the area, also change some unsigned variables to size_t, and introduce an LLVM_FALLTHROUGH instead of a comment stating that.

[PATCH] D25981: [PP] Remove another unused parameter

erikjv created this revision. erikjv added a reviewer: bkramer. erikjv added a subscriber: cfe-commits. https://reviews.llvm.org/D25981 Files: include/clang/Lex/Preprocessor.h lib/Lex/Pragma.cpp Index: lib/Lex/Pragma.cpp ===

[PATCH] D25939: PP: Replace some uses of unsigned with size_t

This revision was automatically updated to reflect the committed changes. Closed by commit rL285182: [PP] Replace some uses of unsigned with size_t (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D25939?vs=75836=75841#toc Repository: rL LLVM

r285182 - [PP] Replace some uses of unsigned with size_t

Author: erikjv Date: Wed Oct 26 04:58:31 2016 New Revision: 285182 URL: http://llvm.org/viewvc/llvm-project?rev=285182=rev Log: [PP] Replace some uses of unsigned with size_t All values are returned by a method as size_t, and subsequently passed to functions taking a size_t, or used where a

[PATCH] D25938: PP: Remove unused parameters from methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL285180: PP: Remove unused parameters from methods (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D25938?vs=75693=75837#toc Repository: rL LLVM

[PATCH] D25939: PP: Replace some uses of unsigned with size_t

erikjv updated the summary for this revision. erikjv updated this revision to Diff 75836. https://reviews.llvm.org/D25939 Files: lib/Lex/PPDirectives.cpp Index: lib/Lex/PPDirectives.cpp === --- lib/Lex/PPDirectives.cpp +++

[PATCH] D25938: PP: Remove unused parameters from methods

erikjv created this revision. erikjv added a reviewer: bkramer. erikjv added a subscriber: cfe-commits. NFC https://reviews.llvm.org/D25938 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPDirectives.cpp Index: lib/Lex/PPDirectives.cpp

[PATCH] D25870: Fix 'unknown documentation command' warning ranges

erikjv closed this revision. erikjv added a comment. r285056 https://reviews.llvm.org/D25870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25871: Include full filename range for missing includes

erikjv closed this revision. erikjv added a comment. r285057 https://reviews.llvm.org/D25871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285057 - Include full filename range for missing includes

Author: erikjv Date: Tue Oct 25 05:13:10 2016 New Revision: 285057 URL: http://llvm.org/viewvc/llvm-project?rev=285057=rev Log: Include full filename range for missing includes For the purpose of highlighting in an IDE. Added: cfe/trunk/test/Preprocessor/missing-include-range-check.h

r285056 - Fix 'unknown documentation command' warning ranges

Author: erikjv Date: Tue Oct 25 05:06:11 2016 New Revision: 285056 URL: http://llvm.org/viewvc/llvm-project?rev=285056=rev Log: Fix 'unknown documentation command' warning ranges Warnings generated by -Wdocumentation-unknown-command did only have a start location, not a full source range. This

[PATCH] D25870: Fix 'unknown documentation command' warning ranges

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Warnings generated by -Wdocumentation-unknown-command did only have a start location, not a full source range. This resulted in only the "carret" being show in messages, and IDEs

[PATCH] D25871: Include full filename range for missing includes

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. For the purpose of highlighting in an IDE. https://reviews.llvm.org/D25871 Files: lib/Lex/PPDirectives.cpp test/Preprocessor/missing-include-range-check.h Index:

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv added a comment. Yes, the patch was not committed, because there were errors in it. So, I fixed it and put up a new version, but I have no idea how to reset the state. Still waiting for rsmith to review... https://reviews.llvm.org/D15994

Re: [PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated the summary for this revision. erikjv updated this revision to Diff 62748. erikjv added a comment. This version stores/loads the conditional stack in the preprocessor the the generated pch file. It suppresses errors about unfinished conditional preprocessor blocks, and after

Re: [PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv added a comment. I'll add tests in the next diff, but I'd like to know if these changes are ok. Comment at: lib/Sema/SemaType.cpp:1339 @@ +1338,3 @@ +auto R = DS.getSourceRange(); +if (R.getEnd().isInvalid()) + R.setEnd(R.getBegin());

Re: [PATCH] D15926: Do not print certain warnings when input is a header.

erikjv added a comment. ping? http://reviews.llvm.org/D15926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21176: Mark invalid RecordDecls as completed.

erikjv created this revision. erikjv added a reviewer: rsmith. erikjv added a subscriber: cfe-commits. Sema::ActOnTag creates TagDecls for records. However, if those record declarations are invalid, and the parser is in C++ mode, it would silently drop the TagDecl (and leave it as

Re: [PATCH] D15926: Do not print certain warnings when input is a header.

erikjv updated this revision to Diff 60023. http://reviews.llvm.org/D15926 Files: include/clang/Basic/LangOptions.h lib/Frontend/CompilerInvocation.cpp lib/Lex/PPDirectives.cpp lib/Lex/PPMacroExpansion.cpp lib/Lex/Pragma.cpp test/Preprocessor/header_is_main_file.c Index:

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv abandoned this revision. erikjv added a comment. Wrong patch http://reviews.llvm.org/D21074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv abandoned this revision. erikjv added a comment. This will give errors about unbalanced #if/#endif for header guards. http://reviews.llvm.org/D15994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv created this revision. erikjv added a reviewer: bkramer. erikjv added a subscriber: cfe-commits. Previously, a preamble only included #if blocks (and friends like #ifdef) if there was a corresponding #endif before any declaration or definition. The problem is that any header file that uses

[PATCH] D15926: Do not print certain warnings when input is a header.

erikjv created this revision. erikjv added reviewers: klimek, rsmith. erikjv added a subscriber: cfe-commits. When generating pre-compiled headers, or when opening a header file with libclang, suppress the warnings "#pragma once in main file" and "#include_next in primary source file". Fixes

r256939 - Show inclusions from a preamble in clang_getInclusions.

Author: erikjv Date: Wed Jan 6 09:12:51 2016 New Revision: 256939 URL: http://llvm.org/viewvc/llvm-project?rev=256939=rev Log: Show inclusions from a preamble in clang_getInclusions. When reparsing a translation unit with preamble generation turned on, no includes are found. This is due to the

Re: [PATCH] D14329: Show inclusions from a preamble in clang_getInclusions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL256939: Show inclusions from a preamble in clang_getInclusions. (authored by erikjv). Changed prior to commit: http://reviews.llvm.org/D14329?vs=39187=44120#toc Repository: rL LLVM

r252045 - Initialize member field.

Author: erikjv Date: Wed Nov 4 08:34:43 2015 New Revision: 252045 URL: http://llvm.org/viewvc/llvm-project?rev=252045=rev Log: Initialize member field. Modified: cfe/trunk/include/clang/Frontend/FrontendOptions.h Modified: cfe/trunk/include/clang/Frontend/FrontendOptions.h URL:

Re: [PATCH] D11752: [X86] Pre-define __MOVBE__ when the target supports it.

erikjv added a comment. GCC doesn't define this, but icc does. Just like e.g. __AVX512CD__, it can be used to conditionally enable code that uses the instruction as a fast implementation for an algorithm. http://reviews.llvm.org/D11752 ___

[PATCH] D14329: Show inclusions from a preamble in clang_getInclusions.

erikjv created this revision. erikjv added a reviewer: klimek. erikjv added a subscriber: cfe-commits. When reparsing a translation unit with preamble generation turned on, no includes are found. This is due to the fact that all SLocs from AST/PCH files are skipped as they are 'loaded', and