[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay added a comment. In D157933#4591627 , @ABataev wrote: > Could you also add the nesting tests for outer scope directive? Currently it > tests only for inner Added. Please take a look. CHANGES SINCE LAST ACTION

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay updated this revision to Diff 550521. mdfazlay added a comment. Updated nesting of regions checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933 Files: clang/include/clang-c/Index.h

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay added a comment. In D157933#4586816 , @ABataev wrote: > Need to add the tests (and the checks, if required) for the nesting of the > regions I think I have the nesting of regions checks in //scope_messages.cpp//. Do you prefer to have those

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay created this revision. mdfazlay added reviewers: ABataev, jyu2, mikerice. Herald added subscribers: steakhal, martong, arphaman, guansong, yaxunl. Herald added a reviewer: NoQ. Herald added a project: All. mdfazlay requested review of this revision. Herald added a reviewer: jdoerfert.

[PATCH] D155635: [OpenMP] [Reduction] Allow PLUS (+) operator on reduction clauses in OMP > 52

mdfazlay added a comment. In D155635#4512243 , @ABataev wrote: > In D155635#4512188 , @mdfazlay > wrote: > >> In D155635#4512183 , @ABataev >> wrote: >> >>> Tests? >>

[PATCH] D155635: [OpenMP] [Reduction] Allow PLUS (+) operator on reduction clauses in OMP > 52

mdfazlay added a comment. In D155635#4512183 , @ABataev wrote: > Tests? I think I need to use `-fopenmp-version=60` to test this revision. As OMP 6.0 is not official yet, am I allowed to use `-fopenmp-version=60` in my LIT test? Repository: rG LLVM

[PATCH] D155635: [OpenMP] [Reduction] Allow PLUS (+) operator on reduction clauses in OMP > 52

mdfazlay created this revision. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. mdfazlay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. Currently,

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

mdfazlay closed this revision. mdfazlay added a comment. Commit ID - c657363 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150394/new/ https://reviews.llvm.org/D150394

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

mdfazlay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10487-10488 "a reduction list item with incomplete type %0">; +def err_omp_reduction_minus_type : Error< + "a reduction list item with minus(-) operator is not supported">; +def

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

mdfazlay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10490 +def warn_omp_minus_in_reduction_deprecated : Warning< + "minus(-) operator for reductions is deprecated; use an user defined reduction instead">, + InGroup;

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

mdfazlay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10490 +def warn_omp_minus_in_reduction_deprecated : Warning< + "minus(-) operator for reductions is deprecated; use an user defined reduction instead">, + InGroup;

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay updated this revision to Diff 495196. mdfazlay added a comment. @ABataev, I have addressed your last two comments and updated the diff. Please take a look at your convenient time :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143021/new/ https://reviews.llvm.org/D143021

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay added a comment. Updated the diff. Please take a look. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:496 +def err_destroy_clause_without_argument +: Error<"'destroy' clause without argument on '#pragma omp depobj' " ABataev

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay updated this revision to Diff 494415. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143021/new/ https://reviews.llvm.org/D143021 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/depobj_messages.cpp Index:

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay created this revision. mdfazlay added reviewers: ABataev, mikerice, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. mdfazlay requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Deprecate

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay updated this revision to Diff 476259. mdfazlay added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added corresponding definitions in// llvm/include/llvm/Frontend/OpenMP/OMP.td// file. CHANGES SINCE LAST ACTION

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay added a comment. In D138217#3934677 , @ABataev wrote: > Looks like you dud not add corresponding definitions to llvm/Frontend Do you mean in //llvm/include/llvm/Frontend/OpenMP/OMP.td// file? CHANGES SINCE LAST ACTION

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay updated this revision to Diff 476197. mdfazlay added a comment. Added static_cast<>. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138217/new/ https://reviews.llvm.org/D138217 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay updated this revision to Diff 476191. mdfazlay marked 2 inline comments as done. mdfazlay added a comment. > 1. Add full diff context > 2. Add unsuccessful tests for the modifier (parsing and sema) 1. Done 2. I am not quite sure about it it. We have two new tests for ast and message.

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay created this revision. mdfazlay added reviewers: ABataev, mikerice, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. mdfazlay requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

mdfazlay added inline comments. Comment at: clang/include/clang-c/Index.h:2641 */ - CXCursor_TranslationUnit = 300, + CXCursor_TranslationUnit = 350, ABataev wrote: > Does this change affect anything else in the compiler? We had to add and keep the

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

mdfazlay updated this revision to Diff 436994. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127454/new/ https://reviews.llvm.org/D127454 Files: clang/bindings/python/clang/cindex.py clang/include/clang-c/Index.h

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

mdfazlay updated this revision to Diff 436589. mdfazlay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added erroneous tests, nesting of regions test and analysis tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION