[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 526163. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D151076: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0687b47a0ce: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151059: [test] Add C++ ext_vector_type tests

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151059/new/ https://reviews.llvm.org/D151059

[PATCH] D151061: [test] Add ext_vector_type tests for C

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/ https://reviews.llvm.org/D151061

[PATCH] D146987: [Assignment Tracking] Enable by default

fhahn added a comment. Looks like this is causing a crash on current `main`: https://github.com/llvm/llvm-project/issues/62838 Please take a look and revert the commit if it requires longer to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151061: [test] Add ext_vector_type tests for C

fhahn added a comment. Thanks for texting the test coverage! Comment at: clang/test/Sema/ext_vector_ops.c:30 +void test_int_vector_scalar(unsigned int ua, v2u v2ua) { + // Integer vector vs integer operators. These will splat + (void)(v2ua + ua); Not sure if

[PATCH] D151076: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

fhahn created this revision. fhahn added reviewers: rjmccall, aaron.ballman, efriedma. Herald added a subscriber: StephenFan. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is an infinite cycle

[PATCH] D148381: [WIP][Clang] Add element_count attribute

fhahn added reviewers: rapidsna, fcloutier. fhahn added a comment. Adding a few people who have been working on `-fbounds-safety` proposal (https://llvm.swoogo.com/2023eurollvm/session/1414468/keynote-“-fbounds-safety”-enforcing-bounds-safety-for-production-c-code) Repository: rG LLVM Github

[PATCH] D149006: [llvm][Support] Replace `%` operator with `&` in `Align::isAligned(...)`

fhahn added a comment. > it is easier to check reminder by conjunction with mask, which is (Pow2Value > - 1). Hmm, easier in what respect? Isn't the original code more straight-forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149006/new/

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

fhahn resigned from this revision. fhahn added a comment. Sorry, I am not familiar at all with this code. Perhaps @shafik could suggest more appropriate reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148944/new/

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn added a comment. In D122573#4125641 , @bipmis wrote: > @fhahn We are also observing scenarios where this maybe necessary. A couple > of points on where it may be missing > > 1. createScalarTypeNode(OutName, AnyPtr, Size) -> This will generate >

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://reviews.llvm.org/D145270

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:643 + T __builtin_elementwise_exp(T x)returns the base-e exponential, or e^x, of the specified value floating point types + T __builtin_elementwise_exp2(T x) returns the base-2

[PATCH] D145151: clang: Handle MatrixType in hasFloatingRepresentation

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145151/new/ https://reviews.llvm.org/D145151 ___ cfe-commits mailing list

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 502607. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! > The __builtin_align_{up,down} code generation could also make use of this > IIRC. I think the reason I didn't do this initially was concerns about > ptrmask not being optimized

[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jobnoorman. LGTM, thanks! Looks like a straight-forward extension of the existing builtins. Comment at:

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn added a comment. Using `ptrmask` here looks good to me, but it looks like a couple of tests need still updating; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 ___ cfe-commits mailing list

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM ,thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422

[PATCH] D133574: [C2x] reject type definitions in offsetof

fhahn added a comment. In D133574#4053647 , @aaron.ballman wrote: > I'll take care of fixing this up on Tuesday (Mon is a holiday here), but if > anyone wants to get to it sooner, what I plan to do is: > > - Add a new `Extension` diagnostic about

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, but please make sure the `.rst` file builds with `sphinx`. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than x + T__builtin_elementwise_canonicalize(T x) return the platform specific canonical encoding of a floating-point number

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950883 , @lenary wrote: > In D137836#3950846 , @fhahn wrote: > >> (it looks like this job should have sent an email: >>

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. (it looks like this job should have sent an email: https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950825 , @lenary wrote: > In D137836#3950815 , @fhahn wrote: > >> Unfortunately it looks like this commit breaks building on ARM64 macOS. I >> reverted the change for now and

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. Unfortunately it looks like this commit breaks building on ARM64 macOS. I reverted the change for now and added more details on the error in the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn commandeered this revision. fhahn added a reviewer: CJ-Johnson. fhahn added a comment. Commandeering after the recent updates to make review + follow-ups easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

fhahn accepted this revision. fhahn added a comment. LGTM with the suggested changes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

fhahn added a comment. It looks like GISel crashes when building `llvm-test-suite` with -O3 on ARM64. If it isn't trivial to fix we should probably revert the patch to bring things back to green. Reproducer: ; llc -global-isel -O3 target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn updated this revision to Diff 469329. fhahn added a comment. Rebased on current main In D122573#3630767 , @rui.zhang wrote: > I like the direction where this change is leading to and hope there is some > way to land it incrementally. Since

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 469270. fhahn added a comment. Rebase on top of current `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

fhahn added a comment. > Adding this metadata allows {loop.vectorize.enable, false} to be used without > disabling the whole pass. Could you please describe the behavior in more detail here? The new metadata should also be documented in `LangRef`, the new pragma in

[PATCH] D135011: Add sin and cos llvm intrinsics

fhahn added a comment. Could you update the title to make it clear this adds new Clang builtins, not intrinsics (they are lowered to LLVM intrinsics). The behavior of the new builtins should be specified in `LanguageExtensions.rst`

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. Herald added a project: All. In D106005#2904865 , @SaurabhJha wrote: > In D106005#2904424 , @fhahn wrote: > >> In D106005#2896080 , @SaurabhJha

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! You might want to extend the windows check lines to the other tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

fhahn added a comment. In D134441#3808655 , @sgraenitz wrote: > The symptom is that Clang emits `movq %rax, %rdi` instead of `movq %rax, > %rcx` while `objc_retainAutoreleasedReturnValue()` still expects the value in > `%rcx`. > It appears related to

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

fhahn added a comment. In D134316#3808544 , @jloser wrote: > This landed with > https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. > The revision didn't auto-close for some reason. You need to make sure the commit

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. In D133737#3787066 , @RKSimon wrote: > The elementwise builtins should work for scalars as well (and IIRC we do test > this as well). Yep they should, it is specially specified here:

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. I'm not familiar with HLSL but I think making use of the existing vector builtins makes sense here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn abandoned this revision. fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. As of now, I don't think this is safe to do with the precision guarantees Darwin_libsystem_m provides unfortunately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn updated this revision to Diff 458407. fhahn added a comment. Rebase and ping :) The potential benefit of having -m flags is also mentioned in this recent bug report: https://github.com/llvm/llvm-project/issues/57588 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132488: [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2.cmake

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132488/new/ https://reviews.llvm.org/D132488

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. @john.brawn Are you OK with treating those functions as not setting inexact, as per the C23 clarification, as the committed version does? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. In D129231#3716363 , @scanon wrote: >>> Looking at implementations of these functions, it looks like GNU libm >>> doesn't raise inexact, but the bionic libm does. I think I'm leaning >>> towards marking all of them as "fng" as

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES)

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef110a491f70: [Builtins] Do not claim most libfuncs are readnone with trapping math. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D129231?vs=448628=451800#toc Repository:

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D129231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

fhahn added a comment. In D122768#3700486 , @cor3ntin wrote: > In D122768#3700451 , @aeubanks > wrote: > >> in the commit message >> >> In addition, capturing an anonymous union member, >> a bitfield, or a

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

fhahn added a comment. Looks like a nice improvement, thanks! Comment at: llvm/unittests/ADT/SmallVectorTest.cpp:867 - template - static unsigned NumBuiltinElts(const SmallVector&) { return N; } }; This seems like an unrelated change unless I am missing

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn updated this revision to Diff 448628. fhahn added a comment. In D129231#3638946 , @john.brawn wrote: > Looking at the descriptions of maths functions in C99 (and I expect C11 will > be the same) it looks like there are three kinds: > > - Those

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

fhahn added a comment. In D128955#3679418 , @tejohnson wrote: > lgtm > > In D128955#3676478 , @aeubanks > wrote: > >> In D128955#3676198 , @tejohnson >> wrote: >> >>>

[PATCH] D128927: [libc++] Always build c++experimental.a

fhahn added a comment. It looks like this is causing macOS builds to fail on GreenDragon. Please take a look and refer the commit if it takes longer to resolve, as the bot has been red for a while now. [3495/5980]

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn created this revision. fhahn added reviewers: kpn, efriedma, scanon, john.brawn, sepavloff. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. At the moment, Clang only considers errno when deciding if a builtin is const. This ignores the

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 440264. fhahn added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

fhahn added a comment. It looks like this commit is breaking bootstrap builds of LLVM/Clang, e.g. https://lab.llvm.org/buildbot/#/builders/37/builds/14224 FAILED: lib/Bitcode/Reader/CMakeFiles/LLVMBitReader.dir/BitcodeReader.cpp.o

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 435508. fhahn added a comment. Add TySan library when building on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 434471. fhahn added a comment. Rebase & address comments, thanks! Also update the code to link tysan runtime with static linking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

fhahn added a comment. In D124836#3528109 , @vvereschaka wrote: > Hi @void , > > the `zero-call-used-regs.ll` test gets failed on > `llvm-clang-x86_64-expensive-checks-ubuntu` builder with the following errors: > > ... > *** Bad machine code:

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks for breaking this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122126/new/ https://reviews.llvm.org/D122126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn accepted this revision. fhahn added a comment. Still LGTM, thanks! The remaining suggestion can be addressed directly before committing the patch. Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:324 + /// Check if the number of runtime checks

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn accepted this revision. fhahn added a comment. LGTM with additional suggestions inline, thanks! Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10462 +} else { + ORE->emit([&]() { +return OptimizationRemarkAnalysisAliasing( I

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

fhahn added a comment. In D124699#3507250 , @qcolombet wrote: > Thanks @thakis ! > > @fhahn are you okay with the clang tests update as well? Yes looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. In D113779#3207936 , @SjoerdMeijer wrote: >> If anybody has contacts to GCC that would be very helpful. Unfortunately I >> don't think I will be able to drive this.

[PATCH] D117829: [Clang] Add integer mul reduction builtin

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! IIRC @scanon had some opinions about `__builtin_reduce_mul` during some earlier discussions. Please wait a few days in case there are additional comments. Repository: rG LLVM

[PATCH] D124741: [Clang] Add integer add reduction builtin

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks > For other reductions, we've tried to share builtins for float/integer > vectors, but the fadd reduction builtins also take a starting value argument. > Technically I could

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. > @fhahn Remind me - why did you want me to split these? If we're initially > just going for integer support, can't both be done at the same time in this > patch? I think my original thinking was that `__builtin_reduce_mul` isn't defined at the moment

[PATCH] D69740: [profile] Support counter relocation at runtime

fhahn added inline comments. Herald added subscribers: abrachet, MaskRay. Herald added a project: All. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:673 +auto *Add = Builder.CreateAdd(Builder.CreatePtrToInt(Addr, Int64Ty), LI); +Addr =

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

fhahn added a comment. In D122983#3464331 , @xbolva00 wrote: > In D122983#3464315 , @aaron.ballman > wrote: > >> In D122983#3463561 , @MaskRay >> wrote: >> >>> Adding a

[PATCH] D123300: [Clang] Enable opaque pointers by default

fhahn added a comment. In D123300#3454215 , @aeubanks wrote: > $ cat /tmp/a.ll > target triple = "thumbv8-unknown-linux-gnueabihf" > > define void @zot() { > bb: > br label %bb1 > > bb1: ;

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

fhahn added a comment. (splitting up huge monolithic tests likely also speeds up overall testing time on multi-core systems) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

fhahn added a comment. In D123601#3445601 , @tstellar wrote: > Can't we add a timeout exception for this test in buildkite? Splitting the > file in two actually increases the runtime, due to the overhead of setting up > each test. I don't know, this

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 418961. fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. I rebased the patch and added new pm support based on the latest version of D32198 Repository: rG LLVM Github Monorepo

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn added a comment. In D122573#3412109 , @rjmccall wrote: > Hmm. We know that the big picture here, distinguishing pointers by pointee > type, is going to be disruptive and will probably need a specific > enabling/disabling option. I'm not sure

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn created this revision. fhahn added reviewers: rjmccall, aaron.ballman, scanon, rsmith, hfinkel. Herald added subscribers: jeroen.dobbelaere, kosarev. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. This patch extends Clang's TBAA

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. In D117829#3389241 , @RKSimon wrote: > In D117829#3386398 , @fhahn wrote: > >> @RKSimon are you planning on pushing this patch through? From my >> perspective, it looks good with splitting

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

fhahn added a comment. The test also failed in the Phabricator pre-commit CI, please keep an eye on it before re-submitting (failure link for latest diff was https://buildkite.com/llvm-project/premerge-checks/builds/83983#39c06525-7452-412d-af83-ae2cc2d30cdc) Repository: rG LLVM Github

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. In D118259#3389235 , @kpn wrote: > It's been a while, but I think the aarch64-neon-intrinsics-constrained.c test > is trimmed down from the aarch64-neon-intrinsics.c test. Shouldn't the > constrained and non-constrained

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. In D118259#3343554 , @john.brawn wrote: > In D118259#3275297 , @fhahn wrote: > >> Does this clang test actually need to check the generated assembly? >> Shouldn't it be enough to check

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. Herald added a project: All. @RKSimon are you planning on pushing this patch through? From my perspective, it looks good with splitting off `__builtin_reduce_mul` and adding a TODO to also implement it for floating point types. Repository: rG LLVM Github Monorepo

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks! Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // times for large single test files.

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb42e557d8b4: [Driver] Split up huge arm-cortex-cpus.c test. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

fhahn updated this revision to Diff 412974. fhahn added a comment. Thanks! I added a TODO to split it up by categories and I'll plan to land the change soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120876/new/

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f5bdaf481c3: [Driver] Split up huge aarch64-cpus.c test. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn updated this revision to Diff 412971. fhahn added a comment. Thanks everyone! I added a TODO for splitting up by category and plan to land this soon. The update also adds a missing GENERIC check line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120967: [NFC] Divide tests into smaller files

fhahn accepted this revision. fhahn added a comment. Thanks for splitting up the tests! Looks like pre-commit CI is happy again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120967/new/ https://reviews.llvm.org/D120967

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn added a comment. In D120875#3356432 , @simon_tatham wrote: >> While splitting up the test file is not ideal [...] > > Actually I'm not so sure. I'd almost rather go further, and split it up into > lots of //much// smaller files, each with some

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

fhahn created this revision. fhahn added reviewers: simon_tatham, dmgreen, tmatheson, tyb0807. Herald added a subscriber: kristof.beyls. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test file has

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

fhahn added a comment. Herald added a subscriber: pcwang-thead. Herald added a project: All. Unfortunately some of the intrinsics tests have grown so large the the consistently hit the 10 minute timeout in the Phabricator precommit tests, e.g. see

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

fhahn added a comment. Also see https://github.com/llvm/llvm-project/issues/54168 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860 ___ cfe-commits mailing list

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn created this revision. fhahn added reviewers: simon_tatham, dmgreen, tmatheson, tyb0807. Herald added a subscriber: kristof.beyls. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. This test file has grown to the point where it takes a huge

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. In D109239#3340872 , @zahiraam wrote: > @fhahn I think the last commit fixes the issue. I am currently testing it on > MacOS 10.14 and it is still going (slow remote machine). I would like to get > your permission to push this

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. It looks like this patch changed the value of `__FLT_EVAL_METHOD__` when building on macOS for some configurations. This is causing build failures when using macOS 10.15's `math.h` and that is breaking most builds on GreenDragon, e.g. :

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

fhahn added a reviewer: aaron.ballman. fhahn added inline comments. Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:1 +// RUN: %clang_cc1 %s -O1 -emit-llvm -triple aarch64-unknown-unknown -ffast-math -o - | FileCheck %s --check-prefix=AARCH64 +

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

fhahn added a comment. Someone filed https://github.com/llvm/llvm-project/issues/53540, which covers some of the issues also discussed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879

[PATCH] D118464: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

fhahn added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118464/new/ https://reviews.llvm.org/D118464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

fhahn added inline comments. Comment at: clang/test/CodeGen/builtins-elementwise-math.c:117 + // CHECK-NEXT: call <4 x i32> @llvm.usub.sat.v4i32(<4 x i32> [[VU1]], <4 x i32> [[VU2]]) + vu1 = __builtin_elementwise_sub_sat(vu1, vu2); + It might be good to have

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. Does this clang test actually need to check the generated assembly? Shouldn't it be enough to check that the correct intrinsics are generated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. In D117829#3260772 , @RKSimon wrote: > I'm happy to continue with this just for integers or wait until we have a > plan for floats as well. I guess we need to decide if we want to support the > starting value in the fadd/fmul

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

fhahn accepted this revision. fhahn added a comment. Thanks for the patch, it's great to see! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117798/new/ https://reviews.llvm.org/D117798 ___ cfe-commits

  1   2   3   4   5   6   7   8   >