[clang] [clang-tools-extra] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

frederic-tingaud-sonarsource wrote: OK, I understand. Could you point me to where that pattern selection happens? I will not be able to work on that PR for two weeks but I can go back on it afterward. https://github.com/llvm/llvm-project/pull/156011 _

[clang] [clang-tools-extra] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/156011 >From 6c99bc0d1e9ad53133198720ad57c6121b48bc98 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Mon, 25 Aug 2025 20:07:04 +0200 Subject: [PATCH] [clang][AST] Fix source range of class templ

[clang] [clang-tools-extra] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

frederic-tingaud-sonarsource wrote: Just having `TagDecl::isThisDeclarationADefinition()` return false in case of a forward declaration would in my opinion not solve the problem correctly, because that would make matching all class definitions in the AST extremely hard. Right now, it is just `

[clang] [clang-tools-extra] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/156011 >From 86f668015b087134c6f41ecd55ac4795652fa6bd Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Mon, 25 Aug 2025 20:07:04 +0200 Subject: [PATCH] [clang][AST] Fix source range of class templ

[clang] [clang-tools-extra] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/156011 >From c6be607ea1b159cd71c27684bcad9c4c3bc58a2f Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Mon, 25 Aug 2025 20:07:04 +0200 Subject: [PATCH] [clang][AST] Fix source range of class templ

[clang] [clang-tools-extra] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/156011 >From 56c46c1224927289e08b8627484eab51dc21a69b Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Mon, 25 Aug 2025 20:07:04 +0200 Subject: [PATCH] [clang][AST] Fix source range of class templ

[clang] [clang-tools-extra] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/156011 >From e4389f14d926afccc4214de52ee14573b2ac38b0 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Mon, 25 Aug 2025 20:07:04 +0200 Subject: [PATCH] [clang][AST] Fix source range of class templ

[clang] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

frederic-tingaud-sonarsource wrote: Thanks for the feedback @mizvekov. I propose this change for the following reasons: - Class template implicit instantiations have technically no source range anywhere, which is why I think having the same behavior as function template implicit instantiations

[clang] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/156011 >From 2ac48a53ae9ff3867c5de98f2068ed48e2ab76fb Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Mon, 25 Aug 2025 20:07:04 +0200 Subject: [PATCH] [clang][AST] Fix source range of class templ

[clang] [clang][AST] Fix source range of class template implicit instantiations. (PR #156011)

https://github.com/frederic-tingaud-sonarsource created https://github.com/llvm/llvm-project/pull/156011 When getting the source range of the implicit instantiation of a class template, we get the source range of the latest declaration of the class template, even when it is not its definition.

[clang] [clang][ASTMatcher] Handle variable templates in `isInstantiated` and `isInTemplateInstantiation` matchers (PR #110666)

frederic-tingaud-sonarsource wrote: Thanks @AaronBallman! Yes, if you could land the changes, that would be great. https://github.com/llvm/llvm-project/pull/110666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang][ASTMatcher] Handle variable templates in `isInstantiated` and `isInTemplateInstantiation` matchers (PR #110666)

frederic-tingaud-sonarsource wrote: Pinging some recent contributors/reviewers to AST Matchers. @danix800, @AaronBallman, @shafik, @PiotrZSL, @steakhal, @cor3ntin https://github.com/llvm/llvm-project/pull/110666 ___ cfe-commits mailing list cfe-commit

[clang] [clang][ASTMatcher] Handle variable templates in `isInstantiated` and `isInTemplateInstantiation` matchers (PR #110666)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/110666 >From be911d8d0a00d5c6d42b23b40ca6d6abec51966c Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Tue, 1 Oct 2024 16:10:55 +0200 Subject: [PATCH 1/2] Handle variable templates in isInstantiat

[clang] [clang][ASTMatcher]Handle variable templates in `isInstantiated` and `isInTemplateInstantiation` matchers (PR #110666)

https://github.com/frederic-tingaud-sonarsource edited https://github.com/llvm/llvm-project/pull/110666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Handle variable templates in `isInstantiated` and `isInTemplateInstantiation` matchers (PR #110666)

https://github.com/frederic-tingaud-sonarsource created https://github.com/llvm/llvm-project/pull/110666 Fix `isInstantiated` and `isInTemplateInstantiation` matchers, so they return true for instantiations of variable templates, and any declaration in statements contained in such instantiati

[clang] Handle variable templates in `isInstantiated` and `isInTemplateInstantiation` matchers (PR #110666)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/110666 >From be911d8d0a00d5c6d42b23b40ca6d6abec51966c Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Tue, 1 Oct 2024 16:10:55 +0200 Subject: [PATCH] Handle variable templates in isInstantiated a

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

frederic-tingaud-sonarsource wrote: Yes please :) https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/81776 >From c12b2e26ad7a114aff09b89c75178d4ab7890a20 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Wed, 14 Feb 2024 19:40:29 +0100 Subject: [PATCH 1/3] [clang] Fix isInStdNamespace for Decl fla

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

frederic-tingaud-sonarsource wrote: Oh, I didn't know about this, but it does look better. Thanks! https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/81776 >From c12b2e26ad7a114aff09b89c75178d4ab7890a20 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Wed, 14 Feb 2024 19:40:29 +0100 Subject: [PATCH 1/3] [clang] Fix isInStdNamespace for Decl fla

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/81776 >From c12b2e26ad7a114aff09b89c75178d4ab7890a20 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Wed, 14 Feb 2024 19:40:29 +0100 Subject: [PATCH 1/2] [clang] Fix isInStdNamespace for Decl fla

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

https://github.com/frederic-tingaud-sonarsource created https://github.com/llvm/llvm-project/pull/81776 The MSVC STL implementation declares multiple classes using: ```cpp namespace std { extern "C++" class locale { ... }; } ``` `isInStdNamespace` uses the first DeclContext to check wh