[PATCH] D100085: [X86] Support -march=rocketlake

2021-04-07 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

2021-03-07 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5f9489b75405: [X86] Refine "Support -march=alderlake" (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

2021-03-07 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. No more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

2021-03-03 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe marked an inline comment as done. FreddyYe added a comment. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 ___ cfe-commits mailing list

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

2021-03-03 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 327691. FreddyYe added a comment. delete extra spaces. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 Files: clang/test/Preprocessor/predefined-arch

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

2021-03-02 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97832 Files: clang/

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-27 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1edb76cc91e7: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-26 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 319284. FreddyYe added a comment. refine clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/ms-inl

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-26 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 319282. FreddyYe added a comment. If Clobber is edx only, don't change "={eax}" to "=&{eax}". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGe

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-26 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2490 + continue; +std::string::size_type position1 = Constraints.find("={eax}"); +if (position1 != std::string::npos) { pengfei wrote: > If `Clobber` is `edx` only,

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

2021-01-26 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b0acdc6fb5: [NFC] Refine some uninitialized used variables. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95421/new/ https://revie

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-25 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

2021-01-25 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 319216. FreddyYe added a comment. refine according to Lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95421/new/ https://reviews.llvm.org/D95421 Files: clang/lib/CodeGen/CGBlocks.cpp llvm/lib/CodeGen/R

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

2021-01-25 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. Herald added subscribers: pengfei, tpr, hiraditya, qcolombet, MatzeB. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. These warning are reported by static code analysis tool: Klocwo

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-21 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 318128. FreddyYe added a comment. Fix Lint: Pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-20 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 318123. FreddyYe added a comment. consider Clobber == "edx" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-12 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 316324. FreddyYe added a comment. consider "=A" into the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeG

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-11 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2488 + if (Clobber == "eax") { +std::string::size_type position = Constraints.find("={eax}"); +if (position != std::string::npos) { pengfei wrote: > `={eax}` is set in `

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-11 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/ms-inline-asm.c cl

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-06 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e312e004197: [X86] use macros to split GFNI intrinsics into different kinds (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-05 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 303087. FreddyYe marked an inline comment as done. FreddyYe added a comment. Refine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/gfniintr

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-05 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe marked 3 inline comments as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/gfniintrin.h:131-138 #define _mm512_mask_gf2p8affine_epi64_epi8(S, U, A, B, I) \ (__m512i)__builtin_ia32_selectb_512((__mmask64)(U), \

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-05 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 303073. FreddyYe added a comment. Reorganize intrinsic orders to avoid using nested macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-04 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 303047. FreddyYe added a comment. Use header file macros instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/gfniintrin.h Index: clang

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-04 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. In D90822#2375423 , @pengfei wrote: > Craig's method sounds good. > @FreddyYe , Why we check AVX512BW instead of AVX512F. I saw SDM says it > depends on AVX512F. I was referring to the old implement and test case. Seems like a e

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-04 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. The fails are all unknown type errors on Windows, since those typedefs are declared in other header files. The error message goes like: $ clang -march=tremont gfni.c .. ...\lib\clang\12.0.0\include\gfniintrin.h:129:37: error: unknown type name '__mmask

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

2020-11-04 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. FreddyYe requested review of this revision. Tremont microarchitecture only has GFNI(SSE) version, not AVX and AVX512 version. This patch is to avoid compiling fail on Windows when using -march=tr

[PATCH] D86503: [X86] Support -march=sapphirerapids

2020-08-24 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe02d081f2b60: [X86] Support -march=sapphirerapids (authored by FreddyYe). Changed prior to commit: https://reviews.llvm.org/D86503?vs=287547&id=28

[PATCH] D86503: [X86] Support -march=sapphirerapids

2020-08-24 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. FreddyYe added reviewers: craig.topper, pengfei, LuoYuanke. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. FreddyYe requested review of this revision. Support -march=sapphirerapids for x86.

<    1   2   3   4