[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

gromer marked an inline comment as done. gromer added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

gromer added a comment. In D56731#1358926 , @jdennett wrote: > In D56731#1358907 , @Quuxplusone > wrote: > > > For my own use-cases, I will continue to want a 100% comprehensive > > `-Wctad`. All these

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

gromer added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no user-defined deduction guides" >, + InGroup,

[PATCH] D51812: Simplify CheckFallThroughForBody

gromer added a comment. OK, the diffs are now un-borked. Sorry for the flailing incompetence. https://reviews.llvm.org/D51812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51812: Simplify CheckFallThroughForBody

gromer updated this revision to Diff 166558. https://reviews.llvm.org/D51812 Files: b/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp Index: b/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp === ---

[PATCH] D51812: Simplify CheckFallThroughForBody

gromer updated this revision to Diff 166545. https://reviews.llvm.org/D51812 Files: B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp Index: B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp === ---

[PATCH] D51812: Simplify CheckFallThroughForBody

gromer added inline comments. Comment at: b/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp:601 +case MaybeFallThrough: + if (ReturnsValue) +S.Diag(RBrace, diag::warn_maybe_falloff_nonvoid_coroutine) rsmith wrote: > This `if` and the one

[PATCH] D51812: Simplify CheckFallThroughForBody

gromer updated this revision to Diff 166521. gromer marked 2 inline comments as done. https://reviews.llvm.org/D51812 Files: B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp Index: B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D51812: Simplify CheckFallThroughForBody

gromer created this revision. gromer added a reviewer: rsmith. Herald added subscribers: cfe-commits, modocache. Split CheckFallThroughForBody into separate implementations for blocks, lambdas, coroutines, and all other functions. This simplifies the code because virtually every part of it