[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

This revision was automatically updated to reflect the committed changes. Closed by commit rGe726703c27c4: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w (authored by gonglingqin). Changed prior to commit: https://reviews.llvm.org/D139987?vs=484466=484792#toc

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

This revision was automatically updated to reflect the committed changes. Closed by commit rGaeb8f911b169: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

gonglingqin updated this revision to Diff 484466. gonglingqin added a comment. Address @SixWeining's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139987/new/ https://reviews.llvm.org/D139987 Files: clang/lib/Headers/larchintrin.h

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

gonglingqin added inline comments. Comment at: clang/lib/Headers/larchintrin.h:17-20 +typedef struct drdtime { + unsigned long dvalue; + unsigned long dtimeid; +} __drdtime_t; SixWeining wrote: > Should be moved into the belowing `#if __loongarch_grlen == 64`.

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin updated this revision to Diff 484465. gonglingqin added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139915/new/ https://reviews.llvm.org/D139915 Files: clang/include/clang/Basic/BuiltinsLoongArch.def

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.h:91 IOCSRWR_D, + + CPUCFG, SixWeining wrote: > Better to leave some comment like line 82? Thanks, I'll add comments. Repository: rG LLVM Github Monorepo

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin updated this revision to Diff 482372. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139915/new/ https://reviews.llvm.org/D139915 Files:

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin added a comment. In D139915#3991089 , @xen0n wrote: > Linux only requires `__cpucfg` among the ones you just added. Please amend > the patch summary so it's more accurate. > > Otherwise LGTM, thanks! Thanks for your review, I will modify

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG048612050a2f: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139397: [LoongArch] Add testcases for privileged intrinsic macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a5e5402cf80: [LoongArch] Add testcases for privileged intrinsic macros (authored by gonglingqin). Changed prior to commit:

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

This revision was automatically updated to reflect the committed changes. Closed by commit rG685bbe65f5c3: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin updated this revision to Diff 480371. gonglingqin added a comment. Add testcases for macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139288/new/ https://reviews.llvm.org/D139288 Files:

[PATCH] D139397: [LoongArch] Add testcases for privileged intrinsic macros

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin added inline comments. Comment at: clang/lib/Headers/larchintrin.h:67-96 #define __break(/*ui15*/ _1) __builtin_loongarch_break((_1)) #define __dbar(/*ui15*/ _1) __builtin_loongarch_dbar((_1)) #define __ibar(/*ui15*/ _1) __builtin_loongarch_ibar((_1))

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin updated this revision to Diff 479967. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139288/new/ https://reviews.llvm.org/D139288 Files:

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin added a comment. In D139288#3969746 , @xen0n wrote: > You'll also need the IOCSR intrinsics too for building Linux. Since they're > very similar to some of the CSR intrinsics you added here, do you plan to add > support for them later here

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG624401612c3a: [LoongArch] Add remaining intrinsics for CRC check instructions (authored by gonglingqin). Changed prior to commit:

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin updated this revision to Diff 477393. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files:

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin updated this revision to Diff 477382. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files:

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin updated this revision to Diff 477363. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files:

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cf2286cb8f8: [LoongArch] Fix issue on CMake Xcode build configuration (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940432 , @WowbaggersLiquidLunch wrote: > In D136906#3940377 , @gonglingqin > wrote: > >> Can you use https://reviews.llvm.org/D138403 to solve this problem? > > Thanks

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940427 , @WowbaggersLiquidLunch wrote: >> I get the following error: >> >>> CMake Error: Could not create named generator Xcode > > Sorry, I forgot to mention that Xcode is only available on macOS. > >> But when

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940289 , @WowbaggersLiquidLunch wrote: > Hi, this seems to be causing some problems when generating Xcode project. > > When I try to generate the Xcode project with the following command: > > cmake -G "Xcode"

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940289 , @WowbaggersLiquidLunch wrote: > Hi, this seems to be causing some problems when generating Xcode project. > > When I try to generate the Xcode project with the following command: > > cmake -G "Xcode"

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2ec455f183d: [LoongArch] Add intrinsics for ibar, break and syscall (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin updated this revision to Diff 475987. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/ https://reviews.llvm.org/D138094 Files:

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:603 case Intrinsic::loongarch_dbar: { -SDValue Op0 = Op.getOperand(0); -SDValue Op2 = Op.getOperand(2); -if (!isa(Op2)) { -

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin updated this revision to Diff 475715. gonglingqin added a comment. Address @arsenm's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/ https://reviews.llvm.org/D138094 Files:

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsLoongArch.def:20-23 TARGET_BUILTIN(__builtin_loongarch_dbar, "vIUi", "nc", "") +TARGET_BUILTIN(__builtin_loongarch_ibar, "vIUi", "nc", "") +TARGET_BUILTIN(__builtin_loongarch_break, "vIUi", "nc",

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddbb21bdb579: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar (authored by gonglingqin). Changed prior to commit:

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

gonglingqin updated this revision to Diff 475333. gonglingqin added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137809/new/

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

gonglingqin added inline comments. Comment at: clang/test/CodeGen/LoongArch/intrinsic-error.c:11 +void dbar() { + return __builtin_loongarch_dbar(32768); // expected-error {{argument value 32768 is outside the valid range [0, 32767]}} +} SixWeining wrote: >

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda34aff90d2b: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add… (authored by gonglingqin). Changed prior to commit:

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG60e5cfe2a4eb: [Clang][LoongArch] Define more LoongArch specific built-in macros (authored by SixWeining, committed by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85f08c4197ae: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin (authored by gonglingqin). Changed prior to commit:

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG135a9272a4c9: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options (authored by SixWeining, committed by gonglingqin).

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin updated this revision to Diff 473909. gonglingqin added a comment. Add test cases to detect whether the immediate is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906 Files:

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added inline comments. Comment at: llvm/test/CodeGen/LoongArch/intrinsic-error.ll:10 + +declare void @llvm.loongarch.dbar(i32) SixWeining wrote: > It's better to add a test that immediate is out of range. Thanks, I will add test cases. Repository:

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin updated this revision to Diff 473620. gonglingqin added a comment. Delete blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137316/new/ https://reviews.llvm.org/D137316 Files: clang/include/clang/Basic/BuiltinsLoongArch.def

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:174 +const std::vector ) const { + + if (getTriple().getArch() == llvm::Triple::loongarch64) SixWeining wrote: > Delete blank line. Thanks, I will delete it.

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin updated this revision to Diff 473564. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137316/new/ https://reviews.llvm.org/D137316 Files:

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:54 +def int_loongarch_crc_w_d_w : Intrinsic<[llvm_i32_ty], +[llvm_i64_ty, llvm_i32_ty], []>; } // TargetPrefix = "loongarch"

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin updated this revision to Diff 473561. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906 Files:

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:39 + +def int_loongarch_dbar : Intrinsic<[], [llvm_i32_ty], []>; } // TargetPrefix = "loongarch" SixWeining wrote: > Seems this arg is unnecessary because the defalut

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds support to prevent

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: