[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet added a comment. In D150461#4338499 , @jhuber6 wrote: > In D150461#4338498 , @gchatelet > wrote: > >> quick question, did you try to build the openmp runtime as well to check if >> the tests still

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet added a comment. quick question, did you try to build the openmp runtime as well to check if the tests still pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet accepted this revision. gchatelet added a comment. You beat me to it :) Thx for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461 ___

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet added a comment. Herald added a subscriber: jobnoorman. In D143386#4107144 , @efriedma wrote: > Almost all the specifications you're specifying are wrong. Very few targets > should be using "i". Off the top of my head, 32-bit ARM, MIPS

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet created this revision. gchatelet added a reviewer: efriedma. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added a comment. Thx @efriedma for reminding me of this. I'll update the documentation and try to give a shot at removing `MaybeAlign` from `GlobalObject`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142459/new/

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); +

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); +

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This remove the last uses of GlobalObject::getAlignment and

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

gchatelet closed this revision. gchatelet added a comment. So i've submitted the following patches which remove the usage of `TypeSize::getFixedSize()` and `TypeSize::getKnownMinSize()` - rG6916ebd02650 : [clang][NFC] Use

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

gchatelet added a comment. I've created https://reviews.llvm.org/D141267 to get a feel of what it looks like to only keep the Size version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141134/new/ https://reviews.llvm.org/D141134

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

gchatelet updated this revision to Diff 487339. gchatelet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fix missing clang change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141134/new/

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. In D126903#3885269 , @aganea wrote: > In D126903#3885114 , @gchatelet > wrote: > >> It should be fixed now @aganea . Can you check? > > Works now, thanks again for the quick response.

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. It should be fixed now @aganea . Can you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 ___ cfe-commits mailing list

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. In D126903#3884873 , @courbet wrote: > I think there's a bug in the code though: > > // If this is memset, we just need to see if the offset is valid in the size > // of the memset.. > if (MI->getIntrinsicID() ==

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

gchatelet added a comment. It also broke `llvm-exegesis` for 32 bits targets, see https://github.com/llvm/llvm-project/issues/57348 Reverting changes for the files in `tools/llvm-exegesis/` solves the compilation issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38637ee47754: [clang] Add support for __builtin_memset_inline (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435893. gchatelet added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435890. gchatelet added a comment. - Update assert message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435883. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7334 if (TSI) { SDValue Result = TSI->EmitTargetCodeForMemset( *this, dl, Chain, Dst, Src, Size, Alignment, isVol, DstPtrInfo); courbet wrote: > There is

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435877. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files:

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. Pending D127279 before making sure that all `EmitTargetCodeForMemset` implementations are enforcing `AlwaysInline`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 434793. gchatelet marked 8 inline comments as done. gchatelet added a comment. Herald added subscribers: pmatos, asb, aheejin, jgravelle-google, sbc100, dschuff. - Address comments, add more codegen tests, rebase Repository: rG LLVM Github Monorepo

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.cpp:11 +void test_memcpy_inline_invalid_arg_types() { + __builtin_memcpy_inline(1, 2, 3); // expected-error {{cannot initialize a parameter of type 'void *' with an rvalue of type 'int'}} +}

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 434750. gchatelet marked 2 inline comments as done. gchatelet added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files:

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2293-2315 + case Builtin::BI__builtin_memset_inline: { +if (checkArgCount(*this, TheCall, 3)) + return ExprError(); +auto

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 433982. gchatelet added a comment. - Fix sema checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 433978. gchatelet added a comment. - Rebase over formatted CGBuilder.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 433858. gchatelet added a comment. - remove unused variable and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet created this revision. gchatelet added reviewers: courbet, efriedma, t.p.northover, jdoerfert. Herald added subscribers: jsji, pengfei, hiraditya. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b3a27e2e026: Add validation for number of arguments of __builtin_memcpy_inline (authored by royjacobson, committed by gchatelet). Repository: rG

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121965/new/ https://reviews.llvm.org/D121965

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. Much better, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121475/new/ https://reviews.llvm.org/D121475 ___ cfe-commits mailing

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx for the patch, please address the comment before submitting. Comment at: clang/lib/Sema/SemaChecking.cpp:1946-1953 +auto ArgArrayConversion = [&](unsigned Arg)

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

gchatelet added a comment. LGTM once tests are passing. Maybe wait a bit for a comment from @aaron.ballman . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 ___ cfe-commits mailing list

[PATCH] D104018: [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG89c41c335dac: [clang-tidy] Allow disabling integer narrowing conversions for… (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104018: [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. gchatelet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet abandoned this revision. gchatelet added a comment. In D102760#2802520 , @Quuxplusone wrote: > @gchatelet: Thanks for the link to D102679 > — that seems like very relevant background info I didn't have!

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet added a comment. @Quuxplusone thx a lot for the comment. It is very relevant and I agree that this addition may be dangerous. The intend was to prevent adding more constructors (and dependencies) to SmallVector in D102679 . I can try to see what it

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 348228. gchatelet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + fhahn wrote: > how is this related? > how is this related? I'm glad you ask! I'm still investigating the errors that led to this

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346669. gchatelet added a comment. - Forward argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346657. gchatelet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Remove dependency on iterable_range header - Simplified implementation, added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet accepted this revision. gchatelet added a comment. LGTM as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97223/new/ https://reviews.llvm.org/D97223 ___ cfe-commits mailing list

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet added a comment. In D97223#2581587 , @jyknight wrote: > In D97223#2581126 , @rjmccall wrote: > >> Looks like you didn't update the .bc reader/writer and the .ll >> printer/parser. > > The instructions

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1037 + assert(AddrAlign >= ResultTy->getPrimitiveSizeInBits() / 8); + Add an error message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91975: clang-tidy: detect narrowing conversions involving typedefs

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org/D91975

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2439 +guarantees not to call any external functions. See LLVM IR `llvm.memcpy.inline +`_

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2439 +guarantees not to call any external functions. See LLVM IR `llvm.memcpy.inline +`_

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe38be7091ee3: [Clang] Clarify __builtin_memcpy_inline documentation (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87458/new/

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet requested review of this revision. This patch updates the documentation about `__builtin_memcpy_inline` and reorders the sections so it is more

[PATCH] D79279: Add overloaded versions of builtin mem* functions

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:489 BUILTIN(__builtin_memcpy_inline, "vv*vC*Iz", "nt") +BUILTIN(__builtin_overloaded_memcpy, "v*v*vC*z", "nt") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") jfb wrote: >

[PATCH] D79279: Add overloaded versions of builtin mem* functions

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:489 BUILTIN(__builtin_memcpy_inline, "vv*vC*Iz", "nt") +BUILTIN(__builtin_overloaded_memcpy, "v*v*vC*z", "nt") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") `overloaded` doesn't

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet marked 3 inline comments as done. gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.c:7 +#warning defined as expected +// expected-warning@-1 {{defined as expected}} +#endif efriedma wrote: > melver wrote: > > It

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.c:7 +#warning defined as expected +// expected-warning@-1 {{defined as expected}} +#endif gchatelet wrote: > efriedma wrote: > >

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

gchatelet added a comment. I would harden the verifier and declare the i64 versions of mem intrinsics illegal on 32 bits architectures. Also the intrinsic sections of LangRef should be updated accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

gchatelet added a comment. Thx @craig.topper ! I'm happy to see this effort percolate :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78443/new/ https://reviews.llvm.org/D78443 ___ cfe-commits

[PATCH] D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign()

gchatelet updated this revision to Diff 251971. gchatelet added a comment. Herald added a reviewer: jdoerfert. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76551/new/ https://reviews.llvm.org/D76551 Files:

[PATCH] D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign()

gchatelet updated this revision to Diff 251969. gchatelet marked 3 inline comments as done. gchatelet added a comment. Herald added subscribers: libc-commits, openmp-commits, libcxx-commits, cfe-commits, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg,

[PATCH] D76504: [clang] Fix crash during template sema checking

This revision was automatically updated to reflect the committed changes. Closed by commit rGd260a10d98df: [clang] Fix crash during template sema checking (authored by gchatelet). Changed prior to commit: https://reviews.llvm.org/D76504?vs=251780=251837#toc Repository: rG LLVM Github

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251780. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251671. gchatelet marked an inline comment as done. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files:

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || courbet wrote: > Are the

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet created this revision. gchatelet added reviewers: efriedma, courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet added a subscriber: abrachet. gchatelet added a comment. Buggy trace here

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added a comment. Buggy trace here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet abandoned this revision. gchatelet added a comment. This has been implemented in the following patches: - https://reviews.llvm.org/D67923 - https://reviews.llvm.org/D74162 - https://reviews.llvm.org/D73543 - https://reviews.llvm.org/D71710 Repository: rG LLVM Github Monorepo

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rGd65bbf81f8be: [clang] Add support for __builtin_memcpy_inline (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. Thx a lot ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 243289. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Remove unrelated memcpy in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2229 +* ``memcpy`` * ``memchr`` efriedma wrote: > Not sure putting "memcpy" in this list makes sense. We did add support for > constant-evaluating memcpy, but it was separately

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. Anything else @efriedma ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2252 + + * ``__builtin_memcpy_inline`` + efriedma wrote: > This is in the wrong section of the documentation. We could > constant-evaluate __builtin_memcpy_inline, I guess, but that

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241988. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files:

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241649. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files:

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. @efriedma would you mind having a look? It should be my last patch on that matter :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241356. gchatelet added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files: clang/docs/LanguageExtensions.rst

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2259 +``__builtin_memcpy_inline(dst, src, size)`` is identical to +``__builtin_memcpy(dst, src, size)`` expect that the generated code is +guaranteed not to call any external functions. See [LLVM IR

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241158. gchatelet marked 4 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files:

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

gchatelet added a comment. Thx for the fix @thegameg Comment at: clang/lib/CodeGen/CGCall.cpp:1845 + + // First, handle the language options passed through -fno-builtin[-] + if (LangOpts.NoBuiltin) { Can you remove the trailing `[-]`? Repository: rG LLVM

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet created this revision. gchatelet added reviewers: efriedma, courbet, tejohnson. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is a follow up on D61634 and the last step to implement

[PATCH] D73449: [Alignment][NFC] Use Align with CreateAlignedLoad

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c9d5326648: [Alignment][NFC] Use Align with CreateAlignedLoad (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73449/new/

[PATCH] D73449: [Alignment][NFC] Use Align with CreateAlignedLoad

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context:

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

gchatelet added a comment. In D72998#1838834 , @lebedev.ri wrote: > Is that still an issue after a8c3608a27a82cf1c66f33b96a06423fe0e708fc > ? >

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

gchatelet added a comment. Actually there's an issue with the code. It doesn't compile in shared_library mode. ld.lld: error: undefined symbol: clang::Sema::MaximumAlignment >>> referenced by SemaChecking.cpp:5397 (/redacted/llvm-project/clang/lib/Sema/SemaChecking.cpp:5397) >>>

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

This revision was automatically updated to reflect the committed changes. Closed by commit rG805c157e8aee: [Alignment][NFC] Deprecate Align::None() (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

gchatelet updated this revision to Diff 240148. gchatelet added a comment. - rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/ https://reviews.llvm.org/D73099 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

This revision was automatically updated to reflect the committed changes. Closed by commit rG59f95222d4c5: [Alignment][NFC] Use Align with CreateAlignedStore (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73274/new/

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

gchatelet updated this revision to Diff 239906. gchatelet marked 5 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73274/new/ https://reviews.llvm.org/D73274 Files:

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

gchatelet updated this revision to Diff 239903. gchatelet added a comment. - Improving DataLayout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73274/new/ https://reviews.llvm.org/D73274 Files: clang/lib/CodeGen/CGBlocks.cpp

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, nhaehnle, jvesely, arsenm. Herald added a reviewer: bollu. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

gchatelet updated this revision to Diff 239801. gchatelet added a comment. - Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/ https://reviews.llvm.org/D73099 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

This revision was automatically updated to reflect the committed changes. Closed by commit rG0957233320eb: [Alignment][NFC] Use Align with CreateMaskedStore (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73106/new/

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: llvm/docs/LangRef.rst:14945 -The first operand is the base pointer for the load. The second operand is the alignment of the source location. It must be a constant integer value. The

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet updated this revision to Diff 239513. gchatelet marked an inline comment as done. gchatelet added a comment. - Reverting LangRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73106/new/ https://reviews.llvm.org/D73106 Files:

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2907 Value *Addr = I.getArgOperand(1); -const MaybeAlign Alignment( +const Align Alignment(

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet updated this revision to Diff 239501. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73106/new/ https://reviews.llvm.org/D73106 Files:

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

gchatelet added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72998/new/ https://reviews.llvm.org/D72998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context:

  1   2   3   >