gruuprasad added a comment.
Email:gruupras...@gmail.com
GitHub username: gruuprasad
Either of these fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156724/new/
https://reviews.llvm.org/D156724
___
gruuprasad added a comment.
@steakhal, ok, this is my first contribution, I don't have the commit access
yet.
Can you please merge this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156724/new/
https://reviews.llvm.org/D156724
gruuprasad added a comment.
I went through the build logs, but failed test (Clang :: Driver/fsanitize.c)
seems to be irrelevant to the changes in this patch.
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:596-599
os << "Note:"
<< "line "
gruuprasad updated this revision to Diff 545807.
gruuprasad added a comment.
Add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156724/new/
https://reviews.llvm.org/D156724
Files:
clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
gruuprasad added a comment.
Sure, Initially I didn't find the folder `StaticAnalysis` in the `clang/test`
folder, found that relevant tests are in `test/Analysis`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156724/new/
gruuprasad created this revision.
gruuprasad added reviewers: NoQ, xazax.hun.
Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp,
donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware.
Herald added a project: All.
gruuprasad requested review of this revision.
Herald
