[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

2023-06-30 Thread Hamish Knight via Phabricator via cfe-commits
hamishknight marked an inline comment as done. hamishknight added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3965 unsaved_files); - std::unique_ptr Unit(ASTUnit::LoadFromCommandLine( + auto Unit = ASTUnit::LoadFromCommandLine( Args->data(),

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

2023-06-30 Thread Hamish Knight via Phabricator via cfe-commits
hamishknight updated this revision to Diff 536426. hamishknight added a comment. Updated to use explicit `std::unique_ptr` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154257/new/ https://reviews.llvm.org/D154257 Files: clang/include/clang/Frontend/ASTUnit.h

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

2023-06-30 Thread Hamish Knight via Phabricator via cfe-commits
hamishknight created this revision. hamishknight added a reviewer: bnbarham. hamishknight added a project: clang. Herald added subscribers: arphaman, martong. Herald added a project: All. hamishknight requested review of this revision. Herald added a subscriber: cfe-commits. Change

[PATCH] D154134: [clang] Fix ASTUnit working directory handling

2023-06-30 Thread Hamish Knight via Phabricator via cfe-commits
hamishknight updated this revision to Diff 536163. hamishknight added a comment. Updated ReparseWorkingDirTest to fix Windows CI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154134/new/ https://reviews.llvm.org/D154134 Files: clang/lib/Frontend/ASTUnit.cpp

[PATCH] D154134: [clang] Fix ASTUnit working directory handling

2023-06-29 Thread Hamish Knight via Phabricator via cfe-commits
hamishknight created this revision. hamishknight added reviewers: bnbarham, benlangmuir. hamishknight added a project: clang. Herald added a project: All. hamishknight requested review of this revision. Herald added a subscriber: cfe-commits. Fix a couple of issues with the handling of the