[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo added a comment. In D101239#2747370 , @njames93 wrote: > In D101239#2746675 , @h-joo wrote: > >> In D101239#2746644 , @njames93 >> wrote: >> >>> LGTM, thanks. >>

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo added a comment. In D101239#2746644 , @njames93 wrote: > LGTM, thanks. @njames93, I appreciate your time for the review. May I ask one more thing? I do not have commit rights. Would it be possible for you to make the commit? Thank you!!

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo added a comment. In D101239#2746147 , @njames93 wrote: > Whats the expected behaviour of sugar types. Can tests be added that > demonstrate the behaviour. > I'd argue these cases shouldn't be warned on if `IgnoreArrays` is enabled and > If that

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo updated this revision to Diff 343864. h-joo added a comment. Extended the test case to confirm the fix also works for alias types(`typedef`, `using`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101239/new/ https://reviews.llvm.org/D101239 Files:

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo updated this revision to Diff 342233. h-joo added a comment. Change `1` to `true` in the test flag as requested by the reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101239/new/ https://reviews.llvm.org/D101239 Files:

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo accepted this revision. h-joo added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo requested changes to this revision. h-joo added a comment. This revision now requires changes to proceed. In D101515#2726889 , @krasimir wrote: > @h-joo , seems we had a comment race :D cheers! :D Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:252 + SmallVector + sortModuleReferences(SmallVector ) { +// Sort module references. `References` seem read-only. Can you make it `const Smallvector &`?

[PATCH] D101239: Enable IgnoreArray flag in pro-type-member-init rule

h-joo created this revision. h-joo added a reviewer: alexfh. h-joo added a project: clang-tools-extra. Herald added subscribers: kbarton, nemanjai. h-joo requested review of this revision. Herald added a subscriber: cfe-commits. The flag used to exist but wasn't implemented. Fixes b/47288

[PATCH] D100953: clang-format: [JS] do not wrap after `asserts`

h-joo added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3856 return false; // Otherwise automatic semicolon insertion would trigger. +if (NonComment && NonComment->is(tok::identifier) && +NonComment->TokenText == "asserts")

[PATCH] D100953: clang-format: [JS] do not wrap after `asserts`

h-joo accepted this revision. h-joo added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:3856 return false; // Otherwise automatic semicolon insertion would trigger. +if (NonComment &&

[PATCH] D100466: clang-format: [JS] merge import lines.

h-joo accepted this revision. h-joo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100466/new/ https://reviews.llvm.org/D100466 ___

[PATCH] D100466: clang-format: [JS] merge import lines.

h-joo added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:154 +// Merge module references: +// After sorting, find all references that import named symbols from the Would it be better if this were a named function?

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo added a comment. In D78643#2012511 , @jdoerfert wrote: > In D78643#2012212 , @h-joo wrote: > > > Sorry, I feel like I'm holding back the fix for this bug since I'm stuck on > > how to proceed with the build

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo marked an inline comment as done. h-joo added a comment. Sorry, I feel like I'm holding back the fix for this bug since I'm stuck on how to proceed with the build failure, @ABataev would you like to proceed with the other revision that you were working

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo updated this revision to Diff 259343. h-joo added a comment. In D78643#1997405 , @ABataev wrote: > In D78643#1997344 , @jdoerfert wrote: > > > This looks reasonable to me. @ABataev WDYT? > > > I would add a

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo updated this revision to Diff 259326. h-joo added a comment. In D78643#1997103 , @jdoerfert wrote: > Can we create a test case that shows even if it is a dependent type we will > eventuall issue an error if it is not an addressable lvalue or array

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo created this revision. h-joo added a reviewer: ABataev. h-joo added projects: clang, OpenMP. Herald added subscribers: cfe-commits, arphaman, guansong, yaxunl. Herald added a reviewer: jdoerfert. This is a fix for Bug 45383 . This revision fixes