Re: [clang-tools-extra] r354505 - [clangd] Store index in '.clangd/index' instead of '.clangd-index'

2019-02-27 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354982. On Wed, Feb 20, 2019 at 8:07 PM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Wed Feb 20 11:08:06 2019 > New Revision: 354505 > > URL: http://llvm.org/viewvc/llvm-project?rev=354505=rev > Log: > [clangd] Store index in '.clangd/index' instead

Re: [clang-tools-extra] r353422 - [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

2019-02-27 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354980. On Thu, Feb 7, 2019 at 5:04 PM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Thu Feb 7 08:04:30 2019 > New Revision: 353422 > > URL: http://llvm.org/viewvc/llvm-project?rev=353422=rev > Log: > [clangd] Reduce number of threads used by

r354968 - AttrDocs.td: fix broken bullet-point indentation

2019-02-27 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 27 05:11:37 2019 New Revision: 354968 URL: http://llvm.org/viewvc/llvm-project?rev=354968=rev Log: AttrDocs.td: fix broken bullet-point indentation Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL:

Re: r354723 - Remove OpenBSD case for old system libstdc++ header path as OpenBSD

2019-02-26 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354859. On Sat, Feb 23, 2019 at 8:20 AM Brad Smith via cfe-commits wrote: > > Author: brad > Date: Fri Feb 22 23:21:19 2019 > New Revision: 354723 > > URL: http://llvm.org/viewvc/llvm-project?rev=354723=rev > Log: > Remove OpenBSD case for old system libstdc++ header

Re: r354721 - Remove sanitizer context workaround no longer necessary

2019-02-26 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354858. On Sat, Feb 23, 2019 at 7:18 AM Brad Smith via cfe-commits wrote: > > Author: brad > Date: Fri Feb 22 22:19:28 2019 > New Revision: 354721 > > URL: http://llvm.org/viewvc/llvm-project?rev=354721=rev > Log: > Remove sanitizer context workaround no longer necessary

Re: r354351 - Remove extraneous space in MSVC-style diagnostic output

2019-02-20 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354459. On Tue, Feb 19, 2019 at 5:57 PM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Tue Feb 19 08:58:25 2019 > New Revision: 354351 > > URL: http://llvm.org/viewvc/llvm-project?rev=354351=rev > Log: > Remove extraneous space

r354351 - Remove extraneous space in MSVC-style diagnostic output

2019-02-19 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 19 08:58:25 2019 New Revision: 354351 URL: http://llvm.org/viewvc/llvm-project?rev=354351=rev Log: Remove extraneous space in MSVC-style diagnostic output There was an extra space between the file location and the diagnostic message: /tmp/a.c(1,12): warning: unused

Re: r354147 - Variable auto-init of blocks capturing self after init bugfix

2019-02-18 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354248. On Fri, Feb 15, 2019 at 6:25 PM JF Bastien via cfe-commits wrote: > > Author: jfb > Date: Fri Feb 15 09:26:29 2019 > New Revision: 354147 > > URL: http://llvm.org/viewvc/llvm-project?rev=354147=rev > Log: > Variable auto-init of blocks capturing self after init

Re: r354035 - [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

2019-02-18 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354247. On Thu, Feb 14, 2019 at 4:42 PM Bruno Ricci via cfe-commits wrote: > > Author: brunoricci > Date: Thu Feb 14 07:43:17 2019 > New Revision: 354035 > > URL: http://llvm.org/viewvc/llvm-project?rev=354035=rev > Log: > [Sema] Fix a regression introduced in

Re: r353943 - [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-15 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r354130. Please let me know if there are any follow-ups. On Wed, Feb 13, 2019 at 1:25 PM Adam Balogh via cfe-commits wrote: > > Author: baloghadamsoftware > Date: Wed Feb 13 04:25:47 2019 > New Revision: 353943 > > URL: http://llvm.org/viewvc/llvm-project?rev=353943=rev >

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

2019-02-15 Thread Hans Wennborg via cfe-commits
Merged in r354129. Please let me know if there are any follow-ups. Thanks, Hans On Fri, Feb 15, 2019 at 12:16 AM Erik Pilkington wrote: > > Hans, can you merge this diagnostic regression fix into LLVM 8? > > Thanks! > > > On Feb 14, 2019, at 2:48 PM, Erik Pilkington via cfe-commits > > wrote:

Re: r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

2019-02-14 Thread Hans Wennborg via cfe-commits
Thanks everyone, merged in r354015. On Wed, Feb 13, 2019 at 9:48 PM Aaron Ballman wrote: > > I'm fine with rolling it into 8.0. > > ~Aaron > > On Wed, Feb 13, 2019 at 3:47 PM Erik Pilkington via cfe-commits > wrote: > > > > It isn’t a super common issue, but this is a pretty low-risk fix so I

Re: r350404 - Refactor the way we handle diagnosing unused expression results.

2019-02-13 Thread Hans Wennborg via cfe-commits
Reverted on the release_80 branch in r353935. On Fri, Jan 4, 2019 at 6:01 PM Aaron Ballman via cfe-commits wrote: > > Author: aaronballman > Date: Fri Jan 4 08:58:14 2019 > New Revision: 350404 > > URL: http://llvm.org/viewvc/llvm-project?rev=350404=rev > Log: > Refactor the way we handle

Re: r353656 - long double is double on OpenBSD/NetBSD/PPC.

2019-02-12 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r353831. On Mon, Feb 11, 2019 at 3:52 AM Brad Smith via cfe-commits wrote: > > Author: brad > Date: Sun Feb 10 18:53:16 2019 > New Revision: 353656 > > URL: http://llvm.org/viewvc/llvm-project?rev=353656=rev > Log: > long double is double on OpenBSD/NetBSD/PPC. > > Patch by

Re: r353402 - [clang-cl] support /Oy- on aarch64

2019-02-12 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r353829. On Thu, Feb 7, 2019 at 1:46 PM Martin Storsjo via cfe-commits wrote: > > Author: mstorsjo > Date: Thu Feb 7 04:46:49 2019 > New Revision: 353402 > > URL: http://llvm.org/viewvc/llvm-project?rev=353402=rev > Log: > [clang-cl] support /Oy- on aarch64 > > MSVC supports

Re: r353493 - [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

2019-02-12 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r353828. On Fri, Feb 8, 2019 at 2:17 AM Eli Friedman via cfe-commits wrote: > > Author: efriedma > Date: Thu Feb 7 17:17:49 2019 > New Revision: 353493 > > URL: http://llvm.org/viewvc/llvm-project?rev=353493=rev > Log: > [COFF, ARM64] Fix types for _ReadStatusReg,

Re: r353431 - [OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0

2019-02-12 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r353826. On Thu, Feb 7, 2019 at 6:32 PM Anastasia Stulova via cfe-commits wrote: > > Author: stulova > Date: Thu Feb 7 09:32:37 2019 > New Revision: 353431 > > URL: http://llvm.org/viewvc/llvm-project?rev=353431=rev > Log: > [OpenCL][PR40603] In C++ preserve compatibility with

Re: r353411 - Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS.

2019-02-12 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r353825. On Thu, Feb 7, 2019 at 4:13 PM Erich Keane via cfe-commits wrote: > > Author: erichkeane > Date: Thu Feb 7 07:14:11 2019 > New Revision: 353411 > > URL: http://llvm.org/viewvc/llvm-project?rev=353411=rev > Log: > Fix r350643 to limit COFF emission to <= 32 BYTES

Re: r353495 - Variable auto-init: fix __block initialization

2019-02-12 Thread Hans Wennborg via cfe-commits
Merged to release_80 in r353807. On Fri, Feb 8, 2019 at 2:28 AM JF Bastien via cfe-commits wrote: > > Author: jfb > Date: Thu Feb 7 17:29:17 2019 > New Revision: 353495 > > URL: http://llvm.org/viewvc/llvm-project?rev=353495=rev > Log: > Variable auto-init: fix __block initialization > >

[libunwind] r353414 - Creating release candidate rc2 from release_800 branch

2019-02-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Feb 7 07:36:17 2019 New Revision: 353414 URL: http://llvm.org/viewvc/llvm-project?rev=353414=rev Log: Creating release candidate rc2 from release_800 branch Added: libunwind/tags/RELEASE_800/rc2/ - copied from r353413, libunwind/branches/release_80/

[libclc] r353414 - Creating release candidate rc2 from release_800 branch

2019-02-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Feb 7 07:36:17 2019 New Revision: 353414 URL: http://llvm.org/viewvc/llvm-project?rev=353414=rev Log: Creating release candidate rc2 from release_800 branch Added: libclc/tags/RELEASE_800/rc2/ - copied from r353413, libclc/branches/release_80/

r353393 - Typo: s/follwing/following

2019-02-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Feb 7 03:13:28 2019 New Revision: 353393 URL: http://llvm.org/viewvc/llvm-project?rev=353393=rev Log: Typo: s/follwing/following Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL:

Re: [clang-tools-extra] r353327 - [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

2019-02-07 Thread Hans Wennborg via cfe-commits
Merged in r353391. On Wed, Feb 6, 2019 at 8:17 PM Roman Lebedev via cfe-commits wrote: > > Author: lebedevri > Date: Wed Feb 6 11:17:30 2019 > New Revision: 353327 > > URL: http://llvm.org/viewvc/llvm-project?rev=353327=rev > Log: > [clang-tidy] modernize-avoid-c-arrays: avoid main function

Re: [libunwind] r352016 - [libunwind] Don't abort if encoutering invalid .eh_frame_hdr

2019-02-06 Thread Hans Wennborg via cfe-commits
It seems like a good change, so merged in r353287. Please let me know if you have any concerns. On Tue, Jan 29, 2019 at 3:11 PM Hans Wennborg wrote: > > Should we merge this to 8.0? > > On Wed, Jan 23, 2019 at 10:04 PM Petr Hosek via cfe-commits > wrote: > > > > Author: phosek > > Date: Wed Jan

[libunwind] r353287 - Merging r352016:

2019-02-06 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 6 02:22:11 2019 New Revision: 353287 URL: http://llvm.org/viewvc/llvm-project?rev=353287=rev Log: Merging r352016: r352016 | phosek | 2019-01-24 04:04:42 +0100 (Thu, 24 Jan 2019) | 12 lines

Re: r352307 - Remove Expr sugar decorating the CXXUuidofExpr node.

2019-02-04 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r353031. On Sun, Jan 27, 2019 at 8:23 AM Bill Wendling via cfe-commits wrote: > > Author: void > Date: Sat Jan 26 23:24:03 2019 > New Revision: 352307 > > URL: http://llvm.org/viewvc/llvm-project?rev=352307=rev > Log: > Remove Expr sugar decorating the CXXUuidofExpr node. > >

Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

2019-02-01 Thread Hans Wennborg via cfe-commits
Merged in r352860. On Tue, Jan 29, 2019 at 2:48 PM Hans Wennborg wrote: > > Thanks! I'll merge it after it's been in trunk for a little. Please > let me know if there are any issues or follow-up commits. > > Cheers, > Hans > > On Tue, Jan 29, 2019 at 4:04 AM Sam Parker wrote: > > > > Hi Hans, >

Re: r352463 - [AArch64] Update int64_t ACLE builtin arguments

2019-02-01 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352860. On Tue, Jan 29, 2019 at 10:03 AM Sam Parker via cfe-commits wrote: > > Author: sam_parker > Date: Tue Jan 29 01:04:03 2019 > New Revision: 352463 > > URL: http://llvm.org/viewvc/llvm-project?rev=352463=rev > Log: > [AArch64] Update int64_t ACLE builtin arguments > >

Re: r352156 - [AArch64] Make the test for rsr and rsr64 stricter

2019-02-01 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352859. On Fri, Jan 25, 2019 at 3:42 AM Petr Hosek via cfe-commits wrote: > > Author: phosek > Date: Thu Jan 24 18:42:30 2019 > New Revision: 352156 > > URL: http://llvm.org/viewvc/llvm-project?rev=352156=rev > Log: > [AArch64] Make the test for rsr and rsr64 stricter > > ACLE

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

2019-02-01 Thread Hans Wennborg via cfe-commits
Thanks! I've merged r352822 to the branch in r352855. On Fri, Feb 1, 2019 at 1:37 AM Shoaib Meenai wrote: > > +Hans for managing the 8.0 branch. > > On 1/31/19, 4:15 PM, "ahatan...@apple.com on behalf of Akira Hatanaka" > wrote: > > Reverted patch in r352822. I’ll send a new patch later

Re: r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

2019-02-01 Thread Hans Wennborg via cfe-commits
Sure, r352854. On Wed, Jan 30, 2019 at 10:16 PM Erik Pilkington wrote: > > Hans, can you cherry-pick this into LLVM 8? > > Thanks! > > On 1/30/19 1:14 PM, Erik Pilkington via cfe-commits wrote: > > Author: epilk > > Date: Wed Jan 30 13:14:08 2019 > > New Revision: 352672 > > > > URL:

Re: r352610 - [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes

2019-01-30 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352650. On Wed, Jan 30, 2019 at 3:20 AM Michal Gorny via cfe-commits wrote: > > Author: mgorny > Date: Wed Jan 30 00:20:24 2019 > New Revision: 352610 > > URL: http://llvm.org/viewvc/llvm-project?rev=352610=rev > Log: > [clang] [Driver] [NetBSD] Append -rpath for shared

Re: r352539 - Revert "OpenCL: Extend argument promotion rules to vector types"

2019-01-29 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352547. On Tue, Jan 29, 2019 at 3:49 PM Matt Arsenault via cfe-commits wrote: > > Author: arsenm > Date: Tue Jan 29 12:49:47 2019 > New Revision: 352539 > > URL: http://llvm.org/viewvc/llvm-project?rev=352539=rev > Log: > Revert "OpenCL: Extend argument promotion rules to

Re: [libunwind] r352016 - [libunwind] Don't abort if encoutering invalid .eh_frame_hdr

2019-01-29 Thread Hans Wennborg via cfe-commits
Should we merge this to 8.0? On Wed, Jan 23, 2019 at 10:04 PM Petr Hosek via cfe-commits wrote: > > Author: phosek > Date: Wed Jan 23 19:04:42 2019 > New Revision: 352016 > > URL: http://llvm.org/viewvc/llvm-project?rev=352016=rev > Log: > [libunwind] Don't abort if encoutering invalid

Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

2019-01-29 Thread Hans Wennborg via cfe-commits
Thanks! I'll merge it after it's been in trunk for a little. Please let me know if there are any issues or follow-up commits. Cheers, Hans On Tue, Jan 29, 2019 at 4:04 AM Sam Parker wrote: > > Hi Hans, > > > I've recommitted the change in r352463. > > > cheers, > > Sam > > > Sam Parker > >

Re: r352369 - [AST] Introduce GenericSelectionExpr::Association

2019-01-28 Thread Hans Wennborg via cfe-commits
Hi, This doesn't compile when using GCC 4.8.4: 372/372] Building CXX object tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o FAILED: tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o /work/gccprefix/bin/g++

Re: [clang-tools-extra] r352231 - [clang-tidy] fix unit tests for dropped _Float16 support in X86

2019-01-28 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352368. On Fri, Jan 25, 2019 at 11:05 AM Jonas Toth via cfe-commits wrote: > > Author: jonastoth > Date: Fri Jan 25 11:05:12 2019 > New Revision: 352231 > > URL: http://llvm.org/viewvc/llvm-project?rev=352231=rev > Log: > [clang-tidy] fix unit tests for dropped _Float16 support

Re: r352229 - Remove F16 literal support based on Float16 support.

2019-01-28 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352365. On Fri, Jan 25, 2019 at 10:36 AM Erich Keane via cfe-commits wrote: > > Author: erichkeane > Date: Fri Jan 25 10:36:20 2019 > New Revision: 352229 > > URL: http://llvm.org/viewvc/llvm-project?rev=352229=rev > Log: > Remove F16 literal support based on Float16 support. >

Re: r352221 - Disable _Float16 for non ARM/SPIR Targets

2019-01-28 Thread Hans Wennborg via cfe-commits
Merged together with r35 to 8.0 in r352363. On Fri, Jan 25, 2019 at 9:27 AM Erich Keane via cfe-commits wrote: > > Author: erichkeane > Date: Fri Jan 25 09:27:57 2019 > New Revision: 352221 > > URL: http://llvm.org/viewvc/llvm-project?rev=352221=rev > Log: > Disable _Float16 for non ARM/SPIR

Re: r352105 - [WebAssembly] Add a __wasi__ target macro

2019-01-28 Thread Hans Wennborg via cfe-commits
Merged in r352360. On Thu, Jan 24, 2019 at 1:05 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Thu Jan 24 13:05:11 2019 > New Revision: 352105 > > URL: http://llvm.org/viewvc/llvm-project?rev=352105=rev > Log: > [WebAssembly] Add a __wasi__ target macro > > This adds a `__wasi__`

Re: r352099 - [WebAssembly] Factor commonality between wasm32 and wasm64 in test/Preprocessor/init.c

2019-01-28 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352359. On Thu, Jan 24, 2019 at 12:31 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Thu Jan 24 12:31:11 2019 > New Revision: 352099 > > URL: http://llvm.org/viewvc/llvm-project?rev=352099=rev > Log: > [WebAssembly] Factor commonality between wasm32 and wasm64 in

Re: r352323 - [SemaCXX] Fix ICE with structure bindings to members of template

2019-01-28 Thread Hans Wennborg via cfe-commits
Thanks for letting me know! Merged in r352356. On Sun, Jan 27, 2019 at 12:06 PM Richard Smith wrote: > > Hi Hans, > > This is a safe change that fixes a crash; it'd be good to get this into clang > 8. > > Thanks! > > On Sun, 27 Jan 2019, 11:19 Nicolas Lesser via cfe-commits, > wrote: >> >>

Re: r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

2019-01-28 Thread Hans Wennborg via cfe-commits
Thanks for looking into this. I've reverted the test assertions on the branch in r352354. On Mon, Jan 28, 2019 at 1:14 AM Sam McCall wrote: > > This is kind of expected: r347205 was a bugfix. > Reverting it causes a real bug, and the tests are failing. The bug is > acceptable for 8.0 - it

Re: r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

2019-01-25 Thread Hans Wennborg via cfe-commits
Sorry to bring more bad news, but merging this seems to have regressed a clangd test on the branch (I didn't notice at the time, because I ran the wrong set of tests, d'oh). I've searched my inbox but couldn't find any recent commits touching the test. Do you have any idea what might be

Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

2019-01-25 Thread Hans Wennborg via cfe-commits
I see this was reverted later, but please keep me posted on the resolution as I think we might want to merge this to the 8.0 release branch as well. Thanks, Hans On Mon, Jan 21, 2019 at 3:01 AM Sam Parker via cfe-commits wrote: > > Author: sam_parker > Date: Mon Jan 21 03:01:05 2019 > New

Re: r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

2019-01-25 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352225. On Thu, Jan 24, 2019 at 10:55 AM Sam McCall via cfe-commits wrote: > > Author: sammccall > Date: Thu Jan 24 10:55:24 2019 > New Revision: 352079 > > URL: http://llvm.org/viewvc/llvm-project?rev=352079=rev > Log: > [FileManager] Revert r347205 to avoid PCH

Re: r351579 - [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

2019-01-24 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352139. On Fri, Jan 18, 2019 at 11:58 AM Vladimir Stefanovic via cfe-commits wrote: > > Author: vstefanovic > Date: Fri Jan 18 11:54:51 2019 > New Revision: 351579 > > URL: http://llvm.org/viewvc/llvm-project?rev=351579=rev > Log: > [mips] Add '-mrelax-pic-calls',

Re: r352102 - Add a triple to this test so it passes for targets where alignof(double)

2019-01-24 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r352132. On Thu, Jan 24, 2019 at 12:52 PM Richard Smith via cfe-commits wrote: > > Author: rsmith > Date: Thu Jan 24 12:52:56 2019 > New Revision: 352102 > > URL: http://llvm.org/viewvc/llvm-project?rev=352102=rev > Log: > Add a triple to this test so it passes for targets where

Re: [clang-tools-extra] r352040 - [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

2019-01-24 Thread Hans Wennborg via cfe-commits
Merged in r352118 (cfe) and r352120 (clang-tools-extra). Please let me know if there are any follow-ups. Thanks, Hans On Thu, Jan 24, 2019 at 5:11 AM Ilya Biryukov wrote: > > +Hans Wennborg, could you please merge this fix into the release branch? > > On Thu, Jan 24, 2019 at 1:41 PM Ilya

[libunwind] r352000 - Creating release candidate rc1 from release_800 branch

2019-01-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 23 16:44:29 2019 New Revision: 352000 URL: http://llvm.org/viewvc/llvm-project?rev=352000=rev Log: Creating release candidate rc1 from release_800 branch Added: libunwind/tags/RELEASE_800/ libunwind/tags/RELEASE_800/rc1/ - copied from r351999,

[libclc] r352000 - Creating release candidate rc1 from release_800 branch

2019-01-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 23 16:44:29 2019 New Revision: 352000 URL: http://llvm.org/viewvc/llvm-project?rev=352000=rev Log: Creating release candidate rc1 from release_800 branch Added: libclc/tags/RELEASE_800/ libclc/tags/RELEASE_800/rc1/ - copied from r351999,

Re: [clang-tools-extra] r351788 - [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

2019-01-23 Thread Hans Wennborg via cfe-commits
Thanks for the info! On Wed, Jan 23, 2019 at 2:24 AM Kadir Çetinkaya wrote: > > Hey Hans, > > There is actually a parent for this patch at > https://reviews.llvm.org/rC351531 and it hasn't been merged. I've merged it now in r351961. > > In addition to that not exactly as a follow-up, but

Re: [clang-tools-extra] r351788 - [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

2019-01-22 Thread Hans Wennborg via cfe-commits
This has been merged to the 8.0 branch in r351860. Please let me know if there are any follow-ups so they can be merged too. Thanks, Hans On Tue, Jan 22, 2019 at 1:10 AM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Tue Jan 22 01:10:20 2019 > New Revision: 351788 > > URL:

Re: r351580 - [OPENMP][DOCS] Release notes/OpenMP support updates, NFC.

2019-01-22 Thread Hans Wennborg via cfe-commits
Thanks, I've merged it to 8.0 in r351839. Since the release notes are for 8.0 and not trunk, I've removed the change from trunk in r351841. On Fri, Jan 18, 2019 at 12:05 PM Kelvin Li wrote: > > Hi Hans, > > I am not sure if it is the proper way to request the change committed > to the

r351841 - ReleaseNotes: remove openmp notes from r351580

2019-01-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 22 09:01:39 2019 New Revision: 351841 URL: http://llvm.org/viewvc/llvm-project?rev=351841=rev Log: ReleaseNotes: remove openmp notes from r351580 They were for the 8.0 branch, and have been committed there in r351839. Modified: cfe/trunk/docs/ReleaseNotes.rst

Re: [clang-tools-extra] r351463 - [Documentation] Add a chapter about Clang-tidy integrations.

2019-01-18 Thread Hans Wennborg via cfe-commits
Merged to 8.0 along with the follow-ups in r351538. On Thu, Jan 17, 2019 at 7:35 PM Eugene Zelenko via cfe-commits wrote: > > Author: eugenezelenko > Date: Thu Jan 17 10:31:34 2019 > New Revision: 351463 > > URL: http://llvm.org/viewvc/llvm-project?rev=351463=rev > Log: > [Documentation] Add a

Re: r351459 - [ObjC] Follow-up r350768 and allow the use of unavailable methods that are

2019-01-18 Thread Hans Wennborg via cfe-commits
Merged in r351535. Please let me know if there are any more issues in this area. Also, do you want to write something for r350768 and this in the release notes? On Thu, Jan 17, 2019 at 7:22 PM Alex L wrote: > > Hi Hans, > > Could you please cherry-pick this change into the release branch? > >

Re: r351457 - TLS: Respect visibility for thread_local variables on Darwin (PR40327)

2019-01-18 Thread Hans Wennborg via cfe-commits
Merged to the 8.0 branch in r351533. Please let me know if there are any further commits for this issue. Thanks, Hans On Thu, Jan 17, 2019 at 6:57 PM Vlad Tsyrklevich via cfe-commits wrote: > > Author: vlad.tsyrklevich > Date: Thu Jan 17 09:53:45 2019 > New Revision: 351457 > > URL:

Re: r351344 - [MSP430] Improve support of 'interrupt' attribute

2019-01-17 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r351441. On Wed, Jan 16, 2019 at 2:47 PM Anton Korobeynikov via cfe-commits wrote: > > Author: asl > Date: Wed Jan 16 05:44:01 2019 > New Revision: 351344 > > URL: http://llvm.org/viewvc/llvm-project?rev=351344=rev > Log: > [MSP430] Improve support of 'interrupt' attribute > > *

Re: r351340 - [MSP430] Fix msp430-toolchain.c on Windows (added in r351228)

2019-01-17 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r351420. On Wed, Jan 16, 2019 at 2:32 PM Anton Korobeynikov via cfe-commits wrote: > > Author: asl > Date: Wed Jan 16 05:28:30 2019 > New Revision: 351340 > > URL: http://llvm.org/viewvc/llvm-project?rev=351340=rev > Log: > [MSP430] Fix msp430-toolchain.c on Windows (added in

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-17 Thread Hans Wennborg via cfe-commits
On Wed, Jan 16, 2019 at 7:46 PM Greg Bedwell wrote: > > > > Unfortunately this trips up a variety of buildbots: > > Platform REQUIRES added in r351360, please do revert & fix if this test is > > supposed to work elsewhere. > > Looks like the test fail just made it into the release-8.0.0 branch

Re: r351334 - Set '-target' flag in the test checking the MacOS include dir

2019-01-16 Thread Hans Wennborg via cfe-commits
Merged to 8.0 in r351343. On Wed, Jan 16, 2019 at 2:22 PM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Wed Jan 16 05:18:59 2019 > New Revision: 351334 > > URL: http://llvm.org/viewvc/llvm-project?rev=351334=rev > Log: > Set '-target' flag in the test checking the MacOS

[libunwind] r351338 - Drop svn version suffix

2019-01-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 16 05:27:08 2019 New Revision: 351338 URL: http://llvm.org/viewvc/llvm-project?rev=351338=rev Log: Drop svn version suffix Modified: libunwind/branches/release_80/CMakeLists.txt Modified: libunwind/branches/release_80/CMakeLists.txt URL:

[libclc] r351321 - Creating release_80 branch off revision 351319

2019-01-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 16 03:00:55 2019 New Revision: 351321 URL: http://llvm.org/viewvc/llvm-project?rev=351321=rev Log: Creating release_80 branch off revision 351319 Added: libclc/branches/release_80/ - copied from r351319, libclc/trunk/

[libunwind] r351321 - Creating release_80 branch off revision 351319

2019-01-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 16 03:00:55 2019 New Revision: 351321 URL: http://llvm.org/viewvc/llvm-project?rev=351321=rev Log: Creating release_80 branch off revision 351319 Added: libunwind/branches/release_80/ - copied from r351319, libunwind/trunk/

[libunwind] r351320 - Bump the trunk version to 9.0.0svn

2019-01-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 16 02:57:02 2019 New Revision: 351320 URL: http://llvm.org/viewvc/llvm-project?rev=351320=rev Log: Bump the trunk version to 9.0.0svn Modified: libunwind/trunk/CMakeLists.txt libunwind/trunk/docs/conf.py Modified: libunwind/trunk/CMakeLists.txt URL:

r351320 - Bump the trunk version to 9.0.0svn

2019-01-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 16 02:57:02 2019 New Revision: 351320 URL: http://llvm.org/viewvc/llvm-project?rev=351320=rev Log: Bump the trunk version to 9.0.0svn Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[clang-tools-extra] r351320 - Bump the trunk version to 9.0.0svn

2019-01-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 16 02:57:02 2019 New Revision: 351320 URL: http://llvm.org/viewvc/llvm-project?rev=351320=rev Log: Bump the trunk version to 9.0.0svn Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/conf.py Modified:

r351312 - UsersManual.rst: Update the clang-cl flags section

2019-01-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 16 01:13:47 2019 New Revision: 351312 URL: http://llvm.org/viewvc/llvm-project?rev=351312=rev Log: UsersManual.rst: Update the clang-cl flags section Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

r351194 - Update year in license files

2019-01-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified:

[libclc] r351194 - Update year in license files

2019-01-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified:

[libunwind] r351194 - Update year in license files

2019-01-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified:

[clang-tools-extra] r351194 - Update year in license files

2019-01-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified:

r348569 - Fix thunks returning memptrs via sret by emitting also scalar return values directly in sret slot (PR39901)

2018-12-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Dec 7 00:17:26 2018 New Revision: 348569 URL: http://llvm.org/viewvc/llvm-project?rev=348569=rev Log: Fix thunks returning memptrs via sret by emitting also scalar return values directly in sret slot (PR39901) Thunks that return member pointers via sret are broken due to

Re: r347417 - Re-Reinstate 347294 with a fix for the failures.

2018-11-28 Thread Hans Wennborg via cfe-commits
There's more details on http://crbug.com/908372, but my conclusion is that there wasn't anything wrong with your commit, it just triggered a bug in Chromium's code that had been hiding there for six years without anyone noticing. I've re-committed your change in r347756. Sorry for the hassle. On

[clang-tools-extra] r347757 - Re-commit r347419 "Update call to EvaluateAsInt() to the new syntax."

2018-11-28 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Nov 28 06:04:26 2018 New Revision: 347757 URL: http://llvm.org/viewvc/llvm-project?rev=347757=rev Log: Re-commit r347419 "Update call to EvaluateAsInt() to the new syntax." Modified: clang-tools-extra/trunk/clang-tidy/bugprone/MisplacedWideningCastCheck.cpp

r347756 - Re-commit r347417 "Re-Reinstate 347294 with a fix for the failures."

2018-11-28 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Nov 28 06:04:12 2018 New Revision: 347756 URL: http://llvm.org/viewvc/llvm-project?rev=347756=rev Log: Re-commit r347417 "Re-Reinstate 347294 with a fix for the failures." This was reverted in r347656 due to me thinking it caused a miscompile of Chromium. Turns out it was

[clang-tools-extra] r347657 - Revert r347419 "Update call to EvaluateAsInt() to the new syntax."

2018-11-27 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Nov 27 06:15:37 2018 New Revision: 347657 URL: http://llvm.org/viewvc/llvm-project?rev=347657=rev Log: Revert r347419 "Update call to EvaluateAsInt() to the new syntax." It's pre-requisite was reverted in r347656. Modified:

Re: r347417 - Re-Reinstate 347294 with a fix for the failures.

2018-11-27 Thread Hans Wennborg via cfe-commits
I've reverted this and the follow-ups in r347656 and included a reduced repro for the miscompile. On Tue, Nov 27, 2018 at 11:36 AM, Hans Wennborg wrote: > We're hitting test failures due to this in Chromium: > https://crbug.com/908372 I'm still not sure what's going on, just > wanted to give a

r347656 - Revert r347417 "Re-Reinstate 347294 with a fix for the failures."

2018-11-27 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Nov 27 06:01:40 2018 New Revision: 347656 URL: http://llvm.org/viewvc/llvm-project?rev=347656=rev Log: Revert r347417 "Re-Reinstate 347294 with a fix for the failures." This caused a miscompile in Chrome (see crbug.com/908372) that's illustrated by this small reduction:

Re: r347417 - Re-Reinstate 347294 with a fix for the failures.

2018-11-27 Thread Hans Wennborg via cfe-commits
We're hitting test failures due to this in Chromium: https://crbug.com/908372 I'm still not sure what's going on, just wanted to give a heads up in case someone else is seeing issues. On Wed, Nov 21, 2018 at 9:44 PM, Bill Wendling via cfe-commits wrote: > Author: void > Date: Wed Nov 21 12:44:18

r346748 - UserManual: Tweak the /Zc:dllexportInlines- docs some

2018-11-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Nov 13 01:05:12 2018 New Revision: 346748 URL: http://llvm.org/viewvc/llvm-project?rev=346748=rev Log: UserManual: Tweak the /Zc:dllexportInlines- docs some Addressing comments on https://reviews.llvm.org/D54319 Modified: cfe/trunk/docs/UsersManual.rst

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

2018-11-12 Thread Hans Wennborg via cfe-commits
Hmm, maybe I misunderstood your initial request for this. The current implementation does what the warnings says: If the compiler falls back to cl.exe, /Zc:dllexportInlines- will be ignored. This suggests to the user that it's a bad idea, but they can go ahead if they want to. It sounds like

r346640 - Release notes: Mention clang-cl's /Zc:dllexportInlines- flag

2018-11-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Nov 12 00:42:21 2018 New Revision: 346640 URL: http://llvm.org/viewvc/llvm-project?rev=346640=rev Log: Release notes: Mention clang-cl's /Zc:dllexportInlines- flag Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

r346639 - clang-cl: Add documentation for /Zc:dllexportInlines-

2018-11-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Nov 12 00:38:10 2018 New Revision: 346639 URL: http://llvm.org/viewvc/llvm-project?rev=346639=rev Log: clang-cl: Add documentation for /Zc:dllexportInlines- Differential revision: https://reviews.llvm.org/D54319 Modified: cfe/trunk/docs/UsersManual.rst

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

2018-11-09 Thread Hans Wennborg via cfe-commits
On Fri, Nov 9, 2018 at 4:53 PM, Nico Weber wrote: > This only prints the warning when /fallback actually happens, right? No, it prints it when the fallback job is created, not when (or if) it runs. I.e. it prints if the /fallback flag is used, regardless of whether it actually falls back or not.

r346393 - clang-cl: Add "/clang:" pass-through arg support.

2018-11-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Nov 8 03:27:04 2018 New Revision: 346393 URL: http://llvm.org/viewvc/llvm-project?rev=346393=rev Log: clang-cl: Add "/clang:" pass-through arg support. The clang-cl driver disables access to command line options outside of the "Core" and "CLOption" sets of command line

Re: r346167 - [Driver] Reland again again: Default Android toolchains to libc++.

2018-11-06 Thread Hans Wennborg via cfe-commits
Just fyi: this broke Chrome's build of compiler-rt using tot Clang against the sysroot generated by NDK r16's (I think) make_standalong_toolchain.py, see https://crbug.com/902270 It looks like we'll just hack around it though. On Mon, Nov 5, 2018 at 9:57 PM, Dan Albert via cfe-commits wrote: >

r345709 - Follow-up to r345699: Call CheckStaticLocalForDllExport later for templates

2018-10-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Oct 31 03:34:46 2018 New Revision: 345709 URL: http://llvm.org/viewvc/llvm-project?rev=345709=rev Log: Follow-up to r345699: Call CheckStaticLocalForDllExport later for templates Calling it too early might cause dllimport to get inherited onto the VarDecl before the

r345699 - [clang-cl] Inherit dllexport to static locals also in template instantiations (PR39496)

2018-10-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Oct 31 01:38:48 2018 New Revision: 345699 URL: http://llvm.org/viewvc/llvm-project?rev=345699=rev Log: [clang-cl] Inherit dllexport to static locals also in template instantiations (PR39496) In the course of D51340, @takuto.ikuta discovered that Clang fails to put

Re: r345330 - Add MS ABI mangling for operator<=>.

2018-10-26 Thread Hans Wennborg via cfe-commits
It seems the generated MS mangling differs between 32- and 64-bit, and the test expects the latter. Let's revert in the meantime.. r345380 On Fri, Oct 26, 2018 at 1:10 PM, Peter Smith via cfe-commits wrote: > This commit, specifically the changes made to >

r345380 - Revert r345330 "Add MS ABI mangling for operator<=>."

2018-10-26 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Oct 26 06:05:45 2018 New Revision: 345380 URL: http://llvm.org/viewvc/llvm-project?rev=345380=rev Log: Revert r345330 "Add MS ABI mangling for operator<=>." The generated MS manglings differ between 32- and 64-bit, and the test only expects the latter. See also the commit

Re: r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

2018-10-23 Thread Hans Wennborg via cfe-commits
I found another assert (two really) caused by this patch. Reproducer for one of them here: https://bugs.chromium.org/p/chromium/issues/detail?id=898160#c3 On Tue, Oct 23, 2018 at 6:19 AM, Hans Wennborg wrote: > This broke Chromium again. I've reverted in rr345026 > > See

Re: r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

2018-10-23 Thread Hans Wennborg via cfe-commits
This broke Chromium again. I've reverted in rr345026 See https://bugs.chromium.org/p/chromium/issues/detail?id=898152#c1 for the reproducer. On Tue, Oct 23, 2018 at 1:06 AM, Hsiangkai Wang via cfe-commits wrote: > Author: hsiangkai > Date: Tue Oct 23 01:06:21 2018 > New Revision: 345009 > >

r345026 - Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix PR39094)"

2018-10-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Oct 23 06:17:13 2018 New Revision: 345026 URL: http://llvm.org/viewvc/llvm-project?rev=345026=rev Log: Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix PR39094)" This broke the Chromium build. See

r344789 - Java annotation declaration being handled correctly

2018-10-19 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Oct 19 09:19:52 2018 New Revision: 344789 URL: http://llvm.org/viewvc/llvm-project?rev=344789=rev Log: Java annotation declaration being handled correctly Previously, Java annotation declarations (@interface AnnotationName) were being handled as ObjC interfaces. This

r344469 - Try harder to fix test/Driver/cl-showfilenames.c

2018-10-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Sat Oct 13 15:22:03 2018 New Revision: 344469 URL: http://llvm.org/viewvc/llvm-project?rev=344469=rev Log: Try harder to fix test/Driver/cl-showfilenames.c Follow-up to r344462. Modified: cfe/trunk/test/Driver/cl-showfilenames.c Modified:

r344462 - Re-commit r344234 "clang-cl: Add /showFilenames option (PR31957)"

2018-10-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Sat Oct 13 12:13:14 2018 New Revision: 344462 URL: http://llvm.org/viewvc/llvm-project?rev=344462=rev Log: Re-commit r344234 "clang-cl: Add /showFilenames option (PR31957)" The test was failing on e.g. PPC which can't target Windows. Fix by requiring X86 target in the test.

r344234 - clang-cl: Add /showFilenames option (PR31957)

2018-10-11 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Oct 11 03:04:15 2018 New Revision: 344234 URL: http://llvm.org/viewvc/llvm-project?rev=344234=rev Log: clang-cl: Add /showFilenames option (PR31957) Add a /showFilenames option for users who want clang to echo the currently compiled filename. MSVC does this echoing by

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-10-02 Thread Hans Wennborg via cfe-commits
On Tue, Oct 2, 2018 at 12:02 PM, Hans Wennborg wrote: > I'm confused about what implicitly deleted means. In this code for example: > > struct S { > S(const S&) = default; > S& operator=(const S&) = default; > const int x; > }; > > void f(S ) { > S t = s; > } > > Clang will warn that

<    1   2   3   4   5   6   7   8   9   10   >