Re: [PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

Richard, what do you think? I don't believe this fixes a 3.9 regression, but the fix looks small, so it might be worth it. On Tue, Jan 31, 2017 at 12:07 PM, Akira Hatanaka wrote: > Thanks for the review. r293678. > > Should this be merged to 4.0? > >> On Jan 31, 2017, at

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

r293702. On Tue, Jan 31, 2017 at 11:12 AM, Richard Smith wrote: > Sure, let's take this for Clang 4. > > On 31 January 2017 at 10:39, Hans Wennborg wrote: >> >> Ping? >> >> On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote: >> >

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

Ping? On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote: > Should we merge this to the release branch? > > On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits > wrote: >> Author: majnemer >> Date: Mon Jan 16 22:14:25 2017 >> New

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On Thu, Jan 26, 2017 at 10:23 AM, Hans Wennborg wrote: > On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: >> On 20 January 2017 at 19:46, Eric Fiselier wrote: >>> This patch fixes a libc++abi test failure when compiled with GCC 5, 6,

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Ping? On Thu, Jan 26, 2017 at 10:21 AM, Hans Wennborg wrote: > Ping? > > On Mon, Jan 23, 2017 at 4:27 PM, Hans Wennborg wrote: >> Ping? >> >> On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: >>> Richard, what do you think? >>> >>>

Re: r293596 - Handle ObjCEncodeExpr in extractStringLiteralCharacter.

Merged in r293653. Thanks, Hans On Mon, Jan 30, 2017 at 7:16 PM, Akira Hatanaka wrote: > Hans, can this be merged to 4.0? This fixes a regression from 3.9 (the part I > touched was committed a few years ago, but didn’t cause an assert until > recently). > >> On Jan 30,

Re: r293416 - [c-index-test] Provide capability for 'c-index-test core' to dump symbol information from a PCH/module file.

Hi Argyrios, Can you provide more background on what this does. Is it fixing an existing issue or doing something new? r293461 is making changes beyond Index/ so I'd like Richard to take a look too. Thanks, Hans On Mon, Jan 30, 2017 at 8:18 AM, Argyrios Kyrtzidis wrote: >

Re: [libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"

Merged to 4.0 as discussed on PR31782. On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits wrote: > Author: bogner > Date: Mon Jan 30 19:26:09 2017 > New Revision: 293581 > > URL: http://llvm.org/viewvc/llvm-project?rev=293581=rev > Log: > Revert "Adorn

[libcxx] r293645 - Merging r293581:

Author: hans Date: Tue Jan 31 10:40:22 2017 New Revision: 293645 URL: http://llvm.org/viewvc/llvm-project?rev=293645=rev Log: Merging r293581: r293581 | bogner | 2017-01-30 17:26:09 -0800 (Mon, 30 Jan 2017) | 12 lines

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:55 PM, David Blaikie wrote: > > > On Fri, Jan 27, 2017 at 2:51 PM Mehdi Amini wrote: >> >> On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: >> >> >> >> On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini

Re: [libcxx] r291928 - Update version to 5.0

Thanks! I tried to update all version numbers I could find, but I obviously missed this one :-) On Fri, Jan 13, 2017 at 10:29 AM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Jan 13 12:29:56 2017 > New Revision: 291928 > > URL:

r293305 - clang-cl: Warn about /U flags that look like filenames (PR31662)

Author: hans Date: Fri Jan 27 11:09:41 2017 New Revision: 293305 URL: http://llvm.org/viewvc/llvm-project?rev=293305=rev Log: clang-cl: Warn about /U flags that look like filenames (PR31662) Both on Mac and Windows, it's common to have a 'Users' directory in the root of the filesystem, so one

Re: r293134 - [index] When indexing an ObjC method declaration use its base name for the location.

Merged in r293303. Thanks, Hans On Fri, Jan 27, 2017 at 8:19 AM, Argyrios Kyrtzidis via cfe-commits wrote: > *bump* > >> On Jan 25, 2017, at 6:36 PM, Argyrios Kyrtzidis wrote: >> >> Hi Hans, >> >> Could this go into the stable branch ? >> >>> On

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

I've got it. Merged in r293302. Thanks, Hans On Fri, Jan 27, 2017 at 4:49 AM, Alexey Bataev wrote: > Yes. Could you do it yourself or you want me to do it? > > - > Best regards, > Alexey Bataev > > 27.01.2017 2:33, Hans Wennborg пишет: >> Should we merge this

[libcxx] r293301 - Merging r292607:

Author: hans Date: Fri Jan 27 10:41:31 2017 New Revision: 293301 URL: http://llvm.org/viewvc/llvm-project?rev=293301=rev Log: Merging r292607: r292607 | ericwf | 2017-01-20 04:54:45 -0800 (Fri, 20 Jan 2017) | 1 line Don't

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

r293298. Thanks, Hans On Thu, Jan 26, 2017 at 6:38 PM, Saleem Abdulrasool wrote: > I think that this is safe enough and does make libunwind work on x86 Linux, > so lets go for it. > > On Thu, Jan 26, 2017 at 10:10 AM, Hans Wennborg wrote: >> >> Michał

[libunwind] r293298 - Merging r292723:

Author: hans Date: Fri Jan 27 10:27:43 2017 New Revision: 293298 URL: http://llvm.org/viewvc/llvm-project?rev=293298=rev Log: Merging r292723: r292723 | compnerd | 2017-01-21 08:22:59 -0800 (Sat, 21 Jan 2017) | 17 lines

Re: r292561 - PR31701: Fix crash on invalid caused by parsing a dependent initializer when we

r293297. Cheers, Hans On Thu, Jan 26, 2017 at 4:45 PM, Richard Smith wrote: > Sure, why not. > > On 26 January 2017 at 15:56, Hans Wennborg wrote: >> >> A candidate for clang 4? >> >> On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits >>

Re: r292561 - PR31701: Fix crash on invalid caused by parsing a dependent initializer when we

A candidate for clang 4? On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Jan 19 19:19:46 2017 > New Revision: 292561 > > URL: http://llvm.org/viewvc/llvm-project?rev=292561=rev > Log: > PR31701: Fix crash on invalid

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

Should we merge this to the release branch? On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Mon Jan 16 22:14:25 2017 > New Revision: 292194 > > URL: http://llvm.org/viewvc/llvm-project?rev=292194=rev > Log: > [AST]

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

Should we merge this to the release branch? On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Fri Jan 20 02:57:28 2017 > New Revision: 292590 > > URL: http://llvm.org/viewvc/llvm-project?rev=292590=rev > Log: > [OPENMP]

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: > On 20 January 2017 at 19:46, Eric Fiselier wrote: >> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. >> We should merge this into 4.0 to help get `check-all` clean. > > Hi

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

What's the status here? Waiting for Marshall? On Mon, Jan 23, 2017 at 10:20 AM, Hans Wennborg wrote: > Sounds good to me. > > On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier wrote: >> We should merge this patch into the 4.0 release branch. It is needed to make

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Ping? On Mon, Jan 23, 2017 at 4:27 PM, Hans Wennborg wrote: > Ping? > > On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: >> Richard, what do you think? >> >> On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: >>> I would love to see

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

Michał suggested on the PR that this should be merged to the release branch. Saleem, what do you think? On Sat, Jan 21, 2017 at 8:22 AM, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Sat Jan 21 10:22:59 2017 > New Revision: 292723 > > URL:

Re: [libcxx] r293154 - Use the new __has_feature(cxx_constexpr_string_builtins) for detection of the C-string intrinsics for constexpr support in std::char_traits. Thanks to Richard for the intrisic s

On Thu, Jan 26, 2017 at 6:08 AM, Marshall Clow wrote: > On Wed, Jan 25, 2017 at 10:58 PM, Marshall Clow via cfe-commits > wrote: >> >> Author: marshall >> Date: Thu Jan 26 00:58:29 2017 >> New Revision: 293154 >> >> URL:

[libcxx] r293193 - Merging r293154:

Author: hans Date: Thu Jan 26 11:55:46 2017 New Revision: 293193 URL: http://llvm.org/viewvc/llvm-project?rev=293193=rev Log: Merging r293154: r293154 | marshall | 2017-01-25 22:58:29 -0800 (Wed, 25 Jan 2017) | 1 line Use

Re: [libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

On Thu, Jan 26, 2017 at 6:05 AM, Marshall Clow wrote: > On Wed, Jan 25, 2017 at 9:11 AM, Hans Wennborg wrote: >> >> Should we merge this to 4.0? > > > Yes, please. r293192. Cheers, Hans ___ cfe-commits

[libcxx] r293192 - Merging r292990:

Author: hans Date: Thu Jan 26 11:51:25 2017 New Revision: 293192 URL: http://llvm.org/viewvc/llvm-project?rev=293192=rev Log: Merging r292990: r292990 | marshall | 2017-01-24 15:09:12 -0800 (Tue, 24 Jan 2017) | 1 line

Re: r292991 - PR31742: Don't emit a bogus "zero size array" extwarn when initializing a

Thanks! r293072. On Tue, Jan 24, 2017 at 6:03 PM, Richard Smith wrote: > Hi Hans, > > This is relatively minor, but it's safe and fixes a rejects-valid regression > in some configurations. Might be worth taking for Clang 4. > > On 24 January 2017 at 15:18, Richard Smith

Re: [libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

Should we merge this to 4.0? On Tue, Jan 24, 2017 at 3:09 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Tue Jan 24 17:09:12 2017 > New Revision: 292990 > > URL: http://llvm.org/viewvc/llvm-project?rev=292990=rev > Log: > Change the return type of

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Thanks for letting me know! I've merged your revert to the branch in r292947. Please let me know if there is any more follow-up. On Mon, Jan 23, 2017 at 6:30 PM, Devin Coughlin wrote: > FYI, I reverted r292800 from trunk in r292874. It was causing our internal > validation

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Ping? On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: > Richard, what do you think? > > On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: >> I would love to see this merged. It would make it easier to write libc++ >> tests if the tests didn't have to

Re: r292847 - PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted a (user-visible) error.

Thanks! r292859. On Mon, Jan 23, 2017 at 3:26 PM, Richard Smith wrote: > Hans, this should go into Clang 4. > > On 23 January 2017 at 15:14, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Mon Jan 23 17:14:23 2017 >> New

Re: [libcxx] r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.

Sounds good to me. On Mon, Jan 23, 2017 at 1:56 PM, Eric Fiselier wrote: > This patch should be merge into 4.0 since it is needed to fix compile time > regressions in when using Clang 3.4 and C++03. > > See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info. >

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Merged in r292858. Thanks, Hans On Mon, Jan 23, 2017 at 4:15 PM, Anna Zaks wrote: > Yes, ok to merge! > Thank you. > > Sent from my iPhone > >> On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote: >> >> Sounds good to me. >> >> Anna, you're the code owner here.

Re: r292522 - Don't inline dllimport functions referencing non-imported methods

prit. I speculatively reverted it in r292643. > > On Thu, Jan 19, 2017 at 1:33 PM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: hans >> Date: Thu Jan 19 15:33:13 2017 >> New Revision: 292522 >> >> URL: http://llvm.o

r292856 - Re-commit "Don't inline dllimport functions referencing non-imported methods"

Author: hans Date: Mon Jan 23 17:57:50 2017 New Revision: 292856 URL: http://llvm.org/viewvc/llvm-project?rev=292856=rev Log: Re-commit "Don't inline dllimport functions referencing non-imported methods" This re-commits r292522 with the addition that it also handles calls through pointer to

Re: [libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

Ok, go ahead. On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote: > This patch needs to get merged into 4.0 since the offending commit with the > misspelling is in the 4.0 branch. > > /Eric > > > On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits >

Re: [libcxx] r292830 - Fix GCC C++03 build by hiding default template argument in C++03

We merged the first one, so I suppose we better fix it :-) Sounds good to me. On Mon, Jan 23, 2017 at 1:37 PM, Eric Fiselier wrote: > This patch should be merge into the 4.0 branch. > > It fixes a bug introduced to the 4.0 branch in r292354 >

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Sounds good to me. Anna, you're the code owner here. Ok to merge this? Thanks, Hans On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev wrote: > Hans, > > Could we merge this one into the 4.0.0 release branch? It's a recent bugfix > for the analyzer. > > Thanks, > Artem. > >

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

Sounds good to me. On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier wrote: > We should merge this patch into the 4.0 release branch. It is needed to make > "check-all" pass when using GCC 4, 5 and 6. > > /Eric > > On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits >

Re: r292497 - [Sema] Fix PR28181 by avoiding calling BuildOverloadedBinOp in C mode

On Thu, Jan 19, 2017 at 6:25 PM, Richard Smith wrote: > On 19 January 2017 at 15:52, Hans Wennborg wrote: >> >> Richard, what do you think? > > > Yes, let's merge this. r292808. Cheers, Hans >> On Thu, Jan 19, 2017 at 9:34 AM, Alex L

Re: [libcxx] r292564 - Disable aligned new/delete on Apple platforms without posix_memalign

Thanks! On Thu, Jan 19, 2017 at 6:07 PM, Eric Fiselier wrote: > Merged. > > Relevant commits: > > * r292566 - Merge r292564 > * r292565 - Merge r292560 > > /Eric ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r292555 - P0426: Make the library implementation of constexpr char_traits a little easier

r292807. Thanks, Hans On Thu, Jan 19, 2017 at 5:22 PM, Richard Smith wrote: > Hans, can we get this onto the Clang 4 release branch (along with the > documentation added in r292558 and fixed in r292559)? This will allow us to > avoid libc++ carrying a version test for

Re: r292497 - [Sema] Fix PR28181 by avoiding calling BuildOverloadedBinOp in C mode

Richard, what do you think? On Thu, Jan 19, 2017 at 9:34 AM, Alex L wrote: > Hi Hans, > > Would it be possible to merge this for 4.0? > > Cheers, > Alex > > On 19 January 2017 at 17:17, Alex Lorenz via cfe-commits > wrote: >> >> Author: arphaman

[libcxxabi] r292524 - Merging r292418:

Author: hans Date: Thu Jan 19 15:57:56 2017 New Revision: 292524 URL: http://llvm.org/viewvc/llvm-project?rev=292524=rev Log: Merging r292418: r292418 | jroelofs | 2017-01-18 10:12:39 -0800 (Wed, 18 Jan 2017) | 15 lines

r292522 - Don't inline dllimport functions referencing non-imported methods

Author: hans Date: Thu Jan 19 15:33:13 2017 New Revision: 292522 URL: http://llvm.org/viewvc/llvm-project?rev=292522=rev Log: Don't inline dllimport functions referencing non-imported methods This is another follow-up to r246338. I had assumed methods were already handled by the AST visitor, but

Re: Commits to be merged for 4.0

On Tue, Jan 17, 2017 at 9:48 PM, Marshall Clow wrote: > One is for libc++abi: r292135 Merged in r292495. > The other two are for libc++: > r292276 Eric merged this one. > r292091 Merged in r292494. Cheers, Hans ___

[libcxxabi] r292495 - Merging r292135:

Author: hans Date: Thu Jan 19 10:52:39 2017 New Revision: 292495 URL: http://llvm.org/viewvc/llvm-project?rev=292495=rev Log: Merging r292135: r292135 | marshall | 2017-01-16 07:28:03 -0800 (Mon, 16 Jan 2017) | 1 line Mark

Re: [libcxx] r292091 - Implement the missing constexpr stuff in . Fixes PR#31645.

Merged to 4.0 in r292494 as requested. On Sun, Jan 15, 2017 at 7:02 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Sun Jan 15 21:02:10 2017 > New Revision: 292091 > > URL: http://llvm.org/viewvc/llvm-project?rev=292091=rev > Log: > Implement the

[libcxx] r292494 - Merging r292091:

Author: hans Date: Thu Jan 19 10:50:46 2017 New Revision: 292494 URL: http://llvm.org/viewvc/llvm-project?rev=292494=rev Log: Merging r292091: r292091 | marshall | 2017-01-15 19:02:10 -0800 (Sun, 15 Jan 2017) | 1 line

Re: r291955 - PR31606: Generalize our tentative DR resolution for inheriting copy/move

Merged in r292463. Cheers, Hans On Tue, Jan 17, 2017 at 9:25 PM, Richard Smith wrote: > Yes, let's. > > On 17 Jan 2017 9:11 pm, "Hans Wennborg" wrote: > > What do you think; time to merge it? > > On Fri, Jan 13, 2017 at 1:21 PM, Richard Smith

[libunwind] r292398 - Creating release directory for release_400.

Author: hans Date: Wed Jan 18 09:32:43 2017 New Revision: 292398 URL: http://llvm.org/viewvc/llvm-project?rev=292398=rev Log: Creating release directory for release_400. Added: libunwind/tags/RELEASE_400/ ___ cfe-commits mailing list

[libunwind] r292399 - Creating release candidate rc1 from release_400 branch

Author: hans Date: Wed Jan 18 09:32:46 2017 New Revision: 292399 URL: http://llvm.org/viewvc/llvm-project?rev=292399=rev Log: Creating release candidate rc1 from release_400 branch Added: libunwind/tags/RELEASE_400/rc1/ - copied from r292398, libunwind/branches/release_40/

[libcxx] r292385 - Creating release candidate rc1 from release_400 branch

Author: hans Date: Wed Jan 18 09:32:14 2017 New Revision: 292385 URL: http://llvm.org/viewvc/llvm-project?rev=292385=rev Log: Creating release candidate rc1 from release_400 branch Added: libcxx/tags/RELEASE_400/rc1/ (props changed) - copied from r292384, libcxx/branches/release_40/

[libcxxabi] r292387 - Creating release candidate rc1 from release_400 branch

Author: hans Date: Wed Jan 18 09:32:18 2017 New Revision: 292387 URL: http://llvm.org/viewvc/llvm-project?rev=292387=rev Log: Creating release candidate rc1 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc1/ - copied from r292386, libcxxabi/branches/release_40/

[libcxxabi] r292386 - Creating release directory for release_400.

Author: hans Date: Wed Jan 18 09:32:16 2017 New Revision: 292386 URL: http://llvm.org/viewvc/llvm-project?rev=292386=rev Log: Creating release directory for release_400. Added: libcxxabi/tags/RELEASE_400/ ___ cfe-commits mailing list

[libcxx] r292384 - Creating release directory for release_400.

Author: hans Date: Wed Jan 18 09:32:11 2017 New Revision: 292384 URL: http://llvm.org/viewvc/llvm-project?rev=292384=rev Log: Creating release directory for release_400. Added: libcxx/tags/RELEASE_400/ ___ cfe-commits mailing list

Re: [libcxx] r292013 - Fix last_write_time tests for filesystems that don't support negative and very large times

I went ahead and merged it in r292341. On Tue, Jan 17, 2017 at 4:26 PM, Eric Fiselier wrote: > @Jonas please go ahead and merge this patch. > > On Tue, Jan 17, 2017 at 5:24 PM, Hans Wennborg wrote: >> >> Yes, go ahead. >> >> Apologies for the delay. >> >> -

Re: r291955 - PR31606: Generalize our tentative DR resolution for inheriting copy/move

What do you think; time to merge it? On Fri, Jan 13, 2017 at 1:21 PM, Richard Smith wrote: > I'd like to wait a bit to see how the dust settles on this one, but this is > a bugfix for a previous bugfix for a standard change, and we've had several > user complaints

Re: r292052 - [code-completion] Fix crash when trying to do postfix completion of instance member inside a static function.

Merged in r292313. Thanks, Hans On Tue, Jan 17, 2017 at 8:56 AM, Argyrios Kyrtzidis wrote: > Hi Hans, > > Could this go into the stable branch ? > > On Sat, Jan 14, 2017 at 10:11 PM, Argyrios Kyrtzidis via cfe-commits > wrote: >> >> Author:

Re: r292032 - Fix PR31644 introduced by r287138 and add a regression test.

On Sat, Jan 14, 2017 at 1:26 PM, Dimitry Andric wrote: > On 14 Jan 2017, at 22:12, Yaron Keren via cfe-commits > wrote: >> Author: yrnkrn >> Date: Sat Jan 14 15:12:08 2017 >> New Revision: 292032 >> >> URL:

Re: [libcxx] r292013 - Fix last_write_time tests for filesystems that don't support negative and very large times

Yes, go ahead. Apologies for the delay. - Hans On Sat, Jan 14, 2017 at 5:54 AM, Eric Fiselier wrote: > +1 from me. @Hans am I OK to merge this? > > On Sat, Jan 14, 2017 at 4:53 AM, Hahnfeld, Jonas > wrote: >> >> Hi Hans, >> >> can this be merged for

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Richard, what do you think? On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: > I would love to see this merged. It would make it easier to write libc++ > tests if the tests didn't have to worry about the old 4.0 behavior. > > CC'ing Richard: Would merging this be OK? > > On

r292265 - UsersManual.rst: add missing newline

Author: hans Date: Tue Jan 17 15:31:57 2017 New Revision: 292265 URL: http://llvm.org/viewvc/llvm-project?rev=292265=rev Log: UsersManual.rst: add missing newline Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: r291964 - PR31631: fix bad CFG (and bogus warnings) when an if-statement has an init-statement and has binary operator as its condition.

Merged in r291978. (Please keep the list cc'd on merge requests.) Thanks, Hans On Fri, Jan 13, 2017 at 2:28 PM, Richard Smith wrote: > Seems sensible to put this in clang 4. > > -- Forwarded message -- > From: Richard Smith via cfe-commits

Re: r291879 - Add a necessary newline for diagnose_if documentation.

Merged in r291952. Thanks, Hans On Thu, Jan 12, 2017 at 5:52 PM, Eric Christopher via cfe-commits wrote: > Author: echristo > Date: Thu Jan 12 19:52:04 2017 > New Revision: 291879 > > URL: http://llvm.org/viewvc/llvm-project?rev=291879=rev > Log: > Add a necessary

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

Merged in r291951. Thanks, Hans On Fri, Jan 13, 2017 at 11:46 AM, Chandler Carruth wrote: > Also need to pull in r291881. Sorry about that. > > > On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote: >> >> On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth

Re: r291907 - Revert "Support for Python 3 in libclang python bindings"

On Fri, Jan 13, 2017 at 8:06 AM, Jonathan Coe via cfe-commits wrote: > Author: jbcoe > Date: Fri Jan 13 10:06:59 2017 > New Revision: 291907 > > URL: http://llvm.org/viewvc/llvm-project?rev=291907=rev > Log: > Revert "Support for Python 3 in libclang python bindings" >

Re: r291877 - [Sema] Restrict explicit instantation definition dllexport

Merged in r291943. Thanks, Hans On Thu, Jan 12, 2017 at 5:58 PM, Shoaib Meenai wrote: > Requesting a merge to the 4.0 branch. This is a pretty small change, and it > fixes an assertion failure on Windows (see PR31608 for details). > > On 1/12/17, 5:28 PM, "cfe-commits on behalf

Re: r291871 - Update C++ status pages for Clang 4 branch:

On Thu, Jan 12, 2017 at 4:57 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Jan 12 18:57:54 2017 > New Revision: 291871 > > URL: http://llvm.org/viewvc/llvm-project?rev=291871=rev > Log: > Update C++ status pages for Clang 4 branch: > > * Update

Re: r291865 - Improve handling of instantiated thread_local variables in Itanium C++ ABI.

Merged in r291912. Thanks, Hans On Thu, Jan 12, 2017 at 5:50 PM, Richard Smith wrote: > This should go onto the 4.0 branch. > > -- Forwarded message -- > From: Richard Smith via cfe-commits > Date: 12 January 2017 at 16:43 >

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth wrote: >> This isn't quite right, it should either be left as-is or dropped >> completely. This path was allowing people to spell "-mllvm >> -disable-llvm-optzns" for legacy reasons, even though the correct >> spelling is

[libcxx] r291845 - Drop 'svn' suffix from version.

Author: hans Date: Thu Jan 12 16:13:09 2017 New Revision: 291845 URL: http://llvm.org/viewvc/llvm-project?rev=291845=rev Log: Drop 'svn' suffix from version. Modified: libcxx/branches/release_40/CMakeLists.txt Modified: libcxx/branches/release_40/CMakeLists.txt URL:

[libunwind] r291846 - Drop 'svn' suffix from version.

Author: hans Date: Thu Jan 12 16:13:19 2017 New Revision: 291846 URL: http://llvm.org/viewvc/llvm-project?rev=291846=rev Log: Drop 'svn' suffix from version. Modified: libunwind/branches/release_40/CMakeLists.txt Modified: libunwind/branches/release_40/CMakeLists.txt URL:

[libcxxabi] r291844 - Drop 'svn' suffix from version.

Author: hans Date: Thu Jan 12 16:12:54 2017 New Revision: 291844 URL: http://llvm.org/viewvc/llvm-project?rev=291844=rev Log: Drop 'svn' suffix from version. Modified: libcxxabi/branches/release_40/CMakeLists.txt Modified: libcxxabi/branches/release_40/CMakeLists.txt URL:

[clang-tools-extra] r291838 - Clear the release notes for 5.0.0

Author: hans Date: Thu Jan 12 15:58:40 2017 New Revision: 291838 URL: http://llvm.org/viewvc/llvm-project?rev=291838=rev Log: Clear the release notes for 5.0.0 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

r291837 - Clear the release notes for 5.0.0

Author: hans Date: Thu Jan 12 15:55:16 2017 New Revision: 291837 URL: http://llvm.org/viewvc/llvm-project?rev=291837=rev Log: Clear the release notes for 5.0.0 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[clang-tools-extra] r291832 - Update docs/conf.py version

Author: hans Date: Thu Jan 12 15:42:38 2017 New Revision: 291832 URL: http://llvm.org/viewvc/llvm-project?rev=291832=rev Log: Update docs/conf.py version Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL:

r291831 - Update docs/conf.py version

Author: hans Date: Thu Jan 12 15:41:38 2017 New Revision: 291831 URL: http://llvm.org/viewvc/llvm-project?rev=291831=rev Log: Update docs/conf.py version Modified: cfe/trunk/docs/analyzer/conf.py cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/analyzer/conf.py URL:

[libunwind] r291830 - Bump version to 5.0.0svn

Author: hans Date: Thu Jan 12 15:37:55 2017 New Revision: 291830 URL: http://llvm.org/viewvc/llvm-project?rev=291830=rev Log: Bump version to 5.0.0svn Modified: libunwind/trunk/CMakeLists.txt Modified: libunwind/trunk/CMakeLists.txt URL:

[libcxxabi] r291829 - Bump version to 5.0.0svn

Author: hans Date: Thu Jan 12 15:36:22 2017 New Revision: 291829 URL: http://llvm.org/viewvc/llvm-project?rev=291829=rev Log: Bump version to 5.0.0svn Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL:

[libunwind] r291827 - Creating release_40 branch off revision 291814

Author: hans Date: Thu Jan 12 15:26:18 2017 New Revision: 291827 URL: http://llvm.org/viewvc/llvm-project?rev=291827=rev Log: Creating release_40 branch off revision 291814 Added: libunwind/branches/release_40/ - copied from r291814, libunwind/trunk/

[libcxxabi] r291821 - Creating release_40 branch off revision 291814

Author: hans Date: Thu Jan 12 15:25:46 2017 New Revision: 291821 URL: http://llvm.org/viewvc/llvm-project?rev=291821=rev Log: Creating release_40 branch off revision 291814 Added: libcxxabi/branches/release_40/ - copied from r291814, libcxxabi/trunk/

[libcxx] r291820 - Creating release_40 branch off revision 291814

Author: hans Date: Thu Jan 12 15:25:41 2017 New Revision: 291820 URL: http://llvm.org/viewvc/llvm-project?rev=291820=rev Log: Creating release_40 branch off revision 291814 Added: libcxx/branches/release_40/ (props changed) - copied from r291814, libcxx/trunk/ Propchange:

Re: r291783 - UsersManual.rst: Update clang-cl options list

er <tha...@chromium.org> wrote: >> >> Why do we list fdelayed-template-parsing in /? output now? That's on by >> default with clang-cl. >> >> On Thu, Jan 12, 2017 at 1:15 PM, Hans Wennborg via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >>> &

r291798 - UsersManual.rst: Update clang-cl options list again

Author: hans Date: Thu Jan 12 13:26:54 2017 New Revision: 291798 URL: http://llvm.org/viewvc/llvm-project?rev=291798=rev Log: UsersManual.rst: Update clang-cl options list again This time, make ignored options, such as /utf-8, show up as well if they have help text. Also, since we're now

Re: r291783 - UsersManual.rst: Update clang-cl options list

fdelayed-template-parsing in /? output now? That's on by > default with clang-cl. > > On Thu, Jan 12, 2017 at 1:15 PM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: hans >> Date: Thu Jan 12 12:15:06 2017 >> New Revi

r291783 - UsersManual.rst: Update clang-cl options list

Author: hans Date: Thu Jan 12 12:15:06 2017 New Revision: 291783 URL: http://llvm.org/viewvc/llvm-project?rev=291783=rev Log: UsersManual.rst: Update clang-cl options list Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: Upgrade and fix clang-format-vs

Committed in r288393. Cheers, Hans On Thu, Dec 1, 2016 at 9:22 AM, Hans Wennborg wrote: > Looks good to me! > > Do you have commit access, or would you like me to commit it for you? > > Thanks, > Hans > > On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano

r288393 - Fix VS2015 build of clang-format-vsix by using NuGet to pull in required assemblies

Author: hans Date: Thu Dec 1 12:05:41 2016 New Revision: 288393 URL: http://llvm.org/viewvc/llvm-project?rev=288393=rev Log: Fix VS2015 build of clang-format-vsix by using NuGet to pull in required assemblies Also added a gitignore to help track the right items to commit. Patch by Antonio

Re: Upgrade and fix clang-format-vs

Looks good to me! Do you have commit access, or would you like me to commit it for you? Thanks, Hans On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote: > Updated version of patch attached with the changes you suggested. Let me > know if there's anything else you'd

Re: r288207 - Don't try to merge DLL attributes on redeclaration of invalid decl (PR31069)

On Tue, Nov 29, 2016 at 4:37 PM, David Majnemer via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > > On Tue, Nov 29, 2016 at 2:31 PM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: hans >> Date: Tue Nov 29 16:31

r288223 - Fix formatting issue from r288207

Author: hans Date: Tue Nov 29 18:31:39 2016 New Revision: 288223 URL: http://llvm.org/viewvc/llvm-project?rev=288223=rev Log: Fix formatting issue from r288207 Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL:

r288207 - Don't try to merge DLL attributes on redeclaration of invalid decl (PR31069)

Author: hans Date: Tue Nov 29 16:31:00 2016 New Revision: 288207 URL: http://llvm.org/viewvc/llvm-project?rev=288207=rev Log: Don't try to merge DLL attributes on redeclaration of invalid decl (PR31069) Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/Sema/dllimport.c Modified:

Re: Upgrade and fix clang-format-vs

Very nice! I've tried this out and confirmed that the built plugin also works with older Visual Studio versions. Some comments below: > --- /dev/null > +++ b/tools/clang-format-vs/.gitignore > @@ -0,0 +1,11 @@ > +# Visual Studio files > +.vs/ > +/packages/ > +/ClangFormat/obj/ >

Re: Upgrade and fix clang-format-vs

On Mon, Nov 28, 2016 at 11:11 AM, Antonio Maiorano wrote: >> It's built with the script in utils/release/build_llvm_package.bat > which I run manually on my machine once every few weeks. > > Okay, that's good news. So the simplest path to success would be to require > the

Re: Upgrade and fix clang-format-vs

On Mon, Nov 28, 2016 at 10:46 AM, Antonio Maiorano wrote: > Okay, I'll see if upgrading to the 2015 assemblies would allow the VSIX to > keep working in older versions of VS. > > Still waiting on an answer to this question: > >> In either case, though, I must ask: how is the

Re: Upgrade and fix clang-format-vs

On Fri, Nov 25, 2016 at 6:58 PM, Antonio Maiorano wrote: > Ah, no, that's not what I meant. The required referenced assemblies are > versions that are normally installed with VS 2010. > > The first time I worked on this, I had upgraded the referenced assemblies to > the ones

<    5   6   7   8   9   10   11   12   13   14   >